AbterPhp\Admin\Orm\AdminResourceRepo

Complexity

Total Complexity

2

Size/Duplication

Total Lines	23
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	getByUserId()	0	4	1
A	getByIdentifier()	0	4	1

<?php

declare(strict_types=1);

namespace AbterPhp\Admin\Orm;

use AbterPhp\Admin\Domain\Entities\AdminResource as Entity;
use Opulence\Orm\OrmException;
use Opulence\Orm\Repositories\Repository;

class AdminResourceRepo extends Repository
{
    /**
     * @param string $identifier
     *
     * @return Entity|null
     * @throws OrmException
     */
    public function getByIdentifier(string $identifier): ?Entity
    {
        /** @see AdminResourceSqlDataMapper::getByIdentifier() */
        return $this->getFromDataMapper('getByIdentifier', [$identifier]);

The expression return $this->getFromDataMapper('getByIdentifier', array($identifier)) could return the type array<mixed,object> which is incompatible with the type-hinted return AbterPhp\Admin\Domain\Entities\AdminResource|null. Consider adding an additional type-check to rule them out.

    }
    /**
     * @param string $userId
     *
     * @return Entity[]
     * @throws OrmException
     */
    public function getByUserId(string $userId): array
    {
        /** @see AdminResourceSqlDataMapper::getByUserId() */
        return $this->getFromDataMapper('getByUserId', [$userId]);

The expression return $this->getFromDataMapper('getByUserId', array($userId)) could return the type object which is incompatible with the type-hinted return array. Consider adding an additional type-check to rule them out.

    }
}