Cart::getCartData() - Code Metrics - Inspection of "Experimental refactor to reduce complexity" - absalomedia/wasabi - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 43ec3b...86cd9e )

by Lawrence

created 2016-02-19 00:34 UTC

Cart::getCartData() A

↳ Parent: Cart

Complexity

Conditions	1
Paths	1

Size

Total Lines	10
Code Lines	6

Duplication

Lines	10
Ratio	100 %

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
c	2
b	0
f	0
dl	10
loc	10
rs	9.4285
cc	1
eloc	6
nc	1
nop	1

<?php

namespace ABM\Wasabi;

use Analog\Analog;
use Ratchet\ConnectionInterface;
use Ratchet\MessageComponentInterface;

class Cart extends Prestashop 
{

	 /**
     * @param string $data
     */
    private function getCartData($data)

    {
        $cart = substr($data, 0, strpos($data, ','));
        $cust = substr($data, strpos($data, ',') + 1);

        Analog::log("Cart & customer variables: $data");
        $otherCarts = $this->processFindCarts($cart, $cust);

        return $otherCarts;
    }

    /**
     * @param string $cart
     * @param string $cust
     */
    private function processFindCarts($cart, $cust)

    {
        $sql = 'SELECT DISTINCT pc.id_cart as id, DATE_FORMAT(pc.date_upd,"%a %D %b %Y, %l:%i %p") as timer from '._DB_PREFIX_.'cart as pc
                LEFT JOIN  '._DB_PREFIX_.'cart_product as pcp on pcp.id_cart = pc.id_cart
                WHERE pc.id_cart NOT IN (SELECT po.id_cart FROM  '._DB_PREFIX_.'orders as po)
                AND pcp.id_product IS NOT NULL
                AND pc.id_customer = '.(int) $cust.'
                AND pc.id_cart != '.(int) $cart.'
                ORDER BY pc.date_upd DESC
                LIMIT 10';
        if ($results = $this->dbConn->fetchRowMany($sql)) {
            foreach ($results as &$row) {
                $row['token'] = md5(_COOKIE_KEY_.'recover_cart_'.$row['id']);
            }

            return $results;
        }
    }

}

1		<?php
2
3		namespace ABM\Wasabi;
4
5		use Analog\Analog;
6		use Ratchet\ConnectionInterface;
7		use Ratchet\MessageComponentInterface;
8
9		class Cart extends Prestashop
10		{
11
12		/**
13		* @param string $data
14		*/
15	View Code Duplication	private function getCartData($data)
		0 ignored issues – show Bug introduced 2016-02-19 00:36 UTC by Report Bug Copy Issue Report Consider using a different method name as you override a private method of the parent class. Overwriting private methods is generally fine as long as you also use private visibility. It might still be preferable for understandability to use a different method name. Loading history... Duplication introduced 2016-02-19 00:36 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
16		{
17		$cart = substr($data, 0, strpos($data, ','));
18		$cust = substr($data, strpos($data, ',') + 1);
19
20		Analog::log("Cart & customer variables: $data");
21		$otherCarts = $this->processFindCarts($cart, $cust);
22
23		return $otherCarts;
24		}
25
26		/**
27		* @param string $cart
28		* @param string $cust
29		*/
30	View Code Duplication	private function processFindCarts($cart, $cust)
		0 ignored issues – show Bug introduced 2016-02-19 00:36 UTC by Report Bug Copy Issue Report Consider using a different method name as you override a private method of the parent class. Overwriting private methods is generally fine as long as you also use private visibility. It might still be preferable for understandability to use a different method name. Loading history... Duplication introduced 2016-02-19 00:36 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
31		{
32		$sql = 'SELECT DISTINCT pc.id_cart as id, DATE_FORMAT(pc.date_upd,"%a %D %b %Y, %l:%i %p") as timer from '._DB_PREFIX_.'cart as pc
33		LEFT JOIN '._DB_PREFIX_.'cart_product as pcp on pcp.id_cart = pc.id_cart
34		WHERE pc.id_cart NOT IN (SELECT po.id_cart FROM '._DB_PREFIX_.'orders as po)
35		AND pcp.id_product IS NOT NULL
36		AND pc.id_customer = '.(int) $cust.'
37		AND pc.id_cart != '.(int) $cart.'
38		ORDER BY pc.date_upd DESC
39		LIMIT 10';
40		if ($results = $this->dbConn->fetchRowMany($sql)) {
41		foreach ($results as &$row) {
42		$row['token'] = md5(_COOKIE_KEY_.'recover_cart_'.$row['id']);
43		}
44
45		return $results;
46		}
47		}
48
49		}

absalomedia / wasabi

Push — master ( 43ec3b...86cd9e )

Cart::getCartData() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like