Prestashop::getFinalPrice() - Code Metrics - Inspection of "Combination refactor" - absalomedia/wasabi - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 8f8233...93b489 )

by Lawrence

created 2016-02-19 01:42 UTC

Prestashop::getFinalPrice() A

↳ Parent: Project

Complexity

Conditions	2
Paths	2

Size

Total Lines	6
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Importance

Changes	3
Bugs	1	Features	0

Metric	Value
c	3
b	1
f	0
dl	0
loc	6
rs	9.4285
cc	2
eloc	3
nc	2
nop	2

<?php

namespace ABM\Wasabi;

use Analog\Analog;
use Ratchet\ConnectionInterface;
use Ratchet\MessageComponentInterface;

class Prestashop implements MessageComponentInterface
{
    protected $clients;
    protected $dbConn;

    public function __construct()
    {
        $this->clients = new \SplObjectStorage();
        // Now connect to PS DB using Simplon on Composer
        $this->dbConn = new \Simplon\Mysql\Mysql(
    '127.0.0.1',
    _DB_USER_,
    _DB_PASSWD_,
    _DB_NAME_
        );
        $log_file = 'wasabi.log';
        Analog::handler(\Analog\Handler\File::init($log_file));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }

    public function onOpen(ConnectionInterface $conn)
    {
        // Store the new connection to send messages to later
        $this->clients->attach($conn);

        Analog::log("New connection: $conn->resourceId");
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
    }

    public function onMessage(ConnectionInterface $from, $msg)
    {
        $result = null;
        foreach ($this->clients as $client) {
            if ($from == $client) {
                $type = strtolower(substr($msg, 0, strpos($msg, '|')));
                $data = substr($msg, strpos($msg, '|') + 1);
                switch ($type) {
                    case 'cart': $result = Cart::getCartData($data);

                                    break;
                    case 'prod': $result = Product::getProductData($data);

                                    break;
                    case 'comb': $result = Combination::getCombinationData($data);

                                    break;
                    default:        break;
                }
                if (!empty($result)) {
                    $client->send(json_encode($result));
                }
            }
        }
    }


    public function onClose(ConnectionInterface $conn)
    {
        // The connection is closed, remove it, as we can no longer send it messages
        $this->clients->detach($conn);
        Analog::log('Connection '.$conn->resourceId.' has disconnected');
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
    }

    public function onError(ConnectionInterface $conn, \Exception $e)
    {
        echo "An error has occurred: {$e->getMessage()}\n";
        Analog::log('Error: '.$e->getMessage().'');
        $conn->close();
    }
}


1			<?php
2
3			namespace ABM\Wasabi;
4
5			use Analog\Analog;
6			use Ratchet\ConnectionInterface;
7			use Ratchet\MessageComponentInterface;
8
9			class Prestashop implements MessageComponentInterface
10			{
11			protected $clients;
12			protected $dbConn;
13
14			public function __construct()
15			{
16			$this->clients = new \SplObjectStorage();
17			// Now connect to PS DB using Simplon on Composer
18			$this->dbConn = new \Simplon\Mysql\Mysql(
19			'127.0.0.1',
20			_DB_USER_,
21			_DB_PASSWD_,
22			_DB_NAME_
23			);
24			$log_file = 'wasabi.log';
25			Analog::handler(\Analog\Handler\File::init($log_file));
			0 ignored issues – show Documentation introduced 2016-02-08 05:04 UTC by Report Bug Copy Issue Report `\Analog\Handler\File::init($log_file)` is of type `object<Closure>`, but the function expects a `boolean`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
26			}
27
28			public function onOpen(ConnectionInterface $conn)
29			{
30			// Store the new connection to send messages to later
31			$this->clients->attach($conn);
32
33			Analog::log("New connection: $conn->resourceId");
			0 ignored issues – show Bug introduced 2016-02-08 05:04 UTC by Report Bug Copy Issue Report Accessing `resourceId` on the interface `Ratchet\ConnectionInterface` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
34			}
35
36			public function onMessage(ConnectionInterface $from, $msg)
37			{
38			$result = null;
39			foreach ($this->clients as $client) {
40			if ($from == $client) {
41			$type = strtolower(substr($msg, 0, strpos($msg, '\|')));
42			$data = substr($msg, strpos($msg, '\|') + 1);
43			switch ($type) {
44			case 'cart': $result = Cart::getCartData($data);
			0 ignored issues – show Bug introduced 2016-02-19 00:36 UTC by Report Bug Copy Issue Report The method `getCartData()` cannot be called from this context as it is declared private in class `ABM\Wasabi\Cart`. This check looks for access to methods that are not accessible from the current context. If you need to make a method accessible to another context you can raise its visibility level in the defining class. Loading history...
45			break;
46			case 'prod': $result = Product::getProductData($data);
			0 ignored issues – show Bug introduced 2016-02-19 01:40 UTC by Report Bug Copy Issue Report The method `getProductData()` cannot be called from this context as it is declared private in class `ABM\Wasabi\Product`. This check looks for access to methods that are not accessible from the current context. If you need to make a method accessible to another context you can raise its visibility level in the defining class. Loading history...
47			break;
48			case 'comb': $result = Combination::getCombinationData($data);
			0 ignored issues – show Bug introduced 2016-02-19 01:44 UTC by Report Bug Copy Issue Report The method `getCombinationData()` cannot be called from this context as it is declared private in class `ABM\Wasabi\Combination`. This check looks for access to methods that are not accessible from the current context. If you need to make a method accessible to another context you can raise its visibility level in the defining class. Loading history...
49			break;
50			default: break;
51			}
52			if (!empty($result)) {
53			$client->send(json_encode($result));
54			}
55			}
56			}
57			}
58
59
60			public function onClose(ConnectionInterface $conn)
61			{
62			// The connection is closed, remove it, as we can no longer send it messages
63			$this->clients->detach($conn);
64			Analog::log('Connection '.$conn->resourceId.' has disconnected');
			0 ignored issues – show Bug introduced 2016-02-08 05:04 UTC by Report Bug Copy Issue Report Accessing `resourceId` on the interface `Ratchet\ConnectionInterface` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
65			}
66
67			public function onError(ConnectionInterface $conn, \Exception $e)
68			{
69			echo "An error has occurred: {$e->getMessage()}\n";
70			Analog::log('Error: '.$e->getMessage().'');
71			$conn->close();
72			}
73			}
74

absalomedia / wasabi

Push — master ( 8f8233...93b489 )

Prestashop::getFinalPrice() A

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like