| Conditions | 25 |
| Paths | 25 |
| Total Lines | 114 |
| Code Lines | 83 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 2 | ||
| Bugs | 0 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 158 | static public function fromXML(\XMLReader $xmlReader) |
||
| 159 | { |
||
| 160 | $delaySeconds = NULL; |
||
| 161 | $maximumMessageSize = NULL; |
||
| 162 | $messageRetentionPeriod = NULL; |
||
| 163 | $visibilityTimeout = NULL; |
||
| 164 | $pollingWaitSeconds = NULL; |
||
| 165 | $queueName = NULL; |
||
| 166 | $createTime = NULL; |
||
| 167 | $lastModifyTime = NULL; |
||
| 168 | $activeMessages = NULL; |
||
| 169 | $inactiveMessages = NULL; |
||
| 170 | $delayMessages = NULL; |
||
| 171 | |||
| 172 | while ($xmlReader->read()) |
||
| 173 | { |
||
| 174 | if ($xmlReader->nodeType == \XMLReader::ELEMENT) |
||
| 175 | { |
||
| 176 | switch ($xmlReader->name) { |
||
| 177 | case 'DelaySeconds': |
||
| 178 | $xmlReader->read(); |
||
| 179 | if ($xmlReader->nodeType == \XMLReader::TEXT) |
||
| 180 | { |
||
| 181 | $delaySeconds = $xmlReader->value; |
||
| 182 | } |
||
| 183 | break; |
||
| 184 | case 'MaximumMessageSize': |
||
| 185 | $xmlReader->read(); |
||
| 186 | if ($xmlReader->nodeType == \XMLReader::TEXT) |
||
| 187 | { |
||
| 188 | $maximumMessageSize = $xmlReader->value; |
||
| 189 | } |
||
| 190 | break; |
||
| 191 | case 'MessageRetentionPeriod': |
||
| 192 | $xmlReader->read(); |
||
| 193 | if ($xmlReader->nodeType == \XMLReader::TEXT) |
||
| 194 | { |
||
| 195 | $messageRetentionPeriod = $xmlReader->value; |
||
| 196 | } |
||
| 197 | break; |
||
| 198 | case 'VisibilityTimeout': |
||
| 199 | $xmlReader->read(); |
||
| 200 | if ($xmlReader->nodeType == \XMLReader::TEXT) |
||
| 201 | { |
||
| 202 | $visibilityTimeout = $xmlReader->value; |
||
| 203 | } |
||
| 204 | break; |
||
| 205 | case 'PollingWaitSeconds': |
||
| 206 | $xmlReader->read(); |
||
| 207 | if ($xmlReader->nodeType == \XMLReader::TEXT) |
||
| 208 | { |
||
| 209 | $pollingWaitSeconds = $xmlReader->value; |
||
| 210 | } |
||
| 211 | break; |
||
| 212 | case 'QueueName': |
||
| 213 | $xmlReader->read(); |
||
| 214 | if ($xmlReader->nodeType == \XMLReader::TEXT) |
||
| 215 | { |
||
| 216 | $queueName = $xmlReader->value; |
||
| 217 | } |
||
| 218 | break; |
||
| 219 | case 'CreateTime': |
||
| 220 | $xmlReader->read(); |
||
| 221 | if ($xmlReader->nodeType == \XMLReader::TEXT) |
||
| 222 | { |
||
| 223 | $createTime = $xmlReader->value; |
||
| 224 | } |
||
| 225 | break; |
||
| 226 | case 'LastModifyTime': |
||
| 227 | $xmlReader->read(); |
||
| 228 | if ($xmlReader->nodeType == \XMLReader::TEXT) |
||
| 229 | { |
||
| 230 | $lastModifyTime = $xmlReader->value; |
||
| 231 | } |
||
| 232 | break; |
||
| 233 | case 'ActiveMessages': |
||
| 234 | $xmlReader->read(); |
||
| 235 | if ($xmlReader->nodeType == \XMLReader::TEXT) |
||
| 236 | { |
||
| 237 | $activeMessages = $xmlReader->value; |
||
| 238 | } |
||
| 239 | break; |
||
| 240 | case 'InactiveMessages': |
||
| 241 | $xmlReader->read(); |
||
| 242 | if ($xmlReader->nodeType == \XMLReader::TEXT) |
||
| 243 | { |
||
| 244 | $inactiveMessages = $xmlReader->value; |
||
| 245 | } |
||
| 246 | break; |
||
| 247 | case 'DelayMessages': |
||
| 248 | $xmlReader->read(); |
||
| 249 | if ($xmlReader->nodeType == \XMLReader::TEXT) |
||
| 250 | { |
||
| 251 | $delayMessages = $xmlReader->value; |
||
| 252 | } |
||
| 253 | break; |
||
| 254 | } |
||
| 255 | } |
||
| 256 | } |
||
| 257 | |||
| 258 | $attributes = new QueueAttributes( |
||
| 259 | $delaySeconds, |
||
| 260 | $maximumMessageSize, |
||
| 261 | $messageRetentionPeriod, |
||
| 262 | $visibilityTimeout, |
||
| 263 | $pollingWaitSeconds, |
||
| 264 | $queueName, |
||
| 265 | $createTime, |
||
| 266 | $lastModifyTime, |
||
| 267 | $activeMessages, |
||
| 268 | $inactiveMessages, |
||
| 269 | $delayMessages); |
||
| 270 | return $attributes; |
||
| 271 | } |
||
| 272 | } |
||
| 275 |