Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 7 | class DeleteMessageRequest extends BaseRequest |
||
| 8 | { |
||
| 9 | private $queueName; |
||
| 10 | private $receiptHandle; |
||
| 11 | |||
| 12 | public function __construct($queueName, $receiptHandle) |
||
| 13 | { |
||
| 14 | parent::__construct('delete', 'queues/' . $queueName . '/messages'); |
||
| 15 | |||
| 16 | $this->queueName = $queueName; |
||
| 17 | $this->receiptHandle = $receiptHandle; |
||
| 18 | } |
||
| 19 | |||
| 20 | public function getQueueName() |
||
| 21 | { |
||
| 22 | return $this->queueName; |
||
| 23 | } |
||
| 24 | |||
| 25 | public function getReceiptHandle() |
||
| 26 | { |
||
| 27 | return $this->receiptHandle; |
||
| 28 | } |
||
| 29 | |||
| 30 | public function generateBody() |
||
| 31 | { |
||
| 32 | return NULL; |
||
| 33 | } |
||
| 34 | |||
| 35 | public function generateQueryString() |
||
| 36 | { |
||
| 37 | return http_build_query(array("ReceiptHandle" => $this->receiptHandle)); |
||
| 38 | } |
||
| 39 | } |
||
| 40 | ?> |
||
| 41 |