Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
13 | class BatchSendFailException extends MnsException |
||
14 | { |
||
15 | protected $sendMessageResponseItems; |
||
16 | |||
17 | public function __construct($code, $message, $previousException = NULL, $requestId = NULL, $hostId = NULL) |
||
18 | { |
||
19 | parent::__construct($code, $message, $previousException, Constants::BATCH_SEND_FAIL, $requestId, $hostId); |
||
20 | |||
21 | $this->sendMessageResponseItems = array(); |
||
22 | } |
||
23 | |||
24 | public function addSendMessageResponseItem(SendMessageResponseItem $item) |
||
25 | { |
||
26 | $this->sendMessageResponseItems[] = $item; |
||
27 | } |
||
28 | |||
29 | public function getSendMessageResponseItems() |
||
30 | { |
||
31 | return $this->sendMessageResponseItems; |
||
32 | } |
||
33 | } |
||
34 | |||
36 |