Completed
Pull Request — master (#19)
by
unknown
05:12
created
Instapago/Api.php 2 patches
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -199,9 +199,9 @@
 block discarded – undo
199 199
    * Realiza Transaccion
200 200
    * Efectúa y retornar una respuesta a un metodo de pago.
201 201
    *
202
-   * @param $url endpoint a consultar
202
+   * @param string $url endpoint a consultar
203 203
    * @param $fields datos para la consulta
204
-   * @param $method verbo http de la consulta
204
+   * @param string $method verbo http de la consulta
205 205
    *
206 206
    * @return $obj array resultados de la transaccion
207 207
    */
Please login to merge, or discard this patch.
Spacing   +12 added lines, -12 removed lines patch added patch discarded remove patch
@@ -47,7 +47,7 @@  discard block
 block discarded – undo
47 47
    *                            Requeridas.
48 48
    */
49 49
   public function __construct($keyId, $publicKeyId) {
50
-    if ( empty($keyId) || empty($publicKeyId) ) {
50
+    if (empty($keyId) || empty($publicKeyId)) {
51 51
       throw new Exceptions\InstapagoException('Los parámetros "keyId" y "publicKeyId" son requeridos para procesar la petición.');
52 52
     }
53 53
     $this->publicKeyId = $publicKeyId;
@@ -94,9 +94,9 @@  discard block
 block discarded – undo
94 94
     $type = null;
95 95
     if ($paymentType == 'direct') {
96 96
       $type = '2';
97
-    }else if ($paymentType == 'reserve') {
97
+    } else if ($paymentType == 'reserve') {
98 98
       $type = '1';
99
-    }else{
99
+    } else {
100 100
       throw new Exceptions\InstapagoException("Invalid Payment type");
101 101
     }
102 102
 
@@ -132,7 +132,7 @@  discard block
 block discarded – undo
132 132
    * @return \ArrayObject<string, string> Respuesta de Instapago
133 133
    * @throws Exceptions\InstapagoException
134 134
    */
135
-  public function continuePayment($fields){
135
+  public function continuePayment($fields) {
136 136
     $validator = (new Validator())->release()->validate($fields);
137 137
     $fields = [
138 138
       'KeyID'        => $this->keyId, //required
@@ -217,11 +217,11 @@  discard block
 block discarded – undo
217 217
       $args = [
218 218
         'query' => $fields
219 219
       ];
220
-    }else if ($method == 'POST' || $method == 'DELETE') {
220
+    } else if ($method == 'POST' || $method == 'DELETE') {
221 221
       $args = [
222 222
           'form_params' => $fields
223 223
       ];
224
-    }else{
224
+    } else {
225 225
       throw new Exception("Not implemented yet", 1);
226 226
     }
227 227
     
@@ -250,24 +250,24 @@  discard block
 block discarded – undo
250 250
       throw new Exceptions\InvalidInputException(
251 251
         'Error al validar los datos enviados.'
252 252
       );
253
-    }else if ($code == 401) {
253
+    } else if ($code == 401) {
254 254
       throw new Exceptions\AuthException(
255 255
         'Error de autenticación, ha ocurrido un error'
256 256
         . ' con las llaves utilizadas.');
257
-    }else if ($code == 403) {
257
+    } else if ($code == 403) {
258 258
       throw new Exceptions\BankRejectException(
259 259
         'Pago Rechazado por el banco.'
260 260
       );
261
-    }else if ($code == 500) {
261
+    } else if ($code == 500) {
262 262
       throw new Exceptions\InstapagoException(
263 263
         'Ha Ocurrido un error interno dentro del servidor.'
264 264
       );
265
-    }else if ($code == 503) {
265
+    } else if ($code == 503) {
266 266
       throw new Exceptions\InstapagoException(
267 267
         'Ha Ocurrido un error al procesar los parámetros de entrada.'
268 268
         . ' Revise los datos enviados y vuelva a intentarlo.'
269 269
       );
270
-    }else if ($code == 201) {
270
+    } else if ($code == 201) {
271 271
       return [
272 272
         'code'         => $code,
273 273
         'msg_banco'    => $obj->message,
@@ -275,7 +275,7 @@  discard block
 block discarded – undo
275 275
         'id_pago'      => $obj->id,
276 276
         'reference'    => $obj->reference,
277 277
       ];
278
-    }else {
278
+    } else {
279 279
       throw new \Exception('Not implemented yet');
280 280
     }
281 281
   }
Please login to merge, or discard this patch.
Instapago/Exceptions/InvalidInputException.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -31,4 +31,4 @@
 block discarded – undo
31 31
 /**
32 32
  * Custom InvalidInputException.
33 33
  */
34
-class InvalidInputException extends \Exception{}
34
+class InvalidInputException extends \Exception {}
Please login to merge, or discard this patch.
Instapago/Exceptions/ValidationException.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -31,4 +31,4 @@
 block discarded – undo
31 31
 /**
32 32
  * Custom ValidationException.
33 33
  */
34
-class ValidationException extends \Exception{}
34
+class ValidationException extends \Exception {}
Please login to merge, or discard this patch.
Instapago/Exceptions/BankRejectException.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -31,4 +31,4 @@
 block discarded – undo
31 31
 /**
32 32
  * Custom BankRejectException.
33 33
  */
34
-class BankRejectException extends \Exception{}
34
+class BankRejectException extends \Exception {}
Please login to merge, or discard this patch.
Instapago/Exceptions/AuthException.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -31,4 +31,4 @@
 block discarded – undo
31 31
 /**
32 32
  * Custom AuthException.
33 33
  */
34
-class AuthException extends \Exception{}
34
+class AuthException extends \Exception {}
Please login to merge, or discard this patch.
Instapago/Exceptions/TimeoutException.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -31,4 +31,4 @@
 block discarded – undo
31 31
 /**
32 32
  * Custom TimeoutException.
33 33
  */
34
-class TimeoutException extends \Exception{}
34
+class TimeoutException extends \Exception {}
Please login to merge, or discard this patch.
Instapago/Exceptions/InstapagoException.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -31,4 +31,4 @@
 block discarded – undo
31 31
 /**
32 32
  * Custom InstapagoException.
33 33
  */
34
-class InstapagoException extends \Exception{}
34
+class InstapagoException extends \Exception {}
Please login to merge, or discard this patch.
Instapago/Validator.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -51,7 +51,7 @@  discard block
 block discarded – undo
51 51
     return $this;
52 52
   }
53 53
 
54
-  public function release(){
54
+  public function release() {
55 55
     $this->validations = [
56 56
       'amount' => [FILTER_VALIDATE_FLOAT],
57 57
       'id' => [FILTER_VALIDATE_REGEXP, '/^([0-9a-f]{8})\-([0-9a-f]{4})\-([0-9a-f]{4})\-([0-9a-f]{4})\-([0-9a-f]{12})$/'],
@@ -59,23 +59,23 @@  discard block
 block discarded – undo
59 59
     return $this;
60 60
   }
61 61
 
62
-  public function query(){
62
+  public function query() {
63 63
     $this->validations = [
64 64
       'id' => [FILTER_VALIDATE_REGEXP, '/^([0-9a-f]{8})\-([0-9a-f]{4})\-([0-9a-f]{4})\-([0-9a-f]{4})\-([0-9a-f]{12})$/'],
65 65
     ];
66 66
     return $this;
67 67
   }
68 68
 
69
-  public function validate($fields){
69
+  public function validate($fields) {
70 70
     foreach ($this->validations as $key => $filters) {
71
-      if ( !$this->_validation($fields[$key], $filters) ){
71
+      if ( ! $this->_validation($fields[$key], $filters)) {
72 72
         throw new Exceptions\ValidationException("Error {$key}: {$fields[$key]}");
73 73
       }
74 74
     }
75 75
 
76 76
   }
77 77
 
78
-  private function _validation ($value, $filters)
78
+  private function _validation($value, $filters)
79 79
   {
80 80
     $filter = $filters[0];
81 81
     $flags = [];
Please login to merge, or discard this patch.