AbstractCheckCommandFactoryTest::testCreateService() - Code Metrics - Inspection of "add two new diagnostic checks" - abacaphiliac/doctrine-orm-diagnostics-module - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#4)

by Timothy

created 2016-07-10 01:31 UTC

testCreateService() A

↳ Parent: AbstractCheckCommandFactoryTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	10
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
c	1
b	0
f	1
dl	0
loc	10
rs	9.4285
cc	1
eloc	5
nc	1
nop	0

<?php

namespace Abacaphiliac\DoctrineORMDiagnosticsModuleTest;

use Abacaphiliac\DoctrineORMDiagnosticsModule\AbstractCheckCommandFactory;
use Abacaphiliac\DoctrineORMDiagnosticsModule\CheckCommand;
use Symfony\Component\Console\Command\Command;
use Zend\ServiceManager\ServiceManager;

/**
 * @covers \Abacaphiliac\DoctrineORMDiagnosticsModule\AbstractCheckCommandFactory
 */
class AbstractCheckCommandFactoryTest extends \PHPUnit_Framework_TestCase
{
    /** @var ServiceManager */
    private $serviceLocator;
    
    /** @var \PHPUnit_Framework_MockObject_MockObject|AbstractCheckCommandFactory */
    private $sut;

    protected function setUp()
    {
        parent::setUp();

        $this->serviceLocator = new ServiceManager();
        
        $this->sut = $this->getMockForAbstractClass(AbstractCheckCommandFactory::class);
    }
    
    public function testCreateService()
    {
        $this->sut->method('getCommandServiceName')->willReturn('FooBar');
        
        $this->serviceLocator->setService('FooBar', new Command('FooBar'));

        $actual = $this->sut->createService($this->serviceLocator);
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
        
        self::assertInstanceOf(CheckCommand::class, $actual);
    }

    /**
     * @expectedException \UnexpectedValueException
     */
    public function testNotCreateServiceDueToInvalidCommandType()
    {
        $this->sut->method('getCommandServiceName')->willReturn('FooBar');
        
        $this->serviceLocator->setService('FooBar', new \stdClass());

        $this->sut->createService($this->serviceLocator);
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
    }
}


1			<?php
2
3			namespace Abacaphiliac\DoctrineORMDiagnosticsModuleTest;
4
5			use Abacaphiliac\DoctrineORMDiagnosticsModule\AbstractCheckCommandFactory;
6			use Abacaphiliac\DoctrineORMDiagnosticsModule\CheckCommand;
7			use Symfony\Component\Console\Command\Command;
8			use Zend\ServiceManager\ServiceManager;
9
10			/**
11			* @covers \Abacaphiliac\DoctrineORMDiagnosticsModule\AbstractCheckCommandFactory
12			*/
13			class AbstractCheckCommandFactoryTest extends \PHPUnit_Framework_TestCase
14			{
15			/** @var ServiceManager */
16			private $serviceLocator;
17
18			/** @var \PHPUnit_Framework_MockObject_MockObject\|AbstractCheckCommandFactory */
19			private $sut;
20
21			protected function setUp()
22			{
23			parent::setUp();
24
25			$this->serviceLocator = new ServiceManager();
26
27			$this->sut = $this->getMockForAbstractClass(AbstractCheckCommandFactory::class);
28			}
29
30			public function testCreateService()
31			{
32			$this->sut->method('getCommandServiceName')->willReturn('FooBar');
33
34			$this->serviceLocator->setService('FooBar', new Command('FooBar'));
35
36			$actual = $this->sut->createService($this->serviceLocator);
			0 ignored issues – show Bug introduced 2016-07-07 13:51 UTC by Report Bug Copy Issue Report The method `createService` does only exist in `Abacaphiliac\DoctrineORM...ractCheckCommandFactory`, but not in `PHPUnit_Framework_MockObject_MockObject`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
37
38			self::assertInstanceOf(CheckCommand::class, $actual);
39			}
40
41			/**
42			* @expectedException \UnexpectedValueException
43			*/
44			public function testNotCreateServiceDueToInvalidCommandType()
45			{
46			$this->sut->method('getCommandServiceName')->willReturn('FooBar');
47
48			$this->serviceLocator->setService('FooBar', new \stdClass());
49
50			$this->sut->createService($this->serviceLocator);
			0 ignored issues – show Bug introduced 2016-07-07 13:51 UTC by Report Bug Copy Issue Report The method `createService` does only exist in `Abacaphiliac\DoctrineORM...ractCheckCommandFactory`, but not in `PHPUnit_Framework_MockObject_MockObject`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
51			}
52			}
53

abacaphiliac / doctrine-orm-diagnostics-module

Pull Request — master (#4)

testCreateService() A

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like