PostSaver::execute() - Code Metrics - Inspection of "Merge pull request #12 from aaemnnosttv/refactor/m..." - aaemnnosttv/silk - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( ed9f5f...162e0f )

by Evan

created 2016-07-07 21:34 UTC

PostSaver::execute() A

↳ Parent: PostSaver

Complexity

Conditions	3
Paths	4

Size

Total Lines	15
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
cc	3
eloc	9
c	1
b	0
f	1
nc	4
nop	0
dl	0
loc	15
rs	9.4285

<?php

namespace Silk\Post\Action;

use Silk\Database\Action;
use Silk\Exception\WP_ErrorException;

class PostSaver extends Action
{
    public function execute()
    {
        if (! $this->model->id) {
            $result = wp_insert_post($this->model->post->to_array(), true);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        } else {
            $result = wp_update_post($this->model->post, true);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        }

        if (is_wp_error($result)) {
            throw new WP_ErrorException($result);
        }

        $this->model->setId($result)
            ->refresh();
    }
}


1			<?php
2
3			namespace Silk\Post\Action;
4
5			use Silk\Database\Action;
6			use Silk\Exception\WP_ErrorException;
7
8			class PostSaver extends Action
9			{
10			public function execute()
11			{
12			if (! $this->model->id) {
13			$result = wp_insert_post($this->model->post->to_array(), true);
			0 ignored issues – show Documentation introduced 2016-07-06 13:11 UTC by Report Bug Copy Issue Report The property `post` does not exist on `object<Silk\Database\ActiveRecord>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
14			} else {
15			$result = wp_update_post($this->model->post, true);
			0 ignored issues – show Documentation introduced 2016-07-06 13:11 UTC by Report Bug Copy Issue Report The property `post` does not exist on `object<Silk\Database\ActiveRecord>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
16			}
17
18			if (is_wp_error($result)) {
19			throw new WP_ErrorException($result);
20			}
21
22			$this->model->setId($result)
23			->refresh();
24			}
25			}
26

aaemnnosttv / silk

Push — master ( ed9f5f...162e0f )

PostSaver::execute() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like