QueryBuilder - Code Metrics - Inspection of "refactor QueryBuilders" - aaemnnosttv/silk - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — develop ( d77dc3...4e0099 )

by Evan

created 2016-08-15 22:02 UTC

QueryBuilder A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	124
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes	9
Bugs	0	Features	2

Metric	Value
c	9
b	0
f	2
dl	0
loc	124
rs	10
wmc	11
lcom	1
cbo	1

9 Methods

Rating	Name	Size	Complexity
A	__construct()	8	2
A	make()	4	1
A	limit()	4	1
A	all()	4	1
A	order()	4	1
A	whereStatus()	4	1
A	whereSlug()	4	1
A	set()	6	1
A	query()	9	2

<?php

namespace Silk\Post;

use WP_Query;
use Silk\Query\Builder as BaseBuilder;

class QueryBuilder extends BaseBuilder
{
    /**
     * WP_Query instance
     *
     * @var WP_Query
     */
    protected $query;

    /**
     * Builder constructor.
     *
     * @param WP_Query $query
     */
    public function __construct(WP_Query $query = null)
    {
        if (! $query) {
            $query = new WP_Query();
        }

        $this->query = $query;
    }

    /**
     * Create a new instance.
     *
     * @param WP_Query $query
     *
     * @return static
     */
    public static function make(WP_Query $query = null)
    {
        return new static($query);
    }

    /**
     * Limit the number of returned results
     *
     * @param integer $limit  The maximum number of results to return
     *                        use -1 for no limit
     *
     * @return $this
     */
    public function limit($limit)
    {
        return $this->set('posts_per_page', (int) $limit);
    }

    /**
     * Return an unlimited number of results.
     *
     * @return $this
     */
    public function all()
    {
        return $this->limit(-1);
    }

    /**
     * Set the order for the query
     *
     * @param  string $order
     *
     * @return $this
     */
    public function order($order)
    {
        return $this->set('order', strtoupper($order));
    }

    /**
     * Query by post status
     *
     * @param  string|array $status  the post status or stati to match
     *
     * @return $this
     */
    public function whereStatus($status)
    {
        return $this->set('post_status', $status);
    }

    /**
     * Query by slug
     *
     * @param  string $slug  the post slug to query by
     *
     * @return $this
     */
    public function whereSlug($slug)
    {
        return $this->set('name', $slug);
    }

    /**
     * Set a query variable on the query
     *
     * @param string $var   Query variable key
     * @param mixed  $value Query value for key
     *
     * @return $this
     */
    public function set($var, $value)
    {
        $this->query->set($var, $value);

        return $this;
    }

    /**
     * Execute the query and return the raw results.
     *
     * @return array
     */
    protected function query()
    {
        if ($this->model) {
            $this->set('post_type', $this->model->post_type)
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                 ->set('fields', ''); // as WP_Post objects
        }

        return $this->query->get_posts();
    }
}


1			<?php
2
3			namespace Silk\Post;
4
5			use WP_Query;
6			use Silk\Query\Builder as BaseBuilder;
7
8			class QueryBuilder extends BaseBuilder
9			{
10			/**
11			* WP_Query instance
12			*
13			* @var WP_Query
14			*/
15			protected $query;
16
17			/**
18			* Builder constructor.
19			*
20			* @param WP_Query $query
21			*/
22			public function __construct(WP_Query $query = null)
23			{
24			if (! $query) {
25			$query = new WP_Query();
26			}
27
28			$this->query = $query;
29			}
30
31			/**
32			* Create a new instance.
33			*
34			* @param WP_Query $query
35			*
36			* @return static
37			*/
38			public static function make(WP_Query $query = null)
39			{
40			return new static($query);
41			}
42
43			/**
44			* Limit the number of returned results
45			*
46			* @param integer $limit The maximum number of results to return
47			* use -1 for no limit
48			*
49			* @return $this
50			*/
51			public function limit($limit)
52			{
53			return $this->set('posts_per_page', (int) $limit);
54			}
55
56			/**
57			* Return an unlimited number of results.
58			*
59			* @return $this
60			*/
61			public function all()
62			{
63			return $this->limit(-1);
64			}
65
66			/**
67			* Set the order for the query
68			*
69			* @param string $order
70			*
71			* @return $this
72			*/
73			public function order($order)
74			{
75			return $this->set('order', strtoupper($order));
76			}
77
78			/**
79			* Query by post status
80			*
81			* @param string\|array $status the post status or stati to match
82			*
83			* @return $this
84			*/
85			public function whereStatus($status)
86			{
87			return $this->set('post_status', $status);
88			}
89
90			/**
91			* Query by slug
92			*
93			* @param string $slug the post slug to query by
94			*
95			* @return $this
96			*/
97			public function whereSlug($slug)
98			{
99			return $this->set('name', $slug);
100			}
101
102			/**
103			* Set a query variable on the query
104			*
105			* @param string $var Query variable key
106			* @param mixed $value Query value for key
107			*
108			* @return $this
109			*/
110			public function set($var, $value)
111			{
112			$this->query->set($var, $value);
113
114			return $this;
115			}
116
117			/**
118			* Execute the query and return the raw results.
119			*
120			* @return array
121			*/
122			protected function query()
123			{
124			if ($this->model) {
125			$this->set('post_type', $this->model->post_type)
			0 ignored issues – show Documentation introduced 2016-08-15 22:05 UTC by Report Bug Copy Issue Report The property `post_type` does not exist on `object<Silk\Type\Model>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
126			->set('fields', ''); // as WP_Post objects
127			}
128
129			return $this->query->get_posts();
130			}
131			}
132

aaemnnosttv / silk

Push — develop ( d77dc3...4e0099 )

QueryBuilder A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

9 Methods

Duplication Side-by-Side

Filter issues like