Silk\Type\ShorthandProperties

Complexity

Total Complexity

4

Size/Duplication

Total Lines	28
Duplicated Lines	0 %

Importance

Changes

0

1 Method

Rating	Name	Duplication	Size	Complexity
A	expandAlias()	0	17	4

<?php

namespace Silk\Type;

trait ShorthandProperties
{
    protected $object;

    /**
     * Expands an alias into its respective object property name.
     *
     * @param string $key  Alias key
     *
     * @return mixed|string
     */
    protected function expandAlias($key)
    {
        $aliased = $this->getAliasedObject();

It seems like getAliasedObject() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        if (is_object($aliased) || ! empty(static::OBJECT_TYPE)) {

The constant Silk\Type\ShorthandProperties::OBJECT_TYPE was not found. Maybe you did not declare it correctly or list all dependencies?

            /**
             * Automatically alias shorthand syntax for type_name
             * Eg: 'post_content' is aliased to 'content'
             */
            $expanded = static::OBJECT_TYPE . '_' . $key;

            if (property_exists($aliased, $expanded)) {
                return $expanded;
            }
        }

        return parent::expandAlias($key);
    }
}