Issues in VCRSubscriber.php (master) - Issues in master - aaa2000/behat-vcr-extension - Measure and Improve Code Quality continuously with Scrutinizer

Issues (9)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/EventDispatcher/VCRSubscriber.php (2 issues)

Labels

Severity

Minor 2

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace BVCR\Behat\EventDispatcher;

use Behat\Behat\EventDispatcher\Event\BeforeOutlineTested;
use Behat\Behat\EventDispatcher\Event\ExampleTested;
use Behat\Behat\EventDispatcher\Event\OutlineTested;
use Behat\Gherkin\Node\OutlineNode;
use Symfony\Component\EventDispatcher\Event;
use Symfony\Component\EventDispatcher\EventSubscriberInterface;
use Behat\Behat\EventDispatcher\Event\ScenarioTested;
use VCR\Videorecorder;
use BVCR\Behat\Resolver\ConfigurationResolver;
use BVCR\Behat\Resolver\Configuration;

class VCRSubscriber implements EventSubscriberInterface
{
    /** @var \VCR\Videorecorder */
    private $videorecorder;
    /** @var \BVCR\Behat\Resolver\ConfigurationResolver */
    private $configurationResolver;
    /** @var OutlineNode */
    private $outline;


    public function __construct(Videorecorder $videorecorder, ConfigurationResolver $configurationResolver)

    {
        $this->videorecorder = $videorecorder;
        $this->configurationResolver = $configurationResolver;
    }

    public static function getSubscribedEvents()
    {
        return array(
            ScenarioTested::BEFORE => 'turnOnVCR',
            ScenarioTested::AFTER => 'turnOffVCR',
            ExampleTested::BEFORE => 'turnOnVCR',
            ExampleTested::AFTER => 'turnOffVCR',
            OutlineTested::BEFORE => 'captureOutlineOnBeforeOutlineEvent',
            OutlineTested::AFTER => 'forgetOutlineOnAfterOutlineEvent',
        );
    }

    public function turnOnVCR(ScenarioTested $event)
    {
        $configuration = $this->configurationResolver->resolve($event->getScenario());

        if ($configuration) {
            $this->videorecorder->turnOn();
            $this->configureVCR($configuration, $event);
        }
    }

    /**
     * Captures outline into the ivar on outline BEFORE event.
     *
     * @param Event $event
     */
    public function captureOutlineOnBeforeOutlineEvent(Event $event)
    {
        if (!$event instanceof BeforeOutlineTested) {
            return;
        }

        $this->outline = $event->getOutline();
    }

    /**
     * Removes outline from the ivar on outline AFTER event.
     *
     * @param Event $event
     */
    public function forgetOutlineOnAfterOutlineEvent(Event $event)
    {
        if (!$event instanceof BeforeOutlineTested) {
            return;
        }

        $this->outline = null;
    }

    private function configureVCR(Configuration $configuration, ScenarioTested $event)
    {
        $currentVcrConfiguration = $this->videorecorder->configure();


        if ($configuration->getCassettePath()) {
            $currentVcrConfiguration->setCassettePath($configuration->getCassettePath());
        }
        if ($configuration->getCassetteStorage()) {
            $currentVcrConfiguration->setStorage($configuration->getCassetteStorage());
        }
        if ($configuration->getLibraryHooks()) {
            $currentVcrConfiguration->enableLibraryHooks($configuration->getLibraryHooks());
        }
        if ($configuration->getRequestMatchers()) {
            $currentVcrConfiguration->enableRequestMatchers($configuration->getRequestMatchers());
        }
        if ($configuration->getMode()) {
            $currentVcrConfiguration->setMode($configuration->getMode());
        }

        $filename = $configuration->getFileNamingStrategy()->createFilename(
            $event->getFeature(),
            $event->getScenario(),
            $this->outline
        );
        $this->videorecorder->insertCassette($filename);
    }

    public function turnOffVCR()
    {
        $this->videorecorder->turnOff();
    }
}


1			<?php
2
3			namespace BVCR\Behat\EventDispatcher;
4
5			use Behat\Behat\EventDispatcher\Event\BeforeOutlineTested;
6			use Behat\Behat\EventDispatcher\Event\ExampleTested;
7			use Behat\Behat\EventDispatcher\Event\OutlineTested;
8			use Behat\Gherkin\Node\OutlineNode;
9			use Symfony\Component\EventDispatcher\Event;
10			use Symfony\Component\EventDispatcher\EventSubscriberInterface;
11			use Behat\Behat\EventDispatcher\Event\ScenarioTested;
12			use VCR\Videorecorder;
13			use BVCR\Behat\Resolver\ConfigurationResolver;
14			use BVCR\Behat\Resolver\Configuration;
15
16			class VCRSubscriber implements EventSubscriberInterface
17			{
18			/** @var \VCR\Videorecorder */
19			private $videorecorder;
20			/** @var \BVCR\Behat\Resolver\ConfigurationResolver */
21			private $configurationResolver;
22			/** @var OutlineNode */
23			private $outline;
24
25
26			public function __construct(Videorecorder $videorecorder, ConfigurationResolver $configurationResolver)
			0 ignored issues – show Comprehensibility Naming introduced 2016-08-31 20:26 UTC by Report Bug Copy Issue Report Show Similar Issues like this The variable name `$configurationResolver` exceeds the maximum configured length of `20`. Very long variable names usually make code harder to read. It is therefore recommended not to make variable names too verbose. Loading history...
27			{
28			$this->videorecorder = $videorecorder;
29			$this->configurationResolver = $configurationResolver;
30			}
31
32			public static function getSubscribedEvents()
33			{
34			return array(
35			ScenarioTested::BEFORE => 'turnOnVCR',
36			ScenarioTested::AFTER => 'turnOffVCR',
37			ExampleTested::BEFORE => 'turnOnVCR',
38			ExampleTested::AFTER => 'turnOffVCR',
39			OutlineTested::BEFORE => 'captureOutlineOnBeforeOutlineEvent',
40			OutlineTested::AFTER => 'forgetOutlineOnAfterOutlineEvent',
41			);
42			}
43
44			public function turnOnVCR(ScenarioTested $event)
45			{
46			$configuration = $this->configurationResolver->resolve($event->getScenario());
47
48			if ($configuration) {
49			$this->videorecorder->turnOn();
50			$this->configureVCR($configuration, $event);
51			}
52			}
53
54			/**
55			* Captures outline into the ivar on outline BEFORE event.
56			*
57			* @param Event $event
58			*/
59			public function captureOutlineOnBeforeOutlineEvent(Event $event)
60			{
61			if (!$event instanceof BeforeOutlineTested) {
62			return;
63			}
64
65			$this->outline = $event->getOutline();
66			}
67
68			/**
69			* Removes outline from the ivar on outline AFTER event.
70			*
71			* @param Event $event
72			*/
73			public function forgetOutlineOnAfterOutlineEvent(Event $event)
74			{
75			if (!$event instanceof BeforeOutlineTested) {
76			return;
77			}
78
79			$this->outline = null;
80			}
81
82			private function configureVCR(Configuration $configuration, ScenarioTested $event)
83			{
84			$currentVcrConfiguration = $this->videorecorder->configure();
			0 ignored issues – show Comprehensibility Naming introduced 2016-08-31 20:26 UTC by Report Bug Copy Issue Report Show Similar Issues like this The variable name `$currentVcrConfiguration` exceeds the maximum configured length of `20`. Very long variable names usually make code harder to read. It is therefore recommended not to make variable names too verbose. Loading history...
85
86			if ($configuration->getCassettePath()) {
87			$currentVcrConfiguration->setCassettePath($configuration->getCassettePath());
88			}
89			if ($configuration->getCassetteStorage()) {
90			$currentVcrConfiguration->setStorage($configuration->getCassetteStorage());
91			}
92			if ($configuration->getLibraryHooks()) {
93			$currentVcrConfiguration->enableLibraryHooks($configuration->getLibraryHooks());
94			}
95			if ($configuration->getRequestMatchers()) {
96			$currentVcrConfiguration->enableRequestMatchers($configuration->getRequestMatchers());
97			}
98			if ($configuration->getMode()) {
99			$currentVcrConfiguration->setMode($configuration->getMode());
100			}
101
102			$filename = $configuration->getFileNamingStrategy()->createFilename(
103			$event->getFeature(),
104			$event->getScenario(),
105			$this->outline
106			);
107			$this->videorecorder->insertCassette($filename);
108			}
109
110			public function turnOffVCR()
111			{
112			$this->videorecorder->turnOff();
113			}
114			}
115

GitHub Access Token became invalid

Issues (9)

Security Analysis not enabled

src/EventDispatcher/VCRSubscriber.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

aaa2000 / behat-vcr-extension

GitHub Access Token became invalid

Issues (9)

Security Analysis not enabled

src/EventDispatcher/VCRSubscriber.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like