ZsgsDesign / NOJ

app/Http/Controllers/ProblemController.php

<?php

namespace App\Http\Controllers;

use App\Models\ProblemModel;
use App\Models\Submission\SubmissionModel;
use App\Models\CompilerModel;
use App\Models\AccountModel;
use App\Http\Controllers\Controller;
use Illuminate\Http\Request;
use App\Models\Eloquent\Tool\MonacoTheme;
use JavaScript;
use Auth;

class ProblemController extends Controller
{
    /**
     * Show the Problem Index Page.
     *
     * @return Response

The type App\Http\Controllers\Response was not found. Did you mean Response? If so, make sure to prefix the type with \.

     */
    public function index(Request $request)
    {
        $all_data=$request->all();
        $problem=new ProblemModel();
        $filter["oj"]=isset($all_data["oj"]) ? $all_data["oj"] : null;

$filter was never initialized. Although not strictly required by PHP, it is generally a good practice to add $filter = array(); before regardless.

        $filter["tag"]=isset($all_data["tag"]) ? $all_data["tag"] : null;
        $list_return=$problem->list($filter, Auth::check() ?Auth::user()->id : null);

Accessing id on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

        $tags=$problem->tags();
        $ojs=$problem->ojs();
        if (is_null($list_return)) {
            if (isset($all_data["page"]) && $all_data["page"]>1) {
                return redirect("/problem");

The expression return redirect('/problem') returns the type Illuminate\Http\RedirectResponse which is incompatible with the documented return type App\Http\Controllers\Response.

            } else {
                return view('problem.index', [

The expression return view('problem.index', array('page_title' => 'Problem', 'site_title' => config('app.name'), 'navigation' => 'Problem', 'prob_list' => null, 'prob_paginate' => null, 'tags' => $tags, 'ojs' => $ojs, 'filter' => $filter)) returns the type Illuminate\View\View which is incompatible with the documented return type App\Http\Controllers\Response.

                    'page_title' => "Problem",
                    'site_title' => config("app.name"),
                    'navigation' => "Problem",
                    'prob_list' => null,
                    'prob_paginate' => null,
                    'tags' => $tags,
                    'ojs' => $ojs,
                    'filter' => $filter
                ]);
            }
        } else {
            return view('problem.index', [

The expression return view('problem.index', array('page_title' => 'Problem', 'site_title' => config('app.name'), 'navigation' => 'Problem', 'prob_list' => $list_return['problems'], 'paginator' => $list_return['paginator'], 'tags' => $tags, 'ojs' => $ojs, 'filter' => $filter)) returns the type Illuminate\View\View which is incompatible with the documented return type App\Http\Controllers\Response.

                'page_title' => "Problem",
                'site_title' => config("app.name"),
                'navigation' => "Problem",
                'prob_list' => $list_return['problems'],
                'paginator' => $list_return['paginator'],
                'tags' => $tags,
                'ojs' => $ojs,
                'filter' => $filter
            ]);
        }
    }
    /**
     * Show the Problem Detail Page.
     *
     * @return Response
     */
    public function detail($pcode)
    {
        $problem=new ProblemModel();
        $prob_detail=$problem->detail($pcode);
        if(blank($prob_detail) || $problem->isHidden($prob_detail["pid"])) {
            return redirect("/problem");

The expression return redirect('/problem') returns the type Illuminate\Http\RedirectResponse which is incompatible with the documented return type App\Http\Controllers\Response.

        }
        if ($problem->isBlocked($prob_detail["pid"])) {
            return abort('403');
        }
        return view('problem.detail', [

The expression return view('problem.detail', array('page_title' => $prob_detail['title'], 'site_title' => config('app.name'), 'navigation' => 'Problem', 'detail' => $prob_detail)) returns the type Illuminate\View\View which is incompatible with the documented return type App\Http\Controllers\Response.

            'page_title'=>$prob_detail["title"],
            'site_title'=>config("app.name"),
            'navigation' => "Problem",
            'detail' => $prob_detail
        ]);
    }

    /**
     * Show the Problem Solution Page.
     *
     * @return Response
     */
    public function solution($pcode)
    {
        $problem=new ProblemModel();
        $prob_detail=$problem->detail($pcode);
        if ($problem->isBlocked($prob_detail["pid"]) || $problem->isHidden($prob_detail["pid"])) {
            return abort('403');
        }
        $solution=$problem->solutionList($prob_detail["pid"], Auth::check() ?Auth::user()->id : null);

Accessing id on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

        $submitted=Auth::check() ? $problem->solution($prob_detail["pid"], Auth::user()->id) : [];
        return is_null($prob_detail) ?  redirect("/problem") : view('problem.solution', [

The expression return is_null($prob_detail) ? redirect('/problem') : view('problem.solution', array('page_title' => 'Solution', 'site_title' => config('app.name'), 'navigation' => $prob_detail['title'], 'detail' => $prob_detail, 'solution' => $solution, 'submitted' => $submitted)) returns the type Illuminate\Http\RedirectResponse|Illuminate\View\View which is incompatible with the documented return type App\Http\Controllers\Response.

                                            'page_title'=> "Solution",
                                            'site_title'=>config("app.name"),
                                            'navigation' => $prob_detail["title"],
                                            'detail' => $prob_detail,
                                            'solution'=>$solution,
                                            'submitted'=>$submitted
                                        ]);
    }

    /**
     * Show the Problem Editor Page.
     *
     * @return Response
     */
    public function editor($pcode)
    {
        $problem=new ProblemModel();
        $compiler=new CompilerModel();
        $submission=new SubmissionModel();
        $account=new AccountModel();

The assignment to $account is dead and can be removed.

        $prob_detail=$problem->detail($pcode);
        if ($problem->isBlocked($prob_detail["pid"]) || $problem->isHidden($prob_detail["pid"])) {
            return abort('403');
        }
        $compiler_list=$compiler->list($prob_detail["OJ"], $prob_detail["pid"]);
        $prob_status=$submission->getProblemStatus($prob_detail["pid"], Auth::user()->id);

Accessing id on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

        $compiler_pref=$compiler->pref($compiler_list, $prob_detail["pid"], Auth::user()->id);
        $pref=$compiler_pref["pref"];
        $submit_code=$compiler_pref["code"];

        $oj_detail=$problem->ojdetail($prob_detail["OJ"]);

        if (empty($prob_status)) {
            $prob_status=[
                "verdict"=>"NOT SUBMIT",
                "color"=>""
            ];
        }

        $accountExt=Auth::user()->getExtra(['editor_left_width', 'editor_theme']);

The method getExtra() does not exist on Illuminate\Contracts\Auth\Authenticatable. It seems like you code against a sub-type of said class. However, the method does not exist in Illuminate\Auth\GenericUser. Are you sure you never get one of those?

        $editor_left_width=isset($accountExt['editor_left_width']) ? $accountExt['editor_left_width'] : '40';
        $editor_theme=isset($accountExt['editor_theme']) ? $accountExt['editor_theme'] : config('app.editor_theme');
        $themeConfig=MonacoTheme::getTheme($editor_theme);

        return is_null($prob_detail) ?  redirect("/problem") : view('problem.editor', [

The expression return is_null($prob_detail) ? redirect('/problem') : view('problem.editor', array('page_title' => $prob_detail['title'], 'site_title' => config('app.name'), 'navigation' => 'Problem', 'detail' => $prob_detail, 'compiler_list' => $compiler_list, 'status' => $prob_status, 'pref' => $pref < 0 ? 0 : $pref, 'submit_code' => $submit_code, 'contest_mode' => false, 'oj_detail' => $oj_detail, 'editor_left_width' => $editor_left_width, 'theme_config' => $themeConfig, 'editor_themes' => App\Models\Eloquent\Tool\MonacoTheme::getAll())) returns the type Illuminate\Http\RedirectResponse|Illuminate\View\View which is incompatible with the documented return type App\Http\Controllers\Response.

                                            'page_title'=>$prob_detail["title"],
                                            'site_title'=>config("app.name"),
                                            'navigation' => "Problem",
                                            'detail' => $prob_detail,
                                            'compiler_list' => $compiler_list,
                                            'status' => $prob_status,
                                            'pref'=>$pref<0 ? 0 : $pref,
                                            'submit_code'=>$submit_code,
                                            'contest_mode'=> false,
                                            'oj_detail'=>$oj_detail,
                                            'editor_left_width'=>$editor_left_width,
                                            'theme_config'=>$themeConfig,
                                            'editor_themes'=>MonacoTheme::getAll(),
                                        ]);
    }

    /**
     * Show the Problem Discussion Page.
     *
     * @return Response
     */
    public function discussion($pcode)
    {
        //TODO
        $problem=new ProblemModel();
        $prob_detail=$problem->detail($pcode);
        if ($problem->isBlocked($prob_detail["pid"])) {
            return abort('403');
        }
        $list=$problem->discussionList($prob_detail["pid"]);
        $discussion=$list['list'];
        $paginator=$list['paginator'];
        return is_null($prob_detail) ?  redirect("/problem") : view('problem.discussion', [

The expression return is_null($prob_detail) ? redirect('/problem') : view('problem.discussion', array('page_title' => 'Discussion', 'site_title' => config('app.name'), 'navigation' => $prob_detail['title'], 'detail' => $prob_detail, 'discussion' => $discussion, 'paginator' => $paginator)) returns the type Illuminate\Http\RedirectResponse|Illuminate\View\View which is incompatible with the documented return type App\Http\Controllers\Response.

                                            'page_title'=> "Discussion",
                                            'site_title'=>config("app.name"),
                                            'navigation' => $prob_detail["title"],
                                            'detail' => $prob_detail,
                                            'discussion'=>$discussion,
                                            'paginator'=>$paginator
                                        ]);
    }

    /**
     * Show the Problem Discussion Post Page.
     *
     * @return Response
     */
    public function discussionPost($dcode)
    {
        //TODO
        $problem=new ProblemModel();
        $pcode=$problem->pcodeByPdid($dcode);
        $prob_detail=$problem->detail($pcode);
        if ($problem->isBlocked($prob_detail["pid"])) {
            return abort('403');
        }
        $detail=$problem->discussionDetail($dcode);
        $main=$detail['main'];
        $paginator=$detail['paginator'];
        $comment=$detail['comment'];
        $comment_count=$detail['comment_count'];
        return is_null($prob_detail) ?  redirect("/problem") : view('problem.discussion_post', [

The expression return is_null($prob_detail) ? redirect('/problem') : view('problem.discussion_post', array('page_title' => 'Discussion', 'site_title' => config('app.name'), 'navigation' => $prob_detail['title'], 'detail' => $prob_detail, 'main' => $main, 'paginator' => $paginator, 'comment' => $comment, 'comment_count' => $comment_count)) returns the type Illuminate\Http\RedirectResponse|Illuminate\View\View which is incompatible with the documented return type App\Http\Controllers\Response.

                                            'page_title'=> "Discussion",
                                            'site_title'=>config("app.name"),
                                            'navigation' => $prob_detail["title"],
                                            'detail' => $prob_detail,
                                            'main'=>$main,
                                            'paginator'=>$paginator,
                                            'comment'=>$comment,
                                            'comment_count'=>$comment_count
                                        ]);
    }
}