App\Http\Controllers\VirtualCrawler\PTA\PTA::crawling()

Complexity

Conditions	10
Paths	56

Size

Total Lines	106
Code Lines	73

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
    public function crawling($conType)
    {
        $start=time();
        $f = fopen(__DIR__."/pta_status.log", "w") or die("Unable to open file!");

Using exit here is not recommended.

        if ($conType == 'all') {
            // Here is the script
            //
            // var a="";
            // document.querySelectorAll('a[href^="/problem-sets/"]').forEach(v=>{a+=v.href.split("/")[4]+","})
            // console.log(a);

            $conList=[12,13,14,15,16,17,434,994805046380707840,994805148990160896,994805260223102976,994805342720868352];
        } else {
            $conList=[intval($conType)];
        }

        foreach ($conList as $con) {
            $this->con = $con;
            $this->imgi = 1;
            $problemModel=new ProblemModel();
            $res = Requests::post("https://pintia.cn/api/problem-sets/$con/exams",[
                "Content-Type"=>"application/json"
            ],"{}");

            if (strpos($res->body, 'PROBLEM_SET_NOT_FOUND') !== false) {
                header('HTTP/1.1 404 Not Found');
                die();
            } else {
                $generalDetails=json_decode($res->body,true);
                $compilerModel = new CompilerModel();
                $list = $compilerModel->list($this->oid);
                $compilers = [];
                foreach ($generalDetails['problemSet']['problemSetConfig']['compilers'] as $lcode) {
                    foreach ($list as $compiler) {
                        if ($compiler['lcode'] == $lcode) {
                            array_push($compilers, $compiler['coid']);
                            break;
                        }
                    }
                }
                $this->pro['special_compiler'] = join(',', $compilers);
            }

            $now=time()-$start;
            fwrite($f, "General Detail API Success at {$now}".PHP_EOL);

It seems like $f can also be of type false; however, parameter $handle of fwrite() does only seem to accept resource, maybe add an additional type check?

            $probLists = json_decode(Requests::get(
                "https://pintia.cn/api/problem-sets/$con/problems?type=PROGRAMMING&exam_id=0",[
                    "Content-Type"=>"application/json"
                ]
            )->body, true)["problemSetProblems"];

            $now=time()-$start;
            fwrite($f, "    Problems List API Success at {$now}".PHP_EOL);

            foreach ($probLists as $prob) {
                $probDetails = json_decode(Requests::get(
                    "https://pintia.cn/api/problem-sets/$con/problems/{$prob["id"]}?exam_id=0",[
                        "Content-Type"=>"application/json"
                    ]
                )->body, true)["problemSetProblem"];

                $now=time()-$start;
                fwrite($f, "    Problem Details API Success at {$now}".PHP_EOL);

                $this->pro['pcode'] = 'PTA'.$prob["id"];
                $this->pro['OJ'] = $this->oid;
                $this->pro['contest_id'] = $con;
                $this->pro['index_id'] = $prob["id"];
                $this->pro['origin'] = "https://pintia.cn/problem-sets/$con/problems/{$prob["id"]}";
                $this->pro['title'] = $prob["title"];
                $this->pro['time_limit'] = $probDetails["problemConfig"]["programmingProblemConfig"]["timeLimit"];
                $this->pro['memory_limit'] = $probDetails["problemConfig"]["programmingProblemConfig"]["memoryLimit"];
                $this->pro['solved_count'] = $prob["acceptCount"];
                $this->pro['input_type'] = 'standard input';
                $this->pro['output_type'] = 'standard output';

                $this->pro['description'] = str_replace("](~/","](https://images.ptausercontent.com/",$probDetails["content"]);
                $this->pro['description'] = str_replace("$$","$",$this->pro['description']);
                $this->pro['markdown'] = 1;
                $this->pro['tot_score'] = $probDetails["score"];
                $this->pro["partial"] = 1;
                $this->pro['input'] = null;
                $this->pro['output'] = null;
                $this->pro['note'] = null;
                $this->pro['sample'] = [];
                $this->pro['source'] = $generalDetails["problemSet"]["name"];

                $problem=$problemModel->pid($this->pro['pcode']);

                if ($problem) {
                    $problemModel->clearTags($problem);
                    $new_pid=$this->update_problem($this->oid);

The assignment to $new_pid is dead and can be removed.

                } else {
                    $new_pid=$this->insert_problem($this->oid);
                }

                $now=time()-$start;
                fwrite($f, "    Problem {$this->pro['pcode']} Success at {$now}".PHP_EOL);

                sleep(1); // PTA Restrictions

                // $problemModel->addTags($new_pid, $tag);
            }
        }
        fclose($f);

It seems like $f can also be of type false; however, parameter $handle of fclose() does only seem to accept resource, maybe add an additional type check?

    }