ZsgsDesign / NOJ

app/Http/Controllers/Group/IndexController.php

Braces +10 added lines, -4 removed lines

@@ -43,7 +43,9 @@ 
         $groupModel=new GroupModel();
         $contestModel=new ContestModel();
         $basic_info=$groupModel->details($gcode);
-        if(empty($basic_info)) return Redirect::route('group.index');
+        if(empty($basic_info)) {
+            return Redirect::route('group.index');
+        }
         $my_profile=$groupModel->userProfile(Auth::user()->id, $basic_info["gid"]);
         $clearance=$groupModel->judgeClearance($basic_info["gid"], Auth::user()->id);
         $member_list=$groupModel->userList($basic_info["gid"]);
@@ -89,9 +91,13 @@ 
     public function analysis($gcode){
         $groupModel = new GroupModel();
         $basic_info=$groupModel->details($gcode);
-        if(empty($basic_info)) return Redirect::route('group.index');
+        if(empty($basic_info)) {
+            return Redirect::route('group.index');
+        }
         $clearance=$groupModel->judgeClearance($basic_info["gid"], Auth::user()->id);
-        if($clearance < 1) return Redirect::route('group.detail',['gcode' => $gcode]);
+        if($clearance < 1) {
+            return Redirect::route('group.detail',['gcode' => $gcode]);
+        }
         $group_info = $groupModel->details($gcode);
         return view('group.settings.analysis', [
             'page_title'=>"Group Analysis",
@@ -123,7 +129,7 @@ 
                 ),
                 $gcode . '_Group_Contest_Analysis.xlsx'
             );
-        }else{
+        } else{
             $data = $groupModel->groupMemberPracticeTagStat($group_info['gid']);
             return Excel::download(
                 new GroupAnalysisExport(

app/Console/Kernel.php

Braces +2 added lines, -2 removed lines

@@ -65,12 +65,12 @@
             foreach ($ret as $gid => $group) {
                 if(empty($group['result'])){
                     Log::channel('group_elo')->info('Refreshed Group Elo (Empty) : ('.$gid.')'.$group['name']);
-                }else{
+                } else{
                     Log::channel('group_elo')->info('Refreshing Group Elo: ('.$gid.')'.$group['name']);
                     foreach ($group['result'] as $contest) {
                         if($contest['ret'] == 'success'){
                             Log::channel('group_elo')->info('    Elo Clac Successfully : ('.$contest['cid'].')'.$contest['name']);
-                        }else{
+                        } else{
                             Log::channel('group_elo')->info('    Elo Clac Faild (Judge Not Over) : ('.$contest['cid'].')'.$contest['name'].'  sids:');
                             foreach ($contest['submissions'] as $sid) {
                                 Log::channel('group_elo')->info('        '.$sid['sid']);

app/Babel/Submit/Curl.php

Braces +105 added lines, -21 removed lines

@@ -18,11 +18,31 @@ 
 
     public function login($all_data)
     {
-        if(isset($all_data["url"]))    $url = $all_data["url"];       else throw new Exception("url is not exist in all_data");
-        if(isset($all_data["data"]))   $data = $all_data["data"];     else throw new Exception("data is not exist in all_data");
-        if(isset($all_data["oj"]))     $oj = $all_data["oj"];         else throw new Exception("oj is not exist in all_data");
-        if(isset($all_data["ret"]))    $ret = $all_data["ret"];       else $ret = 'false';
-        if(isset($all_data["handle"])) $handle = $all_data["handle"]; else $handle = "default";
+        if(isset($all_data["url"])) {
+            $url = $all_data["url"];
+        } else {
+            throw new Exception("url is not exist in all_data");
+        }
+        if(isset($all_data["data"])) {
+            $data = $all_data["data"];
+        } else {
+            throw new Exception("data is not exist in all_data");
+        }
+        if(isset($all_data["oj"])) {
+            $oj = $all_data["oj"];
+        } else {
+            throw new Exception("oj is not exist in all_data");
+        }
+        if(isset($all_data["ret"])) {
+            $ret = $all_data["ret"];
+        } else {
+            $ret = 'false';
+        }
+        if(isset($all_data["handle"])) {
+            $handle = $all_data["handle"];
+        } else {
+            $handle = "default";
+        }
 
         $datapost=curl_init();
         $headers=array("Expect:");
@@ -54,12 +74,36 @@ 
 
     public function grab_page($all_data)
     {
-        if(isset($all_data["site"]))    $site = $all_data["site"];          else throw new Exception("site is not exist in all_data");
-        if(isset($all_data["oj"]))      $oj = $all_data["oj"];              else throw new Exception("oj is not exist in all_data");
-        if(isset($all_data["headers"])) $headers = $all_data["headers"];    else $headers = [];
-        if(isset($all_data["handle"]))  $handle = $all_data["handle"];      else $handle = "default";
-        if(isset($all_data["follow"]))  $follow = $all_data["follow"];      else $follow = false;
-        if(isset($all_data["vcid"]))  $vcid = $all_data["vcid"]."_";      else $vcid = "";
+        if(isset($all_data["site"])) {
+            $site = $all_data["site"];
+        } else {
+            throw new Exception("site is not exist in all_data");
+        }
+        if(isset($all_data["oj"])) {
+            $oj = $all_data["oj"];
+        } else {
+            throw new Exception("oj is not exist in all_data");
+        }
+        if(isset($all_data["headers"])) {
+            $headers = $all_data["headers"];
+        } else {
+            $headers = [];
+        }
+        if(isset($all_data["handle"])) {
+            $handle = $all_data["handle"];
+        } else {
+            $handle = "default";
+        }
+        if(isset($all_data["follow"])) {
+            $follow = $all_data["follow"];
+        } else {
+            $follow = false;
+        }
+        if(isset($all_data["vcid"])) {
+            $vcid = $all_data["vcid"]."_";
+        } else {
+            $vcid = "";
+        }
 
         $handle=urlencode($handle);
 
@@ -86,16 +130,56 @@ 
 
     public function post_data($all_data)
     {
-        if(isset($all_data["site"]))         $site = $all_data["site"];                 else throw new Exception("site is not exist in all_data");
-        if(isset($all_data["data"]))         $data = $all_data["data"];                 else throw new Exception("data is not exist in all_data");
-        if(isset($all_data["oj"]))           $oj = $all_data["oj"];                     else throw new Exception("oj is not exist in all_data");
-        if(isset($all_data["ret"]))          $ret = $all_data["ret"];                   else $ret = false;
-        if(isset($all_data["follow"]))       $follow = $all_data["follow"];             else $follow = true;
-        if(isset($all_data["returnHeader"])) $returnHeader = $all_data["returnHeader"]; else $returnHeader = true;
-        if(isset($all_data["postJson"]))     $postJson = $all_data["postJson"];         else $postJson = false;
-        if(isset($all_data["extraHeaders"])) $extraHeaders = $all_data["extraHeaders"]; else $extraHeaders = [];
-        if(isset($all_data["handle"]))       $handle = $all_data["handle"];             else $handle = "default";
-        if(isset($all_data["vcid"]))  $vcid = $all_data["vcid"]."_";      else $vcid = "";
+        if(isset($all_data["site"])) {
+            $site = $all_data["site"];
+        } else {
+            throw new Exception("site is not exist in all_data");
+        }
+        if(isset($all_data["data"])) {
+            $data = $all_data["data"];
+        } else {
+            throw new Exception("data is not exist in all_data");
+        }
+        if(isset($all_data["oj"])) {
+            $oj = $all_data["oj"];
+        } else {
+            throw new Exception("oj is not exist in all_data");
+        }
+        if(isset($all_data["ret"])) {
+            $ret = $all_data["ret"];
+        } else {
+            $ret = false;
+        }
+        if(isset($all_data["follow"])) {
+            $follow = $all_data["follow"];
+        } else {
+            $follow = true;
+        }
+        if(isset($all_data["returnHeader"])) {
+            $returnHeader = $all_data["returnHeader"];
+        } else {
+            $returnHeader = true;
+        }
+        if(isset($all_data["postJson"])) {
+            $postJson = $all_data["postJson"];
+        } else {
+            $postJson = false;
+        }
+        if(isset($all_data["extraHeaders"])) {
+            $extraHeaders = $all_data["extraHeaders"];
+        } else {
+            $extraHeaders = [];
+        }
+        if(isset($all_data["handle"])) {
+            $handle = $all_data["handle"];
+        } else {
+            $handle = "default";
+        }
+        if(isset($all_data["vcid"])) {
+            $vcid = $all_data["vcid"]."_";
+        } else {
+            $vcid = "";
+        }
 
         $handle=urlencode($handle);
 

app/Http/Controllers/Contest/BoardController.php

Braces +12 added lines, -10 removed lines

@@ -37,7 +37,7 @@ 
         if (!$clearance || time() < strtotime($basicInfo['begin_time'])) {
             if($clearance == 3){
                 return Redirect::route('contest.admin', ['cid' => $cid]);
-            }else{
+            } else{
                 return Redirect::route('contest.detail', ['cid' => $cid]);
             }
         }
@@ -83,7 +83,7 @@ 
         if (!$clearance || time() < strtotime($basicInfo['begin_time'])) {
             if($clearance == 3){
                 return Redirect::route('contest.admin', ['cid' => $cid]);
-            }else{
+            } else{
                 return Redirect::route('contest.detail', ['cid' => $cid]);
             }
         }
@@ -116,7 +116,9 @@ 
         }
 
         $editor_left_width = $accountModel->getExtra(Auth::user()->id, 'editor_left_width');
-        if(empty($editor_left_width)) $editor_left_width='40';
+        if(empty($editor_left_width)) {
+            $editor_left_width='40';
+        }
 
         return view('contest.board.editor', [
             'page_title'=>"Problem Detail",
@@ -153,7 +155,7 @@ 
         if (!$clearance || time() < strtotime($basicInfo['begin_time'])) {
             if($clearance == 3){
                 return Redirect::route('contest.admin', ['cid' => $cid]);
-            }else{
+            } else{
                 return Redirect::route('contest.detail', ['cid' => $cid]);
             }
         }
@@ -168,10 +170,10 @@ 
             if($i != 0) {
                 if($r['score'] == $contestRank[$i-1]['score'] && $r['penalty'] == $contestRank[$i-1]['penalty']){
                     $r['rank'] = $contestRank[$i-1]['rank'];
-                }else{
+                } else{
                     $r['rank'] = $i + 1;
                 }
-            }else{
+            } else{
                 $r['rank'] = 1;
             }
         }
@@ -212,7 +214,7 @@ 
         if (!$clearance || time() < strtotime($basicInfo['begin_time'])) {
             if($clearance == 3){
                 return Redirect::route('contest.admin', ['cid' => $cid]);
-            }else{
+            } else{
                 return Redirect::route('contest.detail', ['cid' => $cid]);
             }
         }
@@ -250,7 +252,7 @@ 
         if (!$clearance || time() < strtotime($basicInfo['begin_time'])) {
             if($clearance == 3){
                 return Redirect::route('contest.admin', ['cid' => $cid]);
-            }else{
+            } else{
                 return Redirect::route('contest.detail', ['cid' => $cid]);
             }
         }
@@ -285,7 +287,7 @@ 
         if (!$clearance || time() < strtotime($basicInfo['begin_time'])) {
             if($clearance == 3){
                 return Redirect::route('contest.admin', ['cid' => $cid]);
-            }else{
+            } else{
                 return Redirect::route('contest.detail', ['cid' => $cid]);
             }
         }
@@ -310,7 +312,7 @@ 
         if (!$clearance || time() < strtotime($basicInfo['begin_time'])) {
             if($clearance == 3){
                 return Redirect::route('contest.admin', ['cid' => $cid]);
-            }else{
+            } else{
                 return Redirect::route('contest.detail', ['cid' => $cid]);
             }
         }