App\Http\Controllers\Oauth\GithubController

Complexity

Total Complexity

12

Size/Duplication

Total Lines	181
Duplicated Lines	0 %

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
B	handleCallback()	0	69	5
A	unbind()	0	36	2
A	confirmUnbind()	0	34	2
A	redirectTo()	0	25	3

<?php

namespace App\Http\Controllers\Oauth;

use Illuminate\Http\Request;
use App\Http\Controllers\Controller;
use App\Models\AccountModel;
use App\Models\UserModel;
use Laravel\Socialite\Facades\Socialite;
use Auth;

class GithubController extends Controller
{
    public function redirectTo()
    {
        $accountModel = new AccountModel();
        if(Auth::check() && $accountModel->getExtra(Auth::user()->id ,'github_id')){
            return view('oauth.index',[
                'page_title'=>"OAuth",
                'site_title'=>"NOJ",
                'navigation'=>"OAuth",
                'platform' => 'Github',
                'display_html' => 'You\'re already tied to the github account : <span class="text-info">'.$accountModel->getExtra(Auth::user()->id ,'github_email').'</span><br />

Are you sure $accountModel->getExtra(Auth::user()->id, 'github_email') of type array|string can be used in concatenation?

                You can choose to unbind or go back to the homepage',
                'buttons' => [
                    [
                        'text' => 'unbind',
                        'href' => route('oauth_github_unbind'),
                        'style' => 'btn-danger'
                    ],
                    [
                        'text' => 'home',
                        'href' => route('home'),
                    ],
                ]
            ]);
        }
        return Socialite::driver('github')->redirect();
    }

    public function handleCallback()
    {
        $github_user = Socialite::driver('github')->user();
        $accountModel = new AccountModel();

        if(Auth::check()){
            $user_id = Auth::user()->id;
            $ret = $accountModel->findExtra('github_id',$github_user->id);

Accessing id on the interface Laravel\Socialite\Contracts\User suggest that you code against a concrete implementation. How about adding an instanceof check?

            if(!empty($ret) && $ret['uid'] != $user_id){
                $user = UserModel::find($ret['uid']);
                return view('oauth.index',[
                    'page_title'=>"OAuth",
                    'site_title'=>"NOJ",
                    'navigation'=>"OAuth",
                    'platform' => 'Github',
                    'display_html' => 'The github account is now tied to another NOJ account : <span class="text-danger">'.$user->email.'</span><br />
                    You can try logging in using github',
                    'buttons' => [
                        [
                            'text' => 'home',
                            'href' => route('home'),
                        ],
                    ]
                ]);
            }
            $accountModel->setExtra($user_id,'github_id',$github_user->id);
            $accountModel->setExtra($user_id,'github_email',$github_user->email);

Accessing email on the interface Laravel\Socialite\Contracts\User suggest that you code against a concrete implementation. How about adding an instanceof check?

            $accountModel->setExtra($user_id,'github_nickname',$github_user->nickname);

Accessing nickname on the interface Laravel\Socialite\Contracts\User suggest that you code against a concrete implementation. How about adding an instanceof check?

            $accountModel->setExtra($user_id,'github_homepage',($github_user->user)['html_url']);

Accessing user on the interface Laravel\Socialite\Contracts\User suggest that you code against a concrete implementation. How about adding an instanceof check?

            $accountModel->setExtra($user_id,'github_token',$github_user->token,101);

Accessing token on the interface Laravel\Socialite\Contracts\User suggest that you code against a concrete implementation. How about adding an instanceof check?

            return view('oauth.index',[
                'page_title'=>"OAuth",
                'site_title'=>"NOJ",
                'navigation'=>"OAuth",
                'platform' => 'Github',
                'display_html' => 'You have successfully tied up the github account : <span class="text-info">'.$accountModel->getExtra(Auth::user()->id ,'github_email').'</span><br />

Are you sure $accountModel->getExtra(Auth::user()->id, 'github_email') of type array|string can be used in concatenation?

                You can log in to NOJ later using this account',
                'buttons' => [
                    [
                        'text' => 'home',
                        'href' => route('home'),
                    ],
                ]
            ]);
        }else{
            $ret = $accountModel->findExtra('github_id',$github_user->id);
            if(!empty($ret)){
                $github_user = Socialite::driver('github')->user();
                Auth::loginUsingId($ret['uid']);
                $accountModel->setExtra($user_id,'github_email',$github_user->email);

The variable $user_id seems to be never defined.

                $accountModel->setExtra($user_id,'github_nickname',$github_user->nickname);
                $accountModel->setExtra($user_id,'github_homepage',($github_user->user)['html_url']);
                $accountModel->setExtra($user_id,'github_token',$github_user->token,101);
                return redirect('/');
            }else{
                return view('oauth.index',[
                    'page_title'=>"OAuth",
                    'site_title'=>"NOJ",
                    'navigation'=>"OAuth",
                    'platform' => 'Github',
                    'display_text' => 'This github account doesn\'t seem to have a NOJ account, please register or log in first',
                    'buttons' => [
                        [
                            'text' => 'login',
                            'href' => route('login'),
                        ],
                        [
                            'text' => 'register',
                            'href' => route('register'),
                        ],
                    ]
                ]);
            }
        }
    }

    public function unbind()
    {
        $accountModel = new AccountModel();
        if($accountModel->getExtra(Auth::user()->id ,'github_id')){
            return view('oauth.index',[
                'page_title'=>"OAuth",
                'site_title'=>"NOJ",
                'navigation'=>"OAuth",
                'platform' => 'Github',
                'display_html' => 'You are trying to unbind the following two : <br />
                Your NOJ account : <span class="text-info">'.Auth::user()->email.'</span><br />

The property email does not exist on App\User. Since you implemented __get, consider adding a @property annotation.

                This Github account : <span class="text-info">'.$accountModel->getExtra(Auth::user()->id ,'github_email').'</span><br />

Are you sure $accountModel->getExtra(Auth::user()->id, 'github_email') of type array|string can be used in concatenation?

                Make your decision carefully, although you can later establish the binding again',
                'buttons' => [
                    [
                        'text' => 'confirm',
                        'href' => route('oauth_github_unbind_confirm'),
                        'style' => 'btn-danger'
                    ],
                    [
                        'text' => 'home',
                        'href' => route('home'),
                    ],
                ]
            ]);
        }else{
            return view('oauth.index',[
                'page_title'=>"OAuth",
                'site_title'=>"NOJ",
                'navigation'=>"OAuth",
                'platform' => 'Github',
                'display_html' => 'You\'re not tied to github',
                'buttons' => [
                    [
                        'text' => 'home',
                        'href' => route('home'),
                    ],
                ]
            ]);
        }
    }

    public function confirmUnbind()
    {
        $accountModel = new AccountModel();
        $user_id = Auth::user()->id;
        if($accountModel->getExtra($user_id ,'github_id')){
            $accountModel->setExtra($user_id,'github_id',null);
            $accountModel->setExtra($user_id,'github_email',null);
            $accountModel->setExtra($user_id,'github_nickname',null);
            $accountModel->setExtra($user_id,'github_homepage',null);
            $accountModel->setExtra($user_id,'github_token',null);
            return view('oauth.index',[
                'page_title'=>"OAuth",
                'site_title'=>"NOJ",
                'navigation'=>"OAuth",
                'platform' => 'Github',
                'display_html' => 'You have successfully unbound your Github account from your NOJ account',
                'buttons' => [
                    [
                        'text' => 'home',
                        'href' => route('home'),
                    ],
                ]
            ]);
        }else{
            return view('oauth.index',[
                'page_title'=>"OAuth",
                'site_title'=>"NOJ",
                'navigation'=>"OAuth",
                'platform' => 'Github',
                'display_html' => 'You\'re not tied to github',
                'buttons' => [
                    [
                        'text' => 'home',
                        'href' => route('home'),
                    ],
                ]
            ]);
        }

    }
}