ZsgsDesign / NOJ

app/Babel/Install/InstallerBase.php

Spacing +5 added lines, -5 removed lines

@@ -39,8 +39,8 @@ 
             //writing database
             $this->transactionDB();
 
-        }catch(Throwable $e){
-            if ($e->getMessage()!==""){
+        } catch (Throwable $e) {
+            if ($e->getMessage()!=="") {
                 $this->command->line("\n  <bg=red;fg=white> {$e->getMessage()} </>\n");
             }
         }
@@ -59,12 +59,12 @@ 
     public function __construct($class)
     {
         $this->command=$class;
-        $this->versionParser = new VersionConstraintParser();
+        $this->versionParser=new VersionConstraintParser();
     }
 
     private function parseVersion()
     {
-        if(empty($this->babelConfig)){
+        if (empty($this->babelConfig)) {
             throw new Exception('Missing babel.json Config file.');
         }
 
@@ -134,7 +134,7 @@ 
 
             DB::commit();
 
-        }catch(Throwable $e){
+        } catch (Throwable $e) {
             DB::rollback();
             if ($e->getMessage()!=="") {
                 $this->command->line("\n  <bg=red;fg=white> {$e->getMessage()} </>\n");

app/Models/Submission/SubmissionModel.php

Spacing +13 added lines, -13 removed lines

@@ -413,7 +413,7 @@ 
                                             ->where(['verdict'=>'Waiting'])
                                             ->get()
                                             ->all();
-        foreach($ret as &$r){
+        foreach ($ret as &$r) {
             $r["ocode"]=DB::table("oj")->where(["oid"=>$r["oid"]])->first()["ocode"];
         }
         return $ret;
@@ -431,15 +431,15 @@ 
         if (isset($sub['verdict'])) {
             $sub["color"]=$this->colorScheme[$sub['verdict']];
         }
-        $result = DB::table($this->tableName)->where(['sid'=>$sid])->update($sub);
-        $contestModel = new ContestModel();
-        $submission_info = DB::table($this->tableName) -> where(['sid'=>$sid]) -> get() -> first();
-        if ($result==1 && $submission_info['cid'] && $contestModel->isContestRunning($submission_info['cid'])){
-            $sub['pid'] = $submission_info['pid'];
-            $sub['uid'] = $submission_info['uid'];
-            $sub['cid'] = $submission_info['cid'];
-            $sub['sid'] = $sid;
-            $contestModel->updateContestRankTable($submission_info['cid'],$sub);
+        $result=DB::table($this->tableName)->where(['sid'=>$sid])->update($sub);
+        $contestModel=new ContestModel();
+        $submission_info=DB::table($this->tableName) -> where(['sid'=>$sid]) -> get() -> first();
+        if ($result==1 && $submission_info['cid'] && $contestModel->isContestRunning($submission_info['cid'])) {
+            $sub['pid']=$submission_info['pid'];
+            $sub['uid']=$submission_info['uid'];
+            $sub['cid']=$submission_info['cid'];
+            $sub['sid']=$sid;
+            $contestModel->updateContestRankTable($submission_info['cid'], $sub);
         }
         return $result;
     }
@@ -510,15 +510,15 @@ 
             'desc'
         );
 
-        if($filter["pcode"]){
+        if ($filter["pcode"]) {
             $paginator=$paginator->where(["pcode"=>$filter["pcode"]]);
         }
 
-        if($filter["result"]){
+        if ($filter["result"]) {
             $paginator=$paginator->where(["verdict"=>$filter["result"]]);
         }
 
-        if($filter["account"]){
+        if ($filter["account"]) {
             $paginator=$paginator->where(["name"=>$filter["account"]]);
         }
 

app/Http/Controllers/Group/AdminController.php

Spacing +10 added lines, -10 removed lines

@@ -21,7 +21,7 @@ 
      */
     public function settings($gcode)
     {
-        return Redirect::route('group.settings.general', ['gcode' => $gcode]);;
+        return Redirect::route('group.settings.general', ['gcode' => $gcode]); ;
     }
 
     /**
@@ -31,7 +31,7 @@ 
      */
     public function settingsReturn($gcode)
     {
-        return Redirect::route('group.detail', ['gcode' => $gcode]);;
+        return Redirect::route('group.detail', ['gcode' => $gcode]); ;
     }
 
     /**
@@ -43,7 +43,7 @@ 
     {
         $groupModel=new GroupModel();
         $basic_info=$groupModel->details($gcode);
-        if(empty($basic_info)) return Redirect::route('group.index');
+        if (empty($basic_info)) return Redirect::route('group.index');
         $clearance=$groupModel->judgeClearance($basic_info["gid"], Auth::user()->id);
         $member_list=$groupModel->userList($basic_info["gid"]);
         return view('group.settings.general', [
@@ -61,10 +61,10 @@ 
      *
      * @return Response
      */
-    public function problems($gcode){
-        $groupModel = new GroupModel();
-        $group_info = $groupModel->details($gcode);
-        $problems = $groupModel->problems($group_info['gid']);
+    public function problems($gcode) {
+        $groupModel=new GroupModel();
+        $group_info=$groupModel->details($gcode);
+        $problems=$groupModel->problems($group_info['gid']);
         $basic_info=$groupModel->details($gcode);
         return view('group.settings.problems', [
             'page_title'=>"Group Problems",
@@ -85,7 +85,7 @@ 
     {
         $groupModel=new GroupModel();
         $basic_info=$groupModel->details($gcode);
-        if(empty($basic_info)) return Redirect::route('group.index');
+        if (empty($basic_info)) return Redirect::route('group.index');
         return view('group.settings.danger', [
             'page_title'=>"Group Setting danger",
             'site_title'=>config("app.name"),
@@ -104,7 +104,7 @@ 
         $groupModel=new GroupModel();
         $contestModel=new ContestModel();
         $basic_info=$groupModel->details($gcode);
-        if(empty($basic_info)) return Redirect::route('group.index');
+        if (empty($basic_info)) return Redirect::route('group.index');
         $clearance=$groupModel->judgeClearance($basic_info["gid"], Auth::user()->id);
         $member_list=$groupModel->userList($basic_info["gid"]);
         $group_notice=$groupModel->detailNotice($gcode);
@@ -124,7 +124,7 @@ 
         $groupModel=new GroupModel();
         $contestModel=new ContestModel();
         $basic_info=$groupModel->details($gcode);
-        if(empty($basic_info)) return Redirect::route('group.index');
+        if (empty($basic_info)) return Redirect::route('group.index');
         $clearance=$groupModel->judgeClearance($basic_info["gid"], Auth::user()->id);
         $contest_list=$contestModel->listForSetting($basic_info["gid"]);
         $member_list=$groupModel->userList($basic_info["gid"]);

app/Http/Controllers/Ajax/GroupAdminController.php

Spacing +5 added lines, -5 removed lines

@@ -48,11 +48,11 @@ 
 
         $groupModel=new GroupModel();
         $clearance=$groupModel->judgeClearance($all_data["gid"], Auth::user()->id);
-        if ($clearance < 2) {
+        if ($clearance<2) {
             return ResponseModel::err(7002);
         }
-        $tags = $groupModel->problemTags($all_data['gid'],$all_data['pid']);
-        if(in_array($all_data['tag'],$tags)){
+        $tags=$groupModel->problemTags($all_data['gid'], $all_data['pid']);
+        if (in_array($all_data['tag'], $tags)) {
             return ResponseModel::err(7007);
         }
 
@@ -84,9 +84,9 @@ 
         $request->validate([
             'gid' => 'required|string',
         ]);
-        $gid = $request->input('gid');
+        $gid=$request->input('gid');
         $groupModel=new GroupModel();
-        if($groupModel->judgeClearance($gid,Auth::user()->id) < 2) {
+        if ($groupModel->judgeClearance($gid, Auth::user()->id)<2) {
             return ResponseModel::err(2001);
         }
         $groupModel->refreshElo($gid);

app/Models/ProblemModel.php

Spacing +4 added lines, -4 removed lines

@@ -178,9 +178,9 @@ 
 
     private function inteliAudit($uid, $content)
     {
-        if (strpos($content, '```')!==false){
+        if (strpos($content, '```')!==false) {
             $userSolutionHistory=DB::table("problem_solution")->where(['uid'=>$uid])->orderByDesc('updated_at')->first();
-            if (!empty($userSolutionHistory) && $userSolutionHistory["audit"]==1){
+            if (!empty($userSolutionHistory) && $userSolutionHistory["audit"]==1) {
                 return 1;
             }
         }
@@ -430,7 +430,7 @@ 
 
         if (!empty($data["sample"])) {
             foreach ($data["sample"] as $d) {
-                if(!isset($d['sample_note'])) $d['sample_note']=null;
+                if (!isset($d['sample_note'])) $d['sample_note']=null;
                 DB::table("problem_sample")->insert([
                     'pid'=>$pid,
                     'sample_input'=>$d['sample_input'],
@@ -476,7 +476,7 @@ 
 
         if (!empty($data["sample"])) {
             foreach ($data["sample"] as $d) {
-                if(!isset($d['sample_note'])) $d['sample_note']=null;
+                if (!isset($d['sample_note'])) $d['sample_note']=null;
                 DB::table("problem_sample")->insert([
                     'pid'=>$pid,
                     'sample_input'=>$d['sample_input'],

app/Models/JudgerModel.php

Spacing +2 added lines, -2 removed lines

@@ -59,7 +59,7 @@ 
             "oid"=>$oid,
             "available"=>1,
             "status"=>0
-        ])->orderBy('usage','desc')->get()->first();
+        ])->orderBy('usage', 'desc')->get()->first();
 
         return $serverList;
     }
@@ -68,7 +68,7 @@ 
     {
         $serverList=DB::table("judge_server")->where(["oid"=>$oid])->get()->all();
         foreach ($serverList as &$server) {
-            $server["status_parsed"]=is_null($server["status"])?self::$status["-1"]:self::$status[$server["status"]];
+            $server["status_parsed"]=is_null($server["status"]) ?self::$status["-1"] : self::$status[$server["status"]];
         }
         return $serverList;
     }

app/Helpers/functions.php

Spacing +10 added lines, -10 removed lines

@@ -63,20 +63,20 @@ 
     }
 }
 
-if (! function_exists('babel_path')) {
+if (!function_exists('babel_path')) {
     /**
      * Get the path to the application folder.
      *
      * @param  string  $path
      * @return string
      */
-    function babel_path($path = '')
+    function babel_path($path='')
     {
         return app('path').DIRECTORY_SEPARATOR.'Babel'.($path ? DIRECTORY_SEPARATOR.$path : $path);
     }
 }
 
-if (! function_exists('glob_recursive')) {
+if (!function_exists('glob_recursive')) {
     /**
      * Find pathnames matching a pattern recursively.
      *
@@ -84,11 +84,11 @@ 
      * @param  int     $flags   Valid flags: GLOB_MARK
      * @return array|false      an array containing the matched files/directories, an empty array if no file matched or false on error.
      */
-    function glob_recursive($pattern, $flags = 0)
+    function glob_recursive($pattern, $flags=0)
     {
-        $files = glob($pattern, $flags);
-        foreach (glob(dirname($pattern).'/*', GLOB_ONLYDIR|GLOB_NOSORT) as $dir) {
-            $files = array_merge($files, glob_recursive($dir.'/'.basename($pattern), $flags));
+        $files=glob($pattern, $flags);
+        foreach (glob(dirname($pattern).'/*', GLOB_ONLYDIR | GLOB_NOSORT) as $dir) {
+            $files=array_merge($files, glob_recursive($dir.'/'.basename($pattern), $flags));
         }
         return $files;
     }
@@ -122,8 +122,8 @@ 
     function delFile($dirName)
     {
         if (file_exists($dirName) && $handle=opendir($dirName)) {
-            while (false!==($item = readdir($handle))) {
-                if ($item!= "." && $item != "..") {
+            while (false!==($item=readdir($handle))) {
+                if ($item!="." && $item!="..") {
                     if (file_exists($dirName.'/'.$item) && is_dir($dirName.'/'.$item)) {
                         delFile($dirName.'/'.$item);
                     } else {
@@ -141,6 +141,6 @@ 
 if (!function_exists('convertMarkdownToHtml')) {
     function convertMarkdownToHtml($md)
     {
-        return is_string($md)?Markdown::convertToHtml($md):'';
+        return is_string($md) ?Markdown::convertToHtml($md) : '';
     }
 }

app/Http/Controllers/Ajax/GroupManageController.php

Spacing +18 added lines, -18 removed lines

@@ -36,7 +36,7 @@ 
 
         $all_data=$request->all();
 
-        if(($all_data['public'] ?? 0) && ($all_data['practice'] ?? 0)){
+        if (($all_data['public'] ?? 0) && ($all_data['practice'] ?? 0)) {
             return ResponseModel::err(4007);
         }
 
@@ -67,7 +67,7 @@ 
             return ResponseModel::err(1003);
         }
 
-        $cid = $contestModel->arrangeContest($all_data["gid"], [
+        $cid=$contestModel->arrangeContest($all_data["gid"], [
             "assign_uid"=>Auth::user()->id,
             "name"=>$all_data["name"],
             "description"=>$all_data["description"],
@@ -77,7 +77,7 @@ 
             "public"=>$all_data["public"] ?? 0,
         ], $problemSet);
 
-        return ResponseModel::success(200,'Successful!',$cid);
+        return ResponseModel::success(200, 'Successful!', $cid);
     }
 
     public function changeGroupName(Request $request)
@@ -91,7 +91,7 @@ 
 
         $groupModel=new GroupModel();
         $clearance=$groupModel->judgeClearance($all_data["gid"], Auth::user()->id);
-        if ($clearance < 2){
+        if ($clearance<2) {
             return ResponseModel::err(2001);
         }
 
@@ -110,11 +110,11 @@ 
 
         $groupModel=new GroupModel();
         $clearance=$groupModel->judgeClearance($all_data["gid"], Auth::user()->id);
-        if ($clearance < 2){
+        if ($clearance<2) {
             return ResponseModel::err(2001);
         }
 
-        if ($all_data["join_policy"] < 1 || $all_data["join_policy"] > 3){
+        if ($all_data["join_policy"]<1 || $all_data["join_policy"]>3) {
             return ResponseModel::err(1007);
         }
 
@@ -128,7 +128,7 @@ 
             'gid' => 'required|integer',
         ]);
 
-        $all_data = $request->all();
+        $all_data=$request->all();
 
         if (!empty($request->file('img')) && $request->file('img')->isValid()) {
             $extension=$request->file('img')->extension();
@@ -140,7 +140,7 @@ 
 
         $groupModel=new GroupModel();
         $clearance=$groupModel->judgeClearance($all_data["gid"], Auth::user()->id);
-        if ($clearance < 2){
+        if ($clearance<2) {
             return ResponseModel::err(2001);
         }
 
@@ -178,18 +178,18 @@ 
         $clearance=$groupModel->judgeClearance($all_data["gid"], Auth::user()->id);
         $target_clearance=$groupModel->judgeClearance($all_data["gid"], $all_data['uid']);
 
-        if($target_clearance == -3){
+        if ($target_clearance==-3) {
             return ResponseModel::err(7004);
         }
 
-        if($target_clearance >= $clearance || $clearance < 2 || $all_data['permission'] >= $clearance){
+        if ($target_clearance>=$clearance || $clearance<2 || $all_data['permission']>=$clearance) {
             return ResponseModel::err(2001);
         }
 
         $groupModel->changeClearance($all_data['uid'], $all_data["gid"], $all_data['permission']);
 
-        $result_info = $groupModel->userProfile($all_data['uid'],$all_data["gid"]);
-        return ResponseModel::success(200,null,$result_info);
+        $result_info=$groupModel->userProfile($all_data['uid'], $all_data["gid"]);
+        return ResponseModel::success(200, null, $result_info);
     }
 
     public function approveMember(Request $request)
@@ -205,7 +205,7 @@ 
         $clearance=$groupModel->judgeClearance($all_data["gid"], Auth::user()->id);
         $targetClearance=$groupModel->judgeClearance($all_data["gid"], $all_data["uid"]);
         if ($clearance>1) {
-            if($targetClearance!=0) {
+            if ($targetClearance!=0) {
                 return ResponseModel::err(7003);
             }
             $groupModel->changeClearance($all_data["uid"], $all_data["gid"], 1);
@@ -226,7 +226,7 @@ 
         $groupModel=new GroupModel();
         $clearance=$groupModel->judgeClearance($all_data["gid"], Auth::user()->id);
         $targetClearance=$groupModel->judgeClearance($all_data["gid"], $all_data["uid"]);
-        if ($clearance <= 1 || $clearance <= $targetClearance){
+        if ($clearance<=1 || $clearance<=$targetClearance) {
             return ResponseModel::err(7002);
         }
 
@@ -246,11 +246,11 @@ 
 
         $groupModel=new GroupModel();
         $is_user=$groupModel->isUser($all_data["email"]);
-        if(!$is_user) return ResponseModel::err(2006);
+        if (!$is_user) return ResponseModel::err(2006);
         $clearance=$groupModel->judgeClearance($all_data["gid"], Auth::user()->id);
-        if($clearance<2) return ResponseModel::err(7002);
+        if ($clearance<2) return ResponseModel::err(7002);
         $targetClearance=$groupModel->judgeEmailClearance($all_data["gid"], $all_data["email"]);
-        if($targetClearance!=-3) return ResponseModel::err(7003);
+        if ($targetClearance!=-3) return ResponseModel::err(7003);
         $groupModel->inviteMember($all_data["gid"], $all_data["email"]);
         return ResponseModel::success(200);
     }
@@ -287,7 +287,7 @@ 
 
         $groupModel=new GroupModel();
         $clearance=$groupModel->judgeClearance($all_data["gid"], Auth::user()->id);
-        if ($clearance < 2){
+        if ($clearance<2) {
             return ResponseModel::err(2001);
         }
         $groupModel->createNotice($all_data["gid"], Auth::user()->id, $all_data["title"], $all_data["content"]);

app/Models/Rating/GroupRatingCalculator.php

Spacing +85 added lines, -85 removed lines

@@ -14,36 +14,36 @@ 
     public $totParticipants=0;
     public $INITIAL_RATING=1500;
 
-    public function __construct($cid){
-        $contestModel = new ContestModel();
-        $this->cid = $cid;
-        $this->gid = $contestModel->gid($cid);
+    public function __construct($cid) {
+        $contestModel=new ContestModel();
+        $this->cid=$cid;
+        $this->gid=$contestModel->gid($cid);
         // get rank
         $this->getRecord();
     }
 
-    private function getRecord(){
-        $contestModel = new ContestModel();
-        $contestRankRaw = $contestModel->contestRank($this->cid);
-        foreach($contestRankRaw as $key => $contestRank){
-            if(isset($contestRank['remote']) && $contestRank['remote']){
+    private function getRecord() {
+        $contestModel=new ContestModel();
+        $contestRankRaw=$contestModel->contestRank($this->cid);
+        foreach ($contestRankRaw as $key => $contestRank) {
+            if (isset($contestRank['remote']) && $contestRank['remote']) {
                 unset($contestRankRaw[$key]);
             }
         }
-        $contestRankRaw = array_values($contestRankRaw);
-        $members = array_column($contestRankRaw,'uid');
-        $ratings_temp = DB::table('group_member')
+        $contestRankRaw=array_values($contestRankRaw);
+        $members=array_column($contestRankRaw, 'uid');
+        $ratings_temp=DB::table('group_member')
             ->where([
                 'gid' => $this->gid,
-            ])->whereIn('uid',$members)
-            ->select('uid','ranking')
+            ])->whereIn('uid', $members)
+            ->select('uid', 'ranking')
             ->get()->all();
-        $ratings = [];
+        $ratings=[];
         foreach ($ratings_temp as $rating) {
-            $ratings[$rating['uid']] = $rating['ranking'];
+            $ratings[$rating['uid']]=$rating['ranking'];
         }
-        foreach($contestRankRaw as $c){
-            if(!isset($ratings[$c['uid']])){
+        foreach ($contestRankRaw as $c) {
+            if (!isset($ratings[$c['uid']])) {
                 continue;
             }
             $this->contestants[]=[
@@ -52,87 +52,87 @@ 
                 "rating"=>$ratings[$c['uid']],
             ];
         }
-        $this->totParticipants = count($this->contestants);
+        $this->totParticipants=count($this->contestants);
     }
 
-    private function reassignRank(){
+    private function reassignRank() {
         $this->sort("points");
-        $idx = 0;
-        $points = $this->contestants[0]["points"];
-        $i = 1;
-        while($i < $this->totParticipants){
-            if($this->contestants[$i]["points"] < $points){
-                $j = $idx;
-                while($j < $i){
-                    $this->contestants[$j]["rank"] = $i;
-                    $j += 1;
+        $idx=0;
+        $points=$this->contestants[0]["points"];
+        $i=1;
+        while ($i<$this->totParticipants) {
+            if ($this->contestants[$i]["points"]<$points) {
+                $j=$idx;
+                while ($j<$i) {
+                    $this->contestants[$j]["rank"]=$i;
+                    $j+=1;
                 }
-                $idx = $i;
-                $points = $this->contestants[$i]["points"];
+                $idx=$i;
+                $points=$this->contestants[$i]["points"];
             }
-            $i += 1;
+            $i+=1;
         }
-        $j = $idx;
-        while($j < $this->totParticipants){
-            $this->contestants[$j]["rank"] = $this->totParticipants;
-            $j += 1;
+        $j=$idx;
+        while ($j<$this->totParticipants) {
+            $this->contestants[$j]["rank"]=$this->totParticipants;
+            $j+=1;
         }
     }
 
-    private function getEloWinProbability($Ra, $Rb){
-        return 1.0 / (1 + pow(10, ($Rb-$Ra)/400.0));
+    private function getEloWinProbability($Ra, $Rb) {
+        return 1.0 / (1+pow(10, ($Rb-$Ra) / 400.0));
     }
 
-    private function getSeed($rating){
-        $result = 1.0;
-        foreach($this->contestants as $other){
-            $result += $this->getEloWinProbability($other["rating"], $rating);
+    private function getSeed($rating) {
+        $result=1.0;
+        foreach ($this->contestants as $other) {
+            $result+=$this->getEloWinProbability($other["rating"], $rating);
         }
         return $result;
     }
 
-    private function getRatingToRank($rank){
+    private function getRatingToRank($rank) {
         $left=1;
         $right=8000;
-        while($right - $left > 1){
-            $mid = floor(($right + $left)/2);
-            if($this->getSeed($mid) < $rank){
-                $right = $mid;
-            }else{
-                $left = $mid;
+        while ($right-$left>1) {
+            $mid=floor(($right+$left) / 2);
+            if ($this->getSeed($mid)<$rank) {
+                $right=$mid;
+            } else {
+                $left=$mid;
             }
         }
         return $left;
     }
 
-    private function sort($key){
-        usort($this->contestants, function ($a, $b) use ($key) {
+    private function sort($key) {
+        usort($this->contestants, function($a, $b) use ($key) {
             return $b[$key] <=> $a[$key];
         });
     }
 
-    public function calculate(){
-        if(empty($this->contestants)){
+    public function calculate() {
+        if (empty($this->contestants)) {
             return;
         }
 
         // recalc rank
         $this->reassignRank();
 
-        foreach($this->contestants as &$member){
-            $member["seed"] = 1.0;
-            foreach($this->contestants as $other){
-                if($member["uid"] != $other["uid"]){
-                    $member["seed"] += $this->getEloWinProbability($other["rating"], $member["rating"]);
+        foreach ($this->contestants as &$member) {
+            $member["seed"]=1.0;
+            foreach ($this->contestants as $other) {
+                if ($member["uid"]!=$other["uid"]) {
+                    $member["seed"]+=$this->getEloWinProbability($other["rating"], $member["rating"]);
                 }
             }
         }
         unset($member);
 
-        foreach($this->contestants as &$contestant){
-            $midRank = sqrt($contestant["rank"] * $contestant["seed"]);
-            $contestant["needRating"] = $this->getRatingToRank($midRank);
-            $contestant["delta"] = floor(($contestant["needRating"] - $contestant["rating"])/2);
+        foreach ($this->contestants as &$contestant) {
+            $midRank=sqrt($contestant["rank"] * $contestant["seed"]);
+            $contestant["needRating"]=$this->getRatingToRank($midRank);
+            $contestant["delta"]=floor(($contestant["needRating"]-$contestant["rating"]) / 2);
         }
         unset($contestant);
 
@@ -140,39 +140,39 @@ 
 
         // DO some adjuct
         // Total sum should not be more than ZERO.
-        $sum = 0;
+        $sum=0;
 
-        foreach($this->contestants as $contestant){
-            $sum += $contestant["delta"];
+        foreach ($this->contestants as $contestant) {
+            $sum+=$contestant["delta"];
         }
-        $inc = -floor($sum / $this->totParticipants) - 1;
-        foreach($this->contestants as &$contestant){
-            $contestant["delta"] += $inc;
+        $inc=-floor($sum / $this->totParticipants)-1;
+        foreach ($this->contestants as &$contestant) {
+            $contestant["delta"]+=$inc;
         }
         unset($contestant);
 
         // Sum of top-4*sqrt should be adjusted to ZERO.
 
-        $sum = 0;
-        $zeroSumCount = min(intval(4*round(sqrt($this->totParticipants))), $this->totParticipants);
+        $sum=0;
+        $zeroSumCount=min(intval(4 * round(sqrt($this->totParticipants))), $this->totParticipants);
 
-        for($i=0;$i<$zeroSumCount;$i++){
-            $sum += $this->contestants[$i]["delta"];
+        for ($i=0; $i<$zeroSumCount; $i++) {
+            $sum+=$this->contestants[$i]["delta"];
         }
 
-        $inc = min(max(-floor($sum / $zeroSumCount), -10), 0);
+        $inc=min(max(-floor($sum / $zeroSumCount), -10), 0);
 
-        for($i=0;$i<$zeroSumCount;$i++){
-            $this->contestants[$i]["delta"] += $inc;
+        for ($i=0; $i<$zeroSumCount; $i++) {
+            $this->contestants[$i]["delta"]+=$inc;
         }
 
         return $this->validateDeltas();
     }
 
-    public function storage(){
+    public function storage() {
         $contestants=$this->contestants;
-        DB::transaction(function () use ($contestants) {
-            foreach($contestants as $contestant){
+        DB::transaction(function() use ($contestants) {
+            foreach ($contestants as $contestant) {
                 $newRating=$contestant["rating"]+$contestant["delta"];
                 DB::table("group_member")->where([
                     'gid' => $this->gid,
@@ -190,20 +190,20 @@ 
         }, 5);
     }
 
-    private function validateDeltas(){
+    private function validateDeltas() {
         $this->sort("points");
 
-        for($i=0;$i<$this->totParticipants;$i++){
-            for($j=$i+1;$j<$this->totParticipants;$j++){
-                if($this->contestants[$i]["rating"] > $this->contestants[$j]["rating"]){
-                    if($this->contestants[$i]["rating"] + $this->contestants[$i]["delta"] < $this->contestants[$j]["rating"] + $this->contestants[$j]["delta"]){
+        for ($i=0; $i<$this->totParticipants; $i++) {
+            for ($j=$i+1; $j<$this->totParticipants; $j++) {
+                if ($this->contestants[$i]["rating"]>$this->contestants[$j]["rating"]) {
+                    if ($this->contestants[$i]["rating"]+$this->contestants[$i]["delta"]<$this->contestants[$j]["rating"]+$this->contestants[$j]["delta"]) {
                         Log::warning("First rating invariant failed: {$this->contestants[$i]["uid"]} vs. {$this->contestants[$j]["uid"]}.");
                         return false;
                     }
                 }
 
-                if($this->contestants[$i]["rating"] < $this->contestants[$j]["rating"]){
-                    if($this->contestants[$i]["delta"] < $this->contestants[$j]["delta"]){
+                if ($this->contestants[$i]["rating"]<$this->contestants[$j]["rating"]) {
+                    if ($this->contestants[$i]["delta"]<$this->contestants[$j]["delta"]) {
                         Log::warning("Second rating invariant failed: {$this->contestants[$i]["uid"]} vs.  {$this->contestants[$j]["uid"]}.");
                         return false;
                     }