GroupController::form() - Code Metrics - Inspection of "release: 0.16.0 Bryconinae" - ZsgsDesign/NOJ - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#648)

by John

created 2021-08-25 19:46 UTC

GroupController::form() B

↳ Parent: GroupController

Complexity

Conditions	7
Paths	1

Size

Total Lines	53
Code Lines	40

Duplication

Lines	0
Ratio	0 %

Importance

Changes	2
Bugs	1	Features	0

Metric	Value
cc	7
eloc	40
c	2
b	1
f	0
nc	1
nop	0
dl	0
loc	53
rs	8.3466

How to fix Long Method

<?php

namespace App\Admin\Controllers;

use App\Models\Eloquent\Group;
use App\Models\Eloquent\User;
use App\Http\Controllers\Controller;
use Encore\Admin\Controllers\HasResourceActions;
use Encore\Admin\Form;
use Encore\Admin\Grid;
use Encore\Admin\Layout\Content;
use Encore\Admin\Show;
use Illuminate\Support\MessageBag;
use App\Models\Eloquent\GroupMember;

class GroupController extends Controller
{
    use HasResourceActions;

    /**
     * Index interface.
     *
     * @param Content $content
     * @return Content
     */
    public function index(Content $content)
    {
        return $content
            ->header('Groups')
            ->description('all groups')
            ->body($this->grid()->render());
    }

    /**
     * Show interface.
     *
     * @param mixed $id
     * @param Content $content
     * @return Content
     */
    public function show($id, Content $content)
    {
        return $content
            ->header('Group Detail')
            ->description('the detail of groups')
            ->body($this->detail($id));
    }

    /**
     * Edit interface.
     *
     * @param mixed $id
     * @param Content $content
     * @return Content
     */
    public function edit($id, Content $content)
    {
        return $content
            ->header('Edit Group')
            ->description('edit the detail of groups')
            ->body($this->form()->edit($id));
    }

    /**
     * Create interface.
     *
     * @param Content $content
     * @return Content
     */
    public function create(Content $content)
    {
        return $content
            ->header('Create New Group')
            ->description('create a new group')
            ->body($this->form());
    }

    /**
     * Make a grid builder.
     *
     * @return Grid
     */
    protected function grid()
    {
        $grid=new Grid(new Group);
        $grid->column('gid', "ID")->sortable();
        $grid->column("gcode", "Group Code");
        $grid->img("Focus Image")->display(function($url) {
            return '<img src="'.$url.'" style="max-width:200px;max-height:200px" class="img img-thumbnail">';
        });
        $grid->name("Name")->editable();
        $grid->public("Publicity")->display(function($public) {
            return $public ? "Public" : "Private";
        });
        $grid->verified("Verified")->display(function($verified) {
            return $verified ? "Yes" : "No";
        });
        $grid->join_policy("Join Policy");
        // $grid->custom_icon("Custom Icon")->image();
        // $grid->custom_title("Custom Title");
        $grid->filter(function(Grid\Filter $filter) {
            $filter->like('gcode');
            $filter->like('name');
        });
        return $grid;
    }

    /**
     * Make a show builder.
     *
     * @param mixed $id
     * @return Show
     */
    protected function detail($id)
    {
        $show=new Show(Group::findOrFail($id));
        return $show;
    }

    /**
     * Make a form builder.
     *
     * @return Form
     */
    protected function form()
    {
        $form=new Form(new Group);
        $form->model()->makeVisible('password');
        $form->tab('Basic', function(Form $form) {
            $form->text('gcode')->rules('required|alpha_dash|min:3|max:50');
            $form->text('name')->rules('required|min:3|max:50');
            $form->switch('public')->default(true);
            $form->textarea('description')->rules('nullable|max:60000');
            $form->select('join_policy', 'Join Policy')->options([
                0 => "Cannot Join",
                1 => "Invite Only",
                2 => "Apply Only",
                3 => "Invite & Apply"
            ])->default(1);
            $form->image('img', 'Custom Group Focus Image')->uniqueName()->move("static/img/group");
            if ($form->isCreating()) {
                $form->select('leader_uid', 'Group Leader')->options(function ($id) {
                    $user = User::find($id);
                    if ($user) {
                        return [$user->id => $user->readable_name];
                    }
                })->config('minimumInputLength', 4)->ajax(route('admin.api.users'))->required();
            }
            $form->ignore(['leader_uid']);
            $form->saving(function(Form $form) {
                $err=function($msg, $title='Error occur.') {
                    $error=new MessageBag([
                        'title'   => $title,
                        'message' => $msg,
                    ]);
                    return back()->with(compact('error'));
                };
                $gcode=$form->gcode;
                $g=Group::where('gcode', $gcode)->first();
                //check gcode has been token.
                $gid=$form->model()->gid ?? null;
                if (!empty($gcode) && !blank($g) && $g->gid!=$gid) {
                    return $err('Gcode has been token', 'Error occur.');
                }
            });
            $form->saved(function(Form $form) {
                if ($form->isCreating()) {
                    $form->model()->members()->saveMany([new GroupMember([
                        'gid' => $form->model()->gid,
                        'uid' => request('leader_uid'),
                        'role' => 3,
                        'ranking' => 1500,
                    ])]);
                }
            });
        });
        return $form;
    }
}


1			<?php
2
3			namespace App\Admin\Controllers;
4
5			use App\Models\Eloquent\Group;
6			use App\Models\Eloquent\User;
7			use App\Http\Controllers\Controller;
8			use Encore\Admin\Controllers\HasResourceActions;
9			use Encore\Admin\Form;
10			use Encore\Admin\Grid;
11			use Encore\Admin\Layout\Content;
12			use Encore\Admin\Show;
13			use Illuminate\Support\MessageBag;
14			use App\Models\Eloquent\GroupMember;
15
16			class GroupController extends Controller
17			{
18			use HasResourceActions;
19
20			/**
21			* Index interface.
22			*
23			* @param Content $content
24			* @return Content
25			*/
26			public function index(Content $content)
27			{
28			return $content
29			->header('Groups')
30			->description('all groups')
31			->body($this->grid()->render());
32			}
33
34			/**
35			* Show interface.
36			*
37			* @param mixed $id
38			* @param Content $content
39			* @return Content
40			*/
41			public function show($id, Content $content)
42			{
43			return $content
44			->header('Group Detail')
45			->description('the detail of groups')
46			->body($this->detail($id));
47			}
48
49			/**
50			* Edit interface.
51			*
52			* @param mixed $id
53			* @param Content $content
54			* @return Content
55			*/
56			public function edit($id, Content $content)
57			{
58			return $content
59			->header('Edit Group')
60			->description('edit the detail of groups')
61			->body($this->form()->edit($id));
62			}
63
64			/**
65			* Create interface.
66			*
67			* @param Content $content
68			* @return Content
69			*/
70			public function create(Content $content)
71			{
72			return $content
73			->header('Create New Group')
74			->description('create a new group')
75			->body($this->form());
76			}
77
78			/**
79			* Make a grid builder.
80			*
81			* @return Grid
82			*/
83			protected function grid()
84			{
85			$grid=new Grid(new Group);
86			$grid->column('gid', "ID")->sortable();
87			$grid->column("gcode", "Group Code");
88			$grid->img("Focus Image")->display(function($url) {
89			return '<img src="'.$url.'" style="max-width:200px;max-height:200px" class="img img-thumbnail">';
90			});
91			$grid->name("Name")->editable();
92			$grid->public("Publicity")->display(function($public) {
93			return $public ? "Public" : "Private";
94			});
95			$grid->verified("Verified")->display(function($verified) {
96			return $verified ? "Yes" : "No";
97			});
98			$grid->join_policy("Join Policy");
99			// $grid->custom_icon("Custom Icon")->image();
100			// $grid->custom_title("Custom Title");
101			$grid->filter(function(Grid\Filter $filter) {
102			$filter->like('gcode');
103			$filter->like('name');
104			});
105			return $grid;
106			}
107
108			/**
109			* Make a show builder.
110			*
111			* @param mixed $id
112			* @return Show
113			*/
114			protected function detail($id)
115			{
116			$show=new Show(Group::findOrFail($id));
117			return $show;
118			}
119
120			/**
121			* Make a form builder.
122			*
123			* @return Form
124			*/
125			protected function form()
126			{
127			$form=new Form(new Group);
128			$form->model()->makeVisible('password');
129			$form->tab('Basic', function(Form $form) {
130			$form->text('gcode')->rules('required\|alpha_dash\|min:3\|max:50');
131			$form->text('name')->rules('required\|min:3\|max:50');
132			$form->switch('public')->default(true);
133			$form->textarea('description')->rules('nullable\|max:60000');
134			$form->select('join_policy', 'Join Policy')->options([
135			0 => "Cannot Join",
136			1 => "Invite Only",
137			2 => "Apply Only",
138			3 => "Invite & Apply"
139			])->default(1);
140			$form->image('img', 'Custom Group Focus Image')->uniqueName()->move("static/img/group");
141			if ($form->isCreating()) {
142			$form->select('leader_uid', 'Group Leader')->options(function ($id) {
143			$user = User::find($id);
144			if ($user) {
145			return [$user->id => $user->readable_name];
146			}
147			})->config('minimumInputLength', 4)->ajax(route('admin.api.users'))->required();
148			}
149			$form->ignore(['leader_uid']);
150			$form->saving(function(Form $form) {
151			$err=function($msg, $title='Error occur.') {
152			$error=new MessageBag([
153			'title' => $title,
154			'message' => $msg,
155			]);
156			return back()->with(compact('error'));
157			};
158			$gcode=$form->gcode;
159			$g=Group::where('gcode', $gcode)->first();
160			//check gcode has been token.
161			$gid=$form->model()->gid ?? null;
162			if (!empty($gcode) && !blank($g) && $g->gid!=$gid) {
163			return $err('Gcode has been token', 'Error occur.');
164			}
165			});
166			$form->saved(function(Form $form) {
167			if ($form->isCreating()) {
168			$form->model()->members()->saveMany([new GroupMember([
169			'gid' => $form->model()->gid,
170			'uid' => request('leader_uid'),
171			'role' => 3,
172			'ranking' => 1500,
173			])]);
174			}
175			});
176			});
177			return $form;
178			}
179			}
180

ZsgsDesign / NOJ

Pull Request — master (#648)

GroupController::form() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like