ZsgsDesign / NOJ

app/Http/Controllers/Group/AdminController.php

Spacing +6 added lines, -6 removed lines

@@ -21,7 +21,7 @@ 
      */
     public function settings($gcode)
     {
-        return Redirect::route('group.settings.general', ['gcode' => $gcode]);;
+        return Redirect::route('group.settings.general', ['gcode' => $gcode]); ;
     }
 
     /**
@@ -31,7 +31,7 @@ 
      */
     public function settingsReturn($gcode)
     {
-        return Redirect::route('group.detail', ['gcode' => $gcode]);;
+        return Redirect::route('group.detail', ['gcode' => $gcode]); ;
     }
 
     /**
@@ -60,10 +60,10 @@ 
      *
      * @return Response
      */
-    public function problems($gcode){
-        $groupModel = new GroupModel();
-        $group_info = $groupModel->details($gcode);
-        $problems = $groupModel->problems($group_info['gid']);
+    public function problems($gcode) {
+        $groupModel=new GroupModel();
+        $group_info=$groupModel->details($gcode);
+        $problems=$groupModel->problems($group_info['gid']);
         $basic_info=$groupModel->details($gcode);
         return view('group.settings.problems', [
             'page_title'=>"Group Problems",

app/Http/Middleware/User/Banned.php

Spacing +8 added lines, -8 removed lines

@@ -17,25 +17,25 @@
     public function handle($request, Closure $next)
     {
         //check login
-        if(!Auth::check()){
+        if (!Auth::check()) {
             return $next($request);
         }
-        $user = Auth::user();
-        $banned = $user->banneds()->orderBy('removed_at', 'desc')->first();
+        $user=Auth::user();
+        $banned=$user->banneds()->orderBy('removed_at', 'desc')->first();
         //check if there are any banned records
-        if(empty($banned)) {
+        if (empty($banned)) {
             return $next($request);
         }
         //check the time of the last record
-        if(strtotime($banned->removed_at) <= time()){
+        if (strtotime($banned->removed_at)<=time()) {
             return $next($request);
         }
         //return error page
-        if($request->method() == 'GET'){
-            return response()->view('errors.451',[
+        if ($request->method()=='GET') {
+            return response()->view('errors.451', [
                 'description' => "Your account is currently blocked and will remain so until {$banned->removed_at}. Here's why: {$banned->reason}",
             ]);
-        }else{
+        } else {
             return response()->json([
                 'ret' => 451,
                 'desc' => 'Unavailable For Legal Reasons',

Braces +1 added lines, -1 removed lines

@@ -35,7 +35,7 @@
             return response()->view('errors.451',[
                 'description' => "Your account is currently blocked and will remain so until {$banned->removed_at}. Here's why: {$banned->reason}",
             ]);
-        }else{
+        } else{
             return response()->json([
                 'ret' => 451,
                 'desc' => 'Unavailable For Legal Reasons',

app/Http/Middleware/Group/Banned.php

Spacing +6 added lines, -6 removed lines

@@ -17,12 +17,12 @@
      */
     public function handle($request, Closure $next)
     {
-        $gcode = $request->gcode;
-        $group = Group::where('gcode',$gcode)->first();
-        $banneds = $group->banneds()->where('removed_at','>',date('Y-m-d H:i:s'))->first();
-        $user = Auth::user();
-        if(!empty($banneds) && $user->id != $group->leader->id) {
-            return response()->view('errors.451',[
+        $gcode=$request->gcode;
+        $group=Group::where('gcode', $gcode)->first();
+        $banneds=$group->banneds()->where('removed_at', '>', date('Y-m-d H:i:s'))->first();
+        $user=Auth::user();
+        if (!empty($banneds) && $user->id!=$group->leader->id) {
+            return response()->view('errors.451', [
                 'description' => 'This group is currently banned. Please contact the group administrator.'
             ]);
         }

app/Http/Middleware/Group/Exists.php

Spacing +4 added lines, -4 removed lines

@@ -16,11 +16,11 @@
      */
     public function handle($request, Closure $next)
     {
-        $gcode = $request->gcode;
-        $group = Group::where('gcode',$gcode)->first();
-        if(!empty($group)){
+        $gcode=$request->gcode;
+        $group=Group::where('gcode', $gcode)->first();
+        if (!empty($group)) {
             return $next($request);
-        }else{
+        } else {
             return redirect('/group');
         }
 

Braces +1 added lines, -1 removed lines

@@ -20,7 +20,7 @@
         $group = Group::where('gcode',$gcode)->first();
         if(!empty($group)){
             return $next($request);
-        }else{
+        } else{
             return redirect('/group');
         }
 

app/Admin/Controllers/AbuseController.php

Spacing +26 added lines, -26 removed lines

@@ -23,7 +23,7 @@ 
      *
      * @var string
      */
-    protected $title = 'Abuses';
+    protected $title='Abuses';
 
     /**
      * Make a grid builder.
@@ -32,7 +32,7 @@ 
      */
     protected function grid()
     {
-        $grid = new Grid(new Abuse);
+        $grid=new Grid(new Abuse);
 
         $grid->column('id', __('Id'));
         $grid->column('title', __('Title'));
@@ -58,7 +58,7 @@ 
      */
     protected function detail($id)
     {
-        $show = new Show(Abuse::findOrFail($id));
+        $show=new Show(Abuse::findOrFail($id));
 
         $show->field('id', __('Id'));
         $show->field('title', __('Title'));
@@ -81,7 +81,7 @@ 
      */
     protected function form()
     {
-        $form = new Form(new Abuse);
+        $form=new Form(new Abuse);
 
         $form->text('title', __('Title'));
         $form->number('cause', __('Cause'));
@@ -92,23 +92,23 @@ 
 
         $form->ignore(['created_at']);
 
-        $form->saving(function (Form $form) {
-            $abuse = $form->model();
+        $form->saving(function(Form $form) {
+            $abuse=$form->model();
             //get gategory and subject id
-            $regex = '/^([A-Za-z]+) #(\d+)/';
-            $matches = [];
-            preg_match($regex,$abuse->title,$matches);
-            $category = array_search(strtolower($matches[1]),Abuse::$supportCategory);
-            $subject_id = (int)$matches[2];
-            switch($abuse->category) {
+            $regex='/^([A-Za-z]+) #(\d+)/';
+            $matches=[];
+            preg_match($regex, $abuse->title, $matches);
+            $category=array_search(strtolower($matches[1]), Abuse::$supportCategory);
+            $subject_id=(int) $matches[2];
+            switch ($abuse->category) {
                 case 0:
-                    $gid = $subject_id;
-                    $group = Group::find($gid);
-                    if(empty($group)) {
-                        return ;
+                    $gid=$subject_id;
+                    $group=Group::find($gid);
+                    if (empty($group)) {
+                        return;
                     }
-                    if($form->audit) {
-                        $ban_time = request()->created_at;
+                    if ($form->audit) {
+                        $ban_time=request()->created_at;
                         sendMessage([
                             'sender'    => 1,
                             'receiver'  => $abuse->user_id,
@@ -128,8 +128,8 @@ 
                             'reason'     => $abuse->supplement,
                             'removed_at' => $ban_time
                         ]);
-                        return ;
-                    }else{
+                        return;
+                    } else {
                         sendMessage([
                             'sender'    => 1,
                             'receiver'  => $abuse->user_id,
@@ -137,11 +137,11 @@ 
                             'content'   => "Hi, Dear **{$abuse->user->name}**,\n\n We have checked your Abuse report about group **[{$group->name}]({$group->link})**.\n\n However, we regret to say that the information you submitted is not sufficient for us to take action.\n\n Of course, we will continue to follow up the investigation.\n\n Thank you for your contribution to our community environment.\n\n Sincerely, NOJ"
                         ]);
                         $abuse->delete();
-                        return ;
+                        return;
                     }
                     return;
                 case 1:
-                    $ban_time = request()->created_at;
+                    $ban_time=request()->created_at;
                     UserBanned::create([
                         'abuse_id'   => $abuse->id,
                         'user_id'    => $subject_id,
@@ -170,15 +170,15 @@ 
 
     protected function check_form()
     {
-        $form = new Form(new Abuse);
-        $form->display('id',__('Abuse id'));
+        $form=new Form(new Abuse);
+        $form->display('id', __('Abuse id'));
         $form->display('title', __('Title'));
         $form->display('cause', __('Cause'));
         $form->display('supplement', __('Supplement'));
         $form->display('link', __('Group Link'));
         $form->display('user_id', __('Submitter'));
-        $form->radio('audit','result')->options(['0' => 'Reject', '1'=> 'Pass']);
-        $form->datetime('created_at','ban until');
+        $form->radio('audit', 'result')->options(['0' => 'Reject', '1'=> 'Pass']);
+        $form->datetime('created_at', 'ban until');
 
         return $form;
     }

Braces +1 added lines, -1 removed lines

@@ -129,7 +129,7 @@
                             'removed_at' => $ban_time
                         ]);
                         return ;
-                    }else{
+                    } else{
                         sendMessage([
                             'sender'    => 1,
                             'receiver'  => $abuse->user_id,

app/Admin/Controllers/ProblemController.php

Spacing +35 added lines, -35 removed lines

@@ -142,19 +142,19 @@ 
      *
      * @return Form
      */
-    protected function form($create = false)
+    protected function form($create=false)
     {
         $form=new Form(new EloquentProblemModel);
         $form->model()->makeVisible('password');
-        $form->tab('Basic', function(Form $form){
+        $form->tab('Basic', function(Form $form) {
             $form->text('pid')->readonly();
             $form->text('pcode')->rules('required');
             $form->text('title')->rules('required');
             $form->text('time_limit')->rules('required');
             $form->text('memory_limit')->rules('required');
             $form->textarea('description')->rows(5);
-            $form->textarea('input','Sample Input')->rows(3);
-            $form->textarea('output','Sample Output')->rows(3);
+            $form->textarea('input', 'Sample Input')->rows(3);
+            $form->textarea('output', 'Sample Output')->rows(3);
             $form->textarea('note')->rows(2);
             $form->display('OJ');
             $form->display('update_date');
@@ -170,64 +170,64 @@ 
             $form->file('test_case');
             $form->ignore(['test_case']);
         });
-        if($create){
-            $form->tools(function (Form\Tools $tools) {
+        if ($create) {
+            $form->tools(function(Form\Tools $tools) {
                 $tools->add('<a href="/'.config('admin.route.prefix').'/problems/import" class="btn btn-sm btn-success" style="margin-right:1rem"><i class="MDI file-powerpoint-box"></i>&nbsp;&nbsp;Import from file</a>');
             });
         }
-        $form->saving(function (Form $form){
-            $err = function ($msg) {
-                $error = new MessageBag([
+        $form->saving(function(Form $form) {
+            $err=function($msg) {
+                $error=new MessageBag([
                     'title'   => 'Test case file parse faild.',
                     'message' => $msg,
                 ]);
                 return back()->with(compact('error'));
             };
-            $pcode = $form->pcode;
-            $p = EloquentProblemModel::where('pcode',$pcode)->first();
-            $pid = $form->pid ?? null;
-            if(!empty($p) && $p->pid != $pid){
-                $error = new MessageBag([
+            $pcode=$form->pcode;
+            $p=EloquentProblemModel::where('pcode', $pcode)->first();
+            $pid=$form->pid ?? null;
+            if (!empty($p) && $p->pid!=$pid) {
+                $error=new MessageBag([
                     'title'   => 'Error occur.',
                     'message' => 'Pcode has been token',
                 ]);
                 return back()->with(compact('error'));
             }
-            $test_case = \request()->file('test_case');
-            if(!empty($test_case)){
-                if($test_case->extension() != 'zip'){
+            $test_case=\request()->file('test_case');
+            if (!empty($test_case)) {
+                if ($test_case->extension()!='zip') {
                     $err('You must upload a zip file iuclude test case info and content.');
                 }
-                $path = $test_case->path();
-                $zip = new ZipArchive;
-                if($zip->open($path) !== true) {
+                $path=$test_case->path();
+                $zip=new ZipArchive;
+                if ($zip->open($path)!==true) {
                     $err('You must upload a zip file without encrypt and can open successfully.');
                 };
-                if(($zip->getFromName('info')) === false){
+                if (($zip->getFromName('info'))===false) {
                     $err('The zip files must include a file named info including info of test cases, and the format can see ZsgsDesign/NOJ wiki.');
                 };
-                $test_case_info = json_decode($zip->getFromName('info'),true);
-                $test_cases = $test_case_info['test_cases'];
-                foreach($test_cases as $index => $case) {
-                    if(!isset($case['input_name']) || !isset($case['output_name'])) {
+                $test_case_info=json_decode($zip->getFromName('info'), true);
+                $test_cases=$test_case_info['test_cases'];
+                foreach ($test_cases as $index => $case) {
+                    if (!isset($case['input_name']) || !isset($case['output_name'])) {
                         $err("Test case index {$index}: configuration missing input/output files name.");
                     }
-                    if($zip->getFromName($case['input_name']) === false || $zip->getFromName($case['output_name']) === false ) {
+                    if ($zip->getFromName($case['input_name'])===false || $zip->getFromName($case['output_name'])===false) {
                         $err("Test case index {$index}: missing input/output files that record in the configuration.");
                     }
                 }
-                if(!empty($form->pid)){
-                    $problem = EloquentProblemModel::find($form->pid);
-                    if(!empty($problem)){
-                        $pcode = $problem->pcode;
-                    }else{
-                        $pcode = $form->pcode;
+                if (!empty($form->pid)) {
+                    $problem=EloquentProblemModel::find($form->pid);
+                    if (!empty($problem)) {
+                        $pcode=$problem->pcode;
+                    } else {
+                        $pcode=$form->pcode;
                     }
-                }else{
-                    $pcode = $form->pcode;
+                } else {
+                    $pcode=$form->pcode;
                 }
 
-                if(Storage::exists(base_path().'/storage/test_case/'.$pcode)){
+                if (Storage::exists(base_path().'/storage/test_case/'.$pcode)) {
                     Storage::deleteDirectory(base_path().'/storage/test_case/'.$pcode);
                 }
                 Storage::makeDirectory(base_path().'/storage/test_case/'.$pcode);

Braces +2 added lines, -2 removed lines

@@ -220,10 +220,10 @@
                     $problem = EloquentProblemModel::find($form->pid);
                     if(!empty($problem)){
                         $pcode = $problem->pcode;
-                    }else{
+                    } else{
                         $pcode = $form->pcode;
                     }
-                }else{
+                } else{
                     $pcode = $form->pcode;
                 }
 

app/Admin/routes.php

Spacing +1 added lines, -1 removed lines

@@ -20,7 +20,7 @@
     $router->resource('groups', GroupController::class);
     $router->resource('abuses', AbuseController::class);
 
-    Route::group(['prefix' => 'babel'], function (Router $router) {
+    Route::group(['prefix' => 'babel'], function(Router $router) {
         $router->get('/', 'BabelController@index')->name('admin.babel.index');
         $router->get('installed', 'BabelController@installed')->name('admin.babel.installed');
         $router->get('marketspace', 'BabelController@marketspace')->name('admin.babel.marketspace');

app/Admin/Forms/ImportPOEM.php

Spacing +43 added lines, -43 removed lines

@@ -17,7 +17,7 @@ 
      *
      * @var string
      */
-    public $title = 'Import';
+    public $title='Import';
 
     /**
      * Handle the form request.
@@ -28,29 +28,29 @@ 
      */
     public function handle(Request $request)
     {
-        $err = function ($msg) {
-            $error = new MessageBag([
+        $err=function($msg) {
+            $error=new MessageBag([
                 'title'   => 'POEM parse failed.',
                 'message' => $msg,
             ]);
             return back()->with(compact('error'));
         };
-        $success_message = '';
+        $success_message='';
 
-        $file = $request->file('Files');
-        if(!$file->isValid()){
+        $file=$request->file('Files');
+        if (!$file->isValid()) {
             $err('Invalid POEM files');
         }
 
-        $path      = $file->getRealPath();
-        $poetryRaw = file_get_contents($path);
-        $parser    = new POEMParser();
-        $poem      = $parser->parse($poetryRaw);
-        if(empty($poem)){
+        $path=$file->getRealPath();
+        $poetryRaw=file_get_contents($path);
+        $parser=new POEMParser();
+        $poem=$parser->parse($poetryRaw);
+        if (empty($poem)) {
             $err('Malformed POEM files');
         }
 
-        $success_message .= "
+        $success_message.="
             POEM standard : {$poem['standard']} <br />
             generator : {$poem['generator']} <br />
             url : {$poem['url']} <br />
@@ -58,31 +58,31 @@ 
             problems: <br />
         ";
 
-        $memory_unit = [
+        $memory_unit=[
             'kb' => 1,
             'mb' => 1024,
-            'gb' => 1024*1024
+            'gb' => 1024 * 1024
         ];
-        $time_unit = [
+        $time_unit=[
             'ms' => 1,
             's' => 1000,
             'm' => 60000,
             'h' => 3600000
         ];
 
-        $prefix = 'NOJ';
-        $p = ProblemModel::where('pcode','like',$prefix.'%')->orderBy('pcode','desc')->select('pcode')->first();
-        if(empty($p)){
-            $count = 1000;
-        }else{
-            $count = (int) str_replace($prefix,'',$p['pcode']);
+        $prefix='NOJ';
+        $p=ProblemModel::where('pcode', 'like', $prefix.'%')->orderBy('pcode', 'desc')->select('pcode')->first();
+        if (empty($p)) {
+            $count=1000;
+        } else {
+            $count=(int) str_replace($prefix, '', $p['pcode']);
         }
 
         foreach ($poem['problems'] as $problem) {
             //insert problem
-            $title = $problem['title'];
-            $pro = [
-                'pcode'        => $prefix . (++$count),
+            $title=$problem['title'];
+            $pro=[
+                'pcode'        => $prefix.(++$count),
                 'solved_count' => 0,
                 'difficulty'   => -1,
                 'file'         => 0,
@@ -101,49 +101,49 @@ 
                 'force_raw'    => $problem['extra']['forceRaw'],
                 'partial'      => $problem['extra']['partial']
             ];
-            $pid = ProblemModel::insertGetId($pro);
+            $pid=ProblemModel::insertGetId($pro);
 
             //migrate sample
-            $sample_count = 0;
-            foreach($problem['sample'] as $sample){
-                $sam = [
+            $sample_count=0;
+            foreach ($problem['sample'] as $sample) {
+                $sam=[
                     'pid'           => $pid,
                     'sample_input'  => $sample['input'],
                     'sample_output' => $sample['output'],
                 ];
-                $psid = DB::table('problem_sample')->insert($sam);
-                $sample_count += 1;
+                $psid=DB::table('problem_sample')->insert($sam);
+                $sample_count+=1;
             }
 
             //create test case file
-            if(Storage::exists(storage_path().'/test_case/'.$pro['pcode'])){
+            if (Storage::exists(storage_path().'/test_case/'.$pro['pcode'])) {
                 Storage::deleteDirectory(storage_path().'/test_case/'.$pro['pcode']);
             }
             Storage::makeDirectory(storage_path().'/test_case/'.$pro['pcode']);
-            $test_case_count = 0;
-            $test_case_info = [
+            $test_case_count=0;
+            $test_case_info=[
                 'spj'        => false,
                 'test_cases' => []
             ];
-            foreach($problem['testCases'] as $test_case){
-                $test_case_count += 1;
-                $test_case_arr = [
+            foreach ($problem['testCases'] as $test_case) {
+                $test_case_count+=1;
+                $test_case_arr=[
                     'input_name'  => "data{$test_case_count}.in",
                     'output_name' => "data{$test_case_count}.out",
                     'input_size'  => strlen($test_case['input']),
                     'output_size' => strlen($test_case['output']),
                     'stripped_output_md5' => md5(trim($test_case['output']))
                 ];
-                array_push($test_case_info['test_cases'],$test_case_arr);
+                array_push($test_case_info['test_cases'], $test_case_arr);
                 Storage::disk('test_case')->put('/'.$pro['pcode'].'/'.$test_case_arr['input_name'], $test_case['input']);
                 Storage::disk('test_case')->put('/'.$pro['pcode'].'/'.$test_case_arr['output_name'], $test_case['output']);
             }
             Storage::disk('test_case')->put('/'.$pro['pcode'].'/info', json_encode($test_case_info));
 
             //migrate solutions
-            $solution_count = 0;
-            foreach($problem['solution'] as $solution) {
-                $s = [
+            $solution_count=0;
+            foreach ($problem['solution'] as $solution) {
+                $s=[
                     'uid' => 1,
                     'pid' => $pid,
                     'content' => '``` '.$solution['source'],
@@ -152,10 +152,10 @@ 
                     'created_at' => date('Y-m-d H:i:s')
                 ];
                 DB::table('problem_solution')->insert($s);
-                $solution_count += 1;
+                $solution_count+=1;
             }
 
-            $success_message .= '&nbsp;&nbsp;&nbsp;&nbsp;'.
+            $success_message.='&nbsp;&nbsp;&nbsp;&nbsp;'.
                 $pro['pcode'].': "
                 '.$title.'" with
                 '.$sample_count.' samples,
@@ -163,7 +163,7 @@ 
                 '.$solution_count.' solutions
                 <br />';
         }
-        admin_success('Import successfully',$success_message);
+        admin_success('Import successfully', $success_message);
         return back();
     }
 

Braces +1 added lines, -1 removed lines

@@ -74,7 +74,7 @@
         $p = ProblemModel::where('pcode','like',$prefix.'%')->orderBy('pcode','desc')->select('pcode')->first();
         if(empty($p)){
             $count = 1000;
-        }else{
+        } else{
             $count = (int) str_replace($prefix,'',$p['pcode']);
         }
 

app/Models/GroupModel.php

Spacing +120 added lines, -120 removed lines

@@ -58,10 +58,10 @@ 
         foreach ($trending_groups as &$t) {
             $t["members"]=$this->countGroupMembers($t["gid"]);
         }
-        usort($trending_groups, function ($a, $b) {
+        usort($trending_groups, function($a, $b) {
             return $b["members"]<=>$a["members"];
         });
-        Cache::tags(['group'])->put('trending', array_slice($trending_groups,0,12), 3600*24);
+        Cache::tags(['group'])->put('trending', array_slice($trending_groups, 0, 12), 3600 * 24);
     }
 
     public function userGroups($uid)
@@ -101,13 +101,13 @@ 
 
     public function changeGroupName($gid, $GroupName)
     {
-        return DB::table("group")->where('gid',$gid)->update([
+        return DB::table("group")->where('gid', $gid)->update([
             "name"=>$GroupName
         ]);
     }
 
-    public function changeJoinPolicy($gid, $JoinPolicy){
-        return DB::table("group")->where('gid',$gid)->update([
+    public function changeJoinPolicy($gid, $JoinPolicy) {
+        return DB::table("group")->where('gid', $gid)->update([
             "join_policy"=>$JoinPolicy
         ]);
     }
@@ -121,7 +121,7 @@ 
     public function details($gcode)
     {
         $basic_info=DB::table($this->tableName)->where(["gcode"=>$gcode])->first();
-        if(empty($basic_info)) return [];
+        if (empty($basic_info)) return [];
         $basic_info["members"]=$this->countGroupMembers($basic_info["gid"]);
         $basic_info["tags"]=$this->getGroupTags($basic_info["gid"]);
         $basic_info["create_time_foramt"]=date_format(date_create($basic_info["created_at"]), 'M jS, Y');
@@ -138,10 +138,10 @@ 
     public function userProfile($uid, $gid)
     {
         $info=DB::table("group_member")
-        ->join('users','users.id','=','group_member.uid')
+        ->join('users', 'users.id', '=', 'group_member.uid')
         ->where(["gid"=>$gid, "uid"=>$uid])
         ->where("role", ">", 0)
-        ->select('avatar','describes','email','gid','uid','name','nick_name','professional_rate','role','sub_group')
+        ->select('avatar', 'describes', 'email', 'gid', 'uid', 'name', 'nick_name', 'professional_rate', 'role', 'sub_group')
         ->first();
         if (!empty($info)) {
             $info["role_parsed"]=$this->role[$info["role"]];
@@ -169,7 +169,7 @@ 
         foreach ($user_list as &$u) {
             $u["role_parsed"]=$this->role[$u["role"]];
             $u["role_color"]=$this->role_color[$u["role"]];
-            if(is_null($u["sub_group"])) $u["sub_group"]="None";
+            if (is_null($u["sub_group"])) $u["sub_group"]="None";
         }
         return $user_list;
     }
@@ -230,16 +230,16 @@ 
         ])->where("role", ">", 0)->count();
     }
 
-    public function problemTags($gid,$pid = -1)
+    public function problemTags($gid, $pid=-1)
     {
-        if($pid == -1){
-            $tags =  DB::table('group_problem_tag')
+        if ($pid==-1) {
+            $tags=DB::table('group_problem_tag')
             ->select('tag')
-            ->where('gid',$gid)
+            ->where('gid', $gid)
             ->distinct()
             ->get()->all();
-        }else{
-            $tags =  DB::table('group_problem_tag')
+        } else {
+            $tags=DB::table('group_problem_tag')
             ->select('tag')
             ->where('gid', $gid)
             ->where('pid', $pid)
@@ -247,10 +247,10 @@ 
             ->get()->all();
         }
 
-        $tags_arr = [];
-        if(!empty($tags)){
+        $tags_arr=[];
+        if (!empty($tags)) {
             foreach ($tags as $value) {
-                array_push($tags_arr,$value['tag']);
+                array_push($tags_arr, $value['tag']);
             }
         }
         return $tags_arr;
@@ -258,28 +258,28 @@ 
 
     public function problems($gid)
     {
-        $contestModel = new ContestModel();
-        $problems = DB::table('contest_problem')
-        ->join('contest','contest_problem.cid', '=', 'contest.cid')
-        ->join('problem','contest_problem.pid', '=', 'problem.pid' )
+        $contestModel=new ContestModel();
+        $problems=DB::table('contest_problem')
+        ->join('contest', 'contest_problem.cid', '=', 'contest.cid')
+        ->join('problem', 'contest_problem.pid', '=', 'problem.pid')
         ->select('contest_problem.cid as cid', 'problem.pid as pid', 'pcode', 'title')
-        ->where('contest.gid',$gid)
-        ->where('contest.practice',1)
-        ->orderBy('contest.created_at','desc')
+        ->where('contest.gid', $gid)
+        ->where('contest.practice', 1)
+        ->orderBy('contest.created_at', 'desc')
         ->distinct()
         ->get()->all();
-        $user_id = Auth::user()->id;
-        foreach($problems as $key => $value){
-            if($contestModel->judgeClearance($value['cid'],$user_id) != 3){
+        $user_id=Auth::user()->id;
+        foreach ($problems as $key => $value) {
+            if ($contestModel->judgeClearance($value['cid'], $user_id)!=3) {
                 unset($problems[$key]);
-            }else{
-                $problems[$key]['tags'] = $this->problemTags($gid,$value['pid']);
+            } else {
+                $problems[$key]['tags']=$this->problemTags($gid, $value['pid']);
             }
         }
         return $problems;
     }
 
-    public function problemAddTag($gid,$pid,$tag)
+    public function problemAddTag($gid, $pid, $tag)
     {
         return DB::table("group_problem_tag")->insert([
             "gid"=>$gid,
@@ -288,7 +288,7 @@ 
         ]);
     }
 
-    public function problemRemoveTag($gid,$pid,$tag)
+    public function problemRemoveTag($gid, $pid, $tag)
     {
         return DB::table("group_problem_tag")->where([
             "gid"=>$gid,
@@ -333,7 +333,7 @@ 
     public function judgeEmailClearance($gid, $email)
     {
         $user=DB::table("users")->where(["email"=>$email])->first();
-        if(empty($user)) return -4;
+        if (empty($user)) return -4;
         $ret=DB::table("group_member")->where([
             "gid"=>$gid,
             "uid"=>$user["id"],
@@ -424,20 +424,20 @@ 
 
     public function groupMemberPracticeContestStat($gid)
     {
-        $contestModel = new ContestModel();
+        $contestModel=new ContestModel();
 
-        $allPracticeContest = DB::table('contest')
+        $allPracticeContest=DB::table('contest')
             ->where([
                 'gid' => $gid,
                 'practice' => 1,
             ])
-            ->select('cid','name')
+            ->select('cid', 'name')
             ->get()->all();
-        $user_list = $this->userList($gid);
+        $user_list=$this->userList($gid);
 
-        $memberData = [];
+        $memberData=[];
         foreach ($user_list as $u) {
-            $memberData[$u['uid']] = [
+            $memberData[$u['uid']]=[
                 'name' => $u['name'],
                 'nick_name' => $u['nick_name'],
                 'elo' => $u['ranking'],
@@ -448,61 +448,61 @@ 
             ];
         }
         foreach ($allPracticeContest as $c) {
-            $contestRankRaw = $contestModel->contestRank($c['cid']);
-            foreach($contestRankRaw as $key => $contestRank){
-                if(isset($contestRank['remote']) && $contestRank['remote']){
+            $contestRankRaw=$contestModel->contestRank($c['cid']);
+            foreach ($contestRankRaw as $key => $contestRank) {
+                if (isset($contestRank['remote']) && $contestRank['remote']) {
                     unset($contestRankRaw[$key]);
                 }
             }
-            $contestRank = array_values($contestRankRaw);
-            $problemsCount = DB::table('contest_problem')
-                ->where('cid',$c['cid'])
+            $contestRank=array_values($contestRankRaw);
+            $problemsCount=DB::table('contest_problem')
+                ->where('cid', $c['cid'])
                 ->count();
-            $index = 1;
-            $rank = 1;
-            $last_cr = [];
-            $last_rank = 1;
+            $index=1;
+            $rank=1;
+            $last_cr=[];
+            $last_rank=1;
             foreach ($contestRank as $cr) {
-                $last_rank = $index;
-                if(!empty($last_cr)){
-                    if($cr['solved'] == $last_cr['solved'] && $cr['penalty'] == $last_cr['penalty'] ){
-                        $rank = $last_rank;
-                    }else{
-                        $rank = $index;
-                        $last_rank = $rank;
+                $last_rank=$index;
+                if (!empty($last_cr)) {
+                    if ($cr['solved']==$last_cr['solved'] && $cr['penalty']==$last_cr['penalty']) {
+                        $rank=$last_rank;
+                    } else {
+                        $rank=$index;
+                        $last_rank=$rank;
                     }
                 }
-                if(in_array($cr['uid'],array_keys($memberData))) {
-                    $memberData[$cr['uid']]['solved_all'] += $cr['solved'];
-                    $memberData[$cr['uid']]['problem_all'] += $problemsCount;
-                    $memberData[$cr['uid']]['penalty'] += $cr['penalty'];
-                    $memberData[$cr['uid']]['contest_detial'][$c['cid']] = [
+                if (in_array($cr['uid'], array_keys($memberData))) {
+                    $memberData[$cr['uid']]['solved_all']+=$cr['solved'];
+                    $memberData[$cr['uid']]['problem_all']+=$problemsCount;
+                    $memberData[$cr['uid']]['penalty']+=$cr['penalty'];
+                    $memberData[$cr['uid']]['contest_detial'][$c['cid']]=[
                         'rank' => $rank,
                         'solved' => $cr['solved'],
                         'problems' => $problemsCount,
                         'penalty' => $cr['penalty']
                     ];
                 }
-                $last_cr = $cr;
+                $last_cr=$cr;
                 $index++;
             }
         }
-        $new_memberData = [];
+        $new_memberData=[];
         foreach ($memberData as $uid => $data) {
-            $contest_count = 0;
-            $rank_sum = 0;
+            $contest_count=0;
+            $rank_sum=0;
             foreach ($data['contest_detial'] as $cid => $c) {
-                $rank_sum += $c['rank'];
-                $contest_count += 1;
+                $rank_sum+=$c['rank'];
+                $contest_count+=1;
             }
-            $temp = $data;
-            $temp['uid'] = $uid;
-            if($contest_count != 0){
-                $temp['rank_ave'] = $rank_sum/$contest_count;
+            $temp=$data;
+            $temp['uid']=$uid;
+            if ($contest_count!=0) {
+                $temp['rank_ave']=$rank_sum / $contest_count;
             }
-            array_push($new_memberData,$temp);
+            array_push($new_memberData, $temp);
         }
-        $ret = [
+        $ret=[
             'contest_list' => $allPracticeContest,
             'member_data' => $new_memberData
         ];
@@ -511,58 +511,58 @@ 
 
     public function groupMemberPracticeTagStat($gid)
     {
-        $tags = $this->problemTags($gid);
-        $tag_problems = [];
+        $tags=$this->problemTags($gid);
+        $tag_problems=[];
 
-        $user_list = $this->userList($gid);
+        $user_list=$this->userList($gid);
         foreach ($tags as $tag) {
-            $tag_problems[$tag] = DB::table('problem')
-                ->join('group_problem_tag','problem.pid','=','group_problem_tag.pid')
+            $tag_problems[$tag]=DB::table('problem')
+                ->join('group_problem_tag', 'problem.pid', '=', 'group_problem_tag.pid')
                 ->where([
                     'group_problem_tag.gid' => $gid,
                     'tag' => $tag
                 ])
-                ->select('group_problem_tag.pid as pid','pcode','title')
+                ->select('group_problem_tag.pid as pid', 'pcode', 'title')
                 ->get()->all();
         }
-        $all_problems = [];
+        $all_problems=[];
         foreach ($tag_problems as &$tag_problem_set) {
             foreach ($tag_problem_set as $problem) {
-                $all_problems[$problem['pid']] = $problem;
+                $all_problems[$problem['pid']]=$problem;
             }
-            $tag_problem_set = array_column($tag_problem_set,'pid');
+            $tag_problem_set=array_column($tag_problem_set, 'pid');
         }
-        $submission_data =  DB::table('submission')
-            ->whereIn('pid',array_keys($all_problems))
-            ->whereIn('uid',array_column($user_list,'uid'))
-            ->where('verdict','Accepted')
-            ->select('pid','uid')
+        $submission_data=DB::table('submission')
+            ->whereIn('pid', array_keys($all_problems))
+            ->whereIn('uid', array_column($user_list, 'uid'))
+            ->where('verdict', 'Accepted')
+            ->select('pid', 'uid')
             ->get()->all();
 
-        $memberData = [];
+        $memberData=[];
         foreach ($user_list as $member) {
-            $completion = [];
-            foreach($tag_problems as $tag => $problems) {
-                $completion[$tag] = [];
+            $completion=[];
+            foreach ($tag_problems as $tag => $problems) {
+                $completion[$tag]=[];
                 foreach ($problems as $problem) {
-                    $is_accepted = 0;
+                    $is_accepted=0;
                     foreach ($submission_data as $sd) {
-                        if($sd['pid'] == $problem && $sd['uid'] == $member['uid']){
-                            $is_accepted = 1;
+                        if ($sd['pid']==$problem && $sd['uid']==$member['uid']) {
+                            $is_accepted=1;
                             break;
                         }
                     }
-                    $completion[$tag][$problem] = $is_accepted;
+                    $completion[$tag][$problem]=$is_accepted;
                 }
             }
-            array_push($memberData,[
+            array_push($memberData, [
                 'uid' => $member['uid'],
                 'name' => $member['name'],
                 'nick_name' => $member['nick_name'],
                 'completion' => $completion,
             ]);
         }
-        $ret = [
+        $ret=[
             'all_problems' => $all_problems,
             'tag_problems' => $tag_problems,
             'member_data' => $memberData
@@ -572,10 +572,10 @@ 
 
     public function refreshAllElo()
     {
-        $result = [];
-        $gids = DB::table('group')->select('gid','name')->get()->all();
+        $result=[];
+        $gids=DB::table('group')->select('gid', 'name')->get()->all();
         foreach ($gids as $gid) {
-            $result[$gid['gid']] = [
+            $result[$gid['gid']]=[
                 'name' => $gid['name'],
                 'result' => $this->refreshElo($gid['gid']),
             ];
@@ -586,41 +586,41 @@ 
     public function refreshElo($gid)
     {
         DB::table('group_rated_change_log')
-            ->where('gid',$gid)
+            ->where('gid', $gid)
             ->delete();
         DB::table('group_member')
-            ->where('gid',$gid)
+            ->where('gid', $gid)
             ->update([
                 'ranking' => 1500
             ]);
-        $contests = DB::table('contest')
+        $contests=DB::table('contest')
             ->where([
                 'gid' => $gid,
                 'practice' => 1
             ])
-            ->where('end_time','<',date("Y-m-d H:i:s"))
-            ->select('cid','name')
+            ->where('end_time', '<', date("Y-m-d H:i:s"))
+            ->select('cid', 'name')
             ->orderBy('end_time')
             ->get()->all();
 
-        if(empty($contests)) {
+        if (empty($contests)) {
             return [];
         }
-        $result = [];
-        $contestModel = new ContestModel();
+        $result=[];
+        $contestModel=new ContestModel();
         foreach ($contests as $contest) {
-            $judge_status = $contestModel->judgeOver($contest['cid']);
-            if($judge_status['result'] == true){
-                $calc = new GroupRatingCalculator($contest['cid']);
+            $judge_status=$contestModel->judgeOver($contest['cid']);
+            if ($judge_status['result']==true) {
+                $calc=new GroupRatingCalculator($contest['cid']);
                 $calc->calculate();
                 $calc->storage();
-                $result[] = [
+                $result[]=[
                     'ret' => 'success',
                     'cid' => $contest['cid'],
                     'name' => $contest['name']
                 ];
-            }else{
-                $result[] = [
+            } else {
+                $result[]=[
                     'ret' => 'judging',
                     'cid' => $contest['cid'],
                     'name' => $contest['name'],
@@ -632,23 +632,23 @@ 
         return $result;
     }
 
-    public function getEloChangeLog($gid,$uid)
+    public function getEloChangeLog($gid, $uid)
     {
-        $ret = DB::table('group_rated_change_log')
-            ->join('contest','group_rated_change_log.cid','=','contest.cid')
+        $ret=DB::table('group_rated_change_log')
+            ->join('contest', 'group_rated_change_log.cid', '=', 'contest.cid')
             ->where([
                 'group_rated_change_log.gid' => $gid,
                 'group_rated_change_log.uid' => $uid
             ])->select('group_rated_change_log.cid as cid', 'contest.name as name', 'ranking', 'end_time')
             ->orderBy('contest.end_time')
             ->get()->all();
-            $begin = [
+            $begin=[
                 'cid' => -1,
                 'name' => '',
                 'ranking' => '1500',
-                'end_time' => date("Y-m-d H:i:s",(strtotime($ret[0]['end_time'] ?? time())  - 3600*24)),
+                'end_time' => date("Y-m-d H:i:s", (strtotime($ret[0]['end_time'] ?? time())-3600 * 24)),
             ];
-            $ret = array_prepend($ret,$begin);
+            $ret=array_prepend($ret, $begin);
         return $ret;
     }
 }

Braces +13 added lines, -7 removed lines

@@ -121,7 +121,9 @@ 
     public function details($gcode)
     {
         $basic_info=DB::table($this->tableName)->where(["gcode"=>$gcode])->first();
-        if(empty($basic_info)) return [];
+        if(empty($basic_info)) {
+            return [];
+        }
         $basic_info["members"]=$this->countGroupMembers($basic_info["gid"]);
         $basic_info["tags"]=$this->getGroupTags($basic_info["gid"]);
         $basic_info["create_time_foramt"]=date_format(date_create($basic_info["created_at"]), 'M jS, Y');
@@ -169,7 +171,9 @@ 
         foreach ($user_list as &$u) {
             $u["role_parsed"]=$this->role[$u["role"]];
             $u["role_color"]=$this->role_color[$u["role"]];
-            if(is_null($u["sub_group"])) $u["sub_group"]="None";
+            if(is_null($u["sub_group"])) {
+                $u["sub_group"]="None";
+            }
         }
         return $user_list;
     }
@@ -238,7 +242,7 @@ 
             ->where('gid',$gid)
             ->distinct()
             ->get()->all();
-        }else{
+        } else{
             $tags =  DB::table('group_problem_tag')
             ->select('tag')
             ->where('gid', $gid)
@@ -272,7 +276,7 @@ 
         foreach($problems as $key => $value){
             if($contestModel->judgeClearance($value['cid'],$user_id) != 3){
                 unset($problems[$key]);
-            }else{
+            } else{
                 $problems[$key]['tags'] = $this->problemTags($gid,$value['pid']);
             }
         }
@@ -333,7 +337,9 @@ 
     public function judgeEmailClearance($gid, $email)
     {
         $user=DB::table("users")->where(["email"=>$email])->first();
-        if(empty($user)) return -4;
+        if(empty($user)) {
+            return -4;
+        }
         $ret=DB::table("group_member")->where([
             "gid"=>$gid,
             "uid"=>$user["id"],
@@ -467,7 +473,7 @@ 
                 if(!empty($last_cr)){
                     if($cr['solved'] == $last_cr['solved'] && $cr['penalty'] == $last_cr['penalty'] ){
                         $rank = $last_rank;
-                    }else{
+                    } else{
                         $rank = $index;
                         $last_rank = $rank;
                     }
@@ -619,7 +625,7 @@ 
                     'cid' => $contest['cid'],
                     'name' => $contest['name']
                 ];
-            }else{
+            } else{
                 $result[] = [
                     'ret' => 'judging',
                     'cid' => $contest['cid'],