Problem::getProblemStatusFromDB() - Code Metrics - Inspection of "release: 0.17.0 Characinae" - ZsgsDesign/NOJ - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#724)

by John

created 2021-10-08 14:53 UTC

Problem::getProblemStatusFromDB() C

↳ Parent: Problem

Complexity

Conditions	11
Paths	169

Size

Total Lines	53
Code Lines	36

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	11
eloc	36
nc	169
nop	3
dl	0
loc	53
rs	6.7416
c	1
b	0
f	0

How to fix Long Method Complexity

<?php

namespace App\Models\Eloquent;

use Illuminate\Database\Eloquent\Model;
use App\Models\Eloquent\Contest;
use Auth;
use Carbon;
use DB;
use Exception;

class Problem extends Model
{
    protected $table = 'problem';
    protected $primaryKey = 'pid';
    const UPDATED_AT = "update_date";

    public function getReadableNameAttribute()
    {
        return $this->pcode . '. ' . $this->title;
    }

    public function submissions()
    {
        return $this->hasMany('App\Models\Eloquent\Submission', 'pid', 'pid');
    }

    public function problemSamples()
    {
        return $this->hasMany('App\Models\Eloquent\ProblemSample', 'pid', 'pid');
    }

    public function homework_problems()
    {
        return $this->hasMany('App\Models\Eloquent\GroupHomeworkProblem', 'problem_id', 'pid');
    }

    public function onlinejudge()
    {
        return $this->belongsTo('App\Models\Eloquent\OJ', 'OJ', 'oid');
    }

    public function getProblemStatusAttribute()
    {
        return $this->getProblemStatus();
    }

    public function getProblemStatus($userID = null, $contestID = null, Carbon $till = null)
    {
        if (blank($userID)) {
            if (Auth::guard('web')->check()) {
                $userID = Auth::guard('web')->user()->id;

            }
        }

        if (filled($userID)) {
            $probStatus = $this->getProblemStatusFromDB($userID, $contestID, $till);
            if (blank($probStatus)) {
                return [
                    "icon" => "checkbox-blank-circle-outline",
                    "color" => "wemd-grey-text"
                ];
            } else {
                return [
                    "icon" => $probStatus->verdict == "Accepted" ? "checkbox-blank-circle" : "cisco-webex",
                    "color" => $probStatus->color
                ];
            }
        } else {
            return [
                "icon" => "checkbox-blank-circle-outline",
                "color" => "wemd-grey-text"
            ];
        }
    }

    private function getProblemStatusFromDB($userID, $contestID = null, Carbon $till = null)
    {
        if (filled($contestID)) {
            try {
                $endedAt = Carbon::parse(Contest::findOrFail($contestID)->endedAt);
            } catch (Exception $e) {
                return null;
            }
        }

        // Get the very first AC record

        $acRecords = $this->submissions()->where([
            'uid' => $userID,
            'cid' => $contestID,
            'verdict' => 'Accepted'
        ]);
        if (filled($contestID)) {
            $acRecords = $acRecords->where("submission_date", "<", $endedAt->timestamp);

        }
        if (filled($till)) {
            $acRecords = $acRecords->where("submission_date", "<", $till->timestamp);
        }
        $acRecords = $acRecords->orderBy('submission_date', 'desc')->first();
        if (blank($acRecords)) {
            $pacRecords = $this->submissions()->where([
                'uid' => $userID,
                'cid' => $contestID,
                'verdict' => 'Partially Accepted'
            ]);
            if (filled($contestID)) {
                $pacRecords = $pacRecords->where("submission_date", "<", $endedAt->timestamp);
            }
            if (filled($till)) {
                $pacRecords = $pacRecords->where("submission_date", "<", $till->timestamp);
            }
            $pacRecords = $pacRecords->orderBy('submission_date', 'desc')->first();
            if (blank($pacRecords)) {
                $otherRecords = $this->submissions()->where([
                    'uid' => $userID,
                    'cid' => $contestID
                ]);
                if (filled($contestID)) {
                    $otherRecords = $otherRecords->where("submission_date", "<", $endedAt->timestamp);
                }
                if (filled($till)) {
                    $otherRecords = $otherRecords->where("submission_date", "<", $till->timestamp);
                }
                return $otherRecords->orderBy('submission_date', 'desc')->first();
            }
            return $pacRecords;
        } else {
            return $acRecords;
        }
    }

    public function users_latest_submission($users, $contestID = null, Carbon $till = null, $verdictFilter = [])
    {
        if (filled($contestID)) {
            $endedAt = Carbon::parse(Contest::findOrFail($contestID)->endedAt);
        }

        $lastRecordSubQuery = $this->submissions()->select('uid', DB::raw('MAX(submission_date) as submission_date'))->whereIntegerInRaw('uid', $users)->where('cid', $contestID)->groupBy('uid');

        if (filled($contestID)) {
            $lastRecordSubQuery = $lastRecordSubQuery->where("submission_date", "<", $endedAt->timestamp);

        }

        if (filled($till)) {
            $lastRecordSubQuery = $lastRecordSubQuery->where("submission_date", "<", $till->timestamp);
        }

        if(filled($verdictFilter)) {
            $lastRecordSubQuery = $lastRecordSubQuery->whereIn('verdict', $verdictFilter);
        }

        $query = DB::table(DB::raw("({$lastRecordSubQuery->toSql()}) last_sub"))->leftJoinSub(Submission::toBase(), 'submissions', function ($join) {
            $join->on('last_sub.submission_date', '=', 'submissions.submission_date')->on('last_sub.uid', '=', 'submissions.uid');
        })->select('sid', 'last_sub.submission_date as submission_date', 'last_sub.uid as uid', 'verdict', 'color')->orderBy('uid', 'ASC');

        return $query->mergeBindings($lastRecordSubQuery->toBase());
    }

    /*     public function getSamplesAttribute()
    {
        return array_map(function($sample) {
            return [
                'sample_input' => $sample->sample_input,
                'sample_output' => $sample->sample_output,
                'sample_note' => $sample->sample_note,
            ];
        }, $this->problemSamples()->select('sample_input', 'sample_output', 'sample_note')->get()->all());
    }

    public function setSamplesAttribute($value)
    {
        return;
    } */
}


1			<?php
2
3			namespace App\Models\Eloquent;
4
5			use Illuminate\Database\Eloquent\Model;
6			use App\Models\Eloquent\Contest;
7			use Auth;
8			use Carbon;
9			use DB;
10			use Exception;
11
12			class Problem extends Model
13			{
14			protected $table = 'problem';
15			protected $primaryKey = 'pid';
16			const UPDATED_AT = "update_date";
17
18			public function getReadableNameAttribute()
19			{
20			return $this->pcode . '. ' . $this->title;
21			}
22
23			public function submissions()
24			{
25			return $this->hasMany('App\Models\Eloquent\Submission', 'pid', 'pid');
26			}
27
28			public function problemSamples()
29			{
30			return $this->hasMany('App\Models\Eloquent\ProblemSample', 'pid', 'pid');
31			}
32
33			public function homework_problems()
34			{
35			return $this->hasMany('App\Models\Eloquent\GroupHomeworkProblem', 'problem_id', 'pid');
36			}
37
38			public function onlinejudge()
39			{
40			return $this->belongsTo('App\Models\Eloquent\OJ', 'OJ', 'oid');
41			}
42
43			public function getProblemStatusAttribute()
44			{
45			return $this->getProblemStatus();
46			}
47
48			public function getProblemStatus($userID = null, $contestID = null, Carbon $till = null)
49			{
50			if (blank($userID)) {
51			if (Auth::guard('web')->check()) {
52			$userID = Auth::guard('web')->user()->id;
			0 ignored issues – show Bug introduced 2021-08-13 20:36 UTC by Report Bug Copy Issue Report Accessing `id` on the interface `Illuminate\Contracts\Auth\Authenticatable` suggest that you code against a concrete implementation. How about adding an `instanceof` check? Loading history...
53			}
54			}
55
56			if (filled($userID)) {
57			$probStatus = $this->getProblemStatusFromDB($userID, $contestID, $till);
58			if (blank($probStatus)) {
59			return [
60			"icon" => "checkbox-blank-circle-outline",
61			"color" => "wemd-grey-text"
62			];
63			} else {
64			return [
65			"icon" => $probStatus->verdict == "Accepted" ? "checkbox-blank-circle" : "cisco-webex",
66			"color" => $probStatus->color
67			];
68			}
69			} else {
70			return [
71			"icon" => "checkbox-blank-circle-outline",
72			"color" => "wemd-grey-text"
73			];
74			}
75			}
76
77			private function getProblemStatusFromDB($userID, $contestID = null, Carbon $till = null)
78			{
79			if (filled($contestID)) {
80			try {
81			$endedAt = Carbon::parse(Contest::findOrFail($contestID)->endedAt);
82			} catch (Exception $e) {
83			return null;
84			}
85			}
86
87			// Get the very first AC record
88
89			$acRecords = $this->submissions()->where([
90			'uid' => $userID,
91			'cid' => $contestID,
92			'verdict' => 'Accepted'
93			]);
94			if (filled($contestID)) {
95			$acRecords = $acRecords->where("submission_date", "<", $endedAt->timestamp);
			0 ignored issues – show Comprehensibility Best Practice introduced 2021-10-08 07:02 UTC by Report Bug Copy Issue Report The variable `$endedAt` does not seem to be defined for all execution paths leading up to this point. Loading history...
96			}
97			if (filled($till)) {
98			$acRecords = $acRecords->where("submission_date", "<", $till->timestamp);
99			}
100			$acRecords = $acRecords->orderBy('submission_date', 'desc')->first();
101			if (blank($acRecords)) {
102			$pacRecords = $this->submissions()->where([
103			'uid' => $userID,
104			'cid' => $contestID,
105			'verdict' => 'Partially Accepted'
106			]);
107			if (filled($contestID)) {
108			$pacRecords = $pacRecords->where("submission_date", "<", $endedAt->timestamp);
109			}
110			if (filled($till)) {
111			$pacRecords = $pacRecords->where("submission_date", "<", $till->timestamp);
112			}
113			$pacRecords = $pacRecords->orderBy('submission_date', 'desc')->first();
114			if (blank($pacRecords)) {
115			$otherRecords = $this->submissions()->where([
116			'uid' => $userID,
117			'cid' => $contestID
118			]);
119			if (filled($contestID)) {
120			$otherRecords = $otherRecords->where("submission_date", "<", $endedAt->timestamp);
121			}
122			if (filled($till)) {
123			$otherRecords = $otherRecords->where("submission_date", "<", $till->timestamp);
124			}
125			return $otherRecords->orderBy('submission_date', 'desc')->first();
126			}
127			return $pacRecords;
128			} else {
129			return $acRecords;
130			}
131			}
132
133			public function users_latest_submission($users, $contestID = null, Carbon $till = null, $verdictFilter = [])
134			{
135			if (filled($contestID)) {
136			$endedAt = Carbon::parse(Contest::findOrFail($contestID)->endedAt);
137			}
138
139			$lastRecordSubQuery = $this->submissions()->select('uid', DB::raw('MAX(submission_date) as submission_date'))->whereIntegerInRaw('uid', $users)->where('cid', $contestID)->groupBy('uid');
140
141			if (filled($contestID)) {
142			$lastRecordSubQuery = $lastRecordSubQuery->where("submission_date", "<", $endedAt->timestamp);
			0 ignored issues – show Comprehensibility Best Practice introduced 2021-10-08 07:02 UTC by Report Bug Copy Issue Report The variable `$endedAt` does not seem to be defined for all execution paths leading up to this point. Loading history...
143			}
144
145			if (filled($till)) {
146			$lastRecordSubQuery = $lastRecordSubQuery->where("submission_date", "<", $till->timestamp);
147			}
148
149			if(filled($verdictFilter)) {
150			$lastRecordSubQuery = $lastRecordSubQuery->whereIn('verdict', $verdictFilter);
151			}
152
153			$query = DB::table(DB::raw("({$lastRecordSubQuery->toSql()}) last_sub"))->leftJoinSub(Submission::toBase(), 'submissions', function ($join) {
154			$join->on('last_sub.submission_date', '=', 'submissions.submission_date')->on('last_sub.uid', '=', 'submissions.uid');
155			})->select('sid', 'last_sub.submission_date as submission_date', 'last_sub.uid as uid', 'verdict', 'color')->orderBy('uid', 'ASC');
156
157			return $query->mergeBindings($lastRecordSubQuery->toBase());
158			}
159
160			/* public function getSamplesAttribute()
161			{
162			return array_map(function($sample) {
163			return [
164			'sample_input' => $sample->sample_input,
165			'sample_output' => $sample->sample_output,
166			'sample_note' => $sample->sample_note,
167			];
168			}, $this->problemSamples()->select('sample_input', 'sample_output', 'sample_note')->get()->all());
169			}
170
171			public function setSamplesAttribute($value)
172			{
173			return;
174			} */
175			}
176

ZsgsDesign / NOJ

Pull Request — master (#724)

Problem::getProblemStatusFromDB() C

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like