ZsgsDesign / NOJ

app/Models/GroupModel.php

Braces +9 added lines, -3 removed lines

@@ -121,7 +121,9 @@ 
     public function details($gcode)
     {
         $basic_info=DB::table($this->tableName)->where(["gcode"=>$gcode])->first();
-        if (empty($basic_info)) return [];
+        if (empty($basic_info)) {
+            return [];
+        }
         $basic_info["members"]=$this->countGroupMembers($basic_info["gid"]);
         $basic_info["tags"]=$this->getGroupTags($basic_info["gid"]);
         $basic_info["create_time_foramt"]=date_format(date_create($basic_info["created_at"]), 'M jS, Y');
@@ -169,7 +171,9 @@ 
         foreach ($user_list as &$u) {
             $u["role_parsed"]=$this->role[$u["role"]];
             $u["role_color"]=$this->role_color[$u["role"]];
-            if (is_null($u["sub_group"])) $u["sub_group"]="None";
+            if (is_null($u["sub_group"])) {
+                $u["sub_group"]="None";
+            }
         }
         return $user_list;
     }
@@ -300,7 +304,9 @@ 
     public function judgeEmailClearance($gid, $email)
     {
         $user=DB::table("users")->where(["email"=>$email])->first();
-        if (empty($user)) return -4;
+        if (empty($user)) {
+            return -4;
+        }
         $ret=DB::table("group_member")->where([
             "gid"=>$gid,
             "uid"=>$user["id"],

app/Models/ProblemModel.php

Braces +6 added lines, -2 removed lines

@@ -454,7 +454,9 @@ 
 
         if (!empty($data["sample"])) {
             foreach ($data["sample"] as $d) {
-                if (!isset($d['sample_note'])) $d['sample_note']=null;
+                if (!isset($d['sample_note'])) {
+                    $d['sample_note']=null;
+                }
                 DB::table("problem_sample")->insert([
                     'pid'=>$pid,
                     'sample_input'=>$d['sample_input'],
@@ -503,7 +505,9 @@ 
 
         if (!empty($data["sample"])) {
             foreach ($data["sample"] as $d) {
-                if (!isset($d['sample_note'])) $d['sample_note']=null;
+                if (!isset($d['sample_note'])) {
+                    $d['sample_note']=null;
+                }
                 DB::table("problem_sample")->insert([
                     'pid'=>$pid,
                     'sample_input'=>$d['sample_input'],

app/Models/Babel/ExtensionModel.php

Braces +12 added lines, -4 removed lines

@@ -80,7 +80,9 @@ 
     {
         $ret=[];
         $marketspaceRaw=self::getRemote();
-        if (empty($marketspaceRaw)) return [];
+        if (empty($marketspaceRaw)) {
+            return [];
+        }
         foreach ($marketspaceRaw["packages"] as $extension) {
             $temp=[
                 "details"=>$extension,
@@ -136,7 +138,9 @@ 
         foreach ($dirs as $d) {
             $extension=basename($d);
             $BabelConfig=json_decode(file_get_contents(babel_path("Extension/$extension/babel.json")), true);
-            if ($extension==$BabelConfig["code"]) $ret[]=$BabelConfig;
+            if ($extension==$BabelConfig["code"]) {
+                $ret[]=$BabelConfig;
+            }
         }
         return $ret;
     }
@@ -153,10 +157,14 @@ 
     public static function remoteDetail($code)
     {
         $babelConfig=self::getRemote();
-        if (empty($babelConfig)) return [];
+        if (empty($babelConfig)) {
+            return [];
+        }
         $babelConfigPackages=$babelConfig["packages"];
         foreach ($babelConfigPackages as $package) {
-            if ($package["code"]==$code) return $package;
+            if ($package["code"]==$code) {
+                return $package;
+            }
         }
         return [];
     }

app/Models/JudgerModel.php

Braces +3 added lines, -1 removed lines

@@ -67,7 +67,9 @@
     public function fetchServer($oid=0)
     {
         $serverList=DB::table("judge_server");
-        if ($oid) $serverList=$serverList->where(["oid"=>$oid]);
+        if ($oid) {
+            $serverList=$serverList->where(["oid"=>$oid]);
+        }
         $serverList=$serverList->get()->all();
         foreach ($serverList as &$server) {
             $server["status_parsed"]=is_null($server["status"]) ?self::$status["-1"] : self::$status[$server["status"]];

app/Models/Latex/LatexModel.php

Braces +3 added lines, -1 removed lines

@@ -9,7 +9,9 @@
 {
     public static function info($ltxsource, $type="png")
     {
-        if (!in_array($type, ['png', 'svg'])) return [];
+        if (!in_array($type, ['png', 'svg'])) {
+            return [];
+        }
         $url=route("latex.$type", ['ltxsource' => $ltxsource]);
         $image=new Imagick();
         $image->readImageBlob(Storage::get('latex-svg/'.urlencode($ltxsource).'.svg'));

app/Models/Eloquent/Dojo/Dojo.php

Braces +9 added lines, -3 removed lines

@@ -42,8 +42,12 @@ 
     {
         $precondition=[];
         foreach (explode(',', $value) as $dojo_id) {
-            if (blank($dojo_id)) continue;
-            if (!is_null(Dojo::find($dojo_id))) $precondition[]=$dojo_id;
+            if (blank($dojo_id)) {
+                continue;
+            }
+            if (!is_null(Dojo::find($dojo_id))) {
+                $precondition[]=$dojo_id;
+            }
         }
         return $precondition;
     }
@@ -66,7 +70,9 @@ 
     public function getAvailabilityAttribute()
     {
         foreach ($this->precondition as $dojo_id) {
-            if (!DojoPass::isPassed($dojo_id)) return 'locked';
+            if (!DojoPass::isPassed($dojo_id)) {
+                return 'locked';
+            }
         }
         return $this->passed ? 'passed' : 'available';
     }

app/Models/Eloquent/Message.php

Braces +4 added lines, -4 removed lines

@@ -35,7 +35,7 @@ 
                         }
                     }
                 }
-            }elseif ($config['type']==2) { //to a leader that member agree to join the group
+            } elseif ($config['type']==2) { //to a leader that member agree to join the group
                 $messages=Message::where([
                     'receiver' => $config['receiver'],
                     'type'     => $config['type'],
@@ -52,7 +52,7 @@ 
                         }
                     }
                 }
-            }elseif ($config['type']==3) { //to a person that solution was passed
+            } elseif ($config['type']==3) { //to a person that solution was passed
                 $message=Message::where([
                     'receiver' => $config['receiver'],
                     'type'     => $config['type'],
@@ -65,7 +65,7 @@ 
                     $message->save();
                     return true;
                 }
-            }elseif ($config['type']==4) { //to a person that solution was blocked
+            } elseif ($config['type']==4) { //to a person that solution was blocked
                 $message=Message::where([
                     'receiver' => $config['receiver'],
                     'type'     => $config['type'],
@@ -223,7 +223,7 @@ 
                 $content=substr($content, 0, strlen($content)-2);
                 $content.=" want to join your group [{$data['group']['name']}]({$data['group']['url']})";
                 return $content;
-            }elseif ($this->type==2) {
+            } elseif ($this->type==2) {
                 foreach ($data['user'] as $user) {
                     $content.="[{$user['name']}]({$user['url']}), ";
                 }

app/Babel/Submit/Curl.php

Braces +105 added lines, -21 removed lines

@@ -18,11 +18,31 @@ 
 
     public function login($all_data)
     {
-        if (isset($all_data["url"]))    $url=$all_data["url"]; else throw new Exception("url is not exist in all_data");
-        if (isset($all_data["data"]))   $data=$all_data["data"]; else throw new Exception("data is not exist in all_data");
-        if (isset($all_data["oj"]))     $oj=$all_data["oj"]; else throw new Exception("oj is not exist in all_data");
-        if (isset($all_data["ret"]))    $ret=$all_data["ret"]; else $ret='false';
-        if (isset($all_data["handle"])) $handle=$all_data["handle"]; else $handle="default";
+        if (isset($all_data["url"])) {
+            $url=$all_data["url"];
+        } else {
+            throw new Exception("url is not exist in all_data");
+        }
+        if (isset($all_data["data"])) {
+            $data=$all_data["data"];
+        } else {
+            throw new Exception("data is not exist in all_data");
+        }
+        if (isset($all_data["oj"])) {
+            $oj=$all_data["oj"];
+        } else {
+            throw new Exception("oj is not exist in all_data");
+        }
+        if (isset($all_data["ret"])) {
+            $ret=$all_data["ret"];
+        } else {
+            $ret='false';
+        }
+        if (isset($all_data["handle"])) {
+            $handle=$all_data["handle"];
+        } else {
+            $handle="default";
+        }
 
         $datapost=curl_init();
         $headers=array("Expect:");
@@ -54,12 +74,36 @@ 
 
     public function grab_page($all_data)
     {
-        if (isset($all_data["site"]))    $site=$all_data["site"]; else throw new Exception("site is not exist in all_data");
-        if (isset($all_data["oj"]))      $oj=$all_data["oj"]; else throw new Exception("oj is not exist in all_data");
-        if (isset($all_data["headers"])) $headers=$all_data["headers"]; else $headers=[];
-        if (isset($all_data["handle"]))  $handle=$all_data["handle"]; else $handle="default";
-        if (isset($all_data["follow"]))  $follow=$all_data["follow"]; else $follow=false;
-        if (isset($all_data["vcid"]))  $vcid=$all_data["vcid"]."_"; else $vcid="";
+        if (isset($all_data["site"])) {
+            $site=$all_data["site"];
+        } else {
+            throw new Exception("site is not exist in all_data");
+        }
+        if (isset($all_data["oj"])) {
+            $oj=$all_data["oj"];
+        } else {
+            throw new Exception("oj is not exist in all_data");
+        }
+        if (isset($all_data["headers"])) {
+            $headers=$all_data["headers"];
+        } else {
+            $headers=[];
+        }
+        if (isset($all_data["handle"])) {
+            $handle=$all_data["handle"];
+        } else {
+            $handle="default";
+        }
+        if (isset($all_data["follow"])) {
+            $follow=$all_data["follow"];
+        } else {
+            $follow=false;
+        }
+        if (isset($all_data["vcid"])) {
+            $vcid=$all_data["vcid"]."_";
+        } else {
+            $vcid="";
+        }
 
         $handle=urlencode($handle);
 
@@ -86,16 +130,56 @@ 
 
     public function post_data($all_data)
     {
-        if (isset($all_data["site"]))         $site=$all_data["site"]; else throw new Exception("site is not exist in all_data");
-        if (isset($all_data["data"]))         $data=$all_data["data"]; else throw new Exception("data is not exist in all_data");
-        if (isset($all_data["oj"]))           $oj=$all_data["oj"]; else throw new Exception("oj is not exist in all_data");
-        if (isset($all_data["ret"]))          $ret=$all_data["ret"]; else $ret=false;
-        if (isset($all_data["follow"]))       $follow=$all_data["follow"]; else $follow=true;
-        if (isset($all_data["returnHeader"])) $returnHeader=$all_data["returnHeader"]; else $returnHeader=true;
-        if (isset($all_data["postJson"]))     $postJson=$all_data["postJson"]; else $postJson=false;
-        if (isset($all_data["extraHeaders"])) $extraHeaders=$all_data["extraHeaders"]; else $extraHeaders=[];
-        if (isset($all_data["handle"]))       $handle=$all_data["handle"]; else $handle="default";
-        if (isset($all_data["vcid"]))  $vcid=$all_data["vcid"]."_"; else $vcid="";
+        if (isset($all_data["site"])) {
+            $site=$all_data["site"];
+        } else {
+            throw new Exception("site is not exist in all_data");
+        }
+        if (isset($all_data["data"])) {
+            $data=$all_data["data"];
+        } else {
+            throw new Exception("data is not exist in all_data");
+        }
+        if (isset($all_data["oj"])) {
+            $oj=$all_data["oj"];
+        } else {
+            throw new Exception("oj is not exist in all_data");
+        }
+        if (isset($all_data["ret"])) {
+            $ret=$all_data["ret"];
+        } else {
+            $ret=false;
+        }
+        if (isset($all_data["follow"])) {
+            $follow=$all_data["follow"];
+        } else {
+            $follow=true;
+        }
+        if (isset($all_data["returnHeader"])) {
+            $returnHeader=$all_data["returnHeader"];
+        } else {
+            $returnHeader=true;
+        }
+        if (isset($all_data["postJson"])) {
+            $postJson=$all_data["postJson"];
+        } else {
+            $postJson=false;
+        }
+        if (isset($all_data["extraHeaders"])) {
+            $extraHeaders=$all_data["extraHeaders"];
+        } else {
+            $extraHeaders=[];
+        }
+        if (isset($all_data["handle"])) {
+            $handle=$all_data["handle"];
+        } else {
+            $handle="default";
+        }
+        if (isset($all_data["vcid"])) {
+            $vcid=$all_data["vcid"]."_";
+        } else {
+            $vcid="";
+        }
 
         $handle=urlencode($handle);