Passed
Push — master ( 515a30...5abd12 )
by John
04:00
created
app/Http/Controllers/Ajax/ContestAdminController.php 2 patches
Spacing   +43 added lines, -43 removed lines patch added patch discarded remove patch
@@ -20,22 +20,22 @@  discard block
 block discarded – undo
20 20
             'cid' => 'required|integer',
21 21
             'uid' => 'required|integer'
22 22
         ]);
23
-        $cid = $request->input('cid');
24
-        $uid = $request->input('uid');
23
+        $cid=$request->input('cid');
24
+        $uid=$request->input('uid');
25 25
 
26
-        $groupModel = new GroupModel();
27
-        $contestModel = new ContestModel();
26
+        $groupModel=new GroupModel();
27
+        $contestModel=new ContestModel();
28 28
 
29
-        $contest_info = $contestModel->basic($cid);
30
-        if($contestModel->judgeClearance($cid,Auth::user()->id) != 3){
29
+        $contest_info=$contestModel->basic($cid);
30
+        if ($contestModel->judgeClearance($cid, Auth::user()->id)!=3) {
31 31
             return ResponseModel::err(2001);
32 32
         }
33 33
 
34
-        if($groupModel->judgeClearance($contest_info['gid'],$uid) < 2){
34
+        if ($groupModel->judgeClearance($contest_info['gid'], $uid)<2) {
35 35
             return ResponseModel::err(7004);
36 36
         }
37 37
 
38
-        $contestModel->assignMember($cid,$uid);
38
+        $contestModel->assignMember($cid, $uid);
39 39
         return ResponseModel::success(200);
40 40
     }
41 41
 
@@ -44,30 +44,30 @@  discard block
 block discarded – undo
44 44
         $request->validate([
45 45
             'cid' => 'required|integer',
46 46
         ]);
47
-        $cid = $request->input('cid');
47
+        $cid=$request->input('cid');
48 48
 
49
-        $contestModel = new ContestModel();
50
-        $groupModel = new GroupModel();
49
+        $contestModel=new ContestModel();
50
+        $groupModel=new GroupModel();
51 51
 
52
-        $contest_problems = $contestModel->problems($cid);
53
-        $contest_detail = $contestModel->basic($cid);
54
-        $contest_detail['problems'] = $contest_problems;
55
-        $assign_uid = $contest_detail['assign_uid'];
56
-        $clearance = $contestModel->judgeClearance($cid,Auth::user()->id);
57
-        if($clearance != 3){
52
+        $contest_problems=$contestModel->problems($cid);
53
+        $contest_detail=$contestModel->basic($cid);
54
+        $contest_detail['problems']=$contest_problems;
55
+        $assign_uid=$contest_detail['assign_uid'];
56
+        $clearance=$contestModel->judgeClearance($cid, Auth::user()->id);
57
+        if ($clearance!=3) {
58 58
             return ResponseModel::err(2001);
59 59
         }
60
-        if($assign_uid != 0){
61
-            $assignee = $groupModel->userProfile($assign_uid,$contest_detail['gid']);
62
-        }else{
63
-            $assignee = null;
60
+        if ($assign_uid!=0) {
61
+            $assignee=$groupModel->userProfile($assign_uid, $contest_detail['gid']);
62
+        } else {
63
+            $assignee=null;
64 64
         }
65
-        $ret = [
65
+        $ret=[
66 66
             'contest_info' => $contest_detail,
67 67
             'assignee' => $assignee,
68
-            'is_admin' => $clearance == 3,
68
+            'is_admin' => $clearance==3,
69 69
         ];
70
-        return ResponseModel::success(200,null,$ret);
70
+        return ResponseModel::success(200, null, $ret);
71 71
     }
72 72
 
73 73
     public function rejudge(Request $request)
@@ -101,15 +101,15 @@  discard block
 block discarded – undo
101 101
             'end_time' => 'required|date|after:begin_time',
102 102
             'description' => 'string'
103 103
         ]);
104
-        $all_data = $request->all();
105
-        $cid = $all_data['cid'];
104
+        $all_data=$request->all();
105
+        $cid=$all_data['cid'];
106 106
 
107
-        $contestModel = new ContestModel();
108
-        if($contestModel->judgeClearance($all_data['cid'],Auth::user()->id) != 3){
107
+        $contestModel=new ContestModel();
108
+        if ($contestModel->judgeClearance($all_data['cid'], Auth::user()->id)!=3) {
109 109
             return ResponseModel::err(2001);
110 110
         }
111 111
 
112
-        if($contestModel->remainingTime($cid) > 0){
112
+        if ($contestModel->remainingTime($cid)>0) {
113 113
             $problems=explode(",", $all_data["problems"]);
114 114
             if (count($problems)>26) {
115 115
                 return ResponseModel::err(4002);
@@ -126,32 +126,32 @@  discard block
 block discarded – undo
126 126
                     ];
127 127
                 }
128 128
             }
129
-            $allow_update = ['name','description','begin_time','end_time'];
129
+            $allow_update=['name', 'description', 'begin_time', 'end_time'];
130 130
 
131
-            foreach($all_data as $key => $value){
132
-                if(!in_array($key,$allow_update)){
131
+            foreach ($all_data as $key => $value) {
132
+                if (!in_array($key, $allow_update)) {
133 133
                     unset($all_data[$key]);
134 134
                 }
135 135
             }
136
-            $contestModel->contestUpdate($cid,$all_data,$problemSet);
136
+            $contestModel->contestUpdate($cid, $all_data, $problemSet);
137 137
             return ResponseModel::success(200);
138
-        }else{
139
-            $allow_update = ['name','description'];
138
+        } else {
139
+            $allow_update=['name', 'description'];
140 140
 
141
-            foreach($all_data as $key => $value){
142
-                if(!in_array($key,$allow_update)){
141
+            foreach ($all_data as $key => $value) {
142
+                if (!in_array($key, $allow_update)) {
143 143
                     unset($all_data[$key]);
144 144
                 }
145 145
             }
146
-            $contestModel->contestUpdate($cid,$all_data,false);
147
-            return ResponseModel::success(200,'
146
+            $contestModel->contestUpdate($cid, $all_data, false);
147
+            return ResponseModel::success(200, '
148 148
                 Successful! However, only the name and description of the match can be changed for the match that has been finished.
149 149
             ');
150 150
         }
151 151
 
152 152
     }
153 153
 
154
-    public function issueAnnouncement(Request $request){
154
+    public function issueAnnouncement(Request $request) {
155 155
         $request->validate([
156 156
             'cid' => 'required|integer',
157 157
             'title' => 'required|string|max:250',
@@ -171,7 +171,7 @@  discard block
 block discarded – undo
171 171
         }
172 172
     }
173 173
 
174
-    public function replyClarification(Request $request){
174
+    public function replyClarification(Request $request) {
175 175
         $request->validate([
176 176
             'cid' => 'required|integer',
177 177
             'ccid' => 'required|integer',
@@ -191,7 +191,7 @@  discard block
 block discarded – undo
191 191
         }
192 192
     }
193 193
 
194
-    public function setClarificationPublic(Request $request){
194
+    public function setClarificationPublic(Request $request) {
195 195
         $request->validate([
196 196
             'cid' => 'required|integer',
197 197
             'ccid' => 'required|integer',
@@ -224,7 +224,7 @@  discard block
 block discarded – undo
224 224
         $groupModel=new GroupModel();
225 225
         $contestModel=new ContestModel();
226 226
         $verified=$contestModel->isVerified($all_data["cid"]);
227
-        if(!$verified){
227
+        if (!$verified) {
228 228
             return ResponseModel::err(2001);
229 229
         }
230 230
         $gid=$contestModel->gid($all_data["cid"]);
Please login to merge, or discard this patch.
Braces   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -60,7 +60,7 @@  discard block
 block discarded – undo
60 60
         }
61 61
         if($assign_uid != 0){
62 62
             $assignee = $groupModel->userProfile($assign_uid,$contest_detail['gid']);
63
-        }else{
63
+        } else{
64 64
             $assignee = null;
65 65
         }
66 66
         $ret = [
@@ -220,7 +220,7 @@  discard block
 block discarded – undo
220 220
             }
221 221
             $contestModel->contestUpdate($cid,$all_data,$problemSet);
222 222
             return ResponseModel::success(200);
223
-        }else{
223
+        } else{
224 224
             $allow_update = ['name','description'];
225 225
 
226 226
             foreach($all_data as $key => $value){
Please login to merge, or discard this patch.
app/Http/Controllers/Ajax/ContestController.php 1 patch
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -41,7 +41,7 @@  discard block
 block discarded – undo
41 41
         $all_data=$request->all();
42 42
 
43 43
         $contestModel=new ContestModel();
44
-        return $contestModel->updateProfessionalRate($all_data["cid"])?ResponseModel::success(200):ResponseModel::err(1001);
44
+        return $contestModel->updateProfessionalRate($all_data["cid"]) ?ResponseModel::success(200) : ResponseModel::err(1001);
45 45
     }
46 46
 
47 47
     public function requestClarification(Request $request)
@@ -77,16 +77,16 @@  discard block
 block discarded – undo
77 77
         $groupModel=new GroupModel();
78 78
         $basic=$contestModel->basic($all_data["cid"]);
79 79
 
80
-        if(!$basic["registration"]){
80
+        if (!$basic["registration"]) {
81 81
             return ResponseModel::err(4003);
82 82
         }
83
-        if(strtotime($basic["registration_due"])<time()){
83
+        if (strtotime($basic["registration_due"])<time()) {
84 84
             return ResponseModel::err(4004);
85 85
         }
86
-        if(!$basic["registant_type"]){
86
+        if (!$basic["registant_type"]) {
87 87
             return ResponseModel::err(4005);
88 88
         }
89
-        if($basic["registant_type"]==1 && !$groupModel->isMember($basic["gid"], Auth::user()->id)){
89
+        if ($basic["registant_type"]==1 && !$groupModel->isMember($basic["gid"], Auth::user()->id)) {
90 90
             return ResponseModel::err(4005);
91 91
         }
92 92
 
@@ -100,13 +100,13 @@  discard block
 block discarded – undo
100 100
         $request->validate([
101 101
             'cid' => 'required|integer'
102 102
         ]);
103
-        $cid = $request->input('cid');
103
+        $cid=$request->input('cid');
104 104
 
105 105
         $contestModel=new ContestModel();
106 106
         $clearance=$contestModel->judgeClearance($cid, Auth::user()->id);
107
-        if ($clearance < 1) {
107
+        if ($clearance<1) {
108 108
             return ResponseModel::err(7002);
109 109
         }
110
-        return ResponseModel::success(200,null,$contestModel->praticeAnalysis($cid));
110
+        return ResponseModel::success(200, null, $contestModel->praticeAnalysis($cid));
111 111
     }
112 112
 }
Please login to merge, or discard this patch.
app/Http/Controllers/Contest/AdminController.php 2 patches
Braces   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -58,7 +58,7 @@
 block discarded – undo
58 58
         $account=$contestModel->getContestAccount($cid);
59 59
         if($account==null){
60 60
             return ;
61
-        }else{
61
+        } else{
62 62
             $AccountExport=new AccountExport($account);
63 63
             $filename="ContestAccount$cid";
64 64
             return Excel::download($AccountExport, $filename.'.xlsx');
Please login to merge, or discard this patch.
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -24,7 +24,7 @@  discard block
 block discarded – undo
24 24
         $contestModel=new ContestModel();
25 25
         $verified=$contestModel->isVerified($cid);
26 26
         $clearance=$contestModel->judgeClearance($cid, Auth::user()->id);
27
-        if ($clearance <= 2) {
27
+        if ($clearance<=2) {
28 28
             return Redirect::route('contest_detail', ['cid' => $cid]);
29 29
         }
30 30
         $contest_name=$contestModel->contestName($cid);
@@ -52,30 +52,30 @@  discard block
 block discarded – undo
52 52
     {
53 53
         $contestModel=new ContestModel();
54 54
         $clearance=$contestModel->judgeClearance($cid, Auth::user()->id);
55
-        if ($clearance <= 2) {
55
+        if ($clearance<=2) {
56 56
             return Redirect::route('contest_detail', ['cid' => $cid]);
57 57
         }
58 58
         $account=$contestModel->getContestAccount($cid);
59
-        if($account==null){
60
-            return ;
61
-        }else{
59
+        if ($account==null) {
60
+            return;
61
+        } else {
62 62
             $AccountExport=new AccountExport($account);
63 63
             $filename="ContestAccount$cid";
64 64
             return Excel::download($AccountExport, $filename.'.xlsx');
65 65
         }
66 66
     }
67 67
 
68
-    public function refreshContestRank($cid){
68
+    public function refreshContestRank($cid) {
69 69
         $contestModel=new ContestModel();
70 70
         $clearance=$contestModel->judgeClearance($cid, Auth::user()->id);
71
-        if ($clearance <= 2) {
71
+        if ($clearance<=2) {
72 72
             return Redirect::route('contest.detail', ['cid' => $cid]);
73 73
         }
74 74
         $contestRankRaw=$contestModel->contestRankCache($cid);
75 75
         Cache::tags(['contest', 'rank'])->put($cid, $contestRankRaw);
76 76
         Cache::tags(['contest', 'rank'])->put("contestAdmin$cid", $contestRankRaw);
77 77
         $end_time=strtotime(DB::table("contest")->where(["cid"=>$cid])->select("end_time")->first()["end_time"]);
78
-        if(time() > strtotime($end_time)){
78
+        if (time()>strtotime($end_time)) {
79 79
             $contestModel->storeContestRankInMySQL($cid, $contestRankRaw);
80 80
         }
81 81
         return Redirect::route('contest.rank', ['cid' => $cid]);
Please login to merge, or discard this patch.
app/Babel/Install/InstallerWorker.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -84,9 +84,9 @@
 block discarded – undo
84 84
             $installed_timestamp=intval($info["compiler_timestamp"]);
85 85
         }
86 86
         $latest_timestamp=$installed_timestamp;
87
-        $ConpilerConfig = glob(babel_path("Extension/$ocode/compiler/*.*"));
87
+        $ConpilerConfig=glob(babel_path("Extension/$ocode/compiler/*.*"));
88 88
         foreach ($ConpilerConfig as $file) {
89
-            if (intval(basename($file)) > $installed_timestamp) {
89
+            if (intval(basename($file))>$installed_timestamp) {
90 90
                 try {
91 91
                     $this->commitCompiler($file, json_decode(file_get_contents($file), true));
92 92
                     $latest_timestamp=intval(basename($file));
Please login to merge, or discard this patch.
app/Models/Submission/SubmissionModel.php 1 patch
Spacing   +13 added lines, -13 removed lines patch added patch discarded remove patch
@@ -413,7 +413,7 @@  discard block
 block discarded – undo
413 413
                                             ->where(['verdict'=>'Waiting'])
414 414
                                             ->get()
415 415
                                             ->all();
416
-        foreach($ret as &$r){
416
+        foreach ($ret as &$r) {
417 417
             $r["ocode"]=DB::table("oj")->where(["oid"=>$r["oid"]])->first()["ocode"];
418 418
         }
419 419
         return $ret;
@@ -431,15 +431,15 @@  discard block
 block discarded – undo
431 431
         if (isset($sub['verdict'])) {
432 432
             $sub["color"]=$this->colorScheme[$sub['verdict']];
433 433
         }
434
-        $result = DB::table($this->tableName)->where(['sid'=>$sid])->update($sub);
435
-        $contestModel = new ContestModel();
436
-        $submission_info = DB::table($this->tableName) -> where(['sid'=>$sid]) -> get() -> first();
437
-        if ($result==1 && $submission_info['cid'] && $contestModel->isContestRunning($submission_info['cid'])){
438
-            $sub['pid'] = $submission_info['pid'];
439
-            $sub['uid'] = $submission_info['uid'];
440
-            $sub['cid'] = $submission_info['cid'];
441
-            $sub['sid'] = $sid;
442
-            $contestModel->updateContestRankTable($submission_info['cid'],$sub);
434
+        $result=DB::table($this->tableName)->where(['sid'=>$sid])->update($sub);
435
+        $contestModel=new ContestModel();
436
+        $submission_info=DB::table($this->tableName) -> where(['sid'=>$sid]) -> get() -> first();
437
+        if ($result==1 && $submission_info['cid'] && $contestModel->isContestRunning($submission_info['cid'])) {
438
+            $sub['pid']=$submission_info['pid'];
439
+            $sub['uid']=$submission_info['uid'];
440
+            $sub['cid']=$submission_info['cid'];
441
+            $sub['sid']=$sid;
442
+            $contestModel->updateContestRankTable($submission_info['cid'], $sub);
443 443
         }
444 444
         return $result;
445 445
     }
@@ -510,15 +510,15 @@  discard block
 block discarded – undo
510 510
             'desc'
511 511
         );
512 512
 
513
-        if($filter["pcode"]){
513
+        if ($filter["pcode"]) {
514 514
             $paginator=$paginator->where(["pcode"=>$filter["pcode"]]);
515 515
         }
516 516
 
517
-        if($filter["result"]){
517
+        if ($filter["result"]) {
518 518
             $paginator=$paginator->where(["verdict"=>$filter["result"]]);
519 519
         }
520 520
 
521
-        if($filter["account"]){
521
+        if ($filter["account"]) {
522 522
             $paginator=$paginator->where(["name"=>$filter["account"]]);
523 523
         }
524 524
 
Please login to merge, or discard this patch.
app/Http/Controllers/Group/AdminController.php 2 patches
Spacing   +10 added lines, -10 removed lines patch added patch discarded remove patch
@@ -21,7 +21,7 @@  discard block
 block discarded – undo
21 21
      */
22 22
     public function settings($gcode)
23 23
     {
24
-        return Redirect::route('group.settings.general', ['gcode' => $gcode]);;
24
+        return Redirect::route('group.settings.general', ['gcode' => $gcode]); ;
25 25
     }
26 26
 
27 27
     /**
@@ -31,7 +31,7 @@  discard block
 block discarded – undo
31 31
      */
32 32
     public function settingsReturn($gcode)
33 33
     {
34
-        return Redirect::route('group.detail', ['gcode' => $gcode]);;
34
+        return Redirect::route('group.detail', ['gcode' => $gcode]); ;
35 35
     }
36 36
 
37 37
     /**
@@ -43,7 +43,7 @@  discard block
 block discarded – undo
43 43
     {
44 44
         $groupModel=new GroupModel();
45 45
         $basic_info=$groupModel->details($gcode);
46
-        if(empty($basic_info)) return Redirect::route('group.index');
46
+        if (empty($basic_info)) return Redirect::route('group.index');
47 47
         $clearance=$groupModel->judgeClearance($basic_info["gid"], Auth::user()->id);
48 48
         $member_list=$groupModel->userList($basic_info["gid"]);
49 49
         return view('group.settings.general', [
@@ -61,10 +61,10 @@  discard block
 block discarded – undo
61 61
      *
62 62
      * @return Response
63 63
      */
64
-    public function problems($gcode){
65
-        $groupModel = new GroupModel();
66
-        $group_info = $groupModel->details($gcode);
67
-        $problems = $groupModel->problems($group_info['gid']);
64
+    public function problems($gcode) {
65
+        $groupModel=new GroupModel();
66
+        $group_info=$groupModel->details($gcode);
67
+        $problems=$groupModel->problems($group_info['gid']);
68 68
         $basic_info=$groupModel->details($gcode);
69 69
         return view('group.settings.problems', [
70 70
             'page_title'=>"Group Problems",
@@ -85,7 +85,7 @@  discard block
 block discarded – undo
85 85
     {
86 86
         $groupModel=new GroupModel();
87 87
         $basic_info=$groupModel->details($gcode);
88
-        if(empty($basic_info)) return Redirect::route('group.index');
88
+        if (empty($basic_info)) return Redirect::route('group.index');
89 89
         return view('group.settings.danger', [
90 90
             'page_title'=>"Group Setting danger",
91 91
             'site_title'=>config("app.name"),
@@ -104,7 +104,7 @@  discard block
 block discarded – undo
104 104
         $groupModel=new GroupModel();
105 105
         $contestModel=new ContestModel();
106 106
         $basic_info=$groupModel->details($gcode);
107
-        if(empty($basic_info)) return Redirect::route('group.index');
107
+        if (empty($basic_info)) return Redirect::route('group.index');
108 108
         $clearance=$groupModel->judgeClearance($basic_info["gid"], Auth::user()->id);
109 109
         $member_list=$groupModel->userList($basic_info["gid"]);
110 110
         $group_notice=$groupModel->detailNotice($gcode);
@@ -124,7 +124,7 @@  discard block
 block discarded – undo
124 124
         $groupModel=new GroupModel();
125 125
         $contestModel=new ContestModel();
126 126
         $basic_info=$groupModel->details($gcode);
127
-        if(empty($basic_info)) return Redirect::route('group.index');
127
+        if (empty($basic_info)) return Redirect::route('group.index');
128 128
         $clearance=$groupModel->judgeClearance($basic_info["gid"], Auth::user()->id);
129 129
         $contest_list=$contestModel->listForSetting($basic_info["gid"]);
130 130
         $member_list=$groupModel->userList($basic_info["gid"]);
Please login to merge, or discard this patch.
Braces   +12 added lines, -4 removed lines patch added patch discarded remove patch
@@ -43,7 +43,9 @@  discard block
 block discarded – undo
43 43
     {
44 44
         $groupModel=new GroupModel();
45 45
         $basic_info=$groupModel->details($gcode);
46
-        if(empty($basic_info)) return Redirect::route('group.index');
46
+        if(empty($basic_info)) {
47
+            return Redirect::route('group.index');
48
+        }
47 49
         $clearance=$groupModel->judgeClearance($basic_info["gid"], Auth::user()->id);
48 50
         $member_list=$groupModel->userList($basic_info["gid"]);
49 51
         return view('group.settings.general', [
@@ -85,7 +87,9 @@  discard block
 block discarded – undo
85 87
     {
86 88
         $groupModel=new GroupModel();
87 89
         $basic_info=$groupModel->details($gcode);
88
-        if(empty($basic_info)) return Redirect::route('group.index');
90
+        if(empty($basic_info)) {
91
+            return Redirect::route('group.index');
92
+        }
89 93
         return view('group.settings.danger', [
90 94
             'page_title'=>"Group Setting danger",
91 95
             'site_title'=>config("app.name"),
@@ -104,7 +108,9 @@  discard block
 block discarded – undo
104 108
         $groupModel=new GroupModel();
105 109
         $contestModel=new ContestModel();
106 110
         $basic_info=$groupModel->details($gcode);
107
-        if(empty($basic_info)) return Redirect::route('group.index');
111
+        if(empty($basic_info)) {
112
+            return Redirect::route('group.index');
113
+        }
108 114
         $clearance=$groupModel->judgeClearance($basic_info["gid"], Auth::user()->id);
109 115
         $member_list=$groupModel->userList($basic_info["gid"]);
110 116
         $group_notice=$groupModel->detailNotice($gcode);
@@ -124,7 +130,9 @@  discard block
 block discarded – undo
124 130
         $groupModel=new GroupModel();
125 131
         $contestModel=new ContestModel();
126 132
         $basic_info=$groupModel->details($gcode);
127
-        if(empty($basic_info)) return Redirect::route('group.index');
133
+        if(empty($basic_info)) {
134
+            return Redirect::route('group.index');
135
+        }
128 136
         $clearance=$groupModel->judgeClearance($basic_info["gid"], Auth::user()->id);
129 137
         $contest_list=$contestModel->listForSetting($basic_info["gid"]);
130 138
         $member_list=$groupModel->userList($basic_info["gid"]);
Please login to merge, or discard this patch.
app/Http/Controllers/Ajax/GroupManageController.php 2 patches
Braces   +9 added lines, -3 removed lines patch added patch discarded remove patch
@@ -244,11 +244,17 @@
 block discarded – undo
244 244
 
245 245
         $groupModel=new GroupModel();
246 246
         $is_user=$groupModel->isUser($all_data["email"]);
247
-        if(!$is_user) return ResponseModel::err(2006);
247
+        if(!$is_user) {
248
+            return ResponseModel::err(2006);
249
+        }
248 250
         $clearance=$groupModel->judgeClearance($all_data["gid"], Auth::user()->id);
249
-        if($clearance<2) return ResponseModel::err(7002);
251
+        if($clearance<2) {
252
+            return ResponseModel::err(7002);
253
+        }
250 254
         $targetClearance=$groupModel->judgeEmailClearance($all_data["gid"], $all_data["email"]);
251
-        if($targetClearance!=-3) return ResponseModel::err(7003);
255
+        if($targetClearance!=-3) {
256
+            return ResponseModel::err(7003);
257
+        }
252 258
         $groupModel->inviteMember($all_data["gid"], $all_data["email"]);
253 259
         return ResponseModel::success(200);
254 260
     }
Please login to merge, or discard this patch.
Spacing   +18 added lines, -18 removed lines patch added patch discarded remove patch
@@ -36,7 +36,7 @@  discard block
 block discarded – undo
36 36
 
37 37
         $all_data=$request->all();
38 38
 
39
-        if(($all_data['public'] ?? 0) && ($all_data['practice'] ?? 0)){
39
+        if (($all_data['public'] ?? 0) && ($all_data['practice'] ?? 0)) {
40 40
             return ResponseModel::err(4007);
41 41
         }
42 42
 
@@ -67,7 +67,7 @@  discard block
 block discarded – undo
67 67
             return ResponseModel::err(1003);
68 68
         }
69 69
 
70
-        $cid = $contestModel->arrangeContest($all_data["gid"], [
70
+        $cid=$contestModel->arrangeContest($all_data["gid"], [
71 71
             "assign_uid"=>Auth::user()->id,
72 72
             "name"=>$all_data["name"],
73 73
             "description"=>$all_data["description"],
@@ -77,7 +77,7 @@  discard block
 block discarded – undo
77 77
             "public"=>$all_data["public"] ?? 0,
78 78
         ], $problemSet);
79 79
 
80
-        return ResponseModel::success(200,'Successful!',$cid);
80
+        return ResponseModel::success(200, 'Successful!', $cid);
81 81
     }
82 82
 
83 83
     public function changeGroupName(Request $request)
@@ -91,7 +91,7 @@  discard block
 block discarded – undo
91 91
 
92 92
         $groupModel=new GroupModel();
93 93
         $clearance=$groupModel->judgeClearance($all_data["gid"], Auth::user()->id);
94
-        if ($clearance < 2){
94
+        if ($clearance<2) {
95 95
             return ResponseModel::err(2001);
96 96
         }
97 97
 
@@ -110,11 +110,11 @@  discard block
 block discarded – undo
110 110
 
111 111
         $groupModel=new GroupModel();
112 112
         $clearance=$groupModel->judgeClearance($all_data["gid"], Auth::user()->id);
113
-        if ($clearance < 2){
113
+        if ($clearance<2) {
114 114
             return ResponseModel::err(2001);
115 115
         }
116 116
 
117
-        if ($all_data["join_policy"] < 1 || $all_data["join_policy"] > 3){
117
+        if ($all_data["join_policy"]<1 || $all_data["join_policy"]>3) {
118 118
             return ResponseModel::err(1007);
119 119
         }
120 120
 
@@ -128,7 +128,7 @@  discard block
 block discarded – undo
128 128
             'gid' => 'required|integer',
129 129
         ]);
130 130
 
131
-        $all_data = $request->all();
131
+        $all_data=$request->all();
132 132
 
133 133
         if (!empty($request->file('img')) && $request->file('img')->isValid()) {
134 134
             $extension=$request->file('img')->extension();
@@ -140,7 +140,7 @@  discard block
 block discarded – undo
140 140
 
141 141
         $groupModel=new GroupModel();
142 142
         $clearance=$groupModel->judgeClearance($all_data["gid"], Auth::user()->id);
143
-        if ($clearance < 2){
143
+        if ($clearance<2) {
144 144
             return ResponseModel::err(2001);
145 145
         }
146 146
 
@@ -178,18 +178,18 @@  discard block
 block discarded – undo
178 178
         $clearance=$groupModel->judgeClearance($all_data["gid"], Auth::user()->id);
179 179
         $target_clearance=$groupModel->judgeClearance($all_data["gid"], $all_data['uid']);
180 180
 
181
-        if($target_clearance == -3){
181
+        if ($target_clearance==-3) {
182 182
             return ResponseModel::err(7004);
183 183
         }
184 184
 
185
-        if($target_clearance >= $clearance || $clearance < 2 || $all_data['permission'] >= $clearance){
185
+        if ($target_clearance>=$clearance || $clearance<2 || $all_data['permission']>=$clearance) {
186 186
             return ResponseModel::err(2001);
187 187
         }
188 188
 
189 189
         $groupModel->changeClearance($all_data['uid'], $all_data["gid"], $all_data['permission']);
190 190
 
191
-        $result_info = $groupModel->userProfile($all_data['uid'],$all_data["gid"]);
192
-        return ResponseModel::success(200,null,$result_info);
191
+        $result_info=$groupModel->userProfile($all_data['uid'], $all_data["gid"]);
192
+        return ResponseModel::success(200, null, $result_info);
193 193
     }
194 194
 
195 195
     public function approveMember(Request $request)
@@ -205,7 +205,7 @@  discard block
 block discarded – undo
205 205
         $clearance=$groupModel->judgeClearance($all_data["gid"], Auth::user()->id);
206 206
         $targetClearance=$groupModel->judgeClearance($all_data["gid"], $all_data["uid"]);
207 207
         if ($clearance>1) {
208
-            if($targetClearance!=0) {
208
+            if ($targetClearance!=0) {
209 209
                 return ResponseModel::err(7003);
210 210
             }
211 211
             $groupModel->changeClearance($all_data["uid"], $all_data["gid"], 1);
@@ -226,7 +226,7 @@  discard block
 block discarded – undo
226 226
         $groupModel=new GroupModel();
227 227
         $clearance=$groupModel->judgeClearance($all_data["gid"], Auth::user()->id);
228 228
         $targetClearance=$groupModel->judgeClearance($all_data["gid"], $all_data["uid"]);
229
-        if ($clearance <= 1 || $clearance <= $targetClearance){
229
+        if ($clearance<=1 || $clearance<=$targetClearance) {
230 230
             return ResponseModel::err(7002);
231 231
         }
232 232
 
@@ -246,11 +246,11 @@  discard block
 block discarded – undo
246 246
 
247 247
         $groupModel=new GroupModel();
248 248
         $is_user=$groupModel->isUser($all_data["email"]);
249
-        if(!$is_user) return ResponseModel::err(2006);
249
+        if (!$is_user) return ResponseModel::err(2006);
250 250
         $clearance=$groupModel->judgeClearance($all_data["gid"], Auth::user()->id);
251
-        if($clearance<2) return ResponseModel::err(7002);
251
+        if ($clearance<2) return ResponseModel::err(7002);
252 252
         $targetClearance=$groupModel->judgeEmailClearance($all_data["gid"], $all_data["email"]);
253
-        if($targetClearance!=-3) return ResponseModel::err(7003);
253
+        if ($targetClearance!=-3) return ResponseModel::err(7003);
254 254
         $groupModel->inviteMember($all_data["gid"], $all_data["email"]);
255 255
         return ResponseModel::success(200);
256 256
     }
@@ -287,7 +287,7 @@  discard block
 block discarded – undo
287 287
 
288 288
         $groupModel=new GroupModel();
289 289
         $clearance=$groupModel->judgeClearance($all_data["gid"], Auth::user()->id);
290
-        if ($clearance < 2){
290
+        if ($clearance<2) {
291 291
             return ResponseModel::err(2001);
292 292
         }
293 293
         $groupModel->createNotice($all_data["gid"], Auth::user()->id, $all_data["title"], $all_data["content"]);
Please login to merge, or discard this patch.
app/Http/Controllers/Ajax/GroupController.php 2 patches
Braces   +6 added lines, -2 removed lines patch added patch discarded remove patch
@@ -69,9 +69,13 @@
 block discarded – undo
69 69
         $all_data=$request->all();
70 70
 
71 71
         $groupModel=new GroupModel();
72
-        if($all_data["gcode"]=="create") return ResponseModel::err(7005);
72
+        if($all_data["gcode"]=="create") {
73
+            return ResponseModel::err(7005);
74
+        }
73 75
         $is_group=$groupModel->isGroup($all_data["gcode"]);
74
-        if($is_group) return ResponseModel::err(7006);
76
+        if($is_group) {
77
+            return ResponseModel::err(7006);
78
+        }
75 79
 
76 80
         $allow_extension=['jpg', 'png', 'jpeg', 'gif', 'bmp'];
77 81
         if (!empty($request->file('img')) && $request->file('img')->isValid()) {
Please login to merge, or discard this patch.
Spacing   +10 added lines, -10 removed lines patch added patch discarded remove patch
@@ -69,9 +69,9 @@  discard block
 block discarded – undo
69 69
         $all_data=$request->all();
70 70
 
71 71
         $groupModel=new GroupModel();
72
-        if($all_data["gcode"]=="create") return ResponseModel::err(7005);
72
+        if ($all_data["gcode"]=="create") return ResponseModel::err(7005);
73 73
         $is_group=$groupModel->isGroup($all_data["gcode"]);
74
-        if($is_group) return ResponseModel::err(7006);
74
+        if ($is_group) return ResponseModel::err(7006);
75 75
 
76 76
         $allow_extension=['jpg', 'png', 'jpeg', 'gif', 'bmp'];
77 77
         if (!empty($request->file('img')) && $request->file('img')->isValid()) {
@@ -100,20 +100,20 @@  discard block
 block discarded – undo
100 100
 
101 101
         $groupModel=new GroupModel();
102 102
         $clearance=$groupModel->judgeClearance($all_data["gid"], Auth::user()->id);
103
-        if ($clearance > 0) {
104
-            switch($all_data['mode']){
103
+        if ($clearance>0) {
104
+            switch ($all_data['mode']) {
105 105
                 case 'contest':
106
-                    $ret = $groupModel->groupMemberPracticeContestStat($all_data["gid"]);
106
+                    $ret=$groupModel->groupMemberPracticeContestStat($all_data["gid"]);
107 107
                 break;
108 108
                 case 'tag':
109
-                    $ret = $groupModel->groupMemberPracticeTagStat($all_data["gid"]);
109
+                    $ret=$groupModel->groupMemberPracticeTagStat($all_data["gid"]);
110 110
                 break;
111 111
                 default:
112 112
                     return ResponseModel::err(1007);
113 113
                 break;
114 114
             }
115 115
 
116
-            return ResponseModel::success(200,null,$ret);
116
+            return ResponseModel::success(200, null, $ret);
117 117
         }
118 118
         return ResponseModel::err(7002);
119 119
     }
@@ -129,10 +129,10 @@  discard block
 block discarded – undo
129 129
 
130 130
         $groupModel=new GroupModel();
131 131
         $clearance=$groupModel->judgeClearance($all_data["gid"], Auth::user()->id);
132
-        if($clearance <= 0){
132
+        if ($clearance<=0) {
133 133
             return ResponseModel::err(7002);
134 134
         }
135
-        $ret = $groupModel->getEloChangeLog($all_data['gid'],$all_data['uid']);
136
-        return ResponseModel::success(200,null,$ret);
135
+        $ret=$groupModel->getEloChangeLog($all_data['gid'], $all_data['uid']);
136
+        return ResponseModel::success(200, null, $ret);
137 137
     }
138 138
 }
Please login to merge, or discard this patch.
app/Http/Controllers/Ajax/GroupAdminController.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -48,11 +48,11 @@  discard block
 block discarded – undo
48 48
 
49 49
         $groupModel=new GroupModel();
50 50
         $clearance=$groupModel->judgeClearance($all_data["gid"], Auth::user()->id);
51
-        if ($clearance < 2) {
51
+        if ($clearance<2) {
52 52
             return ResponseModel::err(7002);
53 53
         }
54
-        $tags = $groupModel->problemTags($all_data['gid'],$all_data['pid']);
55
-        if(in_array($all_data['tag'],$tags)){
54
+        $tags=$groupModel->problemTags($all_data['gid'], $all_data['pid']);
55
+        if (in_array($all_data['tag'], $tags)) {
56 56
             return ResponseModel::err(7007);
57 57
         }
58 58
 
@@ -84,9 +84,9 @@  discard block
 block discarded – undo
84 84
         $request->validate([
85 85
             'gid' => 'required|string',
86 86
         ]);
87
-        $gid = $request->input('gid');
87
+        $gid=$request->input('gid');
88 88
         $groupModel=new GroupModel();
89
-        if($groupModel->judgeClearance($gid,Auth::user()->id) < 2) {
89
+        if ($groupModel->judgeClearance($gid, Auth::user()->id)<2) {
90 90
             return ResponseModel::err(2001);
91 91
         }
92 92
         $groupModel->refreshElo($gid);
Please login to merge, or discard this patch.