App\Http\Controllers\MessageController

Complexity

Total Complexity

4

Size/Duplication

Total Lines	25
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

<?php
class MessageController extends Controller
{
    public function index()
    {
        $uid = Auth::user()->id;
        $messages = MessageModel::list($uid);
        return view('message.index', [
            'page_title'=>"Message",
            'site_title'=>config("app.name"),
            'navigation'=>"Home",
            'messages'=>$messages,
        ]);
    }

    public function detail($id)
    {
        $message = MessageModel::read($id);
        if(empty($message || $message->receiver != Auth::user()->id)){

The expression $message of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

            return Redirect::route('message.index');
        }
        return view('message.detail', [
            'page_title'=>"Message",
            'site_title'=>config("app.name"),
            'navigation'=>"Home",
            'message' => $message
        ]);