App\Babel\Crawl\CrawlerBase::_cacheImage()

Complexity

Conditions	11
Paths	3

Size

Total Lines	50
Code Lines	40

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
    private function _cacheImage($data)
    {
        if(!isset($data["ori"]) || !isset($data["path"]) || !isset($data["baseurl"]) || !isset($data["space_deli"]) || !isset($data["cookie"])){
            throw new Exception("data is not completely exist in cacheImage");

The type App\Babel\Crawl\Exception was not found. Did you mean Exception? If so, make sure to prefix the type with \.

        }
        $ori = $data["ori"];
        $path = $data["path"];
        $baseurl = $data["baseurl"];
        $space_deli = $data["space_deli"];
        $cookie = $data["cookie"];

        $para["path"]=$path;

$para was never initialized. Although not strictly required by PHP, it is generally a good practice to add $para = array(); before regardless.

        $para["base"]=$baseurl;
        $para["trans"]=!$space_deli;
        $para["cookie"]=$cookie;

        if ($space_deli) {
            $reg="/< *im[a]?g[^>]*src *= *[\"\\']?([^\"\\' >]*)[^>]*>/si";
        } else {
            $reg="/< *im[a]?g[^>]*src *= *[\"\\']?([^\"\\'>]*)[^>]*>/si";
        }

        return preg_replace_callback($reg, function($matches) use ($para) {
            global $config;
            $url=trim($matches[1]);
            if (stripos($url, "http://")===false && stripos($url, "https://")===false) {
                if ($para["trans"]) {
                    $url=str_replace(" ", "%20", $url);
                }
                $url=$para["base"].$url;
            }
            $name=basename($url);
            $name="images/".strtr($name, ":", "_");
            $result=str_replace(trim($matches[1]), "online_Judges/spoj/images/".strtr(basename($url), ":", "_"), $matches[0]);
            $ch=curl_init();
            curl_setopt($ch, CURLOPT_URL, $url);

It seems like $ch can also be of type false; however, parameter $ch of curl_setopt() does only seem to accept resource, maybe add an additional type check?

            curl_setopt($ch, CURLOPT_SSL_VERIFYPEER, false);
            curl_setopt($ch, CURLOPT_FOLLOWLOCATION, true);
            if ($para["cookie"]!="") {
                curl_setopt($ch, CURLOPT_COOKIEFILE, $para["cookie"]);
            }
            curl_setopt($ch, CURLOPT_HEADER, 0);
            curl_setopt($ch, CURLOPT_RETURNTRANSFER, true);
            $content=curl_exec($ch);

It seems like $ch can also be of type false; however, parameter $ch of curl_exec() does only seem to accept resource, maybe add an additional type check?

            curl_close($ch);

It seems like $ch can also be of type false; however, parameter $ch of curl_close() does only seem to accept resource, maybe add an additional type check?

            $fp=fopen($name, "wb");
            fwrite($fp, $content);

It seems like $fp can also be of type false; however, parameter $handle of fwrite() does only seem to accept resource, maybe add an additional type check?

            fclose($fp);

It seems like $fp can also be of type false; however, parameter $handle of fclose() does only seem to accept resource, maybe add an additional type check?

            return $result;
        }, $ori);
    }