ZsgsDesign / NOJ

app/Http/Controllers/ContestController.php

Braces +4 added lines, -2 removed lines

@@ -187,7 +187,9 @@ 
         }
 
         $editor_left_width = $accountModel->getExtra(Auth::user()->id, 'editor_left_width');
-        if(empty($editor_left_width)) $editor_left_width='40';
+        if(empty($editor_left_width)) {
+            $editor_left_width='40';
+        }
 
         return view('contest.board.editor', [
             'page_title'=>"Problem Detail",
@@ -383,7 +385,7 @@ 
         $account=$contestModel->getContestAccount($cid);
         if($account==null){
             return ;
-        }else{
+        } else{
             $AccountExport=new AccountExport($account);
             $filename="ContestAccount$cid";
             return Excel::download($AccountExport, $filename.'.xlsx');

Spacing +12 added lines, -12 removed lines

@@ -34,7 +34,7 @@ 
         $filter["rated"]=isset($all_data["rated"]) ? $all_data["rated"] : null;
         $filter["anticheated"]=isset($all_data["anticheated"]) ? $all_data["anticheated"] : null;
         $filter["practice"]=isset($all_data["practice"]) ? $all_data["practice"] : null;
-        $return_list=$contestModel->list($filter,Auth::check()?Auth::user()->id:0);
+        $return_list=$contestModel->list($filter, Auth::check() ?Auth::user()->id : 0);
         $featured=$contestModel->featured();
         if (is_null($return_list)) {
             if (isset($all_data["page"]) && $all_data["page"]>1) {
@@ -188,8 +188,8 @@ 
             ];
         }
 
-        $editor_left_width = $accountModel->getExtra(Auth::user()->id, 'editor_left_width');
-        if(empty($editor_left_width)) $editor_left_width='40';
+        $editor_left_width=$accountModel->getExtra(Auth::user()->id, 'editor_left_width');
+        if (empty($editor_left_width)) $editor_left_width='40';
 
         return view('contest.board.editor', [
             'page_title'=>"Problem Detail",
@@ -351,7 +351,7 @@ 
         $contestModel=new ContestModel();
         $verified=$contestModel->isVerified($cid);
         $clearance=$contestModel->judgeClearance($cid, Auth::user()->id);
-        if ($clearance <= 2) {
+        if ($clearance<=2) {
             return Redirect::route('contest_detail', ['cid' => $cid]);
         }
         $contest_name=$contestModel->contestName($cid);
@@ -379,20 +379,20 @@ 
     {
         $contestModel=new ContestModel();
         $clearance=$contestModel->judgeClearance($cid, Auth::user()->id);
-        if ($clearance <= 2) {
+        if ($clearance<=2) {
             return Redirect::route('contest_detail', ['cid' => $cid]);
         }
         $account=$contestModel->getContestAccount($cid);
-        if($account==null){
-            return ;
-        }else{
+        if ($account==null) {
+            return;
+        } else {
             $AccountExport=new AccountExport($account);
             $filename="ContestAccount$cid";
             return Excel::download($AccountExport, $filename.'.xlsx');
         }
     }
 
-    public function analysis($cid){
+    public function analysis($cid) {
         $contestModel=new ContestModel();
         $clearance=$contestModel->judgeClearance($cid, Auth::user()->id);
         if (!$clearance) {
@@ -413,17 +413,17 @@ 
         ]);
     }
 
-    public function refreshContestRank($cid){
+    public function refreshContestRank($cid) {
         $contestModel=new ContestModel();
         $clearance=$contestModel->judgeClearance($cid, Auth::user()->id);
-        if ($clearance <= 2) {
+        if ($clearance<=2) {
             return Redirect::route('contest.detail', ['cid' => $cid]);
         }
         $contestRankRaw=$contestModel->contestRankCache($cid);
         Cache::tags(['contest', 'rank'])->put($cid, $contestRankRaw);
         Cache::tags(['contest', 'rank'])->put("contestAdmin$cid", $contestRankRaw);
         $end_time=strtotime(DB::table("contest")->where(["cid"=>$cid])->select("end_time")->first()["end_time"]);
-        if(time() > $end_time){
+        if (time()>$end_time) {
             $contestModel->storeContestRankInMySQL($cid, $contestRankRaw);
         }
         return Redirect::route('contest.rank', ['cid' => $cid]);

app/Http/Controllers/AccountController.php

Spacing +6 added lines, -6 removed lines

@@ -28,8 +28,8 @@ 
         $accountModel=new AccountModel();
         $info=$accountModel->detail(Auth::user()->id);
         $feed=$accountModel->feed(Auth::user()->id);
-        $extraInfo = $accountModel->getExtra(Auth::user()->id, ['gender', 'contanct', 'school', 'country', 'location'],100);
-        $socialiteInfo = $accountModel->getSocialiteInfo(Auth::user()->id,100);
+        $extraInfo=$accountModel->getExtra(Auth::user()->id, ['gender', 'contanct', 'school', 'country', 'location'], 100);
+        $socialiteInfo=$accountModel->getSocialiteInfo(Auth::user()->id, 100);
         return view("account.dashboard", [
             'page_title'=>"DashBoard",
             'site_title'=>config("app.name"),
@@ -52,11 +52,11 @@ 
     {
         $accountModel=new AccountModel();
         $info=$accountModel->detail(Auth::user()->id);
-        if(!empty(session('last_email_send'))){
-            $email_cooldown = 300 - (time() - session('last_email_send'));
+        if (!empty(session('last_email_send'))) {
+            $email_cooldown=300-(time()-session('last_email_send'));
         }
-        $extraInfo = $accountModel->getExtra(Auth::user()->id, ['gender', 'contanct', 'school', 'country', 'location'],100);
-        $socialiteInfo = $accountModel->getSocialiteInfo(Auth::user()->id,100);
+        $extraInfo=$accountModel->getExtra(Auth::user()->id, ['gender', 'contanct', 'school', 'country', 'location'], 100);
+        $socialiteInfo=$accountModel->getSocialiteInfo(Auth::user()->id, 100);
         return view("account.dashboard", [
             'page_title'=>"Settings",
             'site_title'=>config("app.name"),

app/Http/Middleware/Privileged.php

Spacing +4 added lines, -4 removed lines

@@ -18,16 +18,16 @@
     public function handle($request, Closure $next)
     {
         if (Auth::check()) {
-            if(isset($request->gcode)){
+            if (isset($request->gcode)) {
                 //group privilege
                 $groupModel=new GroupModel();
-                if($groupModel->judgeClearance($groupModel->gid($request->gcode), Auth::user()->id)>=2){
+                if ($groupModel->judgeClearance($groupModel->gid($request->gcode), Auth::user()->id)>=2) {
                     return $next($request);
                 }
-            }elseif(isset($request->cid)) {
+            }elseif (isset($request->cid)) {
                 //contest privilege
                 $contestModel=new ContestModel();
-                if($contestModel->judgeClearance($request->cid, Auth::user()->id)==3){
+                if ($contestModel->judgeClearance($request->cid, Auth::user()->id)==3) {
                     return $next($request);
                 }
             }

Braces +1 added lines, -1 removed lines

@@ -24,7 +24,7 @@
                 if($groupModel->judgeClearance($groupModel->gid($request->gcode), Auth::user()->id)>=2){
                     return $next($request);
                 }
-            }elseif(isset($request->cid)) {
+            } elseif(isset($request->cid)) {
                 //contest privilege
                 $contestModel=new ContestModel();
                 if($contestModel->judgeClearance($request->cid, Auth::user()->id)==3){

app/Console/Commands/Babel/Crawl.php

Spacing +6 added lines, -6 removed lines

@@ -14,14 +14,14 @@ 
      *
      * @var string
      */
-    protected $signature = 'babel:crawl {extension : The package name of the extension} {--action=crawl_problem : The action of the Crawler} {--con=all : The target problemset of the Crawler} {--cached : Whether cached or not}';
+    protected $signature='babel:crawl {extension : The package name of the extension} {--action=crawl_problem : The action of the Crawler} {--con=all : The target problemset of the Crawler} {--cached : Whether cached or not}';
 
     /**
      * The console command description.
      *
      * @var string
      */
-    protected $description = 'Crawl problems for a given Babel Extension to NOJ';
+    protected $description='Crawl problems for a given Babel Extension to NOJ';
 
     /**
      * Create a new command instance.
@@ -40,10 +40,10 @@ 
      */
     public function handle()
     {
-        $extension = $this->argument('extension');
-        $action = $this->option('action');
-        $con = $this->option('con');
-        $cached = $this->option('cached');
+        $extension=$this->argument('extension');
+        $action=$this->option('action');
+        $con=$this->option('con');
+        $cached=$this->option('cached');
         $babel=new Babel();
         $babel->crawl([
             "name" => $extension,

app/Models/AnnouncementModel.php

Spacing +1 added lines, -1 removed lines

@@ -17,7 +17,7 @@
 
     public function fetch()
     {
-        $list=DB::table($this->table)->orderBy('post_date','desc')->get()->all();
+        $list=DB::table($this->table)->orderBy('post_date', 'desc')->get()->all();
         if (empty($list)) {
             return [];
         }

app/Models/RankModel.php

Spacing +24 added lines, -24 removed lines

@@ -7,7 +7,7 @@ 
 use Illuminate\Support\Facades\DB;
 use Illuminate\Support\Arr;
 use App\Models\Rating\RatingCalculator;
-use Cache,Redis;
+use Cache, Redis;
 
 class RankModel extends Model
 {
@@ -65,28 +65,28 @@ 
 
     public static function getColor($rankTitle)
     {
-        if(is_null($rankTitle)) return "";
+        if (is_null($rankTitle)) return "";
         return self::$casualRanking[$rankTitle];
     }
 
     public static function getProfessionalColor($rankTitle)
     {
-        if(is_null($rankTitle)) return self::$professionalRanking["None"];
+        if (is_null($rankTitle)) return self::$professionalRanking["None"];
         return self::$professionalRanking[$rankTitle];
     }
 
     public function list($num)
     {
         $rankList=Cache::tags(['rank'])->get('general');
-        if($rankList==null) $rankList=[];
-        $rankList=array_slice($rankList,0,$num);
-        $userInfoRaw=DB::table("users")->select("id as uid","avatar","name")->get()->all();
+        if ($rankList==null) $rankList=[];
+        $rankList=array_slice($rankList, 0, $num);
+        $userInfoRaw=DB::table("users")->select("id as uid", "avatar", "name")->get()->all();
         $userInfo=[];
-        foreach($userInfoRaw as $u){
+        foreach ($userInfoRaw as $u) {
             $userInfo[$u["uid"]]=$u;
         }
-        foreach($rankList as &$r){
-            $r["details"]=isset($userInfo[$r["uid"]])?$userInfo[$r["uid"]]:[];
+        foreach ($rankList as &$r) {
+            $r["details"]=isset($userInfo[$r["uid"]]) ? $userInfo[$r["uid"]] : [];
         }
         // var_dump($rankList); exit();
         return $rankList;
@@ -109,8 +109,8 @@ 
                     $rankSolved=$rankItem["totValue"];
                 }
                 $rankTitle=$this->getRankTitle($rankValue);
-                Cache::tags(['rank',$rankItem["uid"]])->put("rank", $rankValue, 86400);
-                Cache::tags(['rank',$rankItem["uid"]])->put("title", $rankTitle, 86400);
+                Cache::tags(['rank', $rankItem["uid"]])->put("rank", $rankValue, 86400);
+                Cache::tags(['rank', $rankItem["uid"]])->put("title", $rankTitle, 86400);
                 $rankListCached[]=[
                     "uid"=>$rankItem["uid"],
                     "rank"=>$rankValue,
@@ -127,14 +127,14 @@ 
 
     public function getProfessionalRanking()
     {
-        $professionalRankList = [];
-        $verifiedUsers = DB::table("users")->select("professional_rate","id as uid","avatar","name")->get()->all();
-        $rankIter = 0;
-        foreach($verifiedUsers as $user) {
-            $rankVal = $user['professional_rate'];
-            $rankTitle = self::getProfessionalTitle($rankVal);
-            $titleColor = self::getProfessionalColor($rankTitle);
-            $professionalRankList[$rankIter++] = [
+        $professionalRankList=[];
+        $verifiedUsers=DB::table("users")->select("professional_rate", "id as uid", "avatar", "name")->get()->all();
+        $rankIter=0;
+        foreach ($verifiedUsers as $user) {
+            $rankVal=$user['professional_rate'];
+            $rankTitle=self::getProfessionalTitle($rankVal);
+            $titleColor=self::getProfessionalColor($rankTitle);
+            $professionalRankList[$rankIter++]=[
                 "name"=>$user["name"],
                 "uid"=>$user["uid"],
                 "avatar"=>$user["avatar"],
@@ -156,7 +156,7 @@ 
                 $tot+=$c;
             }
             foreach ($this->casualRankingPer as &$c) {
-                $c=round($c*$totUsers/$tot);
+                $c=round($c * $totUsers / $tot);
                 $cur+=$c;
                 $c=$cur;
             }
@@ -167,16 +167,16 @@ 
 
     public function getRankTitle($rankVal)
     {
-        foreach($this->casualRankingPer as $title=>$c){
-            if($rankVal<=$c) return $title;
+        foreach ($this->casualRankingPer as $title=>$c) {
+            if ($rankVal<=$c) return $title;
         }
         return Arr::last($this->casualRankingPer);
     }
 
     public static function getProfessionalTitle($rankVal)
     {
-        foreach(self::$professionalRankingPer as $title=>$point) {
-            if($rankVal >= $point) return $title;
+        foreach (self::$professionalRankingPer as $title=>$point) {
+            if ($rankVal>=$point) return $title;
         }
         return Arr::last(self::$professionalRankingPer);
     }

Braces +15 added lines, -5 removed lines

@@ -65,20 +65,26 @@ 
 
     public static function getColor($rankTitle)
     {
-        if(is_null($rankTitle)) return "";
+        if(is_null($rankTitle)) {
+            return "";
+        }
         return self::$casualRanking[$rankTitle];
     }
 
     public static function getProfessionalColor($rankTitle)
     {
-        if(is_null($rankTitle)) return self::$professionalRanking["None"];
+        if(is_null($rankTitle)) {
+            return self::$professionalRanking["None"];
+        }
         return self::$professionalRanking[$rankTitle];
     }
 
     public function list($num)
     {
         $rankList=Cache::tags(['rank'])->get('general');
-        if($rankList==null) $rankList=[];
+        if($rankList==null) {
+            $rankList=[];
+        }
         $rankList=array_slice($rankList,0,$num);
         $userInfoRaw=DB::table("users")->select("id as uid","avatar","name")->get()->all();
         $userInfo=[];
@@ -168,7 +174,9 @@ 
     public function getRankTitle($rankVal)
     {
         foreach($this->casualRankingPer as $title=>$c){
-            if($rankVal<=$c) return $title;
+            if($rankVal<=$c) {
+                return $title;
+            }
         }
         return Arr::last($this->casualRankingPer);
     }
@@ -176,7 +184,9 @@ 
     public static function getProfessionalTitle($rankVal)
     {
         foreach(self::$professionalRankingPer as $title=>$point) {
-            if($rankVal >= $point) return $title;
+            if($rankVal >= $point) {
+                return $title;
+            }
         }
         return Arr::last(self::$professionalRankingPer);
     }

app/Console/Commands/Babel/SyncContest.php

Spacing +8 added lines, -8 removed lines

@@ -14,14 +14,14 @@ 
      *
      * @var string
      */
-    protected $signature = 'babel:sync {extension : The package name of the extension} {--vcid= : The target contest of the Crawler} {--gid=1 : The holding group}';
+    protected $signature='babel:sync {extension : The package name of the extension} {--vcid= : The target contest of the Crawler} {--gid=1 : The holding group}';
 
     /**
      * The console command description.
      *
      * @var string
      */
-    protected $description = 'Crawl contests for a given Babel Extension to NOJ';
+    protected $description='Crawl contests for a given Babel Extension to NOJ';
 
     /**
      * Create a new command instance.
@@ -40,16 +40,16 @@ 
      */
     public function handle()
     {
-        $extension = $this->argument('extension');
-        $vcid = $this->option('vcid');
-        $gid = $this->option('gid');
-        $className = "App\\Babel\\Extension\\$extension\\Synchronizer";
-        $all_data = [
+        $extension=$this->argument('extension');
+        $vcid=$this->option('vcid');
+        $gid=$this->option('gid');
+        $className="App\\Babel\\Extension\\$extension\\Synchronizer";
+        $all_data=[
             'oj'=>$extension,
             'vcid'=>$vcid,
             'gid'=>$gid,
         ];
-        $Sync = new $className($all_data);
+        $Sync=new $className($all_data);
         $Sync->crawlContest();
     }
 }

app/Console/Commands/Babel/RefreshRank.php

Spacing +9 added lines, -9 removed lines

@@ -14,14 +14,14 @@ 
      *
      * @var string
      */
-    protected $signature = 'babel:rerank {extension : The package name of the extension} {--vcid= : The target contest of the Crawler} {--gid=1 : The holding group} {--cid= : The NOJ contest}';
+    protected $signature='babel:rerank {extension : The package name of the extension} {--vcid= : The target contest of the Crawler} {--gid=1 : The holding group} {--cid= : The NOJ contest}';
 
     /**
      * The console command description.
      *
      * @var string
      */
-    protected $description = 'Refresh Rank from a remote contest';
+    protected $description='Refresh Rank from a remote contest';
 
     /**
      * Create a new command instance.
@@ -40,18 +40,18 @@ 
      */
     public function handle()
     {
-        $extension = $this->argument('extension');
-        $vcid = $this->option('vcid');
-        $gid = $this->option('gid');
-        $cid = $this->option('cid');
-        $className = "App\\Babel\\Extension\\$extension\\Synchronizer";
-        $all_data = [
+        $extension=$this->argument('extension');
+        $vcid=$this->option('vcid');
+        $gid=$this->option('gid');
+        $cid=$this->option('cid');
+        $className="App\\Babel\\Extension\\$extension\\Synchronizer";
+        $all_data=[
             'oj'=>$extension,
             'vcid'=>$vcid,
             'gid'=>$gid,
             'cid'=>$cid,
         ];
-        $Sync = new $className($all_data);
+        $Sync=new $className($all_data);
         $Sync->crawlRank();
     }
 }

app/Models/GroupModel.php

Braces +11 added lines, -5 removed lines

@@ -114,7 +114,9 @@ 
     public function details($gcode)
     {
         $basic_info=DB::table($this->tableName)->where(["gcode"=>$gcode])->first();
-        if(empty($basic_info)) return [];
+        if(empty($basic_info)) {
+            return [];
+        }
         $basic_info["members"]=$this->countGroupMembers($basic_info["gid"]);
         $basic_info["tags"]=$this->getGroupTags($basic_info["gid"]);
         $basic_info["create_time_foramt"]=date_format(date_create($basic_info["create_time"]), 'M jS, Y');
@@ -162,7 +164,9 @@ 
         foreach ($user_list as &$u) {
             $u["role_parsed"]=$this->role[$u["role"]];
             $u["role_color"]=$this->role_color[$u["role"]];
-            if(is_null($u["sub_group"])) $u["sub_group"]="None";
+            if(is_null($u["sub_group"])) {
+                $u["sub_group"]="None";
+            }
         }
         return $user_list;
     }
@@ -231,7 +235,7 @@ 
             ->where('gid',$gid)
             ->distinct()
             ->get()->all();
-        }else{
+        } else{
             $tags =  DB::table('group_problem_tag')
             ->select('tag')
             ->where('gid', $gid)
@@ -265,7 +269,7 @@ 
         foreach($problems as $key => $value){
             if($contestModel->judgeClearance($value['cid'],$user_id) != 3){
                 unset($problems[$key]);
-            }else{
+            } else{
                 $problems[$key]['tags'] = $this->problemTags($gid,$value['pid']);
             }
         }
@@ -326,7 +330,9 @@ 
     public function judgeEmailClearance($gid, $email)
     {
         $user=DB::table("users")->where(["email"=>$email])->first();
-        if(empty($user)) return -4;
+        if(empty($user)) {
+            return -4;
+        }
         $ret=DB::table("group_member")->where([
             "gid"=>$gid,
             "uid"=>$user["id"],

Spacing +92 added lines, -92 removed lines

@@ -58,10 +58,10 @@ 
         foreach ($trending_groups as &$t) {
             $t["members"]=$this->countGroupMembers($t["gid"]);
         }
-        usort($trending_groups, function ($a, $b) {
+        usort($trending_groups, function($a, $b) {
             return $b["members"]<=>$a["members"];
         });
-        Cache::tags(['group'])->put('trending', array_slice($trending_groups,0,12), 3600*24);
+        Cache::tags(['group'])->put('trending', array_slice($trending_groups, 0, 12), 3600 * 24);
     }
 
     public function userGroups($uid)
@@ -101,13 +101,13 @@ 
 
     public function changeGroupName($gid, $GroupName)
     {
-        return DB::table("group")->where('gid',$gid)->update([
+        return DB::table("group")->where('gid', $gid)->update([
             "name"=>$GroupName
         ]);
     }
 
-    public function changeJoinPolicy($gid, $JoinPolicy){
-        return DB::table("group")->where('gid',$gid)->update([
+    public function changeJoinPolicy($gid, $JoinPolicy) {
+        return DB::table("group")->where('gid', $gid)->update([
             "join_policy"=>$JoinPolicy
         ]);
     }
@@ -115,7 +115,7 @@ 
     public function details($gcode)
     {
         $basic_info=DB::table($this->tableName)->where(["gcode"=>$gcode])->first();
-        if(empty($basic_info)) return [];
+        if (empty($basic_info)) return [];
         $basic_info["members"]=$this->countGroupMembers($basic_info["gid"]);
         $basic_info["tags"]=$this->getGroupTags($basic_info["gid"]);
         $basic_info["create_time_foramt"]=date_format(date_create($basic_info["create_time"]), 'M jS, Y');
@@ -132,10 +132,10 @@ 
     public function userProfile($uid, $gid)
     {
         $info=DB::table("group_member")
-        ->join('users','users.id','=','group_member.uid')
+        ->join('users', 'users.id', '=', 'group_member.uid')
         ->where(["gid"=>$gid, "uid"=>$uid])
         ->where("role", ">", 0)
-        ->select('avatar','describes','email','gid','uid','name','nick_name','professional_rate','role','sub_group')
+        ->select('avatar', 'describes', 'email', 'gid', 'uid', 'name', 'nick_name', 'professional_rate', 'role', 'sub_group')
         ->first();
         if (!empty($info)) {
             $info["role_parsed"]=$this->role[$info["role"]];
@@ -163,7 +163,7 @@ 
         foreach ($user_list as &$u) {
             $u["role_parsed"]=$this->role[$u["role"]];
             $u["role_color"]=$this->role_color[$u["role"]];
-            if(is_null($u["sub_group"])) $u["sub_group"]="None";
+            if (is_null($u["sub_group"])) $u["sub_group"]="None";
         }
         return $user_list;
     }
@@ -224,16 +224,16 @@ 
         ])->where("role", ">", 0)->count();
     }
 
-    public function problemTags($gid,$pid = -1)
+    public function problemTags($gid, $pid=-1)
     {
-        if($pid == -1){
-            $tags =  DB::table('group_problem_tag')
+        if ($pid==-1) {
+            $tags=DB::table('group_problem_tag')
             ->select('tag')
-            ->where('gid',$gid)
+            ->where('gid', $gid)
             ->distinct()
             ->get()->all();
-        }else{
-            $tags =  DB::table('group_problem_tag')
+        } else {
+            $tags=DB::table('group_problem_tag')
             ->select('tag')
             ->where('gid', $gid)
             ->where('pid', $pid)
@@ -241,10 +241,10 @@ 
             ->get()->all();
         }
 
-        $tags_arr = [];
-        if(!empty($tags)){
+        $tags_arr=[];
+        if (!empty($tags)) {
             foreach ($tags as $value) {
-                array_push($tags_arr,$value['tag']);
+                array_push($tags_arr, $value['tag']);
             }
         }
         return $tags_arr;
@@ -252,28 +252,28 @@ 
 
     public function problems($gid)
     {
-        $contestModel = new ContestModel();
-        $problems = DB::table('contest_problem')
-        ->join('contest','contest_problem.cid', '=', 'contest.cid')
-        ->join('problem','contest_problem.pid', '=', 'problem.pid' )
+        $contestModel=new ContestModel();
+        $problems=DB::table('contest_problem')
+        ->join('contest', 'contest_problem.cid', '=', 'contest.cid')
+        ->join('problem', 'contest_problem.pid', '=', 'problem.pid')
         ->select('contest_problem.cid as cid', 'problem.pid as pid', 'pcode', 'title')
-        ->where('contest.gid',$gid)
-        ->where('contest.practice',1)
-        ->orderBy('contest.create_time','desc')
+        ->where('contest.gid', $gid)
+        ->where('contest.practice', 1)
+        ->orderBy('contest.create_time', 'desc')
         ->distinct()
         ->get()->all();
-        $user_id = Auth::user()->id;
-        foreach($problems as $key => $value){
-            if($contestModel->judgeClearance($value['cid'],$user_id) != 3){
+        $user_id=Auth::user()->id;
+        foreach ($problems as $key => $value) {
+            if ($contestModel->judgeClearance($value['cid'], $user_id)!=3) {
                 unset($problems[$key]);
-            }else{
-                $problems[$key]['tags'] = $this->problemTags($gid,$value['pid']);
+            } else {
+                $problems[$key]['tags']=$this->problemTags($gid, $value['pid']);
             }
         }
         return $problems;
     }
 
-    public function problemAddTag($gid,$pid,$tag)
+    public function problemAddTag($gid, $pid, $tag)
     {
         return DB::table("group_problem_tag")->insert([
             "gid"=>$gid,
@@ -282,7 +282,7 @@ 
         ]);
     }
 
-    public function problemRemoveTag($gid,$pid,$tag)
+    public function problemRemoveTag($gid, $pid, $tag)
     {
         return DB::table("group_problem_tag")->where([
             "gid"=>$gid,
@@ -327,7 +327,7 @@ 
     public function judgeEmailClearance($gid, $email)
     {
         $user=DB::table("users")->where(["email"=>$email])->first();
-        if(empty($user)) return -4;
+        if (empty($user)) return -4;
         $ret=DB::table("group_member")->where([
             "gid"=>$gid,
             "uid"=>$user["id"],
@@ -408,20 +408,20 @@ 
 
     public function groupMemberPracticeContestStat($gid)
     {
-        $contestModel = new ContestModel();
+        $contestModel=new ContestModel();
 
-        $allPracticeContest = DB::table('contest')
+        $allPracticeContest=DB::table('contest')
             ->where([
                 'gid' => $gid,
                 'practice' => 1,
             ])
-            ->select('cid','name')
+            ->select('cid', 'name')
             ->get()->all();
-        $user_list = $this->userList($gid);
+        $user_list=$this->userList($gid);
 
-        $memberData = [];
+        $memberData=[];
         foreach ($user_list as $u) {
-            $memberData[$u['uid']] = [
+            $memberData[$u['uid']]=[
                 'name' => $u['name'],
                 'nick_name' => $u['nick_name'],
                 'elo' => $u['ranking'],
@@ -432,24 +432,24 @@ 
             ];
         }
         foreach ($allPracticeContest as $c) {
-            $contestRankRaw = $contestModel->contestRank($c['cid']);
-            foreach($contestRankRaw as $key => $contestRank){
-                if(isset($contestRank['remote']) && $contestRank['remote']){
+            $contestRankRaw=$contestModel->contestRank($c['cid']);
+            foreach ($contestRankRaw as $key => $contestRank) {
+                if (isset($contestRank['remote']) && $contestRank['remote']) {
                     unset($contestRankRaw[$key]);
                 }
             }
-            $contestRank = array_values($contestRankRaw);
-            $problemsCount = DB::table('contest_problem')
-                ->where('cid',$c['cid'])
+            $contestRank=array_values($contestRankRaw);
+            $problemsCount=DB::table('contest_problem')
+                ->where('cid', $c['cid'])
                 ->count();
-            $rank = 0;
+            $rank=0;
             foreach ($contestRank as $cr) {
                 $rank++;
-                if(in_array($cr['uid'],array_keys($memberData))) {
-                    $memberData[$cr['uid']]['solved_all'] += $cr['solved'];
-                    $memberData[$cr['uid']]['problem_all'] += $problemsCount;
-                    $memberData[$cr['uid']]['penalty'] += $cr['penalty'];
-                    $memberData[$cr['uid']]['contest_detial'][$c['cid']] = [
+                if (in_array($cr['uid'], array_keys($memberData))) {
+                    $memberData[$cr['uid']]['solved_all']+=$cr['solved'];
+                    $memberData[$cr['uid']]['problem_all']+=$problemsCount;
+                    $memberData[$cr['uid']]['penalty']+=$cr['penalty'];
+                    $memberData[$cr['uid']]['contest_detial'][$c['cid']]=[
                         'rank' => $rank,
                         'solved' => $cr['solved'],
                         'problems' => $problemsCount,
@@ -458,22 +458,22 @@ 
                 }
             }
         }
-        $new_memberData = [];
+        $new_memberData=[];
         foreach ($memberData as $uid => $data) {
-            $contest_count = 0;
-            $rank_sum = 0;
+            $contest_count=0;
+            $rank_sum=0;
             foreach ($data['contest_detial'] as $cid => $c) {
-                $rank_sum += $c['rank'];
-                $contest_count += 1;
+                $rank_sum+=$c['rank'];
+                $contest_count+=1;
             }
-            $temp = $data;
-            $temp['uid'] = $uid;
-            if($contest_count != 0){
-                $temp['rank_ave'] = $rank_sum/$contest_count;
+            $temp=$data;
+            $temp['uid']=$uid;
+            if ($contest_count!=0) {
+                $temp['rank_ave']=$rank_sum / $contest_count;
             }
-            array_push($new_memberData,$temp);
+            array_push($new_memberData, $temp);
         }
-        $ret = [
+        $ret=[
             'contest_list' => $allPracticeContest,
             'member_data' => $new_memberData
         ];
@@ -482,58 +482,58 @@ 
 
     public function groupMemberPracticeTagStat($gid)
     {
-        $tags = $this->problemTags($gid);
-        $tag_problems = [];
+        $tags=$this->problemTags($gid);
+        $tag_problems=[];
 
-        $user_list = $this->userList($gid);
+        $user_list=$this->userList($gid);
         foreach ($tags as $tag) {
-            $tag_problems[$tag] = DB::table('problem')
-                ->join('group_problem_tag','problem.pid','=','group_problem_tag.pid')
+            $tag_problems[$tag]=DB::table('problem')
+                ->join('group_problem_tag', 'problem.pid', '=', 'group_problem_tag.pid')
                 ->where([
                     'group_problem_tag.gid' => $gid,
                     'tag' => $tag
                 ])
-                ->select('group_problem_tag.pid as pid','pcode','title')
+                ->select('group_problem_tag.pid as pid', 'pcode', 'title')
                 ->get()->all();
         }
-        $all_problems = [];
+        $all_problems=[];
         foreach ($tag_problems as &$tag_problem_set) {
             foreach ($tag_problem_set as $problem) {
-                $all_problems[$problem['pid']] = $problem;
+                $all_problems[$problem['pid']]=$problem;
             }
-            $tag_problem_set = array_column($tag_problem_set,'pid');
+            $tag_problem_set=array_column($tag_problem_set, 'pid');
         }
-        $submission_data =  DB::table('submission')
-            ->whereIn('pid',array_keys($all_problems))
-            ->whereIn('uid',array_column($user_list,'uid'))
-            ->where('verdict','Accepted')
-            ->select('pid','uid')
+        $submission_data=DB::table('submission')
+            ->whereIn('pid', array_keys($all_problems))
+            ->whereIn('uid', array_column($user_list, 'uid'))
+            ->where('verdict', 'Accepted')
+            ->select('pid', 'uid')
             ->get()->all();
 
-        $memberData = [];
+        $memberData=[];
         foreach ($user_list as $member) {
-            $completion = [];
-            foreach($tag_problems as $tag => $problems) {
-                $completion[$tag] = [];
+            $completion=[];
+            foreach ($tag_problems as $tag => $problems) {
+                $completion[$tag]=[];
                 foreach ($problems as $problem) {
-                    $is_accepted = 0;
+                    $is_accepted=0;
                     foreach ($submission_data as $sd) {
-                        if($sd['pid'] == $problem && $sd['uid'] == $member['uid']){
-                            $is_accepted = 1;
+                        if ($sd['pid']==$problem && $sd['uid']==$member['uid']) {
+                            $is_accepted=1;
                             break;
                         }
                     }
-                    $completion[$tag][$problem] = $is_accepted;
+                    $completion[$tag][$problem]=$is_accepted;
                 }
             }
-            array_push($memberData,[
+            array_push($memberData, [
                 'uid' => $member['uid'],
                 'name' => $member['name'],
                 'nick_name' => $member['nick_name'],
                 'completion' => $completion,
             ]);
         }
-        $ret = [
+        $ret=[
             'all_problems' => $all_problems,
             'tag_problems' => $tag_problems,
             'member_data' => $memberData
@@ -544,29 +544,29 @@ 
     public function refreshElo($gid)
     {
         DB::table('group_rated_change_log')
-            ->where('gid',$gid)
+            ->where('gid', $gid)
             ->delete();
         DB::table('group_member')
-            ->where('gid',$gid)
+            ->where('gid', $gid)
             ->update([
                 'ranking' => 1500
             ]);
-        $contests = DB::table('contest')
+        $contests=DB::table('contest')
             ->where([
                 'gid' => $gid,
                 'practice' => 1
             ])
-            ->where('end_time','<',date("Y-m-d H:i:s"))
+            ->where('end_time', '<', date("Y-m-d H:i:s"))
             ->select('cid')
             ->orderBy('end_time')
             ->get()->all();
 
-        if(empty($contests)) {
+        if (empty($contests)) {
             return true;
         }
 
         foreach ($contests as $contest) {
-            $calc = new GroupRatingCalculator($contest['cid']);
+            $calc=new GroupRatingCalculator($contest['cid']);
             $calc->calculate();
             $calc->storage();
         }