Problem::serializeDate() - Code Metrics - Inspection of "release: 0.17.1 Characinae Build Pack 1" - ZsgsDesign/NOJ - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#744)

by John

created 2021-10-12 00:41 UTC

Problem::serializeDate() A

↳ Parent: Problem

Complexity

Conditions	1
Paths	1

Size

Total Lines	3
Code Lines	1

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
cc	1
eloc	1
c	1
b	0
f	1
nc	1
nop	1
dl	0
loc	3
rs	10

<?php

namespace App\Models\Eloquent;

use Illuminate\Database\Eloquent\Model;
use App\Models\Eloquent\Contest;
use Auth;
use Carbon;
use DB;
use Exception;
use App\Models\Traits\LikeScope;
use DateTimeInterface;

class Problem extends Model
{
    use LikeScope;

    protected $table = 'problem';
    protected $primaryKey = 'pid';
    const UPDATED_AT = "update_date";

    protected function serializeDate(DateTimeInterface $date)
    {
        return $date->format('Y-m-d H:i:s');
    }

    public function getReadableNameAttribute()
    {
        return $this->pcode . '. ' . $this->title;
    }

    public function submissions()
    {
        return $this->hasMany('App\Models\Eloquent\Submission', 'pid', 'pid');
    }

    public function problemSamples()
    {
        return $this->hasMany('App\Models\Eloquent\ProblemSample', 'pid', 'pid');
    }

    public function homework_problems()
    {
        return $this->hasMany('App\Models\Eloquent\GroupHomeworkProblem', 'problem_id', 'pid');
    }

    public function onlinejudge()
    {
        return $this->belongsTo('App\Models\Eloquent\OJ', 'OJ', 'oid');
    }

    public function getProblemStatusAttribute()
    {
        return $this->getProblemStatus();
    }

    public function getProblemStatus($userID = null, $contestID = null, Carbon $till = null)
    {
        if (blank($userID)) {
            if (Auth::guard('web')->check()) {
                $userID = Auth::guard('web')->user()->id;

            }
        }

        if (filled($userID)) {
            $probStatus = $this->getProblemStatusFromDB($userID, $contestID, $till);
            if (blank($probStatus)) {
                return [
                    "icon" => "checkbox-blank-circle-outline",
                    "color" => "wemd-grey-text"
                ];
            } else {
                return [
                    "icon" => $probStatus->verdict == "Accepted" ? "checkbox-blank-circle" : "cisco-webex",
                    "color" => $probStatus->color
                ];
            }
        } else {
            return [
                "icon" => "checkbox-blank-circle-outline",
                "color" => "wemd-grey-text"
            ];
        }
    }

    private function getProblemStatusFromDB($userID, $contestID = null, Carbon $till = null)
    {
        $endedAt = Carbon::now();

        if (filled($contestID)) {
            try {
                $endedAt = Carbon::parse(Contest::findOrFail($contestID)->endedAt);
            } catch (Exception $e) {
                return null;
            }
        }

        // Get the very first AC record

        $acRecords = $this->submissions()->where([
            'uid' => $userID,
            'cid' => $contestID,
            'verdict' => 'Accepted'
        ]);
        if (filled($contestID)) {
            $acRecords = $acRecords->where("submission_date", "<", $endedAt->timestamp);
        }
        if (filled($till)) {
            $acRecords = $acRecords->where("submission_date", "<", $till->timestamp);
        }
        $acRecords = $acRecords->orderBy('submission_date', 'desc')->first();
        if (blank($acRecords)) {
            $pacRecords = $this->submissions()->where([
                'uid' => $userID,
                'cid' => $contestID,
                'verdict' => 'Partially Accepted'
            ]);
            if (filled($contestID)) {
                $pacRecords = $pacRecords->where("submission_date", "<", $endedAt->timestamp);
            }
            if (filled($till)) {
                $pacRecords = $pacRecords->where("submission_date", "<", $till->timestamp);
            }
            $pacRecords = $pacRecords->orderBy('submission_date', 'desc')->first();
            if (blank($pacRecords)) {
                $otherRecords = $this->submissions()->where([
                    'uid' => $userID,
                    'cid' => $contestID
                ]);
                if (filled($contestID)) {
                    $otherRecords = $otherRecords->where("submission_date", "<", $endedAt->timestamp);
                }
                if (filled($till)) {
                    $otherRecords = $otherRecords->where("submission_date", "<", $till->timestamp);
                }
                return $otherRecords->orderBy('submission_date', 'desc')->first();
            }
            return $pacRecords;
        } else {
            return $acRecords;
        }
    }

    public function users_latest_submission($users, $contestID = null, Carbon $till = null, $verdictFilter = [])
    {
        if (filled($contestID)) {
            $endedAt = Carbon::parse(Contest::findOrFail($contestID)->endedAt);
        }

        $lastRecordSubQuery = $this->submissions()->select('uid', DB::raw('MAX(submission_date) as submission_date'))->whereIntegerInRaw('uid', $users)->where('cid', $contestID)->groupBy('uid');

        if (filled($contestID)) {
            $lastRecordSubQuery = $lastRecordSubQuery->where("submission_date", "<", $endedAt->timestamp);

        }

        if (filled($till)) {
            $lastRecordSubQuery = $lastRecordSubQuery->where("submission_date", "<", $till->timestamp);
        }

        if(filled($verdictFilter)) {
            $lastRecordSubQuery = $lastRecordSubQuery->whereIn('verdict', $verdictFilter);
        }

        $query = DB::table(DB::raw("({$lastRecordSubQuery->toSql()}) last_sub"))->leftJoinSub(Submission::toBase(), 'submissions', function ($join) {
            $join->on('last_sub.submission_date', '=', 'submissions.submission_date')->on('last_sub.uid', '=', 'submissions.uid');
        })->select('sid', 'last_sub.submission_date as submission_date', 'last_sub.uid as uid', 'verdict', 'color')->orderBy('uid', 'ASC');

        return $query->mergeBindings($lastRecordSubQuery->toBase());
    }

    /*     public function getSamplesAttribute()
    {
        return array_map(function($sample) {
            return [
                'sample_input' => $sample->sample_input,
                'sample_output' => $sample->sample_output,
                'sample_note' => $sample->sample_note,
            ];
        }, $this->problemSamples()->select('sample_input', 'sample_output', 'sample_note')->get()->all());
    }

    public function setSamplesAttribute($value)
    {
        return;
    } */
}


1			<?php
2
3			namespace App\Models\Eloquent;
4
5			use Illuminate\Database\Eloquent\Model;
6			use App\Models\Eloquent\Contest;
7			use Auth;
8			use Carbon;
9			use DB;
10			use Exception;
11			use App\Models\Traits\LikeScope;
12			use DateTimeInterface;
13
14			class Problem extends Model
15			{
16			use LikeScope;
17
18			protected $table = 'problem';
19			protected $primaryKey = 'pid';
20			const UPDATED_AT = "update_date";
21
22			protected function serializeDate(DateTimeInterface $date)
23			{
24			return $date->format('Y-m-d H:i:s');
25			}
26
27			public function getReadableNameAttribute()
28			{
29			return $this->pcode . '. ' . $this->title;
30			}
31
32			public function submissions()
33			{
34			return $this->hasMany('App\Models\Eloquent\Submission', 'pid', 'pid');
35			}
36
37			public function problemSamples()
38			{
39			return $this->hasMany('App\Models\Eloquent\ProblemSample', 'pid', 'pid');
40			}
41
42			public function homework_problems()
43			{
44			return $this->hasMany('App\Models\Eloquent\GroupHomeworkProblem', 'problem_id', 'pid');
45			}
46
47			public function onlinejudge()
48			{
49			return $this->belongsTo('App\Models\Eloquent\OJ', 'OJ', 'oid');
50			}
51
52			public function getProblemStatusAttribute()
53			{
54			return $this->getProblemStatus();
55			}
56
57			public function getProblemStatus($userID = null, $contestID = null, Carbon $till = null)
58			{
59			if (blank($userID)) {
60			if (Auth::guard('web')->check()) {
61			$userID = Auth::guard('web')->user()->id;
			0 ignored issues – show Bug introduced 2021-08-13 20:36 UTC by Report Bug Copy Issue Report Accessing `id` on the interface `Illuminate\Contracts\Auth\Authenticatable` suggest that you code against a concrete implementation. How about adding an `instanceof` check? Loading history...
62			}
63			}
64
65			if (filled($userID)) {
66			$probStatus = $this->getProblemStatusFromDB($userID, $contestID, $till);
67			if (blank($probStatus)) {
68			return [
69			"icon" => "checkbox-blank-circle-outline",
70			"color" => "wemd-grey-text"
71			];
72			} else {
73			return [
74			"icon" => $probStatus->verdict == "Accepted" ? "checkbox-blank-circle" : "cisco-webex",
75			"color" => $probStatus->color
76			];
77			}
78			} else {
79			return [
80			"icon" => "checkbox-blank-circle-outline",
81			"color" => "wemd-grey-text"
82			];
83			}
84			}
85
86			private function getProblemStatusFromDB($userID, $contestID = null, Carbon $till = null)
87			{
88			$endedAt = Carbon::now();
89
90			if (filled($contestID)) {
91			try {
92			$endedAt = Carbon::parse(Contest::findOrFail($contestID)->endedAt);
93			} catch (Exception $e) {
94			return null;
95			}
96			}
97
98			// Get the very first AC record
99
100			$acRecords = $this->submissions()->where([
101			'uid' => $userID,
102			'cid' => $contestID,
103			'verdict' => 'Accepted'
104			]);
105			if (filled($contestID)) {
106			$acRecords = $acRecords->where("submission_date", "<", $endedAt->timestamp);
107			}
108			if (filled($till)) {
109			$acRecords = $acRecords->where("submission_date", "<", $till->timestamp);
110			}
111			$acRecords = $acRecords->orderBy('submission_date', 'desc')->first();
112			if (blank($acRecords)) {
113			$pacRecords = $this->submissions()->where([
114			'uid' => $userID,
115			'cid' => $contestID,
116			'verdict' => 'Partially Accepted'
117			]);
118			if (filled($contestID)) {
119			$pacRecords = $pacRecords->where("submission_date", "<", $endedAt->timestamp);
120			}
121			if (filled($till)) {
122			$pacRecords = $pacRecords->where("submission_date", "<", $till->timestamp);
123			}
124			$pacRecords = $pacRecords->orderBy('submission_date', 'desc')->first();
125			if (blank($pacRecords)) {
126			$otherRecords = $this->submissions()->where([
127			'uid' => $userID,
128			'cid' => $contestID
129			]);
130			if (filled($contestID)) {
131			$otherRecords = $otherRecords->where("submission_date", "<", $endedAt->timestamp);
132			}
133			if (filled($till)) {
134			$otherRecords = $otherRecords->where("submission_date", "<", $till->timestamp);
135			}
136			return $otherRecords->orderBy('submission_date', 'desc')->first();
137			}
138			return $pacRecords;
139			} else {
140			return $acRecords;
141			}
142			}
143
144			public function users_latest_submission($users, $contestID = null, Carbon $till = null, $verdictFilter = [])
145			{
146			if (filled($contestID)) {
147			$endedAt = Carbon::parse(Contest::findOrFail($contestID)->endedAt);
148			}
149
150			$lastRecordSubQuery = $this->submissions()->select('uid', DB::raw('MAX(submission_date) as submission_date'))->whereIntegerInRaw('uid', $users)->where('cid', $contestID)->groupBy('uid');
151
152			if (filled($contestID)) {
153			$lastRecordSubQuery = $lastRecordSubQuery->where("submission_date", "<", $endedAt->timestamp);
			0 ignored issues – show Comprehensibility Best Practice introduced 2021-10-08 07:02 UTC by Report Bug Copy Issue Report The variable `$endedAt` does not seem to be defined for all execution paths leading up to this point. Loading history...
154			}
155
156			if (filled($till)) {
157			$lastRecordSubQuery = $lastRecordSubQuery->where("submission_date", "<", $till->timestamp);
158			}
159
160			if(filled($verdictFilter)) {
161			$lastRecordSubQuery = $lastRecordSubQuery->whereIn('verdict', $verdictFilter);
162			}
163
164			$query = DB::table(DB::raw("({$lastRecordSubQuery->toSql()}) last_sub"))->leftJoinSub(Submission::toBase(), 'submissions', function ($join) {
165			$join->on('last_sub.submission_date', '=', 'submissions.submission_date')->on('last_sub.uid', '=', 'submissions.uid');
166			})->select('sid', 'last_sub.submission_date as submission_date', 'last_sub.uid as uid', 'verdict', 'color')->orderBy('uid', 'ASC');
167
168			return $query->mergeBindings($lastRecordSubQuery->toBase());
169			}
170
171			/* public function getSamplesAttribute()
172			{
173			return array_map(function($sample) {
174			return [
175			'sample_input' => $sample->sample_input,
176			'sample_output' => $sample->sample_output,
177			'sample_note' => $sample->sample_note,
178			];
179			}, $this->problemSamples()->select('sample_input', 'sample_output', 'sample_note')->get()->all());
180			}
181
182			public function setSamplesAttribute($value)
183			{
184			return;
185			} */
186			}
187

ZsgsDesign / NOJ

Pull Request — master (#744)

Problem::serializeDate() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like