Passed
Pull Request — master (#414)
by John
12:18
created
app/Http/Controllers/MessageController.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -10,8 +10,8 @@  discard block
 block discarded – undo
10 10
 {
11 11
     public function index()
12 12
     {
13
-        $uid = Auth::user()->id;
14
-        $messages = Message::list($uid);
13
+        $uid=Auth::user()->id;
14
+        $messages=Message::list($uid);
15 15
         return view('message.index', [
16 16
             'page_title'=>"Message",
17 17
             'site_title'=>config("app.name"),
@@ -22,8 +22,8 @@  discard block
 block discarded – undo
22 22
 
23 23
     public function detail($id)
24 24
     {
25
-        $message = Message::read($id);
26
-        if(empty($message) || $message->receiver != Auth::user()->id){
25
+        $message=Message::read($id);
26
+        if (empty($message) || $message->receiver!=Auth::user()->id) {
27 27
             return Redirect::route('message.index');
28 28
         }
29 29
         return view('message.detail', [
Please login to merge, or discard this patch.
app/Http/Controllers/MainController.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -59,11 +59,11 @@
 block discarded – undo
59 59
     public function oldRedirect(Request $request)
60 60
     {
61 61
         $all_data=$request->all();
62
-        $method=isset($all_data["method"])?$all_data["method"]:null;
63
-        $id=isset($all_data["id"])?$all_data["id"]:null;
64
-        if($method=="showdetail" && !is_null($id)){
62
+        $method=isset($all_data["method"]) ? $all_data["method"] : null;
63
+        $id=isset($all_data["id"]) ? $all_data["id"] : null;
64
+        if ($method=="showdetail" && !is_null($id)) {
65 65
             $problemModel=new ProblemModel();
66
-            return ($problemModel->existPCode("NOJ$id"))?Redirect::route('problem.detail', ['pcode' => "NOJ$id"]):Redirect::route('problem_index');
66
+            return ($problemModel->existPCode("NOJ$id")) ?Redirect::route('problem.detail', ['pcode' => "NOJ$id"]) : Redirect::route('problem_index');
67 67
         }
68 68
         return Redirect::route('home');
69 69
     }
Please login to merge, or discard this patch.
app/Http/Controllers/Group/IndexController.php 2 patches
Spacing   +15 added lines, -15 removed lines patch added patch discarded remove patch
@@ -85,12 +85,12 @@  discard block
 block discarded – undo
85 85
      *
86 86
      * @return Response
87 87
      */
88
-    public function analysis($gcode){
89
-        $groupModel = new GroupModel();
88
+    public function analysis($gcode) {
89
+        $groupModel=new GroupModel();
90 90
         $basic_info=$groupModel->details($gcode);
91 91
         $clearance=$groupModel->judgeClearance($basic_info["gid"], Auth::user()->id);
92
-        if($clearance < 1) return Redirect::route('group.detail',['gcode' => $gcode]);
93
-        $group_info = $groupModel->details($gcode);
92
+        if ($clearance<1) return Redirect::route('group.detail', ['gcode' => $gcode]);
93
+        $group_info=$groupModel->details($gcode);
94 94
         return view('group.settings.analysis', [
95 95
             'page_title'=>"Group Analysis",
96 96
             'site_title'=>"NOJ",
@@ -100,13 +100,13 @@  discard block
 block discarded – undo
100 100
         ]);
101 101
     }
102 102
 
103
-    public function analysisDownload($gcode,Request $request){
104
-        $all_data = $request->all();
105
-        $groupModel = new GroupModel();
106
-        $group_info = $groupModel->details($gcode);
107
-        $mode = $all_data['mode'] ?? 'contest';
108
-        if($mode == 'contest'){
109
-            $data = $groupModel->groupMemberPracticeContestStat($group_info['gid']);
103
+    public function analysisDownload($gcode, Request $request) {
104
+        $all_data=$request->all();
105
+        $groupModel=new GroupModel();
106
+        $group_info=$groupModel->details($gcode);
107
+        $mode=$all_data['mode'] ?? 'contest';
108
+        if ($mode=='contest') {
109
+            $data=$groupModel->groupMemberPracticeContestStat($group_info['gid']);
110 110
             return Excel::download(
111 111
                 new GroupAnalysisExport(
112 112
                     [
@@ -119,10 +119,10 @@  discard block
 block discarded – undo
119 119
                         'percent' => $all_data['percent'] ?? false,
120 120
                     ]
121 121
                 ),
122
-                $gcode . '_Group_Contest_Analysis.xlsx'
122
+                $gcode.'_Group_Contest_Analysis.xlsx'
123 123
             );
124
-        }else{
125
-            $data = $groupModel->groupMemberPracticeTagStat($group_info['gid']);
124
+        } else {
125
+            $data=$groupModel->groupMemberPracticeTagStat($group_info['gid']);
126 126
             return Excel::download(
127 127
                 new GroupAnalysisExport(
128 128
                     [
@@ -135,7 +135,7 @@  discard block
 block discarded – undo
135 135
                         'percent' => $all_data['percent'] ?? false,
136 136
                     ]
137 137
                 ),
138
-                $gcode . '_Group_Tag_Analysis.xlsx'
138
+                $gcode.'_Group_Tag_Analysis.xlsx'
139 139
             );
140 140
         }
141 141
     }
Please login to merge, or discard this patch.
Braces   +4 added lines, -2 removed lines patch added patch discarded remove patch
@@ -89,7 +89,9 @@  discard block
 block discarded – undo
89 89
         $groupModel = new GroupModel();
90 90
         $basic_info=$groupModel->details($gcode);
91 91
         $clearance=$groupModel->judgeClearance($basic_info["gid"], Auth::user()->id);
92
-        if($clearance < 1) return Redirect::route('group.detail',['gcode' => $gcode]);
92
+        if($clearance < 1) {
93
+            return Redirect::route('group.detail',['gcode' => $gcode]);
94
+        }
93 95
         $group_info = $groupModel->details($gcode);
94 96
         return view('group.settings.analysis', [
95 97
             'page_title'=>"Group Analysis",
@@ -121,7 +123,7 @@  discard block
 block discarded – undo
121 123
                 ),
122 124
                 $gcode . '_Group_Contest_Analysis.xlsx'
123 125
             );
124
-        }else{
126
+        } else{
125 127
             $data = $groupModel->groupMemberPracticeTagStat($group_info['gid']);
126 128
             return Excel::download(
127 129
                 new GroupAnalysisExport(
Please login to merge, or discard this patch.
app/Http/Controllers/Group/AdminController.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -21,7 +21,7 @@  discard block
 block discarded – undo
21 21
      */
22 22
     public function settings($gcode)
23 23
     {
24
-        return Redirect::route('group.settings.general', ['gcode' => $gcode]);;
24
+        return Redirect::route('group.settings.general', ['gcode' => $gcode]); ;
25 25
     }
26 26
 
27 27
     /**
@@ -31,7 +31,7 @@  discard block
 block discarded – undo
31 31
      */
32 32
     public function settingsReturn($gcode)
33 33
     {
34
-        return Redirect::route('group.detail', ['gcode' => $gcode]);;
34
+        return Redirect::route('group.detail', ['gcode' => $gcode]); ;
35 35
     }
36 36
 
37 37
     /**
@@ -60,10 +60,10 @@  discard block
 block discarded – undo
60 60
      *
61 61
      * @return Response
62 62
      */
63
-    public function problems($gcode){
64
-        $groupModel = new GroupModel();
65
-        $group_info = $groupModel->details($gcode);
66
-        $problems = $groupModel->problems($group_info['gid']);
63
+    public function problems($gcode) {
64
+        $groupModel=new GroupModel();
65
+        $group_info=$groupModel->details($gcode);
66
+        $problems=$groupModel->problems($group_info['gid']);
67 67
         $basic_info=$groupModel->details($gcode);
68 68
         return view('group.settings.problems', [
69 69
             'page_title'=>"Group Problems",
Please login to merge, or discard this patch.
app/Http/Middleware/User/Banned.php 2 patches
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -17,25 +17,25 @@
 block discarded – undo
17 17
     public function handle($request, Closure $next)
18 18
     {
19 19
         //check login
20
-        if(!Auth::check()){
20
+        if (!Auth::check()) {
21 21
             return $next($request);
22 22
         }
23
-        $user = Auth::user();
24
-        $banned = $user->banneds()->orderBy('removed_at', 'desc')->first();
23
+        $user=Auth::user();
24
+        $banned=$user->banneds()->orderBy('removed_at', 'desc')->first();
25 25
         //check if there are any banned records
26
-        if(empty($banned)) {
26
+        if (empty($banned)) {
27 27
             return $next($request);
28 28
         }
29 29
         //check the time of the last record
30
-        if(strtotime($banned->removed_at) <= time()){
30
+        if (strtotime($banned->removed_at)<=time()) {
31 31
             return $next($request);
32 32
         }
33 33
         //return error page
34
-        if($request->method() == 'GET'){
35
-            return response()->view('errors.451',[
34
+        if ($request->method()=='GET') {
35
+            return response()->view('errors.451', [
36 36
                 'description' => "Your account is currently blocked and will remain so until {$banned->removed_at}. Here's why: {$banned->reason}",
37 37
             ]);
38
-        }else{
38
+        } else {
39 39
             return response()->json([
40 40
                 'ret' => 451,
41 41
                 'desc' => 'Unavailable For Legal Reasons',
Please login to merge, or discard this patch.
Braces   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -35,7 +35,7 @@
 block discarded – undo
35 35
             return response()->view('errors.451',[
36 36
                 'description' => "Your account is currently blocked and will remain so until {$banned->removed_at}. Here's why: {$banned->reason}",
37 37
             ]);
38
-        }else{
38
+        } else{
39 39
             return response()->json([
40 40
                 'ret' => 451,
41 41
                 'desc' => 'Unavailable For Legal Reasons',
Please login to merge, or discard this patch.
app/Http/Middleware/Group/Banned.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -17,12 +17,12 @@
 block discarded – undo
17 17
      */
18 18
     public function handle($request, Closure $next)
19 19
     {
20
-        $gcode = $request->gcode;
21
-        $group = Group::where('gcode',$gcode)->first();
22
-        $banneds = $group->banneds()->where('removed_at','>',date('Y-m-d H:i:s'))->first();
23
-        $user = Auth::user();
24
-        if(!empty($banneds) && $user->id != $group->leader->id) {
25
-            return response()->view('errors.451',[
20
+        $gcode=$request->gcode;
21
+        $group=Group::where('gcode', $gcode)->first();
22
+        $banneds=$group->banneds()->where('removed_at', '>', date('Y-m-d H:i:s'))->first();
23
+        $user=Auth::user();
24
+        if (!empty($banneds) && $user->id!=$group->leader->id) {
25
+            return response()->view('errors.451', [
26 26
                 'description' => 'This group is currently banned. Please contact the group administrator.'
27 27
             ]);
28 28
         }
Please login to merge, or discard this patch.
app/Http/Middleware/Group/Exists.php 2 patches
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -16,11 +16,11 @@
 block discarded – undo
16 16
      */
17 17
     public function handle($request, Closure $next)
18 18
     {
19
-        $gcode = $request->gcode;
20
-        $group = Group::where('gcode',$gcode)->first();
21
-        if(!empty($group)){
19
+        $gcode=$request->gcode;
20
+        $group=Group::where('gcode', $gcode)->first();
21
+        if (!empty($group)) {
22 22
             return $next($request);
23
-        }else{
23
+        } else {
24 24
             return redirect('/group');
25 25
         }
26 26
 
Please login to merge, or discard this patch.
Braces   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -20,7 +20,7 @@
 block discarded – undo
20 20
         $group = Group::where('gcode',$gcode)->first();
21 21
         if(!empty($group)){
22 22
             return $next($request);
23
-        }else{
23
+        } else{
24 24
             return redirect('/group');
25 25
         }
26 26
 
Please login to merge, or discard this patch.
app/Admin/Controllers/DashboardController.php 1 patch
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -13,15 +13,15 @@
 block discarded – undo
13 13
     {
14 14
         $version=UpdateModel::checkUpdate();
15 15
 
16
-        $status = [
17
-            ['name' => 'NOJ Version',       'value' => version()],
18
-            ['name' => 'Lastest Version',   'value' => is_null($version)?'Failed to fetch latest version':$version["name"]],
19
-            ['name' => 'Problems',          'value' => \App\Models\Eloquent\ProblemModel::count()],
20
-            ['name' => 'Solutions',         'value' => \App\Models\Eloquent\ProblemSolutionModel::count()],
21
-            ['name' => 'Submissions',       'value' => \App\Models\Eloquent\SubmissionModel::count()],
22
-            ['name' => 'Contests',          'value' => \App\Models\Eloquent\ContestModel::count()],
23
-            ['name' => 'Users',             'value' => \App\Models\Eloquent\UserModel::count()],
24
-            ['name' => 'Groups',            'value' => \App\Models\Eloquent\Group::count()],
16
+        $status=[
17
+            ['name' => 'NOJ Version', 'value' => version()],
18
+            ['name' => 'Lastest Version', 'value' => is_null($version) ? 'Failed to fetch latest version' : $version["name"]],
19
+            ['name' => 'Problems', 'value' => \App\Models\Eloquent\ProblemModel::count()],
20
+            ['name' => 'Solutions', 'value' => \App\Models\Eloquent\ProblemSolutionModel::count()],
21
+            ['name' => 'Submissions', 'value' => \App\Models\Eloquent\SubmissionModel::count()],
22
+            ['name' => 'Contests', 'value' => \App\Models\Eloquent\ContestModel::count()],
23
+            ['name' => 'Users', 'value' => \App\Models\Eloquent\UserModel::count()],
24
+            ['name' => 'Groups', 'value' => \App\Models\Eloquent\Group::count()],
25 25
         ];
26 26
 
27 27
         return view('admin::dashboard.general', [
Please login to merge, or discard this patch.
app/Admin/Controllers/AbuseController.php 2 patches
Spacing   +26 added lines, -26 removed lines patch added patch discarded remove patch
@@ -23,7 +23,7 @@  discard block
 block discarded – undo
23 23
      *
24 24
      * @var string
25 25
      */
26
-    protected $title = 'Abuses';
26
+    protected $title='Abuses';
27 27
 
28 28
     /**
29 29
      * Make a grid builder.
@@ -32,7 +32,7 @@  discard block
 block discarded – undo
32 32
      */
33 33
     protected function grid()
34 34
     {
35
-        $grid = new Grid(new Abuse);
35
+        $grid=new Grid(new Abuse);
36 36
 
37 37
         $grid->column('id', __('Id'));
38 38
         $grid->column('title', __('Title'));
@@ -58,7 +58,7 @@  discard block
 block discarded – undo
58 58
      */
59 59
     protected function detail($id)
60 60
     {
61
-        $show = new Show(Abuse::findOrFail($id));
61
+        $show=new Show(Abuse::findOrFail($id));
62 62
 
63 63
         $show->field('id', __('Id'));
64 64
         $show->field('title', __('Title'));
@@ -81,7 +81,7 @@  discard block
 block discarded – undo
81 81
      */
82 82
     protected function form()
83 83
     {
84
-        $form = new Form(new Abuse);
84
+        $form=new Form(new Abuse);
85 85
 
86 86
         $form->text('title', __('Title'));
87 87
         $form->number('cause', __('Cause'));
@@ -92,23 +92,23 @@  discard block
 block discarded – undo
92 92
 
93 93
         $form->ignore(['created_at']);
94 94
 
95
-        $form->saving(function (Form $form) {
96
-            $abuse = $form->model();
95
+        $form->saving(function(Form $form) {
96
+            $abuse=$form->model();
97 97
             //get gategory and subject id
98
-            $regex = '/^([A-Za-z]+) #(\d+)/';
99
-            $matches = [];
100
-            preg_match($regex,$abuse->title,$matches);
101
-            $category = array_search(strtolower($matches[1]),Abuse::$supportCategory);
102
-            $subject_id = (int)$matches[2];
103
-            switch($abuse->category) {
98
+            $regex='/^([A-Za-z]+) #(\d+)/';
99
+            $matches=[];
100
+            preg_match($regex, $abuse->title, $matches);
101
+            $category=array_search(strtolower($matches[1]), Abuse::$supportCategory);
102
+            $subject_id=(int) $matches[2];
103
+            switch ($abuse->category) {
104 104
                 case 0:
105
-                    $gid = $subject_id;
106
-                    $group = Group::find($gid);
107
-                    if(empty($group)) {
108
-                        return ;
105
+                    $gid=$subject_id;
106
+                    $group=Group::find($gid);
107
+                    if (empty($group)) {
108
+                        return;
109 109
                     }
110
-                    if($form->audit) {
111
-                        $ban_time = request()->created_at;
110
+                    if ($form->audit) {
111
+                        $ban_time=request()->created_at;
112 112
                         sendMessage([
113 113
                             'sender'    => 1,
114 114
                             'receiver'  => $abuse->user_id,
@@ -128,8 +128,8 @@  discard block
 block discarded – undo
128 128
                             'reason'     => $abuse->supplement,
129 129
                             'removed_at' => $ban_time
130 130
                         ]);
131
-                        return ;
132
-                    }else{
131
+                        return;
132
+                    } else {
133 133
                         sendMessage([
134 134
                             'sender'    => 1,
135 135
                             'receiver'  => $abuse->user_id,
@@ -137,11 +137,11 @@  discard block
 block discarded – undo
137 137
                             'content'   => "Hi, Dear **{$abuse->user->name}**,\n\n We have checked your Abuse report about group **[{$group->name}]({$group->link})**.\n\n However, we regret to say that the information you submitted is not sufficient for us to take action.\n\n Of course, we will continue to follow up the investigation.\n\n Thank you for your contribution to our community environment.\n\n Sincerely, NOJ"
138 138
                         ]);
139 139
                         $abuse->delete();
140
-                        return ;
140
+                        return;
141 141
                     }
142 142
                     return;
143 143
                 case 1:
144
-                    $ban_time = request()->created_at;
144
+                    $ban_time=request()->created_at;
145 145
                     UserBanned::create([
146 146
                         'abuse_id'   => $abuse->id,
147 147
                         'user_id'    => $subject_id,
@@ -170,15 +170,15 @@  discard block
 block discarded – undo
170 170
 
171 171
     protected function check_form()
172 172
     {
173
-        $form = new Form(new Abuse);
174
-        $form->display('id',__('Abuse id'));
173
+        $form=new Form(new Abuse);
174
+        $form->display('id', __('Abuse id'));
175 175
         $form->display('title', __('Title'));
176 176
         $form->display('cause', __('Cause'));
177 177
         $form->display('supplement', __('Supplement'));
178 178
         $form->display('link', __('Group Link'));
179 179
         $form->display('user_id', __('Submitter'));
180
-        $form->radio('audit','result')->options(['0' => 'Reject', '1'=> 'Pass']);
181
-        $form->datetime('created_at','ban until');
180
+        $form->radio('audit', 'result')->options(['0' => 'Reject', '1'=> 'Pass']);
181
+        $form->datetime('created_at', 'ban until');
182 182
 
183 183
         return $form;
184 184
     }
Please login to merge, or discard this patch.
Braces   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -129,7 +129,7 @@
 block discarded – undo
129 129
                             'removed_at' => $ban_time
130 130
                         ]);
131 131
                         return ;
132
-                    }else{
132
+                    } else{
133 133
                         sendMessage([
134 134
                             'sender'    => 1,
135 135
                             'receiver'  => $abuse->user_id,
Please login to merge, or discard this patch.