App\Http\Controllers\Tool\Ajax\ImageHostingController::generate()

Complexity

Conditions	5
Paths	4

Size

Total Lines	30
Code Lines	22

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

<?php
    public function generate(Request $request)
    {
        $user=Auth::user();

        if (!$user->hasPermission(26)) {

The method hasPermission() does not exist on Illuminate\Contracts\Auth\Authenticatable. It seems like you code against a sub-type of said class. However, the method does not exist in Illuminate\Auth\GenericUser. Are you sure you never get one of those?

            return ResponseModel::err(2001);

The expression return App\Models\ResponseModel::err(2001) returns the type Illuminate\Http\JsonResponse which is incompatible with the documented return type Illuminate\Http\Response.

        }

        $isValid=$request->file('image')->isValid();
        if ($isValid) {
            $extension=$request->file('image')->extension();
        } else {
            return ResponseModel::err(1005);

The expression return App\Models\ResponseModel::err(1005) returns the type Illuminate\Http\JsonResponse which is incompatible with the documented return type Illuminate\Http\Response.

        }

        $allow_extension=['jpg', 'png', 'jpeg', 'gif', 'bmp'];
        if ($isValid && in_array($extension, $allow_extension)) {
            $path=$request->file('image')->store('/static/img/upload', 'NOJPublic');
            $id=ImageHosting::create([
                'user_id' => $user->id,

Accessing id on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

                'relative_path' => "/$path"
            ])->id;
            return ResponseModel::success(200, null, [

The expression return App\Models\ResponseModel::success(200, null, array('relative_path' => '/'.$path, 'path' => url($path), 'id' => $id, 'redirect_url' => route('tool.imagehosting.detail', array('id' => $id)))) returns the type Illuminate\Http\JsonResponse which is incompatible with the documented return type Illuminate\Http\Response.

                'relative_path' => "/$path",
                'path' => url($path),

It seems like $path can also be of type false; however, parameter $path of url() does only seem to accept null|string, maybe add an additional type check?

                'id' => $id,
                'redirect_url' => route('tool.imagehosting.detail', ['id'=>$id]),
            ]);
        } else {
            return ResponseModel::err(1005);

The expression return App\Models\ResponseModel::err(1005) returns the type Illuminate\Http\JsonResponse which is incompatible with the documented return type Illuminate\Http\Response.

        }