App\Http\Controllers\OAuth\GithubController::handleCallback()

Complexity

Conditions	9
Paths	8

Size

Total Lines	61
Code Lines	50

Duplication

Lines	0
Ratio	0 %

Importance

Changes	4
Bugs	2	Features	1

<?php
    public function handleCallback()
    {
        try {
            $github_user=Socialite::driver('github')->user();
        } catch (\Laravel\Socialite\Two\InvalidStateException $e) {
            return redirect()->route('home');
        }

        if (Auth::check()) {
            $user_id=Auth::user()->id;

Accessing id on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

            $ret=UserExtra::search('github_id', $github_user->id);

Accessing id on the interface Laravel\Socialite\Contracts\User suggest that you code against a concrete implementation. How about adding an instanceof check?

            if (!empty($ret) && $ret[0]['uid']!=$user_id) {
                $user=User::find($ret[0]['uid']);
                return $this->generateDuplicateView($user->email);
            }
            Auth::user()->setExtra('github_id', $github_user->id);

The method setExtra() does not exist on Illuminate\Contracts\Auth\Authenticatable. It seems like you code against a sub-type of said class. However, the method does not exist in Illuminate\Auth\GenericUser. Are you sure you never get one of those?

            Auth::user()->setExtra('github_email', $github_user->email);

Accessing email on the interface Laravel\Socialite\Contracts\User suggest that you code against a concrete implementation. How about adding an instanceof check?

            Auth::user()->setExtra('github_nickname', $github_user->nickname);

Accessing nickname on the interface Laravel\Socialite\Contracts\User suggest that you code against a concrete implementation. How about adding an instanceof check?

            Auth::user()->setExtra('github_homepage', ($github_user->user)['html_url']);

Accessing user on the interface Laravel\Socialite\Contracts\User suggest that you code against a concrete implementation. How about adding an instanceof check?

            Auth::user()->setExtra('github_token', $github_user->token, 101);

Accessing token on the interface Laravel\Socialite\Contracts\User suggest that you code against a concrete implementation. How about adding an instanceof check?

            return $this->generateSuccessView(Auth::user()->getExtra('github_email'));
        } else {
            $ret=UserExtra::search('github_id', $github_user->id);
            if (!empty($ret)) {
                Auth::loginUsingId($ret[0]['uid'], true);
                Auth::user()->setExtra('github_email', $github_user->email);
                Auth::user()->setExtra('github_nickname', $github_user->nickname);
                Auth::user()->setExtra('github_homepage', ($github_user->user)['html_url']);
                Auth::user()->setExtra('github_token', $github_user->token, 101);
                return redirect()->route('account.dashboard');
            } else {
                if (config('app.allow_oauth_temp_account')) {
                    try {
                        $createdUser=User::create([
                            'name' => Str::random(12),
                            'email' => Str::random(16)."@temporary.email",
                            'password' => '',
                            'avatar' => '/static/img/avatar/default.png',
                        ]);
                    } catch (QueryException $exception) {
                        return $this->generateUnknownErrorView();
                    }
                    Auth::loginUsingId($createdUser->id, true);
                    Auth::user()->setExtra('github_id', $github_user->id);
                    Auth::user()->setExtra('github_email', $github_user->email);
                    Auth::user()->setExtra('github_nickname', $github_user->nickname);
                    Auth::user()->setExtra('github_homepage', ($github_user->user)['html_url']);
                    Auth::user()->setExtra('github_token', $github_user->token, 101);
                    return redirect()->route('account.dashboard');
                }
                $buttons=[[
                    'text' => 'login',
                    'href' => route('login'),
                ]];
                if (config('function.register')) {
                    $buttons[]=[
                        'text' => 'register',
                        'href' => route('register'),
                    ];
                }
                return $this->generateAccountNotFoundView();
            }