Passed
Pull Request — master (#244)
by Chenyi
04:13
created
app/Http/Controllers/Contest/BoardController.php 1 patch
Braces   +5 added lines, -3 removed lines patch added patch discarded remove patch
@@ -107,7 +107,9 @@  discard block
 block discarded – undo
107 107
         }
108 108
 
109 109
         $editor_left_width = $accountModel->getExtra(Auth::user()->id, 'editor_left_width');
110
-        if(empty($editor_left_width)) $editor_left_width='40';
110
+        if(empty($editor_left_width)) {
111
+            $editor_left_width='40';
112
+        }
111 113
 
112 114
         return view('contest.board.editor', [
113 115
             'page_title'=>"Problem Detail",
@@ -154,10 +156,10 @@  discard block
 block discarded – undo
154 156
             if($i != 0) {
155 157
                 if($r['score'] == $contestRank[$i-1]['score'] && $r['penalty'] == $contestRank[$i-1]['penalty']){
156 158
                     $r['rank'] = $contestRank[$i-1]['rank'];
157
-                }else{
159
+                } else{
158 160
                     $r['rank'] = $i + 1;
159 161
                 }
160
-            }else{
162
+            } else{
161 163
                 $r['rank'] = 1;
162 164
             }
163 165
         }
Please login to merge, or discard this patch.
app/Models/GroupModel.php 1 patch
Braces   +12 added lines, -6 removed lines patch added patch discarded remove patch
@@ -115,7 +115,9 @@  discard block
 block discarded – undo
115 115
     public function details($gcode)
116 116
     {
117 117
         $basic_info=DB::table($this->tableName)->where(["gcode"=>$gcode])->first();
118
-        if(empty($basic_info)) return [];
118
+        if(empty($basic_info)) {
119
+            return [];
120
+        }
119 121
         $basic_info["members"]=$this->countGroupMembers($basic_info["gid"]);
120 122
         $basic_info["tags"]=$this->getGroupTags($basic_info["gid"]);
121 123
         $basic_info["create_time_foramt"]=date_format(date_create($basic_info["create_time"]), 'M jS, Y');
@@ -163,7 +165,9 @@  discard block
 block discarded – undo
163 165
         foreach ($user_list as &$u) {
164 166
             $u["role_parsed"]=$this->role[$u["role"]];
165 167
             $u["role_color"]=$this->role_color[$u["role"]];
166
-            if(is_null($u["sub_group"])) $u["sub_group"]="None";
168
+            if(is_null($u["sub_group"])) {
169
+                $u["sub_group"]="None";
170
+            }
167 171
         }
168 172
         return $user_list;
169 173
     }
@@ -232,7 +236,7 @@  discard block
 block discarded – undo
232 236
             ->where('gid',$gid)
233 237
             ->distinct()
234 238
             ->get()->all();
235
-        }else{
239
+        } else{
236 240
             $tags =  DB::table('group_problem_tag')
237 241
             ->select('tag')
238 242
             ->where('gid', $gid)
@@ -266,7 +270,7 @@  discard block
 block discarded – undo
266 270
         foreach($problems as $key => $value){
267 271
             if($contestModel->judgeClearance($value['cid'],$user_id) != 3){
268 272
                 unset($problems[$key]);
269
-            }else{
273
+            } else{
270 274
                 $problems[$key]['tags'] = $this->problemTags($gid,$value['pid']);
271 275
             }
272 276
         }
@@ -327,7 +331,9 @@  discard block
 block discarded – undo
327 331
     public function judgeEmailClearance($gid, $email)
328 332
     {
329 333
         $user=DB::table("users")->where(["email"=>$email])->first();
330
-        if(empty($user)) return -4;
334
+        if(empty($user)) {
335
+            return -4;
336
+        }
331 337
         $ret=DB::table("group_member")->where([
332 338
             "gid"=>$gid,
333 339
             "uid"=>$user["id"],
@@ -460,7 +466,7 @@  discard block
 block discarded – undo
460 466
                 if(!empty($last_cr)){
461 467
                     if($cr['solved'] == $last_cr['solved'] && $cr['penalty'] == $last_cr['penalty'] ){
462 468
                         $rank = $last_rank;
463
-                    }else{
469
+                    } else{
464 470
                         $rank = $index;
465 471
                         $last_rank = $rank;
466 472
                     }
Please login to merge, or discard this patch.
app/Babel/Submit/Curl.php 1 patch
Braces   +105 added lines, -21 removed lines patch added patch discarded remove patch
@@ -18,11 +18,31 @@  discard block
 block discarded – undo
18 18
 
19 19
     public function login($all_data)
20 20
     {
21
-        if(isset($all_data["url"]))    $url = $all_data["url"];       else throw new Exception("url is not exist in all_data");
22
-        if(isset($all_data["data"]))   $data = $all_data["data"];     else throw new Exception("data is not exist in all_data");
23
-        if(isset($all_data["oj"]))     $oj = $all_data["oj"];         else throw new Exception("oj is not exist in all_data");
24
-        if(isset($all_data["ret"]))    $ret = $all_data["ret"];       else $ret = 'false';
25
-        if(isset($all_data["handle"])) $handle = $all_data["handle"]; else $handle = "default";
21
+        if(isset($all_data["url"])) {
22
+            $url = $all_data["url"];
23
+        } else {
24
+            throw new Exception("url is not exist in all_data");
25
+        }
26
+        if(isset($all_data["data"])) {
27
+            $data = $all_data["data"];
28
+        } else {
29
+            throw new Exception("data is not exist in all_data");
30
+        }
31
+        if(isset($all_data["oj"])) {
32
+            $oj = $all_data["oj"];
33
+        } else {
34
+            throw new Exception("oj is not exist in all_data");
35
+        }
36
+        if(isset($all_data["ret"])) {
37
+            $ret = $all_data["ret"];
38
+        } else {
39
+            $ret = 'false';
40
+        }
41
+        if(isset($all_data["handle"])) {
42
+            $handle = $all_data["handle"];
43
+        } else {
44
+            $handle = "default";
45
+        }
26 46
 
27 47
         $datapost=curl_init();
28 48
         $headers=array("Expect:");
@@ -54,12 +74,36 @@  discard block
 block discarded – undo
54 74
 
55 75
     public function grab_page($all_data)
56 76
     {
57
-        if(isset($all_data["site"]))    $site = $all_data["site"];          else throw new Exception("site is not exist in all_data");
58
-        if(isset($all_data["oj"]))      $oj = $all_data["oj"];              else throw new Exception("oj is not exist in all_data");
59
-        if(isset($all_data["headers"])) $headers = $all_data["headers"];    else $headers = [];
60
-        if(isset($all_data["handle"]))  $handle = $all_data["handle"];      else $handle = "default";
61
-        if(isset($all_data["follow"]))  $follow = $all_data["follow"];      else $follow = false;
62
-        if(isset($all_data["vcid"]))  $vcid = $all_data["vcid"];      else $vcid = "";
77
+        if(isset($all_data["site"])) {
78
+            $site = $all_data["site"];
79
+        } else {
80
+            throw new Exception("site is not exist in all_data");
81
+        }
82
+        if(isset($all_data["oj"])) {
83
+            $oj = $all_data["oj"];
84
+        } else {
85
+            throw new Exception("oj is not exist in all_data");
86
+        }
87
+        if(isset($all_data["headers"])) {
88
+            $headers = $all_data["headers"];
89
+        } else {
90
+            $headers = [];
91
+        }
92
+        if(isset($all_data["handle"])) {
93
+            $handle = $all_data["handle"];
94
+        } else {
95
+            $handle = "default";
96
+        }
97
+        if(isset($all_data["follow"])) {
98
+            $follow = $all_data["follow"];
99
+        } else {
100
+            $follow = false;
101
+        }
102
+        if(isset($all_data["vcid"])) {
103
+            $vcid = $all_data["vcid"];
104
+        } else {
105
+            $vcid = "";
106
+        }
63 107
 
64 108
         $handle=urlencode($handle);
65 109
 
@@ -86,16 +130,56 @@  discard block
 block discarded – undo
86 130
 
87 131
     public function post_data($all_data)
88 132
     {
89
-        if(isset($all_data["site"]))         $site = $all_data["site"];                 else throw new Exception("site is not exist in all_data");
90
-        if(isset($all_data["data"]))         $data = $all_data["data"];                 else throw new Exception("data is not exist in all_data");
91
-        if(isset($all_data["oj"]))           $oj = $all_data["oj"];                     else throw new Exception("oj is not exist in all_data");
92
-        if(isset($all_data["ret"]))          $ret = $all_data["ret"];                   else $ret = false;
93
-        if(isset($all_data["follow"]))       $follow = $all_data["follow"];             else $follow = true;
94
-        if(isset($all_data["returnHeader"])) $returnHeader = $all_data["returnHeader"]; else $returnHeader = true;
95
-        if(isset($all_data["postJson"]))     $postJson = $all_data["postJson"];         else $postJson = false;
96
-        if(isset($all_data["extraHeaders"])) $extraHeaders = $all_data["extraHeaders"]; else $extraHeaders = [];
97
-        if(isset($all_data["handle"]))       $handle = $all_data["handle"];             else $handle = "default";
98
-        if(isset($all_data["vcid"]))  $vcid = $all_data["vcid"];      else $vcid = "";
133
+        if(isset($all_data["site"])) {
134
+            $site = $all_data["site"];
135
+        } else {
136
+            throw new Exception("site is not exist in all_data");
137
+        }
138
+        if(isset($all_data["data"])) {
139
+            $data = $all_data["data"];
140
+        } else {
141
+            throw new Exception("data is not exist in all_data");
142
+        }
143
+        if(isset($all_data["oj"])) {
144
+            $oj = $all_data["oj"];
145
+        } else {
146
+            throw new Exception("oj is not exist in all_data");
147
+        }
148
+        if(isset($all_data["ret"])) {
149
+            $ret = $all_data["ret"];
150
+        } else {
151
+            $ret = false;
152
+        }
153
+        if(isset($all_data["follow"])) {
154
+            $follow = $all_data["follow"];
155
+        } else {
156
+            $follow = true;
157
+        }
158
+        if(isset($all_data["returnHeader"])) {
159
+            $returnHeader = $all_data["returnHeader"];
160
+        } else {
161
+            $returnHeader = true;
162
+        }
163
+        if(isset($all_data["postJson"])) {
164
+            $postJson = $all_data["postJson"];
165
+        } else {
166
+            $postJson = false;
167
+        }
168
+        if(isset($all_data["extraHeaders"])) {
169
+            $extraHeaders = $all_data["extraHeaders"];
170
+        } else {
171
+            $extraHeaders = [];
172
+        }
173
+        if(isset($all_data["handle"])) {
174
+            $handle = $all_data["handle"];
175
+        } else {
176
+            $handle = "default";
177
+        }
178
+        if(isset($all_data["vcid"])) {
179
+            $vcid = $all_data["vcid"];
180
+        } else {
181
+            $vcid = "";
182
+        }
99 183
 
100 184
         $handle=urlencode($handle);
101 185
 
Please login to merge, or discard this patch.