BoardController::editor() - Code Metrics - Inspection of "Update Contest Detail" - ZsgsDesign/NOJ - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#257)

unknown

created 2019-08-12 07:19 UTC

BoardController::editor() C

↳ Parent: BoardController

Complexity

Conditions	11
Paths	9

Size

Total Lines	70
Code Lines	57

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	11
eloc	57
nc	9
nop	2
dl	0
loc	70
rs	6.7915
c	0
b	0
f	0

How to fix Long Method Complexity

<?php

namespace App\Http\Controllers\Contest;

use App\Models\ContestModel;
use App\Models\ProblemModel;
use App\Models\CompilerModel;
use App\Models\Submission\SubmissionModel;
use App\Models\AccountModel;
use App\Http\Controllers\Controller;
use Illuminate\Http\Request;
use Auth;
use Redirect;

class BoardController extends Controller
{
    /**
     * Redirect the Contest Board Page.
     *
     * @return Response

     */
    public function board($cid)
    {
        return Redirect::route('contest.challenge', ['cid' => $cid]);

    }

    /**
     * Show the Contest Challenge Page.
     *
     * @return Response
     */
    public function challenge($cid)
    {
        $contestModel=new ContestModel();
        $clearance=$contestModel->judgeClearance($cid, Auth::user()->id);
        $basicInfo=$contestModel->basic($cid);
        if (!$clearance || time() < strtotime($basicInfo['begin_time'])) {
            if($clearance == 3){
                return Redirect::route('contest.admin', ['cid' => $cid]);

            }else{
                return Redirect::route('contest.detail', ['cid' => $cid]);

            }
        }
        $contest_name=$contestModel->contestName($cid);
        $contest_rule=$contestModel->contestRule($cid);
        $problemSet=$contestModel->contestProblems($cid, Auth::user()->id);
        $remainingTime=$contestModel->remainingTime($cid);
        $customInfo=$contestModel->getCustomInfo($cid);
        $clarificationList=$contestModel->getLatestClarification($cid);
        if ($remainingTime<=0) {
            $remainingTime=0;
        }
        if($basicInfo['public'] && !$basicInfo['audit_status']){
            return Redirect::route('contest.detail', ['cid' => $cid]);

        }
        return view('contest.board.challenge', [

            'page_title'=>"Challenge",
            'navigation' => "Contest",
            'site_title'=>$contest_name,
            'cid'=>$cid,
            'contest_name'=>$contest_name,
            'contest_rule'=>$contest_rule,
            'problem_set'=> $problemSet,
            'remaining_time'=>$remainingTime,
            'custom_info' => $customInfo,
            'clarification_list' => $clarificationList,
            'clearance'=> $clearance,
            'basic'=>$basicInfo,
        ]);
    }

    /**
     * Show the Contest Editor Page.
     *
     * @return Response
     */
    public function editor($cid, $ncode)
    {
        $contestModel=new ContestModel();
        $problemModel=new ProblemModel();
        $compilerModel=new CompilerModel();
        $submissionModel=new SubmissionModel();
        $accountModel=new AccountModel();
        $clearance=$contestModel->judgeClearance($cid, Auth::user()->id);
        $basicInfo=$contestModel->basic($cid);
        if (!$clearance || time() < strtotime($basicInfo['begin_time'])) {
            if($clearance == 3){
                return Redirect::route('contest.admin', ['cid' => $cid]);

            }else{
                return Redirect::route('contest.detail', ['cid' => $cid]);

            }
        }
        $basicInfo=$contestModel->basic($cid);
        if($basicInfo['public'] && !$basicInfo['audit_status']){
            return Redirect::route('contest.detail', ['cid' => $cid]);

        }
        $contest_name=$contestModel->contestName($cid);
        $contest_rule=$contestModel->rule($cid);
        $contest_ended=$contestModel->isContestEnded($cid);
        $pid=$contestModel->getPid($cid, $ncode);
        if (empty($pid)) {
            return Redirect::route('contest.board', ['cid' => $cid]);

        }
        $pcode=$problemModel->pcode($pid);

        $prob_detail=$problemModel->detail($pcode, $cid);
        if ($problemModel->isBlocked($prob_detail["pid"], $cid)) {
            return abort('403');
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {
        }
        $compiler_list=$compilerModel->list($prob_detail["OJ"], $prob_detail["pid"]);
        $prob_status=$submissionModel->getProblemStatus($prob_detail["pid"], Auth::user()->id, $cid);
        $problemSet=$contestModel->contestProblems($cid, Auth::user()->id);
        $compiler_pref=$compilerModel->pref($compiler_list, $prob_detail["pid"], Auth::user()->id, $cid);
        $pref=$compiler_pref["pref"];
        $submit_code=$compiler_pref["code"];
        $oj_detail=$problemModel->ojdetail($prob_detail["OJ"]);

        if (empty($prob_status)) {
            $prob_status=[
                "verdict"=>"NOT SUBMIT",
                "color"=>""
            ];
        }

        $editor_left_width = $accountModel->getExtra(Auth::user()->id, 'editor_left_width');
        if(empty($editor_left_width)) $editor_left_width='40';

        return view('contest.board.editor', [

            'page_title'=>"Problem Detail",
            'navigation' => "Contest",
            'site_title'=>$contest_name,
            'contest_name'=>$contest_name,
            'cid'=> $cid,
            'detail' => $prob_detail,
            'compiler_list' => $compiler_list,
            'status' => $prob_status,
            'pref' => $pref<0 ? 0 : $pref,
            'submit_code' => $submit_code,
            'contest_mode' => true,
            'contest_ended' => $contest_ended,
            'ncode' => $ncode,
            'contest_rule' => $contest_rule,
            'problem_set' => $problemSet,
            'clearance' => $clearance,
            'oj_detail' => $oj_detail,
            'editor_left_width'=>$editor_left_width,
        ]);
    }

    /**
     * Show the Contest Rank Page.
     *
     * @return Response
     */
    public function rank($cid)
    {
        $contestModel=new ContestModel();
        $clearance=$contestModel->judgeClearance($cid, Auth::user()->id);
        $basicInfo=$contestModel->basic($cid);
        if (!$clearance || time() < strtotime($basicInfo['begin_time'])) {
            if($clearance == 3){
                return Redirect::route('contest.admin', ['cid' => $cid]);

            }else{
                return Redirect::route('contest.detail', ['cid' => $cid]);

            }
        }
        $basicInfo=$contestModel->basic($cid);
        if($basicInfo['public'] && !$basicInfo['audit_status']){
            return Redirect::route('contest.detail', ['cid' => $cid]);

        }
        $contest_name=$contestModel->contestName($cid);
        $contest_rule=$contestModel->contestRule($cid);
        $problemSet=$contestModel->contestProblems($cid, Auth::user()->id);
        $customInfo=$contestModel->getCustomInfo($cid);
        $contestRank=$contestModel->contestRank($cid, Auth::user()->id);

        // To determine the ranking
        foreach ($contestRank as $i => &$r) {
            if($i != 0) {
                if($r['score'] == $contestRank[$i-1]['score'] && $r['penalty'] == $contestRank[$i-1]['penalty']){
                    $r['rank'] = $contestRank[$i-1]['rank'];
                }else{
                    $r['rank'] = $i + 1;
                }
            }else{
                $r['rank'] = 1;
            }
        }
        $rankFrozen=$contestModel->isFrozen($cid);
        $frozenTime=$contestModel->frozenTime($cid);
        return view('contest.board.rank', [

            'page_title'=>"Rank",
            'navigation' => "Contest",
            'site_title'=>$contest_name,
            'contest_name'=>$contest_name,
            'contest_rule'=>$contest_rule,
            'cid'=>$cid,
            'problem_set'=>$problemSet,
            'custom_info' => $customInfo,
            'contest_rank' => $contestRank,
            'rank_frozen' => $rankFrozen,
            'frozen_time' => $frozenTime,
            'clearance'=> $clearance,
            'basic'=>$basicInfo,
        ]);
    }

    /**
     * Show the Contest Status Page.
     *
     * @return Response
     */
    public function status(Request $request)
    {
        $all_data=$request->all();
        $filter["ncode"]=isset($all_data["ncode"]) ? $all_data["ncode"] : null;

        $filter["result"]=isset($all_data["result"]) ? $all_data["result"] : null;
        $filter["account"]=isset($all_data["account"]) ? $all_data["account"] : null;
        $cid=$request->cid;
        $contestModel=new ContestModel();
        $clearance=$contestModel->judgeClearance($cid, Auth::user()->id);
        $basicInfo=$contestModel->basic($cid);
        if (!$clearance || time() < strtotime($basicInfo['begin_time'])) {
            if($clearance == 3){
                return Redirect::route('contest.admin', ['cid' => $cid]);

            }else{
                return Redirect::route('contest.detail', ['cid' => $cid]);

            }
        }
        $basicInfo=$contestModel->basic($cid);
        if($basicInfo['public'] && !$basicInfo['audit_status']){
            return Redirect::route('contest.detail', ['cid' => $cid]);

        }
        $contest_name=$contestModel->contestName($cid);
        $customInfo=$contestModel->getCustomInfo($cid);
        $submissionRecordSet=$contestModel->getContestRecord($filter, $cid);
        $rankFrozen=$contestModel->isFrozen($cid);
        $frozenTime=$contestModel->frozenTime($cid);
        return view('contest.board.status', [

            'page_title'=>"Status",
            'navigation' => "Contest",
            'site_title'=>$contest_name,
            'contest_name'=>$contest_name,
            'basic_info'=>$basicInfo,
            'cid'=>$cid,
            'custom_info' => $customInfo,
            'submission_record' => $submissionRecordSet,
            'rank_frozen' => $rankFrozen,
            'frozen_time' => $frozenTime,
            'clearance'=> $clearance,
            'filter' => $filter,
        ]);
    }

    /**
     * Show the Contest Clarification Page.
     *
     * @return Response
     */
    public function clarification($cid)
    {
        $contestModel=new ContestModel();
        $clearance=$contestModel->judgeClearance($cid, Auth::user()->id);
        $basicInfo=$contestModel->basic($cid);
        if (!$clearance || time() < strtotime($basicInfo['begin_time'])) {
            if($clearance == 3){
                return Redirect::route('contest.admin', ['cid' => $cid]);

            }else{
                return Redirect::route('contest.detail', ['cid' => $cid]);

            }
        }
        if($basicInfo['public'] && !$basicInfo['audit_status']){
            return Redirect::route('contest.detail', ['cid' => $cid]);

        }
        $contest_name=$contestModel->contestName($cid);
        $customInfo=$contestModel->getCustomInfo($cid);
        $clarificationList=$contestModel->getClarificationList($cid);
        $contest_ended=$contestModel->isContestEnded($cid);
        return view('contest.board.clarification', [

            'page_title'=>"Clarification",
            'navigation' => "Contest",
            'site_title'=>$contest_name,
            'contest_name'=>$contest_name,
            'cid'=>$cid,
            'custom_info' => $customInfo,
            'clarification_list' => $clarificationList,
            'contest_ended' => $contest_ended,
            'clearance'=> $clearance,
            'basic'=>$basicInfo,
        ]);
    }

    /**
     * Show the Contest Print Page.
     *
     * @return Response
     */
    public function print($cid)
    {
        $contestModel=new ContestModel();
        $clearance=$contestModel->judgeClearance($cid, Auth::user()->id);
        $basicInfo=$contestModel->basic($cid);
        if (!$clearance || time() < strtotime($basicInfo['begin_time'])) {
            if($clearance == 3){
                return Redirect::route('contest.admin', ['cid' => $cid]);

            }else{
                return Redirect::route('contest.detail', ['cid' => $cid]);

            }
        }
        if($basicInfo['public'] && !$basicInfo['audit_status']){
            return Redirect::route('contest.detail', ['cid' => $cid]);

        }
        $contest_name=$contestModel->contestName($cid);
        $customInfo=$contestModel->getCustomInfo($cid);
        return view('contest.board.print', [

            'page_title'=>"Print",
            'navigation' => "Contest",
            'site_title'=>$contest_name,
            'contest_name'=>$contest_name,
            'cid'=>$cid,
            'custom_info' => $customInfo,
            'clearance'=> $clearance,
            'basic'=>$basicInfo,
        ]);
    }

    public function analysis($cid){
        $contestModel=new ContestModel();
        $clearance=$contestModel->judgeClearance($cid, Auth::user()->id);
        $basicInfo=$contestModel->basic($cid);
        if (!$clearance || time() < strtotime($basicInfo['begin_time'])) {
            if($clearance == 3){
                return Redirect::route('contest.admin', ['cid' => $cid]);
            }else{
                return Redirect::route('contest.detail', ['cid' => $cid]);
            }
        }
        $basicInfo=$contestModel->basic($cid);
        if($basicInfo['public'] && !$basicInfo['audit_status']){
            return Redirect::route('contest.detail', ['cid' => $cid]);
        }
        $contest_name=$contestModel->contestName($cid);
        $customInfo=$contestModel->getCustomInfo($cid);
        return view('contest.board.analysis', [
            'page_title'=>"Analysis",
            'navigation' => "Contest",
            'site_title'=>$contest_name,
            'contest_name'=>$contest_name,
            'cid'=>$cid,
            'custom_info' => $customInfo,
            'clearance'=> $clearance,
            'basic'=>$basicInfo,
        ]);
    }
}


1			<?php
2
3			namespace App\Http\Controllers\Contest;
4
5			use App\Models\ContestModel;
6			use App\Models\ProblemModel;
7			use App\Models\CompilerModel;
8			use App\Models\Submission\SubmissionModel;
9			use App\Models\AccountModel;
10			use App\Http\Controllers\Controller;
11			use Illuminate\Http\Request;
12			use Auth;
13			use Redirect;
14
15			class BoardController extends Controller
16			{
17			/**
18			* Redirect the Contest Board Page.
19			*
20			* @return Response
			0 ignored issues – show Bug introduced 2019-08-04 18:59 UTC by Report Bug Copy Issue Report The type `App\Http\Controllers\Contest\Response` was not found. Did you mean `Response`? If so, make sure to prefix the type with `\`. Loading history...
21			*/
22			public function board($cid)
23			{
24			return Redirect::route('contest.challenge', ['cid' => $cid]);
			0 ignored issues – show Bug Best Practice introduced 2019-08-04 18:59 UTC by Report Bug Copy Issue Report The expression `return Redirect::route('..., array('cid' => $cid))` returns the type `Illuminate\Http\RedirectResponse` which is incompatible with the documented return type `App\Http\Controllers\Contest\Response`. Loading history...
25			}
26
27			/**
28			* Show the Contest Challenge Page.
29			*
30			* @return Response
31			*/
32			public function challenge($cid)
33			{
34			$contestModel=new ContestModel();
35			$clearance=$contestModel->judgeClearance($cid, Auth::user()->id);
36			$basicInfo=$contestModel->basic($cid);
37			if (!$clearance \|\| time() < strtotime($basicInfo['begin_time'])) {
38			if($clearance == 3){

ZsgsDesign / NOJ

Pull Request — master (#257)

BoardController::editor() C

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like