Passed
Pull Request — master (#744)
by John
06:52
created
app/Models/Eloquent/Group.php 1 patch
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -66,21 +66,21 @@
 block discarded – undo
66 66
 
67 67
             // Create Homework Itself
68 68
 
69
-            $newHomework = new GroupHomework();
69
+            $newHomework=new GroupHomework();
70 70
 
71
-            $newHomework->title = $title;
72
-            $newHomework->description = $description;
73
-            $newHomework->ended_at = $endedAt;
74
-            $newHomework->is_simple = 1;
71
+            $newHomework->title=$title;
72
+            $newHomework->description=$description;
73
+            $newHomework->ended_at=$endedAt;
74
+            $newHomework->is_simple=1;
75 75
             $this->homework()->save($newHomework);
76 76
 
77 77
             // Created Related Problem List
78 78
 
79
-            $problemIndex = 1;
79
+            $problemIndex=1;
80 80
             foreach ($problems as $problem) {
81
-                $newProblem = new GroupHomeworkProblem();
82
-                $newProblem->problem_id = $problem['pid'];
83
-                $newProblem->order_index = $problemIndex++;
81
+                $newProblem=new GroupHomeworkProblem();
82
+                $newProblem->problem_id=$problem['pid'];
83
+                $newProblem->order_index=$problemIndex++;
84 84
                 $newHomework->problems()->save($newProblem);
85 85
             }
86 86
 
Please login to merge, or discard this patch.
app/Exceptions/Handler.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -12,7 +12,7 @@  discard block
 block discarded – undo
12 12
      *
13 13
      * @var array
14 14
      */
15
-    protected $dontReport = [
15
+    protected $dontReport=[
16 16
         //
17 17
     ];
18 18
 
@@ -21,7 +21,7 @@  discard block
 block discarded – undo
21 21
      *
22 22
      * @var array
23 23
      */
24
-    protected $dontFlash = [
24
+    protected $dontFlash=[
25 25
         'current_password',
26 26
         'password',
27 27
         'password_confirmation',
@@ -34,7 +34,7 @@  discard block
 block discarded – undo
34 34
      */
35 35
     public function register()
36 36
     {
37
-        $this->reportable(function (Throwable $e) {
37
+        $this->reportable(function(Throwable $e) {
38 38
             //
39 39
         });
40 40
     }
Please login to merge, or discard this patch.
app/Console/Commands/Install/Install.php 1 patch
Spacing   +10 added lines, -10 removed lines patch added patch discarded remove patch
@@ -78,10 +78,10 @@  discard block
 block discarded – undo
78 78
         $this->initSystemCheck();
79 79
         return;
80 80
         if ($this->confirm('Do you wish to continue?')) {
81
-            if(!$this->acceptLicense()){
81
+            if (!$this->acceptLicense()) {
82 82
                 return;
83 83
             }
84
-            if($this->createFrontAdminUser()){
84
+            if ($this->createFrontAdminUser()) {
85 85
                 $this->createFrontAdminGroup();
86 86
             }
87 87
             $this->installBabelExtensionNOJ();
@@ -119,19 +119,19 @@  discard block
 block discarded – undo
119 119
     protected function createFrontAdminUser() {
120 120
         $this->line('Creating frontstage admin user...');
121 121
         $this->comment('');
122
-        $shallCreate = true;
122
+        $shallCreate=true;
123 123
         if (User::count()) {
124
-            $shallCreate = $this->confirm('Detected existing frontstage user, do you really want to create frontstage admin?');
124
+            $shallCreate=$this->confirm('Detected existing frontstage user, do you really want to create frontstage admin?');
125 125
             $this->comment('');
126 126
         }
127 127
         if (!$shallCreate) {
128 128
             return false;
129 129
         }
130
-        while(true) {
130
+        while (true) {
131 131
             try {
132
-                $createdUser = $this->createFrontUser();
132
+                $createdUser=$this->createFrontUser();
133 133
                 break;
134
-            } catch(Exception $e) {
134
+            } catch (Exception $e) {
135 135
                 $this->line("\n  <bg=red;fg=white> Exception </> : <fg=yellow>Error occured while creating admin user.</>\n");
136 136
                 continue;
137 137
             }
@@ -140,9 +140,9 @@  discard block
 block discarded – undo
140 140
     }
141 141
 
142 142
     private function createFrontUser() {
143
-        $username = $this->ask('Please choose a username:', 'admin');
144
-        $email = $this->ask('Please choose a email address:', '[email protected]');
145
-        $password = Hash::make(Str::random(8));
143
+        $username=$this->ask('Please choose a username:', 'admin');
144
+        $email=$this->ask('Please choose a email address:', '[email protected]');
145
+        $password=Hash::make(Str::random(8));
146 146
         $createdUser=User::create([
147 147
             'name' => $username,
148 148
             'email' => $email,
Please login to merge, or discard this patch.
app/Http/Controllers/DojoController.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -17,7 +17,7 @@
 block discarded – undo
17 17
      */
18 18
     public function index(Request $request)
19 19
     {
20
-        $status = Auth::check() ? Auth::user()->getDojoStatistics() : false;
20
+        $status=Auth::check() ? Auth::user()->getDojoStatistics() : false;
21 21
         return view('dojo.index', [
22 22
             'page_title' => "Dojo",
23 23
             'site_title' => config("app.name"),
Please login to merge, or discard this patch.
app/Babel/Judge/Judger.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -29,7 +29,7 @@
 block discarded – undo
29 29
 
30 30
         $result=$submissionModel->getWaitingSubmission();
31 31
 
32
-        $submissionCount = count($result);
32
+        $submissionCount=count($result);
33 33
 
34 34
         Log::channel('babel_judge_sync')->info("Currently $submissionCount submission(s) awaiting", [$result]);
35 35
 
Please login to merge, or discard this patch.
app/Models/Eloquent/User.php 1 patch
Spacing   +18 added lines, -18 removed lines patch added patch discarded remove patch
@@ -180,27 +180,27 @@  discard block
 block discarded – undo
180 180
         return $socialites;
181 181
     }
182 182
 
183
-    public function problems_latest_submission($problems, $contestID = null, Carbon $till = null, $verdictFilter = [])
183
+    public function problems_latest_submission($problems, $contestID=null, Carbon $till=null, $verdictFilter=[])
184 184
     {
185 185
         if (filled($contestID)) {
186
-            $endedAt = Carbon::parse(Contest::findOrFail($contestID)->endedAt);
186
+            $endedAt=Carbon::parse(Contest::findOrFail($contestID)->endedAt);
187 187
         }
188 188
 
189
-        $lastRecordSubQuery = $this->submissions()->select('pid', DB::raw('MAX(submission_date) as submission_date'))->whereIntegerInRaw('pid', $problems)->where('cid', $contestID)->groupBy('pid');
189
+        $lastRecordSubQuery=$this->submissions()->select('pid', DB::raw('MAX(submission_date) as submission_date'))->whereIntegerInRaw('pid', $problems)->where('cid', $contestID)->groupBy('pid');
190 190
 
191 191
         if (filled($contestID)) {
192
-            $lastRecordSubQuery = $lastRecordSubQuery->where("submission_date", "<", $endedAt->timestamp);
192
+            $lastRecordSubQuery=$lastRecordSubQuery->where("submission_date", "<", $endedAt->timestamp);
193 193
         }
194 194
 
195 195
         if (filled($till)) {
196
-            $lastRecordSubQuery = $lastRecordSubQuery->where("submission_date", "<", $till->timestamp);
196
+            $lastRecordSubQuery=$lastRecordSubQuery->where("submission_date", "<", $till->timestamp);
197 197
         }
198 198
 
199
-        if(filled($verdictFilter)) {
200
-            $lastRecordSubQuery = $lastRecordSubQuery->whereIn('verdict', $verdictFilter);
199
+        if (filled($verdictFilter)) {
200
+            $lastRecordSubQuery=$lastRecordSubQuery->whereIn('verdict', $verdictFilter);
201 201
         }
202 202
 
203
-        $query = DB::table(DB::raw("({$lastRecordSubQuery->toSql()}) last_sub"))->leftJoinSub(Submission::toBase(), 'submissions', function ($join) {
203
+        $query=DB::table(DB::raw("({$lastRecordSubQuery->toSql()}) last_sub"))->leftJoinSub(Submission::toBase(), 'submissions', function($join) {
204 204
             $join->on('last_sub.submission_date', '=', 'submissions.submission_date')->on('last_sub.pid', '=', 'submissions.pid');
205 205
         })->select('sid', 'last_sub.submission_date as submission_date', 'last_sub.pid as pid', 'verdict', 'color')->orderBy('pid', 'ASC');
206 206
 
@@ -210,40 +210,40 @@  discard block
 block discarded – undo
210 210
     public function getDojoStatistics()
211 211
     {
212 212
         try {
213
-            $statistics = [];
214
-            $problemIDArr = DojoProblem::select('problem_id')->distinct()->get()->pluck('problem_id');
213
+            $statistics=[];
214
+            $problemIDArr=DojoProblem::select('problem_id')->distinct()->get()->pluck('problem_id');
215 215
 
216 216
             foreach ($problemIDArr as $problemID) {
217
-                $statistics[$problemID] = [
217
+                $statistics[$problemID]=[
218 218
                     "icon" => "checkbox-blank-circle-outline",
219 219
                     "color" => "wemd-grey-text"
220 220
                 ];
221 221
             }
222 222
 
223
-            $problemCompleteIDArr = [];
223
+            $problemCompleteIDArr=[];
224 224
 
225 225
             foreach ($this->problems_latest_submission($problemIDArr->diff($problemCompleteIDArr), null, null, ['Accepted'])->get() as $acceptedRecord) {
226
-                $statistics[$acceptedRecord['pid']] = [
226
+                $statistics[$acceptedRecord['pid']]=[
227 227
                     "icon" => "checkbox-blank-circle",
228 228
                     "color" => $acceptedRecord['color']
229 229
                 ];
230
-                $problemCompleteIDArr[] = $acceptedRecord['pid'];
230
+                $problemCompleteIDArr[]=$acceptedRecord['pid'];
231 231
             }
232 232
 
233 233
             foreach ($this->problems_latest_submission($problemIDArr->diff($problemCompleteIDArr), null, null, ['Partially Accepted'])->get() as $acceptedRecord) {
234
-                $statistics[$acceptedRecord['pid']] = [
234
+                $statistics[$acceptedRecord['pid']]=[
235 235
                     "icon" => "cisco-webex",
236 236
                     "color" => $acceptedRecord['color']
237 237
                 ];
238
-                $problemCompleteIDArr[] = $acceptedRecord['pid'];
238
+                $problemCompleteIDArr[]=$acceptedRecord['pid'];
239 239
             }
240 240
 
241 241
             foreach ($this->problems_latest_submission($problemIDArr->diff($problemCompleteIDArr), null, null)->get() as $acceptedRecord) {
242
-                $statistics[$acceptedRecord['pid']] = [
242
+                $statistics[$acceptedRecord['pid']]=[
243 243
                     "icon" => "cisco-webex",
244 244
                     "color" => $acceptedRecord['color']
245 245
                 ];
246
-                $problemCompleteIDArr[] = $acceptedRecord['pid'];
246
+                $problemCompleteIDArr[]=$acceptedRecord['pid'];
247 247
             }
248 248
 
249 249
             return $statistics;
Please login to merge, or discard this patch.
app/Admin/Controllers/ApiController.php 1 patch
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -10,20 +10,20 @@  discard block
 block discarded – undo
10 10
 
11 11
 class ApiController extends AdminController
12 12
 {
13
-    protected function paginate($items, $perPage = 15)
13
+    protected function paginate($items, $perPage=15)
14 14
     {
15
-        $currentPage = Paginator::resolveCurrentPage();
16
-        $offSet = ($currentPage * $perPage) - $perPage;
17
-        $itemsForCurrentPage = array_slice($items, $offSet, $perPage, true);
18
-        $paginator = new LengthAwarePaginator($itemsForCurrentPage, count($items), $perPage, $currentPage, ['path' => Paginator::resolveCurrentPath()]);
15
+        $currentPage=Paginator::resolveCurrentPage();
16
+        $offSet=($currentPage * $perPage)-$perPage;
17
+        $itemsForCurrentPage=array_slice($items, $offSet, $perPage, true);
18
+        $paginator=new LengthAwarePaginator($itemsForCurrentPage, count($items), $perPage, $currentPage, ['path' => Paginator::resolveCurrentPath()]);
19 19
         return $paginator;
20 20
     }
21 21
 
22 22
     public function problems()
23 23
     {
24
-        $q = request()->q;
24
+        $q=request()->q;
25 25
 
26
-        return $this->paginate(Problem::like('pcode', $q)->orLike('title', $q)->orderBy('pcode', 'asc')->get()->values()->transform(function ($problem) {
26
+        return $this->paginate(Problem::like('pcode', $q)->orLike('title', $q)->orderBy('pcode', 'asc')->get()->values()->transform(function($problem) {
27 27
             return [
28 28
                 'id' => $problem->pid,
29 29
                 'text' => $problem->readable_name,
@@ -33,9 +33,9 @@  discard block
 block discarded – undo
33 33
 
34 34
     public function users()
35 35
     {
36
-        $q = request()->q;
36
+        $q=request()->q;
37 37
 
38
-        return $this->paginate(User::like('name', $q)->orLike('email', $q)->orderBy('id', 'asc')->get()->values()->transform(function ($user) {
38
+        return $this->paginate(User::like('name', $q)->orLike('email', $q)->orderBy('id', 'asc')->get()->values()->transform(function($user) {
39 39
             return [
40 40
                 'id' => $user->id,
41 41
                 'text' => $user->readable_name,
Please login to merge, or discard this patch.
app/Console/Commands/Scheduling/UpdateTrendingGroups.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -42,7 +42,7 @@
 block discarded – undo
42 42
         $time=Carbon::now();
43 43
         $this->line("<fg=yellow>[$time] Processing:  </>Update Trending Groups");
44 44
 
45
-        $groupModel = new GroupModel();
45
+        $groupModel=new GroupModel();
46 46
         $groupModel->cacheTrendingGroups();
47 47
 
48 48
         $time=Carbon::now();
Please login to merge, or discard this patch.
app/Models/Eloquent/Problem.php 1 patch
Spacing   +30 added lines, -30 removed lines patch added patch discarded remove patch
@@ -15,9 +15,9 @@  discard block
 block discarded – undo
15 15
 {
16 16
     use LikeScope;
17 17
 
18
-    protected $table = 'problem';
19
-    protected $primaryKey = 'pid';
20
-    const UPDATED_AT = "update_date";
18
+    protected $table='problem';
19
+    protected $primaryKey='pid';
20
+    const UPDATED_AT="update_date";
21 21
 
22 22
     protected function serializeDate(DateTimeInterface $date)
23 23
     {
@@ -26,7 +26,7 @@  discard block
 block discarded – undo
26 26
 
27 27
     public function getReadableNameAttribute()
28 28
     {
29
-        return $this->pcode . '. ' . $this->title;
29
+        return $this->pcode.'. '.$this->title;
30 30
     }
31 31
 
32 32
     public function submissions()
@@ -54,16 +54,16 @@  discard block
 block discarded – undo
54 54
         return $this->getProblemStatus();
55 55
     }
56 56
 
57
-    public function getProblemStatus($userID = null, $contestID = null, Carbon $till = null)
57
+    public function getProblemStatus($userID=null, $contestID=null, Carbon $till=null)
58 58
     {
59 59
         if (blank($userID)) {
60 60
             if (Auth::guard('web')->check()) {
61
-                $userID = Auth::guard('web')->user()->id;
61
+                $userID=Auth::guard('web')->user()->id;
62 62
             }
63 63
         }
64 64
 
65 65
         if (filled($userID)) {
66
-            $probStatus = $this->getProblemStatusFromDB($userID, $contestID, $till);
66
+            $probStatus=$this->getProblemStatusFromDB($userID, $contestID, $till);
67 67
             if (blank($probStatus)) {
68 68
                 return [
69 69
                     "icon" => "checkbox-blank-circle-outline",
@@ -71,7 +71,7 @@  discard block
 block discarded – undo
71 71
                 ];
72 72
             } else {
73 73
                 return [
74
-                    "icon" => $probStatus->verdict == "Accepted" ? "checkbox-blank-circle" : "cisco-webex",
74
+                    "icon" => $probStatus->verdict=="Accepted" ? "checkbox-blank-circle" : "cisco-webex",
75 75
                     "color" => $probStatus->color
76 76
                 ];
77 77
             }
@@ -83,13 +83,13 @@  discard block
 block discarded – undo
83 83
         }
84 84
     }
85 85
 
86
-    private function getProblemStatusFromDB($userID, $contestID = null, Carbon $till = null)
86
+    private function getProblemStatusFromDB($userID, $contestID=null, Carbon $till=null)
87 87
     {
88
-        $endedAt = Carbon::now();
88
+        $endedAt=Carbon::now();
89 89
 
90 90
         if (filled($contestID)) {
91 91
             try {
92
-                $endedAt = Carbon::parse(Contest::findOrFail($contestID)->endedAt);
92
+                $endedAt=Carbon::parse(Contest::findOrFail($contestID)->endedAt);
93 93
             } catch (Exception $e) {
94 94
                 return null;
95 95
             }
@@ -97,41 +97,41 @@  discard block
 block discarded – undo
97 97
 
98 98
         // Get the very first AC record
99 99
 
100
-        $acRecords = $this->submissions()->where([
100
+        $acRecords=$this->submissions()->where([
101 101
             'uid' => $userID,
102 102
             'cid' => $contestID,
103 103
             'verdict' => 'Accepted'
104 104
         ]);
105 105
         if (filled($contestID)) {
106
-            $acRecords = $acRecords->where("submission_date", "<", $endedAt->timestamp);
106
+            $acRecords=$acRecords->where("submission_date", "<", $endedAt->timestamp);
107 107
         }
108 108
         if (filled($till)) {
109
-            $acRecords = $acRecords->where("submission_date", "<", $till->timestamp);
109
+            $acRecords=$acRecords->where("submission_date", "<", $till->timestamp);
110 110
         }
111
-        $acRecords = $acRecords->orderBy('submission_date', 'desc')->first();
111
+        $acRecords=$acRecords->orderBy('submission_date', 'desc')->first();
112 112
         if (blank($acRecords)) {
113
-            $pacRecords = $this->submissions()->where([
113
+            $pacRecords=$this->submissions()->where([
114 114
                 'uid' => $userID,
115 115
                 'cid' => $contestID,
116 116
                 'verdict' => 'Partially Accepted'
117 117
             ]);
118 118
             if (filled($contestID)) {
119
-                $pacRecords = $pacRecords->where("submission_date", "<", $endedAt->timestamp);
119
+                $pacRecords=$pacRecords->where("submission_date", "<", $endedAt->timestamp);
120 120
             }
121 121
             if (filled($till)) {
122
-                $pacRecords = $pacRecords->where("submission_date", "<", $till->timestamp);
122
+                $pacRecords=$pacRecords->where("submission_date", "<", $till->timestamp);
123 123
             }
124
-            $pacRecords = $pacRecords->orderBy('submission_date', 'desc')->first();
124
+            $pacRecords=$pacRecords->orderBy('submission_date', 'desc')->first();
125 125
             if (blank($pacRecords)) {
126
-                $otherRecords = $this->submissions()->where([
126
+                $otherRecords=$this->submissions()->where([
127 127
                     'uid' => $userID,
128 128
                     'cid' => $contestID
129 129
                 ]);
130 130
                 if (filled($contestID)) {
131
-                    $otherRecords = $otherRecords->where("submission_date", "<", $endedAt->timestamp);
131
+                    $otherRecords=$otherRecords->where("submission_date", "<", $endedAt->timestamp);
132 132
                 }
133 133
                 if (filled($till)) {
134
-                    $otherRecords = $otherRecords->where("submission_date", "<", $till->timestamp);
134
+                    $otherRecords=$otherRecords->where("submission_date", "<", $till->timestamp);
135 135
                 }
136 136
                 return $otherRecords->orderBy('submission_date', 'desc')->first();
137 137
             }
@@ -141,27 +141,27 @@  discard block
 block discarded – undo
141 141
         }
142 142
     }
143 143
 
144
-    public function users_latest_submission($users, $contestID = null, Carbon $till = null, $verdictFilter = [])
144
+    public function users_latest_submission($users, $contestID=null, Carbon $till=null, $verdictFilter=[])
145 145
     {
146 146
         if (filled($contestID)) {
147
-            $endedAt = Carbon::parse(Contest::findOrFail($contestID)->endedAt);
147
+            $endedAt=Carbon::parse(Contest::findOrFail($contestID)->endedAt);
148 148
         }
149 149
 
150
-        $lastRecordSubQuery = $this->submissions()->select('uid', DB::raw('MAX(submission_date) as submission_date'))->whereIntegerInRaw('uid', $users)->where('cid', $contestID)->groupBy('uid');
150
+        $lastRecordSubQuery=$this->submissions()->select('uid', DB::raw('MAX(submission_date) as submission_date'))->whereIntegerInRaw('uid', $users)->where('cid', $contestID)->groupBy('uid');
151 151
 
152 152
         if (filled($contestID)) {
153
-            $lastRecordSubQuery = $lastRecordSubQuery->where("submission_date", "<", $endedAt->timestamp);
153
+            $lastRecordSubQuery=$lastRecordSubQuery->where("submission_date", "<", $endedAt->timestamp);
154 154
         }
155 155
 
156 156
         if (filled($till)) {
157
-            $lastRecordSubQuery = $lastRecordSubQuery->where("submission_date", "<", $till->timestamp);
157
+            $lastRecordSubQuery=$lastRecordSubQuery->where("submission_date", "<", $till->timestamp);
158 158
         }
159 159
 
160
-        if(filled($verdictFilter)) {
161
-            $lastRecordSubQuery = $lastRecordSubQuery->whereIn('verdict', $verdictFilter);
160
+        if (filled($verdictFilter)) {
161
+            $lastRecordSubQuery=$lastRecordSubQuery->whereIn('verdict', $verdictFilter);
162 162
         }
163 163
 
164
-        $query = DB::table(DB::raw("({$lastRecordSubQuery->toSql()}) last_sub"))->leftJoinSub(Submission::toBase(), 'submissions', function ($join) {
164
+        $query=DB::table(DB::raw("({$lastRecordSubQuery->toSql()}) last_sub"))->leftJoinSub(Submission::toBase(), 'submissions', function($join) {
165 165
             $join->on('last_sub.submission_date', '=', 'submissions.submission_date')->on('last_sub.uid', '=', 'submissions.uid');
166 166
         })->select('sid', 'last_sub.submission_date as submission_date', 'last_sub.uid as uid', 'verdict', 'color')->orderBy('uid', 'ASC');
167 167
 
Please login to merge, or discard this patch.