ZsgsDesign / NOJ

app/Http/Controllers/UserController.php

Spacing +3 added lines, -3 removed lines

@@ -30,12 +30,12 @@
     {
         $accountModel=new AccountModel();
         $info=$accountModel->detail($uid);
-        if($info == null) {
+        if ($info==null) {
             return redirect("/");
         }
         $feed=$accountModel->feed($uid);
-        $extraInfo = User::find($uid)->getExtra(['gender', 'contact', 'school', 'country', 'location'], 0);
-        $socialiteInfo = User::find($uid)->getSocialiteInfo(0);
+        $extraInfo=User::find($uid)->getExtra(['gender', 'contact', 'school', 'country', 'location'], 0);
+        $socialiteInfo=User::find($uid)->getSocialiteInfo(0);
         return view("account.dashboard", [
             'page_title'=>$info["name"],
             'site_title'=>config("app.name"),

app/Http/Controllers/Ajax/AccountController.php

Spacing +46 added lines, -46 removed lines

@@ -15,7 +15,7 @@ 
 class AccountController extends Controller
 {
 
-    public function updateAvatar(Request $request){
+    public function updateAvatar(Request $request) {
         $isValid=$request->file('avatar')->isValid();
         if ($isValid) {
             $extension=$request->file('avatar')->extension();
@@ -42,7 +42,7 @@ 
         }
     }
 
-    public function changeBasicInfo(Request $request){
+    public function changeBasicInfo(Request $request) {
         $request->validate([
             "username" => [
                 "required",
@@ -53,98 +53,98 @@ 
             ],
             "describes" => "required|string|max:255"
         ]);
-        $username = $request->input('username');
-        $describes = $request->input('describes');
+        $username=$request->input('username');
+        $describes=$request->input('describes');
         $user=Auth::user();
-        if(!Auth::user()->contest_account){
-            $user->name = $username;
+        if (!Auth::user()->contest_account) {
+            $user->name=$username;
         }
-        $user->describes = $describes;
+        $user->describes=$describes;
         $user->save();
         return ResponseModel::success();
     }
 
-    public function changePassword(Request $request){
-        if(!$request->has('old_password') || !$request->has('new_password') || !$request->has('confirm_password')){
+    public function changePassword(Request $request) {
+        if (!$request->has('old_password') || !$request->has('new_password') || !$request->has('confirm_password')) {
             return ResponseModel::err(1003);
         }
-        $old_password = $request->input('old_password');
-        $new_password = $request->input('new_password');
-        $confirm_password = $request->input('confirm_password');
-        if($new_password != $confirm_password){
+        $old_password=$request->input('old_password');
+        $new_password=$request->input('new_password');
+        $confirm_password=$request->input('confirm_password');
+        if ($new_password!=$confirm_password) {
             return ResponseModel::err(2004);
         }
-        if(strlen($new_password) < 8 || strlen($old_password) < 8){
+        if (strlen($new_password)<8 || strlen($old_password)<8) {
             return ResponseModel::err(1006);
         }
-        $user = Auth::user();
-        if($user->hasIndependentPassword() && !Hash::check($old_password, $user->password)){
+        $user=Auth::user();
+        if ($user->hasIndependentPassword() && !Hash::check($old_password, $user->password)) {
             return ResponseModel::err(2005);
         }
-        $user->password = Hash::make($new_password);
+        $user->password=Hash::make($new_password);
         $user->save();
         return ResponseModel::success();
     }
 
-    public function checkEmailCooldown(Request $request){
-        $last_send = $request->session()->get('last_email_send');
-        if(empty($last_send) || time() - $last_send >= 300){
-            $request->session()->put('last_email_send',time());
-            return ResponseModel::success(200,null,0);
-        }else{
-            $cooldown =  300 - (time() - $last_send);
-            return ResponseModel::success(200,null,$cooldown);
+    public function checkEmailCooldown(Request $request) {
+        $last_send=$request->session()->get('last_email_send');
+        if (empty($last_send) || time()-$last_send>=300) {
+            $request->session()->put('last_email_send', time());
+            return ResponseModel::success(200, null, 0);
+        } else {
+            $cooldown=300-(time()-$last_send);
+            return ResponseModel::success(200, null, $cooldown);
         }
     }
 
-    public function changeExtraInfo(Request $request){
-        $input = $request->input();
-        $allow_change = ['gender','contact','school','country','location'];
-        foreach($input as $key => $value){
-            if(!in_array($key,$allow_change)){
+    public function changeExtraInfo(Request $request) {
+        $input=$request->input();
+        $allow_change=['gender', 'contact', 'school', 'country', 'location'];
+        foreach ($input as $key => $value) {
+            if (!in_array($key, $allow_change)) {
                 return ResponseModel::error(1007);
             }
         }
         foreach ($input as $key => $value) {
-            if(strlen($value) != 0){
+            if (strlen($value)!=0) {
                 Auth::user()->setExtra($key, $value, 0);
-            }else{
+            } else {
                 Auth::user()->setExtra($key, null);
             }
         }
         return ResponseModel::success();
     }
 
-    public function saveEditorWidth(Request $request){
-        $input = $request->input();
-        $allow_change = ['editor_left_width'];
-        foreach($input as $key => $value){
-            if(!in_array($key,$allow_change)){
+    public function saveEditorWidth(Request $request) {
+        $input=$request->input();
+        $allow_change=['editor_left_width'];
+        foreach ($input as $key => $value) {
+            if (!in_array($key, $allow_change)) {
                 return ResponseModel::error(1007);
             }
         }
         foreach ($input as $key => $value) {
-            if(strlen($value) != 0){
+            if (strlen($value)!=0) {
                 Auth::user()->setExtra($key, $value, 0);
-            }else{
+            } else {
                 Auth::user()->setExtra($key, null);
             }
         }
         return ResponseModel::success();
     }
 
-    public function saveEditorTheme(Request $request){
-        $input = $request->input();
-        $allow_change = ['editor_theme'];
-        foreach($input as $key => $value){
-            if(!in_array($key,$allow_change)){
+    public function saveEditorTheme(Request $request) {
+        $input=$request->input();
+        $allow_change=['editor_theme'];
+        foreach ($input as $key => $value) {
+            if (!in_array($key, $allow_change)) {
                 return ResponseModel::error(1007);
             }
         }
         foreach ($input as $key => $value) {
-            if(strlen($value) != 0){
+            if (strlen($value)!=0) {
                 Auth::user()->setExtra($key, $value, 0);
-            }else{
+            } else {
                 Auth::user()->setExtra($key, null);
             }
         }

Braces +4 added lines, -4 removed lines

@@ -91,7 +91,7 @@ 
         if(empty($last_send) || time() - $last_send >= 300){
             $request->session()->put('last_email_send',time());
             return ResponseModel::success(200,null,0);
-        }else{
+        } else{
             $cooldown =  300 - (time() - $last_send);
             return ResponseModel::success(200,null,$cooldown);
         }
@@ -108,7 +108,7 @@ 
         foreach ($input as $key => $value) {
             if(strlen($value) != 0){
                 Auth::user()->setExtra($key, $value, 0);
-            }else{
+            } else{
                 Auth::user()->setExtra($key, null);
             }
         }
@@ -126,7 +126,7 @@ 
         foreach ($input as $key => $value) {
             if(strlen($value) != 0){
                 Auth::user()->setExtra($key, $value, 0);
-            }else{
+            } else{
                 Auth::user()->setExtra($key, null);
             }
         }
@@ -144,7 +144,7 @@ 
         foreach ($input as $key => $value) {
             if(strlen($value) != 0){
                 Auth::user()->setExtra($key, $value, 0);
-            }else{
+            } else{
                 Auth::user()->setExtra($key, null);
             }
         }

app/Http/Controllers/Ajax/GroupManageController.php

Spacing +22 added lines, -22 removed lines

@@ -36,7 +36,7 @@ 
 
         $all_data=$request->all();
 
-        if(($all_data['public'] ?? 0) && ($all_data['practice'] ?? 0)){
+        if (($all_data['public'] ?? 0) && ($all_data['practice'] ?? 0)) {
             return ResponseModel::err(4007);
         }
 
@@ -67,7 +67,7 @@ 
             return ResponseModel::err(1003);
         }
 
-        $cid = $contestModel->arrangeContest($all_data["gid"], [
+        $cid=$contestModel->arrangeContest($all_data["gid"], [
             "assign_uid"=>Auth::user()->id,
             "name"=>$all_data["name"],
             "description"=>$all_data["description"],
@@ -78,7 +78,7 @@ 
             "public"=>$all_data["public"] ?? 0,
         ], $problemSet);
 
-        return ResponseModel::success(200,'Successful!',$cid);
+        return ResponseModel::success(200, 'Successful!', $cid);
     }
 
     public function changeGroupName(Request $request)
@@ -92,7 +92,7 @@ 
 
         $groupModel=new GroupModel();
         $clearance=$groupModel->judgeClearance($all_data["gid"], Auth::user()->id);
-        if ($clearance < 2){
+        if ($clearance<2) {
             return ResponseModel::err(2001);
         }
 
@@ -111,11 +111,11 @@ 
 
         $groupModel=new GroupModel();
         $clearance=$groupModel->judgeClearance($all_data["gid"], Auth::user()->id);
-        if ($clearance < 2){
+        if ($clearance<2) {
             return ResponseModel::err(2001);
         }
 
-        if ($all_data["join_policy"] < 1 || $all_data["join_policy"] > 3){
+        if ($all_data["join_policy"]<1 || $all_data["join_policy"]>3) {
             return ResponseModel::err(1007);
         }
 
@@ -129,7 +129,7 @@ 
             'gid' => 'required|integer',
         ]);
 
-        $all_data = $request->all();
+        $all_data=$request->all();
 
         if (!empty($request->file('img')) && $request->file('img')->isValid()) {
             $extension=$request->file('img')->extension();
@@ -141,7 +141,7 @@ 
 
         $groupModel=new GroupModel();
         $clearance=$groupModel->judgeClearance($all_data["gid"], Auth::user()->id);
-        if ($clearance < 2){
+        if ($clearance<2) {
             return ResponseModel::err(2001);
         }
 
@@ -179,18 +179,18 @@ 
         $clearance=$groupModel->judgeClearance($all_data["gid"], Auth::user()->id);
         $target_clearance=$groupModel->judgeClearance($all_data["gid"], $all_data['uid']);
 
-        if($target_clearance == -3){
+        if ($target_clearance==-3) {
             return ResponseModel::err(7004);
         }
 
-        if($target_clearance >= $clearance || $clearance < 2 || $all_data['permission'] >= $clearance){
+        if ($target_clearance>=$clearance || $clearance<2 || $all_data['permission']>=$clearance) {
             return ResponseModel::err(2001);
         }
 
         $groupModel->changeClearance($all_data['uid'], $all_data["gid"], $all_data['permission']);
 
-        $result_info = $groupModel->userProfile($all_data['uid'],$all_data["gid"]);
-        return ResponseModel::success(200,null,$result_info);
+        $result_info=$groupModel->userProfile($all_data['uid'], $all_data["gid"]);
+        return ResponseModel::success(200, null, $result_info);
     }
 
     public function approveMember(Request $request)
@@ -206,7 +206,7 @@ 
         $clearance=$groupModel->judgeClearance($all_data["gid"], Auth::user()->id);
         $targetClearance=$groupModel->judgeClearance($all_data["gid"], $all_data["uid"]);
         if ($clearance>1) {
-            if($targetClearance!=0) {
+            if ($targetClearance!=0) {
                 return ResponseModel::err(7003);
             }
             $groupModel->changeClearance($all_data["uid"], $all_data["gid"], 1);
@@ -227,7 +227,7 @@ 
         $groupModel=new GroupModel();
         $clearance=$groupModel->judgeClearance($all_data["gid"], Auth::user()->id);
         $targetClearance=$groupModel->judgeClearance($all_data["gid"], $all_data["uid"]);
-        if ($clearance <= 1 || $clearance <= $targetClearance){
+        if ($clearance<=1 || $clearance<=$targetClearance) {
             return ResponseModel::err(7002);
         }
 
@@ -247,16 +247,16 @@ 
 
         $groupModel=new GroupModel();
         $is_user=$groupModel->isUser($all_data["email"]);
-        if(!$is_user) return ResponseModel::err(2006);
+        if (!$is_user) return ResponseModel::err(2006);
         $clearance=$groupModel->judgeClearance($all_data["gid"], Auth::user()->id);
-        if($clearance<2) return ResponseModel::err(7002);
+        if ($clearance<2) return ResponseModel::err(7002);
         $targetClearance=$groupModel->judgeEmailClearance($all_data["gid"], $all_data["email"]);
-        if($targetClearance!=-3) return ResponseModel::err(7003);
+        if ($targetClearance!=-3) return ResponseModel::err(7003);
         $groupModel->inviteMember($all_data["gid"], $all_data["email"]);
-        $basic = $groupModel->basic($all_data['gid']);
-        $url = route('group.detail',['gcode' => $basic['gcode']]);
-        $receiverInfo = User::where('email',$all_data['email'])->first();
-        $sender_name = Auth::user()->name;
+        $basic=$groupModel->basic($all_data['gid']);
+        $url=route('group.detail', ['gcode' => $basic['gcode']]);
+        $receiverInfo=User::where('email', $all_data['email'])->first();
+        $sender_name=Auth::user()->name;
         sendMessage([
             'receiver' => $receiverInfo["id"],
             'sender' => Auth::user()->id,
@@ -298,7 +298,7 @@ 
 
         $groupModel=new GroupModel();
         $clearance=$groupModel->judgeClearance($all_data["gid"], Auth::user()->id);
-        if ($clearance < 2){
+        if ($clearance<2) {
             return ResponseModel::err(2001);
         }
         $groupModel->createNotice($all_data["gid"], Auth::user()->id, $all_data["title"], $all_data["content"]);

app/Http/Controllers/Group/AdminController.php

Spacing +7 added lines, -7 removed lines

@@ -21,7 +21,7 @@ 
      */
     public function settings($gcode)
     {
-        return Redirect::route('group.settings.general', ['gcode' => $gcode]);;
+        return Redirect::route('group.settings.general', ['gcode' => $gcode]); ;
     }
 
     /**
@@ -31,7 +31,7 @@ 
      */
     public function settingsReturn($gcode)
     {
-        return Redirect::route('group.detail', ['gcode' => $gcode]);;
+        return Redirect::route('group.detail', ['gcode' => $gcode]); ;
     }
 
     /**
@@ -60,10 +60,10 @@ 
      *
      * @return Response
      */
-    public function problems($gcode){
-        $groupModel = new GroupModel();
-        $group_info = $groupModel->details($gcode);
-        $problems = $groupModel->problems($group_info['gid']);
+    public function problems($gcode) {
+        $groupModel=new GroupModel();
+        $group_info=$groupModel->details($gcode);
+        $problems=$groupModel->problems($group_info['gid']);
         $basic_info=$groupModel->details($gcode);
         return view('group.settings.problems', [
             'page_title'=>"Group Problems",
@@ -105,7 +105,7 @@ 
         $member_list=$groupModel->userList($basic_info["gid"]);
         $group_notice=$groupModel->detailNotice($gcode);
         // PHP 7.4 Fix
-        if(is_null($group_notice)){
+        if (is_null($group_notice)) {
             $group_notice=[
                 'content'=>null,
                 'title'=>null,

app/Http/Controllers/Group/IndexController.php

Spacing +16 added lines, -16 removed lines

@@ -49,7 +49,7 @@ 
         $group_notice=$groupModel->groupNotice($basic_info["gid"]);
         // PHP 7.4 Fix
         $groupContest=$contestModel->listByGroup($basic_info["gid"]);
-        if(is_null($groupContest)){
+        if (is_null($groupContest)) {
             $contest_list=null;
             $paginator=null;
         } else {
@@ -92,12 +92,12 @@ 
      *
      * @return Response
      */
-    public function analysis($gcode){
-        $groupModel = new GroupModel();
+    public function analysis($gcode) {
+        $groupModel=new GroupModel();
         $basic_info=$groupModel->details($gcode);
         $clearance=$groupModel->judgeClearance($basic_info["gid"], Auth::user()->id);
-        if($clearance < 1) return Redirect::route('group.detail',['gcode' => $gcode]);
-        $group_info = $groupModel->details($gcode);
+        if ($clearance<1) return Redirect::route('group.detail', ['gcode' => $gcode]);
+        $group_info=$groupModel->details($gcode);
         return view('group.settings.analysis', [
             'page_title'=>"Group Analysis",
             'site_title'=>"NOJ",
@@ -107,13 +107,13 @@ 
         ]);
     }
 
-    public function analysisDownload($gcode,Request $request){
-        $all_data = $request->all();
-        $groupModel = new GroupModel();
-        $group_info = $groupModel->details($gcode);
-        $mode = $all_data['mode'] ?? 'contest';
-        if($mode == 'contest'){
-            $data = $groupModel->groupMemberPracticeContestStat($group_info['gid']);
+    public function analysisDownload($gcode, Request $request) {
+        $all_data=$request->all();
+        $groupModel=new GroupModel();
+        $group_info=$groupModel->details($gcode);
+        $mode=$all_data['mode'] ?? 'contest';
+        if ($mode=='contest') {
+            $data=$groupModel->groupMemberPracticeContestStat($group_info['gid']);
             return Excel::download(
                 new GroupAnalysisExport(
                     [
@@ -126,10 +126,10 @@ 
                         'percent' => $all_data['percent'] ?? false,
                     ]
                 ),
-                $gcode . '_Group_Contest_Analysis.xlsx'
+                $gcode.'_Group_Contest_Analysis.xlsx'
             );
-        }else{
-            $data = $groupModel->groupMemberPracticeTagStat($group_info['gid']);
+        } else {
+            $data=$groupModel->groupMemberPracticeTagStat($group_info['gid']);
             return Excel::download(
                 new GroupAnalysisExport(
                     [
@@ -142,7 +142,7 @@ 
                         'percent' => $all_data['percent'] ?? false,
                     ]
                 ),
-                $gcode . '_Group_Tag_Analysis.xlsx'
+                $gcode.'_Group_Tag_Analysis.xlsx'
             );
         }
     }

app/Http/Controllers/OAuth/GithubController.php

Spacing +24 added lines, -24 removed lines

@@ -20,12 +20,12 @@ 
     public function redirectTo()
     {
         // 2 ways to access this page, you want to bind(logined), you want to login(not logined)
-        if(Auth::check()){
+        if (Auth::check()) {
             // logined user, only users with non-temp email & pass access and binded can unbind
-            if(!Auth::user()->isIndependent()){
+            if (!Auth::user()->isIndependent()) {
                 return redirect()->route('account.settings');
             }
-            if(Auth::user()->getExtra('github_id')){
+            if (Auth::user()->getExtra('github_id')) {
                 return $this->generateOperationView(Auth::user()->getExtra('github_email'));
             }
         }
@@ -34,17 +34,17 @@ 
 
     public function handleCallback()
     {
-        try{
-            $github_user = Socialite::driver('github')->user();
-        }catch(\Laravel\Socialite\Two\InvalidStateException $e){
+        try {
+            $github_user=Socialite::driver('github')->user();
+        } catch (\Laravel\Socialite\Two\InvalidStateException $e) {
             return redirect()->route('home');
         }
 
-        if(Auth::check()){
-            $user_id = Auth::user()->id;
-            $ret = UserExtra::search('github_id', $github_user->id);
-            if(!empty($ret) && $ret[0]['uid'] != $user_id){
-                $user = User::find($ret[0]['uid']);
+        if (Auth::check()) {
+            $user_id=Auth::user()->id;
+            $ret=UserExtra::search('github_id', $github_user->id);
+            if (!empty($ret) && $ret[0]['uid']!=$user_id) {
+                $user=User::find($ret[0]['uid']);
                 return $this->generateDuplicateView($user->email);
             }
             Auth::user()->setExtra('github_id', $github_user->id);
@@ -53,17 +53,17 @@ 
             Auth::user()->setExtra('github_homepage', ($github_user->user)['html_url']);
             Auth::user()->setExtra('github_token', $github_user->token, 101);
             return $this->generateSuccessView(Auth::user()->getExtra('github_email'));
-        }else{
-            $ret = UserExtra::search('github_id', $github_user->id);
-            if(!empty($ret)){
+        } else {
+            $ret=UserExtra::search('github_id', $github_user->id);
+            if (!empty($ret)) {
                 Auth::loginUsingId($ret[0]['uid'], true);
                 Auth::user()->setExtra('github_email', $github_user->email);
                 Auth::user()->setExtra('github_nickname', $github_user->nickname);
                 Auth::user()->setExtra('github_homepage', ($github_user->user)['html_url']);
                 Auth::user()->setExtra('github_token', $github_user->token, 101);
                 return redirect()->route('account.dashboard');
-            }else{
-                if(config('app.allow_oauth_temp_account')){
+            } else {
+                if (config('app.allow_oauth_temp_account')) {
                     try {
                         $createdUser=User::create([
                             'name' => Str::random(12),
@@ -71,7 +71,7 @@ 
                             'password' => '',
                             'avatar' => '/static/img/avatar/default.png',
                         ]);
-                    }catch(QueryException $exception){
+                    } catch (QueryException $exception) {
                         return $this->generateUnknownErrorView();
                     }
                     Auth::loginUsingId($createdUser->id, true);
@@ -86,7 +86,7 @@ 
                     'text' => 'login',
                     'href' => route('login'),
                 ]];
-                if(config('function.register')){
+                if (config('function.register')) {
                     $buttons[]=[
                         'text' => 'register',
                         'href' => route('register'),
@@ -99,29 +99,29 @@ 
 
     public function unbind()
     {
-        if(!Auth::check()){
+        if (!Auth::check()) {
             return redirect()->route('home');
         }
-        if(Auth::user()->getExtra('github_id')){
+        if (Auth::user()->getExtra('github_id')) {
             return $this->generateUnbindConfirmView(Auth::user()->email, Auth::user()->getExtra('github_email'));
-        }else{
+        } else {
             return $this->generateAlreadyUnbindView();
         }
     }
 
     public function confirmUnbind()
     {
-        if(!Auth::check()){
+        if (!Auth::check()) {
             return redirect()->route('home');
         }
-        if(Auth::user()->getExtra('github_id')){
+        if (Auth::user()->getExtra('github_id')) {
             Auth::user()->setExtra('github_id', null);
             Auth::user()->setExtra('github_email', null);
             Auth::user()->setExtra('github_nickname', null);
             Auth::user()->setExtra('github_homepage', null);
             Auth::user()->setExtra('github_token', null);
             return $this->generateUnbindSuccessView();
-        }else{
+        } else {
             return $this->generateAlreadyUnbindView();
         }
     }

Braces +6 added lines, -6 removed lines

@@ -36,7 +36,7 @@ 
     {
         try{
             $github_user = Socialite::driver('github')->user();
-        }catch(\Laravel\Socialite\Two\InvalidStateException $e){
+        } catch(\Laravel\Socialite\Two\InvalidStateException $e){
             return redirect()->route('home');
         }
 
@@ -53,7 +53,7 @@ 
             Auth::user()->setExtra('github_homepage', ($github_user->user)['html_url']);
             Auth::user()->setExtra('github_token', $github_user->token, 101);
             return $this->generateSuccessView(Auth::user()->getExtra('github_email'));
-        }else{
+        } else{
             $ret = UserExtra::search('github_id', $github_user->id);
             if(!empty($ret)){
                 Auth::loginUsingId($ret[0]['uid'], true);
@@ -62,7 +62,7 @@ 
                 Auth::user()->setExtra('github_homepage', ($github_user->user)['html_url']);
                 Auth::user()->setExtra('github_token', $github_user->token, 101);
                 return redirect()->route('account.dashboard');
-            }else{
+            } else{
                 if(config('app.allow_oauth_temp_account')){
                     try {
                         $createdUser=User::create([
@@ -71,7 +71,7 @@ 
                             'password' => '',
                             'avatar' => '/static/img/avatar/default.png',
                         ]);
-                    }catch(QueryException $exception){
+                    } catch(QueryException $exception){
                         return $this->generateUnknownErrorView();
                     }
                     Auth::loginUsingId($createdUser->id, true);
@@ -104,7 +104,7 @@ 
         }
         if(Auth::user()->getExtra('github_id')){
             return $this->generateUnbindConfirmView(Auth::user()->email, Auth::user()->getExtra('github_email'));
-        }else{
+        } else{
             return $this->generateAlreadyUnbindView();
         }
     }
@@ -121,7 +121,7 @@ 
             Auth::user()->setExtra('github_homepage', null);
             Auth::user()->setExtra('github_token', null);
             return $this->generateUnbindSuccessView();
-        }else{
+        } else{
             return $this->generateAlreadyUnbindView();
         }
     }

app/Http/Controllers/OAuth/AAuthController.php

Spacing +27 added lines, -27 removed lines

@@ -23,12 +23,12 @@ 
     public function redirectTo()
     {
         // 2 ways to access this page, you want to bind(logined), you want to login(not logined)
-        if(Auth::check()){
+        if (Auth::check()) {
             // logined user, only users with non-temp email & pass access and binded can unbind
-            if(!Auth::user()->isIndependent()){
+            if (!Auth::user()->isIndependent()) {
                 return redirect()->route('account.settings');
             }
-            if(Auth::user()->getExtra('aauth_id')){
+            if (Auth::user()->getExtra('aauth_id')) {
                 return $this->generateOperationView(Auth::user()->getExtra('aauth_nickname'));
             }
         }
@@ -37,16 +37,16 @@ 
 
     private function user($code)
     {
-        $response = Requests::post('https://cn.api.aauth.link/auth/',[], json_encode([
+        $response=Requests::post('https://cn.api.aauth.link/auth/', [], json_encode([
             'code' => $code,
             'app' => config('services.aauth.client_id'),
             'secret' => config('services.aauth.client_secret')
         ]));
-        if(!$response->success){
+        if (!$response->success) {
             throw new Exception('Requesting Error');
         }
-        $user = json_decode($response->body);
-        if (json_last_error() !== JSON_ERROR_NONE) {
+        $user=json_decode($response->body);
+        if (json_last_error()!==JSON_ERROR_NONE) {
             throw new Exception('JSON Error');
         }
         return $user;
@@ -54,30 +54,30 @@ 
 
     public function handleCallback()
     {
-        try{
-            $aauth_user = $this->user(request()->code);
-        }catch(Throwable $e){
+        try {
+            $aauth_user=$this->user(request()->code);
+        } catch (Throwable $e) {
             return redirect()->route('home');
         }
 
-        if(Auth::check()){
-            $user_id = Auth::user()->id;
-            $ret = UserExtra::search('aauth_id', $aauth_user->id);
-            if(!empty($ret) && $ret[0]['uid'] != $user_id){
-                $user = User::find($ret[0]['uid']);
+        if (Auth::check()) {
+            $user_id=Auth::user()->id;
+            $ret=UserExtra::search('aauth_id', $aauth_user->id);
+            if (!empty($ret) && $ret[0]['uid']!=$user_id) {
+                $user=User::find($ret[0]['uid']);
                 return $this->generateDuplicateView($user->email);
             }
             Auth::user()->setExtra('aauth_id', $aauth_user->id);
             Auth::user()->setExtra('aauth_nickname', $aauth_user->name);
             return $this->generateSuccessView(Auth::user()->getExtra('aauth_nickname'));
-        }else{
-            $ret = UserExtra::search('aauth_id', $aauth_user->id);
-            if(!empty($ret)){
+        } else {
+            $ret=UserExtra::search('aauth_id', $aauth_user->id);
+            if (!empty($ret)) {
                 Auth::loginUsingId($ret[0]['uid'], true);
                 Auth::user()->setExtra('aauth_nickname', $aauth_user->name);
                 return redirect()->route('account.dashboard');
-            }else{
-                if(config('app.allow_oauth_temp_account')){
+            } else {
+                if (config('app.allow_oauth_temp_account')) {
                     try {
                         $createdUser=User::create([
                             'name' => Str::random(12),
@@ -85,7 +85,7 @@ 
                             'password' => '',
                             'avatar' => '/static/img/avatar/default.png',
                         ]);
-                    }catch(QueryException $exception){
+                    } catch (QueryException $exception) {
                         return $this->generateUnknownErrorView();
                     }
                     Auth::loginUsingId($createdUser->id, true);
@@ -100,26 +100,26 @@ 
 
     public function unbind()
     {
-        if(!Auth::check()){
+        if (!Auth::check()) {
             return redirect()->route('home');
         }
-        if(Auth::user()->getExtra('aauth_id')){
+        if (Auth::user()->getExtra('aauth_id')) {
             return $this->generateUnbindConfirmView(Auth::user()->email, Auth::user()->getExtra('aauth_nickname'));
-        }else{
+        } else {
             return $this->generateAlreadyUnbindView();
         }
     }
 
     public function confirmUnbind()
     {
-        if(!Auth::check()){
+        if (!Auth::check()) {
             return redirect()->route('home');
         }
-        if(Auth::user()->getExtra('aauth_id')){
+        if (Auth::user()->getExtra('aauth_id')) {
             Auth::user()->setExtra('aauth_id', null);
             Auth::user()->setExtra('aauth_nickname', null);
             return $this->generateUnbindSuccessView();
-        }else{
+        } else {
             return $this->generateAlreadyUnbindView();
         }
     }

Braces +6 added lines, -6 removed lines

@@ -56,7 +56,7 @@ 
     {
         try{
             $aauth_user = $this->user(request()->code);
-        }catch(Throwable $e){
+        } catch(Throwable $e){
             return redirect()->route('home');
         }
 
@@ -70,13 +70,13 @@ 
             Auth::user()->setExtra('aauth_id', $aauth_user->id);
             Auth::user()->setExtra('aauth_nickname', $aauth_user->name);
             return $this->generateSuccessView(Auth::user()->getExtra('aauth_nickname'));
-        }else{
+        } else{
             $ret = UserExtra::search('aauth_id', $aauth_user->id);
             if(!empty($ret)){
                 Auth::loginUsingId($ret[0]['uid'], true);
                 Auth::user()->setExtra('aauth_nickname', $aauth_user->name);
                 return redirect()->route('account.dashboard');
-            }else{
+            } else{
                 if(config('app.allow_oauth_temp_account')){
                     try {
                         $createdUser=User::create([
@@ -85,7 +85,7 @@ 
                             'password' => '',
                             'avatar' => '/static/img/avatar/default.png',
                         ]);
-                    }catch(QueryException $exception){
+                    } catch(QueryException $exception){
                         return $this->generateUnknownErrorView();
                     }
                     Auth::loginUsingId($createdUser->id, true);
@@ -105,7 +105,7 @@ 
         }
         if(Auth::user()->getExtra('aauth_id')){
             return $this->generateUnbindConfirmView(Auth::user()->email, Auth::user()->getExtra('aauth_nickname'));
-        }else{
+        } else{
             return $this->generateAlreadyUnbindView();
         }
     }
@@ -119,7 +119,7 @@ 
             Auth::user()->setExtra('aauth_id', null);
             Auth::user()->setExtra('aauth_nickname', null);
             return $this->generateUnbindSuccessView();
-        }else{
+        } else{
             return $this->generateAlreadyUnbindView();
         }
     }

app/Http/Controllers/OAuth/OAuthController.php

Spacing +16 added lines, -16 removed lines

@@ -9,7 +9,7 @@ 
     protected $platformName;
     protected $platformID;
 
-    private function generateView($config){
+    private function generateView($config) {
         $config+=[
             'page_title' => __("oauth.title.platform", ['platform' => $this->platformName]),
             'site_title' => config("app.name"),
@@ -19,7 +19,7 @@ 
         return view('oauth.index', $config);
     }
 
-    protected function generateOperationView($OAuthAccount){
+    protected function generateOperationView($OAuthAccount) {
         return $this->generateView([
             'display_html' => __("oauth.operation", ['platform' => $this->platformName, 'oauthaccount' => $OAuthAccount]),
             'buttons' => [
@@ -36,9 +36,9 @@ 
         ]);
     }
 
-    protected function generateDuplicateView($NOJAccount){
+    protected function generateDuplicateView($NOJAccount) {
         return $this->generateView([
-            'display_html' => __("oauth.duplicate", [ 'platform' => $this->platformName, 'appname' => config("app.name"), 'nojaccount' => $NOJAccount ]),
+            'display_html' => __("oauth.duplicate", ['platform' => $this->platformName, 'appname' => config("app.name"), 'nojaccount' => $NOJAccount]),
             'buttons' => [
                 [
                     'text' => __("oauth.action.home"),
@@ -48,9 +48,9 @@ 
         ]);
     }
 
-    protected function generateSuccessView($OAuthAccount){
+    protected function generateSuccessView($OAuthAccount) {
         return $this->generateView([
-            'display_html' => __("oauth.success", [ 'platform' => $this->platformName, 'appname' => config("app.name"), 'oauthaccount' => $OAuthAccount ]),
+            'display_html' => __("oauth.success", ['platform' => $this->platformName, 'appname' => config("app.name"), 'oauthaccount' => $OAuthAccount]),
             'buttons' => [
                 [
                     'text' => __("oauth.action.home"),
@@ -60,7 +60,7 @@ 
         ]);
     }
 
-    protected function generateUnknownErrorView(){
+    protected function generateUnknownErrorView() {
         return $this->generateView([
             'display_text' => __("oauth.action.unknownerror"),
             'buttons' => [
@@ -72,26 +72,26 @@ 
         ]);
     }
 
-    protected function generateAccountNotFoundView(){
+    protected function generateAccountNotFoundView() {
         $buttons=[[
             'text' => __("oauth.action.login"),
             'href' => route('login'),
         ]];
-        if(config('function.register')){
+        if (config('function.register')) {
             $buttons[]=[
                 'text' => __("oauth.action.register"),
                 'href' => route('register'),
             ];
         }
         return $this->generateView([
-            'display_text' => __("oauth.accountnotfound", [ 'platform' => $this->platformName, 'appname' => config("app.name") ]),
+            'display_text' => __("oauth.accountnotfound", ['platform' => $this->platformName, 'appname' => config("app.name")]),
             'buttons' => $buttons
         ]);
     }
 
-    protected function generateUnbindConfirmView($NOJAccount, $OAuthAccount){
+    protected function generateUnbindConfirmView($NOJAccount, $OAuthAccount) {
         return $this->generateView([
-            'display_html' => __("oauth.unbindconfirm", [ 'platform' => $this->platformName, 'appname' => config("app.name"), 'oauthaccount' => $OAuthAccount, 'nojaccount' => $NOJAccount ]),
+            'display_html' => __("oauth.unbindconfirm", ['platform' => $this->platformName, 'appname' => config("app.name"), 'oauthaccount' => $OAuthAccount, 'nojaccount' => $NOJAccount]),
             'buttons' => [
                 [
                     'text' => __("oauth.action.confirm"),
@@ -106,9 +106,9 @@ 
         ]);
     }
 
-    protected function generateAlreadyUnbindView(){
+    protected function generateAlreadyUnbindView() {
         return $this->generateView([
-            'display_html' => __("oauth.alreadyunbind", [ 'platform' => $this->platformName ]),
+            'display_html' => __("oauth.alreadyunbind", ['platform' => $this->platformName]),
             'buttons' => [
                 [
                     'text' => __("oauth.action.home"),
@@ -118,9 +118,9 @@ 
         ]);
     }
 
-    protected function generateUnbindSuccessView(){
+    protected function generateUnbindSuccessView() {
         return $this->generateView([
-            'display_html' => __("oauth.unbindsuccess", [ 'platform' => $this->platformName, 'appname' => config("app.name") ]),
+            'display_html' => __("oauth.unbindsuccess", ['platform' => $this->platformName, 'appname' => config("app.name")]),
             'buttons' => [
                 [
                     'text' => __("oauth.action.home"),

app/Http/Controllers/Contest/AdminController.php

Spacing +23 added lines, -23 removed lines

@@ -27,7 +27,7 @@ 
         $contestModel=new ContestModel();
         $verified=$contestModel->isVerified($cid);
         $clearance=$contestModel->judgeClearance($cid, Auth::user()->id);
-        if ($clearance <= 2) {
+        if ($clearance<=2) {
             return Redirect::route('contest.detail', ['cid' => $cid]);
         }
         $contest_name=$contestModel->contestName($cid);
@@ -36,20 +36,20 @@ 
         $basicInfo=$contestModel->basic($cid);
         $contest_accounts=$accountModel->getContestAccount($cid);
         $gcode=$contestModel->gcode($cid);
-        $isEnd = $contestModel->remainingTime($cid) < 0;
-        $generatePDFStatus = JobStatus::find(Cache::tags(['contest', 'admin', 'PDFGenerate'])->get($cid, 0));
-        $generatePDFStatus = is_null($generatePDFStatus)?'empty':$generatePDFStatus->status;
-        if(in_array($generatePDFStatus,['finished','failed'])){
+        $isEnd=$contestModel->remainingTime($cid)<0;
+        $generatePDFStatus=JobStatus::find(Cache::tags(['contest', 'admin', 'PDFGenerate'])->get($cid, 0));
+        $generatePDFStatus=is_null($generatePDFStatus) ? 'empty' : $generatePDFStatus->status;
+        if (in_array($generatePDFStatus, ['finished', 'failed'])) {
             Cache::tags(['contest', 'admin', 'PDFGenerate'])->forget($cid);
         }
-        $anticheatStatus = JobStatus::find(Cache::tags(['contest', 'admin', 'anticheat'])->get($cid, 0));
-        $anticheatProgress = is_null($anticheatStatus)?0:$anticheatStatus->progress_percentage;
-        $anticheatStatus = is_null($anticheatStatus)?'empty':$anticheatStatus->status;
-        if(Storage::disk('local')->exists("contest/anticheat/$cid/report/report.zip")) {
+        $anticheatStatus=JobStatus::find(Cache::tags(['contest', 'admin', 'anticheat'])->get($cid, 0));
+        $anticheatProgress=is_null($anticheatStatus) ? 0 : $anticheatStatus->progress_percentage;
+        $anticheatStatus=is_null($anticheatStatus) ? 'empty' : $anticheatStatus->status;
+        if (Storage::disk('local')->exists("contest/anticheat/$cid/report/report.zip")) {
             $anticheatStatus='finished';
             $anticheatProgress=100;
         }
-        if(in_array($anticheatStatus, ['finished','failed'])){
+        if (in_array($anticheatStatus, ['finished', 'failed'])) {
             Cache::tags(['contest', 'admin', 'anticheat'])->forget($cid);
         }
         return view('contest.board.admin', [
@@ -77,51 +77,51 @@ 
     {
         $contestModel=new ContestModel();
         $clearance=$contestModel->judgeClearance($cid, Auth::user()->id);
-        if ($clearance <= 2) {
+        if ($clearance<=2) {
             return Redirect::route('contest.detail', ['cid' => $cid]);
         }
         $account=$contestModel->getContestAccount($cid);
-        if($account==null){
-            return ;
-        }else{
+        if ($account==null) {
+            return;
+        } else {
             $AccountExport=new AccountExport($account);
             $filename="ContestAccount$cid";
             return Excel::download($AccountExport, $filename.'.xlsx');
         }
     }
 
-    public function refreshContestRank($cid){
+    public function refreshContestRank($cid) {
         $contestModel=new ContestModel();
         $clearance=$contestModel->judgeClearance($cid, Auth::user()->id);
-        if ($clearance <= 2) {
+        if ($clearance<=2) {
             return Redirect::route('contest.detail', ['cid' => $cid]);
         }
-        $contest_eloquent = EloquentContestModel::find($cid);
+        $contest_eloquent=EloquentContestModel::find($cid);
         $contestRankRaw=$contest_eloquent->rankRefresh();
         Cache::tags(['contest', 'rank'])->put($cid, $contestRankRaw);
         Cache::tags(['contest', 'rank'])->put("contestAdmin$cid", $contestRankRaw);
         $end_time=strtotime(DB::table("contest")->where(["cid"=>$cid])->select("end_time")->first()["end_time"]);
-        if(time() > strtotime($end_time)){
+        if (time()>strtotime($end_time)) {
             $contestModel->storeContestRankInMySQL($cid, $contestRankRaw);
         }
         $contestModel->deleteZip("contestCodeZip/$cid/");
         return Redirect::route('contest.board.rank', ['cid' => $cid]);
     }
 
-    public function scrollBoard($cid){
+    public function scrollBoard($cid) {
         $contestModel=new ContestModel();
         $clearance=$contestModel->judgeClearance($cid, Auth::user()->id);
-        if ($clearance <= 2) {
+        if ($clearance<=2) {
             return Redirect::route('contest.detail', ['cid' => $cid]);
         }
         $basicInfo=$contestModel->basic($cid);
-        if($basicInfo['froze_length'] == 0){
+        if ($basicInfo['froze_length']==0) {
             return Redirect::route('contest.board.admin', ['cid' => $cid]);
         }
-        if($basicInfo['registration'] == 0){
+        if ($basicInfo['registration']==0) {
             return Redirect::route('contest.board.admin', ['cid' => $cid]);
         }
-        if($basicInfo['rule'] != 1){
+        if ($basicInfo['rule']!=1) {
             return Redirect::route('contest.board.admin', ['cid' => $cid]);
         }
         return view('contest.board.scrollBoard', [