Passed
Pull Request — master (#610)
by John
10:48
created
app/Models/ProblemModel.php 1 patch
Braces   +7 added lines, -3 removed lines patch added patch discarded remove patch
@@ -446,7 +446,9 @@  discard block
 block discarded – undo
446 446
 
447 447
         if (!empty($data["sample"])) {
448 448
             foreach ($data["sample"] as $d) {
449
-                if(!isset($d['sample_note'])) $d['sample_note']=null;
449
+                if(!isset($d['sample_note'])) {
450
+                    $d['sample_note']=null;
451
+                }
450 452
                 DB::table("problem_sample")->insert([
451 453
                     'pid'=>$pid,
452 454
                     'sample_input'=>$d['sample_input'],
@@ -492,7 +494,9 @@  discard block
 block discarded – undo
492 494
 
493 495
         if (!empty($data["sample"])) {
494 496
             foreach ($data["sample"] as $d) {
495
-                if(!isset($d['sample_note'])) $d['sample_note']=null;
497
+                if(!isset($d['sample_note'])) {
498
+                    $d['sample_note']=null;
499
+                }
496 500
                 DB::table("problem_sample")->insert([
497 501
                     'pid'=>$pid,
498 502
                     'sample_input'=>$d['sample_input'],
@@ -679,7 +683,7 @@  discard block
 block discarded – undo
679 683
         $top=DB::table('problem_discussion_comment')->where('pdcid','=',$reply_id)->get()->first()['reply_id'];
680 684
         if(isset($top)){
681 685
             return $this->replyParent($reply_id);
682
-        }else{
686
+        } else{
683 687
             return $reply_id;
684 688
         }
685 689
     }
Please login to merge, or discard this patch.
app/Models/Babel/ExtensionModel.php 1 patch
Braces   +16 added lines, -8 removed lines patch added patch discarded remove patch
@@ -68,7 +68,7 @@  discard block
 block discarded – undo
68 68
                     $temp["settings"]=false;
69 69
                     $temp["available"]=$installedConfig->status;
70 70
                 }
71
-            }catch (Throwable $e){
71
+            } catch (Throwable $e){
72 72
                 continue;
73 73
             }
74 74
             $ret[]=$temp;
@@ -80,7 +80,9 @@  discard block
 block discarded – undo
80 80
     {
81 81
         $ret=[];
82 82
         $marketspaceRaw=self::getRemote();
83
-        if(empty($marketspaceRaw)) return [];
83
+        if(empty($marketspaceRaw)) {
84
+            return [];
85
+        }
84 86
         foreach($marketspaceRaw["packages"] as $extension){
85 87
             $temp=[
86 88
                 "details"=>$extension,
@@ -94,7 +96,7 @@  discard block
 block discarded – undo
94 96
             try {
95 97
                 try {
96 98
                     $BabelConfig=json_decode(file_get_contents(babel_path("Extension/{$extension['code']}/babel.json")), true);
97
-                }catch (Throwable $e){
99
+                } catch (Throwable $e){
98 100
                     $BabelConfig=[];
99 101
                 }
100 102
                 if (!empty($BabelConfig)) {
@@ -120,7 +122,7 @@  discard block
 block discarded – undo
120 122
                         $temp["available"]=$installedConfig->status;
121 123
                     }
122 124
                 }
123
-            }catch (Throwable $e){
125
+            } catch (Throwable $e){
124 126
                 continue;
125 127
             }
126 128
             $ret[]=$temp;
@@ -136,7 +138,9 @@  discard block
 block discarded – undo
136 138
         foreach($dirs as $d){
137 139
             $extension=basename($d);
138 140
             $BabelConfig=json_decode(file_get_contents(babel_path("Extension/$extension/babel.json")), true);
139
-            if($extension==$BabelConfig["code"]) $ret[]=$BabelConfig;
141
+            if($extension==$BabelConfig["code"]) {
142
+                $ret[]=$BabelConfig;
143
+            }
140 144
         }
141 145
         return $ret;
142 146
     }
@@ -145,7 +149,7 @@  discard block
 block discarded – undo
145 149
     {
146 150
         try {
147 151
             return json_decode(file_get_contents(config('babel.mirror')."/babel.json"), true);
148
-        }catch(Throwable $e){
152
+        } catch(Throwable $e){
149 153
             return [];
150 154
         }
151 155
     }
@@ -153,10 +157,14 @@  discard block
 block discarded – undo
153 157
     public static function remoteDetail($code)
154 158
     {
155 159
         $babelConfig=self::getRemote();
156
-        if(empty($babelConfig)) return [];
160
+        if(empty($babelConfig)) {
161
+            return [];
162
+        }
157 163
         $babelConfigPackages=$babelConfig["packages"];
158 164
         foreach($babelConfigPackages as $package) {
159
-            if($package["code"]==$code) return $package;
165
+            if($package["code"]==$code) {
166
+                return $package;
167
+            }
160 168
         }
161 169
         return [];
162 170
     }
Please login to merge, or discard this patch.
app/Http/Controllers/Ajax/GroupManageController.php 1 patch
Braces   +9 added lines, -3 removed lines patch added patch discarded remove patch
@@ -245,11 +245,17 @@
 block discarded – undo
245 245
 
246 246
         $groupModel=new GroupModel();
247 247
         $is_user=$groupModel->isUser($all_data["email"]);
248
-        if(!$is_user) return ResponseModel::err(2006);
248
+        if(!$is_user) {
249
+            return ResponseModel::err(2006);
250
+        }
249 251
         $clearance=$groupModel->judgeClearance($all_data["gid"], Auth::user()->id);
250
-        if($clearance<2) return ResponseModel::err(7002);
252
+        if($clearance<2) {
253
+            return ResponseModel::err(7002);
254
+        }
251 255
         $targetClearance=$groupModel->judgeEmailClearance($all_data["gid"], $all_data["email"]);
252
-        if($targetClearance!=-3) return ResponseModel::err(7003);
256
+        if($targetClearance!=-3) {
257
+            return ResponseModel::err(7003);
258
+        }
253 259
         $groupModel->inviteMember($all_data["gid"], $all_data["email"]);
254 260
         $basic = $groupModel->basic($all_data['gid']);
255 261
         $url = route('group.detail',['gcode' => $basic['gcode']]);
Please login to merge, or discard this patch.
app/Models/Eloquent/ContestProblem.php 1 patch
Braces   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -45,7 +45,7 @@  discard block
 block discarded – undo
45 45
             $ret['solved_time_parsed'] = formatProblemSolvedTime($ret['solved_time']);
46 46
             $ret['wrong_doings']       = $ac_record[2];
47 47
             $ret['color']              = $ac_record[1] ? 'wemd-green-text' : 'wemd-teal-text';
48
-        }else{
48
+        } else{
49 49
             $ret['wrong_doings']       = $ac_record[2];
50 50
         }
51 51
         return $ret;
@@ -76,7 +76,7 @@  discard block
 block discarded – undo
76 76
                     'Presentation Error',
77 77
                     'Output Limit Exceeded'
78 78
                 ])->where('submission_date', '<', $user_ac->submission_date)->count();
79
-        }else{
79
+        } else{
80 80
             $wrong_trys = $this->submissions()->where([
81 81
                 'uid'     => $user->id,
82 82
             ])->whereIn('verdict', [
Please login to merge, or discard this patch.
app/Http/Controllers/Ajax/DojoController.php 1 patch
Braces   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -25,7 +25,7 @@
 block discarded – undo
25 25
             if (!Dojo::findOrFail($dojo_id)->canPass()) {
26 26
                 return ResponseModel::err(10001);
27 27
             }
28
-        }catch(Throwable $e){
28
+        } catch(Throwable $e){
29 29
             return ResponseModel::err(10002);
30 30
         }
31 31
 
Please login to merge, or discard this patch.
app/Http/Controllers/Ajax/ContestAdminController.php 1 patch
Braces   +8 added lines, -4 removed lines patch added patch discarded remove patch
@@ -66,7 +66,7 @@  discard block
 block discarded – undo
66 66
         }
67 67
         if($assign_uid != 0){
68 68
             $assignee = $groupModel->userProfile($assign_uid,$contest_detail['gid']);
69
-        }else{
69
+        } else{
70 70
             $assignee = null;
71 71
         }
72 72
         $ret = [
@@ -142,7 +142,7 @@  discard block
 block discarded – undo
142 142
             }
143 143
             $contestModel->contestUpdate($cid,$all_data,$problemSet);
144 144
             return ResponseModel::success(200);
145
-        }else{
145
+        } else{
146 146
             $allow_update = ['name','description'];
147 147
 
148 148
             foreach($all_data as $key => $value){
@@ -325,7 +325,9 @@  discard block
 block discarded – undo
325 325
         if ($contestModel->judgeClearance($cid,Auth::user()->id) != 3){
326 326
             return ResponseModel::err(2001);
327 327
         }
328
-        if(!is_null(Cache::tags(['contest', 'admin', 'PDFGenerate'])->get($cid))) return ResponseModel::err(8001);
328
+        if(!is_null(Cache::tags(['contest', 'admin', 'PDFGenerate'])->get($cid))) {
329
+            return ResponseModel::err(8001);
330
+        }
329 331
         $generateProcess=new GeneratePDF($cid,$config);
330 332
         dispatch($generateProcess)->onQueue('normal');
331 333
         Cache::tags(['contest', 'admin', 'PDFGenerate'])->put($cid, $generateProcess->getJobStatusId());
@@ -344,7 +346,9 @@  discard block
 block discarded – undo
344 346
         if ($contestModel->judgeClearance($cid,Auth::user()->id) != 3){
345 347
             return ResponseModel::err(2001);
346 348
         }
347
-        if(!is_null(Cache::tags(['contest', 'admin', 'anticheat'])->get($cid))) return ResponseModel::err(8001);
349
+        if(!is_null(Cache::tags(['contest', 'admin', 'anticheat'])->get($cid))) {
350
+            return ResponseModel::err(8001);
351
+        }
348 352
         if(EloquentContestModel::find($cid)->isJudgingComplete()) {
349 353
             $anticheatProcess=new AntiCheat($cid);
350 354
             dispatch($anticheatProcess)->onQueue('normal');
Please login to merge, or discard this patch.
app/Http/Controllers/Ajax/GroupController.php 1 patch
Braces   +6 added lines, -2 removed lines patch added patch discarded remove patch
@@ -184,9 +184,13 @@
 block discarded – undo
184 184
         $all_data=$request->all();
185 185
 
186 186
         $groupModel=new OutdatedGroupModel();
187
-        if($all_data["gcode"]=="create") return ResponseModel::err(7005);
187
+        if($all_data["gcode"]=="create") {
188
+            return ResponseModel::err(7005);
189
+        }
188 190
         $is_group=$groupModel->isGroup($all_data["gcode"]);
189
-        if($is_group) return ResponseModel::err(7006);
191
+        if($is_group) {
192
+            return ResponseModel::err(7006);
193
+        }
190 194
 
191 195
         $allow_extension=['jpg', 'png', 'jpeg', 'gif', 'bmp'];
192 196
         if (!empty($request->file('img')) && $request->file('img')->isValid()) {
Please login to merge, or discard this patch.
app/Http/Controllers/Group/IndexController.php 1 patch
Braces   +4 added lines, -2 removed lines patch added patch discarded remove patch
@@ -89,7 +89,9 @@  discard block
 block discarded – undo
89 89
         $groupModel = new GroupModel();
90 90
         $basic_info=$groupModel->details($gcode);
91 91
         $clearance=$groupModel->judgeClearance($basic_info["gid"], Auth::user()->id);
92
-        if($clearance < 1) return Redirect::route('group.detail',['gcode' => $gcode]);
92
+        if($clearance < 1) {
93
+            return Redirect::route('group.detail',['gcode' => $gcode]);
94
+        }
93 95
         $group_info = $groupModel->details($gcode);
94 96
         return view('group.settings.analysis', [
95 97
             'page_title'=>"Group Analysis",
@@ -121,7 +123,7 @@  discard block
 block discarded – undo
121 123
                 ),
122 124
                 $gcode . '_Group_Contest_Analysis.xlsx'
123 125
             );
124
-        }else{
126
+        } else{
125 127
             $data = $groupModel->groupMemberPracticeTagStat($group_info['gid']);
126 128
             return Excel::download(
127 129
                 new GroupAnalysisExport(
Please login to merge, or discard this patch.
app/Http/Middleware/User/Banned.php 1 patch
Braces   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -35,7 +35,7 @@
 block discarded – undo
35 35
             return response()->view('errors.451',[
36 36
                 'description' => "Your account is currently blocked and will remain so until {$banned->removed_at}. Here's why: {$banned->reason}",
37 37
             ]);
38
-        }else{
38
+        } else{
39 39
             return response()->json([
40 40
                 'ret' => 451,
41 41
                 'desc' => 'Unavailable For Legal Reasons',
Please login to merge, or discard this patch.