ContestModel::rankRefresh() - Code Metrics - Inspection of "Hotfix" - ZsgsDesign/NOJ - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#343)

unknown

created 2019-12-06 20:51 UTC

ContestModel::rankRefresh() B

↳ Parent: ContestModel

Complexity

Conditions	9
Paths	5

Size

Total Lines	60
Code Lines	48

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	9
eloc	48
c	0
b	0
f	0
nc	5
nop	0
dl	0
loc	60
rs	7.5789

How to fix Long Method

<?php

namespace App\Models\Eloquent;

use Illuminate\Database\Eloquent\Collection as EloquentCollection;
use Illuminate\Database\Eloquent\Model;
use Illuminate\Support\Facades\DB;
use App\Models\ContestModel as OutdatedContestModel;
use Cache;

class ContestModel extends Model
{
    protected $table='contest';
    protected $primaryKey='cid';
    const DELETED_AT=null;
    const UPDATED_AT=null;
    const CREATED_AT=null;

    //Repository function
    public function participants($ignore_frozen = true)
    {
        if($this->registration){
            $participants = ContestParticipant::where('cid',$this->cid)->get();
            $participants->load('user');
            $users = new EloquentCollection;
            foreach ($participants as $participant) {
                $user = $participant->user;
                $users->add($user);
            }
            return $users->unique();
        }else{
            $this->load('submissions.user');
            if($ignore_frozen){
                $frozen_time = $this->frozen_time;
                $submissions = $this->submissions()->where('submission_date','<',$frozen_time)->get();
            }else{
                $submissions = $this->submissions;
            }
            $users = new EloquentCollection;
            foreach ($submissions as $submission) {
                $user = $submission->user;
                $users->add($user);
            }
            return $users->unique();
        }
    }

    // Repository/Service? function
    public function rankRefresh()
    {
        $ret = [];
        $participants = $this->participants();
        $contest_problems = $this->problems;
        $contest_problems->load('problem');
        if($this->rule == 1){
            // ACM/ICPC Mode
            foreach ($participants as $participant) {
                $prob_detail=[];
                $totPen=0;
                $totScore=0;
                foreach ($contest_problems as $contest_problem) {
                    $prob_stat = $contest_problem->userStatus($participant);
                    $prob_detail[]=[
                        'ncode'=>$contest_problem->ncode,
                        'pid'=>$contest_problem->pid,
                        'color'=>$prob_stat['color'],
                        'wrong_doings'=>$prob_stat['wrong_doings'],
                        'solved_time_parsed'=>$prob_stat['solved_time_parsed']
                    ];
                    if ($prob_stat['solved']) {
                        $totPen+=$prob_stat['wrong_doings'] * 20;
                        $totPen+=$prob_stat['solved_time'] / 60;
                        $totScore+=$prob_stat['solved'];
                    }
                }
                $ret[]=[
                    "uid" => $participant->id,
                    "name" => $participant->name,
                    "nick_name" => DB::table("group_member")->where([
                        "uid" => $participant->id,
                        "gid" => $this->group->gid
                    ])->where("role", ">", 0)->first()["nick_name"] ?? '',
                    "score" => $totScore,
                    "penalty" => $totPen,
                    "problem_detail" => $prob_detail
                ];
            }
            usort($ret, function ($a, $b) {
                if ($a["score"]==$b["score"]) {
                    if ($a["penalty"]==$b["penalty"]) {
                        return 0;
                    } elseif (($a["penalty"]>$b["penalty"])) {
                        return 1;
                    } else {
                        return -1;
                    }
                } elseif ($a["score"]>$b["score"]) {
                    return -1;
                } else {
                    return 1;
                }
            });
            Cache::tags(['contest', 'rank'])->put($this->cid, $ret, 60);
            return $ret;
        }else{
            // IO Mode
            $c = new OutdatedContestModel();
            return $c->contestRankCache($this->cid);
        }
    }

    public function problems()
    {
        return $this->hasMany('App\Models\Eloquent\ContestProblem','cid','cid');
    }

    public function submissions()
    {
        return $this->hasMany('App\Models\Eloquent\SubmissionModel','cid','cid');
    }

    public function group()
    {
        return $this->hasOne('App\Models\Eloquent\GroupModel','gid','gid');
    }

    public function getFrozenTimeAttribute()
    {
        $end_time = strtotime($this->end_time);
        return $end_time - $this->froze_length;
    }
}


1			<?php
2
3			namespace App\Models\Eloquent;
4
5			use Illuminate\Database\Eloquent\Collection as EloquentCollection;
6			use Illuminate\Database\Eloquent\Model;
7			use Illuminate\Support\Facades\DB;
8			use App\Models\ContestModel as OutdatedContestModel;
9			use Cache;
10
11			class ContestModel extends Model
12			{
13			protected $table='contest';
14			protected $primaryKey='cid';
15			const DELETED_AT=null;
16			const UPDATED_AT=null;
17			const CREATED_AT=null;
18
19			//Repository function
20			public function participants($ignore_frozen = true)
21			{
22			if($this->registration){
23			$participants = ContestParticipant::where('cid',$this->cid)->get();
24			$participants->load('user');
25			$users = new EloquentCollection;
26			foreach ($participants as $participant) {
27			$user = $participant->user;
28			$users->add($user);
29			}
30			return $users->unique();
31			}else{
32			$this->load('submissions.user');
33			if($ignore_frozen){
34			$frozen_time = $this->frozen_time;
35			$submissions = $this->submissions()->where('submission_date','<',$frozen_time)->get();
36			}else{
37			$submissions = $this->submissions;
38			}
39			$users = new EloquentCollection;
40			foreach ($submissions as $submission) {
41			$user = $submission->user;
42			$users->add($user);
43			}
44			return $users->unique();
45			}
46			}
47
48			// Repository/Service? function
49			public function rankRefresh()
50			{
51			$ret = [];
52			$participants = $this->participants();
53			$contest_problems = $this->problems;
54			$contest_problems->load('problem');
55			if($this->rule == 1){
56			// ACM/ICPC Mode
57			foreach ($participants as $participant) {
58			$prob_detail=[];
59			$totPen=0;
60			$totScore=0;
61			foreach ($contest_problems as $contest_problem) {
62			$prob_stat = $contest_problem->userStatus($participant);
63			$prob_detail[]=[
64			'ncode'=>$contest_problem->ncode,
65			'pid'=>$contest_problem->pid,
66			'color'=>$prob_stat['color'],
67			'wrong_doings'=>$prob_stat['wrong_doings'],
68			'solved_time_parsed'=>$prob_stat['solved_time_parsed']
69			];
70			if ($prob_stat['solved']) {
71			$totPen+=$prob_stat['wrong_doings'] * 20;
72			$totPen+=$prob_stat['solved_time'] / 60;
73			$totScore+=$prob_stat['solved'];
74			}
75			}
76			$ret[]=[
77			"uid" => $participant->id,
78			"name" => $participant->name,
79			"nick_name" => DB::table("group_member")->where([
80			"uid" => $participant->id,
81			"gid" => $this->group->gid
82			])->where("role", ">", 0)->first()["nick_name"] ?? '',
83			"score" => $totScore,
84			"penalty" => $totPen,
85			"problem_detail" => $prob_detail
86			];
87			}
88			usort($ret, function ($a, $b) {
89			if ($a["score"]==$b["score"]) {
90			if ($a["penalty"]==$b["penalty"]) {
91			return 0;
92			} elseif (($a["penalty"]>$b["penalty"])) {
93			return 1;
94			} else {
95			return -1;
96			}
97			} elseif ($a["score"]>$b["score"]) {
98			return -1;
99			} else {
100			return 1;
101			}
102			});
103			Cache::tags(['contest', 'rank'])->put($this->cid, $ret, 60);
104			return $ret;
105			}else{
106			// IO Mode
107			$c = new OutdatedContestModel();
108			return $c->contestRankCache($this->cid);
109			}
110			}
111
112			public function problems()
113			{
114			return $this->hasMany('App\Models\Eloquent\ContestProblem','cid','cid');
115			}
116
117			public function submissions()
118			{
119			return $this->hasMany('App\Models\Eloquent\SubmissionModel','cid','cid');
120			}
121
122			public function group()
123			{
124			return $this->hasOne('App\Models\Eloquent\GroupModel','gid','gid');
125			}
126
127			public function getFrozenTimeAttribute()
128			{
129			$end_time = strtotime($this->end_time);
130			return $end_time - $this->froze_length;
131			}
132			}
133

ZsgsDesign / NOJ

Pull Request — master (#343)

ContestModel::rankRefresh() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like