App\Http\Controllers\Contest\IndexController

Complexity

Total Complexity

15

Size/Duplication

Total Lines	76
Duplicated Lines	0 %

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
C	index()	0	35	11
A	detail()	0	25	4

<?php

namespace App\Http\Controllers\Contest;

use App\Models\ContestModel;
use App\Models\GroupModel;
use App\Http\Controllers\Controller;
use Illuminate\Http\Request;
use Auth;
use Redirect;


class IndexController extends Controller
{
    /**
     * Show the Contest Page.
     *
     * @return Response

The type App\Http\Controllers\Contest\Response was not found. Did you mean Response? If so, make sure to prefix the type with \.

     */
    public function index(Request $request)
    {
        $all_data=$request->all();
        $contestModel=new ContestModel();
        $filter["rule"]=isset($all_data["rule"]) ? $all_data["rule"] : null;

$filter was never initialized. Although not strictly required by PHP, it is generally a good practice to add $filter = array(); before regardless.

        $filter["public"]=isset($all_data["public"]) ? $all_data["public"] : null;
        $filter["verified"]=isset($all_data["verified"]) ? $all_data["verified"] : null;
        $filter["rated"]=isset($all_data["rated"]) ? $all_data["rated"] : null;
        $filter["anticheated"]=isset($all_data["anticheated"]) ? $all_data["anticheated"] : null;
        $filter["practice"]=isset($all_data["practice"]) ? $all_data["practice"] : null;
        $return_list=$contestModel->list($filter,Auth::check()?Auth::user()->id:0);
        $featured=$contestModel->featured();
        if (is_null($return_list)) {

The condition is_null($return_list) is always false.

            if (isset($all_data["page"]) && $all_data["page"]>1) {
                return redirect("/contest");
            } else {
                return view('contest.index', [
                    'page_title'=>"Contest",
                    'site_title'=>config("app.name"),
                    'navigation' => "Contest",
                    'contest_list'=> null,
                    'paginator' => null,
                    'featured'=>$featured,
                    'filter' => $filter
                ]);
            }
        } else {
            return view('contest.index', [

The expression return view('contest.index', array('page_title' => 'Contest', 'site_title' => config('app.name'), 'navigation' => 'Contest', 'contest_list' => $return_list['contents'], 'paginator' => $return_list['paginator'], 'featured' => $featured, 'filter' => $filter)) returns the type Illuminate\View\View which is incompatible with the documented return type App\Http\Controllers\Contest\Response.

                'page_title'=>"Contest",
                'site_title'=>config("app.name"),
                'navigation' => "Contest",
                'contest_list'=>$return_list['contents'],
                'paginator' => $return_list['paginator'],
                'featured'=>$featured,
                'filter' => $filter
            ]);
        }
    }

    /**
     * Show the Contest Detail Page.
     *
     * @return Response
     */
    public function detail($cid)
    {
        $contestModel=new ContestModel();
        $groupModel=new GroupModel();
        $clearance=Auth::check() ? $contestModel->judgeClearance($cid, Auth::user()->id) : 0;
        if (Auth::check()) {
            $contest_detail=$contestModel->detail($cid, Auth::user()->id);
            $registration=$contestModel->registration($cid, Auth::user()->id);
            $inGroup=$groupModel->isMember($contest_detail["data"]["contest_detail"]["gid"], Auth::user()->id);
        } else {
            $contest_detail=$contestModel->detail($cid);
            $registration=[];
            $inGroup=false;
        }
        if ($contest_detail["ret"]!=200) {
            return Redirect::route('contest.index');

The expression return Redirect::route('contest.index') returns the type Illuminate\Http\RedirectResponse which is incompatible with the documented return type App\Http\Controllers\Contest\Response.

        }
        return view('contest.detail', [

The expression return view('contest.detail', array('page_title' => 'Contest', 'site_title' => config('app.name'), 'navigation' => 'Contest', 'detail' => $contest_detail['data']['contest_detail'], 'clearance' => $clearance, 'registration' => $registration, 'inGroup' => $inGroup)) returns the type Illuminate\View\View which is incompatible with the documented return type App\Http\Controllers\Contest\Response.

            'page_title'=>"Contest",
            'site_title'=>config("app.name"),
            'navigation' => "Contest",
            'detail'=>$contest_detail["data"]["contest_detail"],
            'clearance' => $clearance,
            'registration' => $registration,
            'inGroup' => $inGroup
        ]);
    }
}