AccountController::changeExtraInfo() - Code Metrics - Inspection of "extra info of user" - ZsgsDesign/NOJ - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#91)

unknown

created 2019-05-20 09:54 UTC

AccountController::changeExtraInfo() A

↳ Parent: AccountController

Complexity

Conditions	5
Paths	7

Size

Total Lines	18
Code Lines	13

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	5
eloc	13
nc	7
nop	1
dl	0
loc	18
rs	9.5222
c	0
b	0
f	0

<?php

namespace App\Http\Controllers\Ajax;

use App\Http\Controllers\Controller;
use App\Models\ResponseModel;
use App\Models\UserModel;
use App\Models\AccountModel;
use Illuminate\Http\Request;
use Illuminate\Http\Response;
use Illuminate\Support\Facades\Validator;
use Illuminate\Support\Facades\Storage;
use Illuminate\Support\Facades\Hash;
use Auth;

class AccountController extends Controller
{
    /**
     * The Ajax Update Avatar.
     *
     * @param Request $request web request
     *
     * @return Response
     */
    public function updateAvatar(Request $request)
    {
        $isValid=$request->file('avatar')->isValid();
        if ($isValid) {
            $extension=$request->file('avatar')->extension();
        } else {
            return ResponseModel::err(1005);

        }

        $allow_extension=['jpg', 'png', 'jpeg', 'gif', 'bmp'];
        if ($isValid && in_array($extension, $allow_extension)) {
            $path=$request->file('avatar')->store('/static/img/avatar', 'NOJPublic');

            $user=Auth::user();
            $old_path=$user->avatar;

            if ($old_path!='/static/img/avatar/default.png' && $old_path!='/static/img/avatar/noj.png') {
                Storage::disk('NOJPublic')->delete($old_path);
            }

            $user->avatar='/'.$path;
            $user->avatar='/'./** @scrutinizer ignore-type */ $path;
            $user->save();

            return ResponseModel::success(200, null, '/'.$path);

        } else {
            return ResponseModel::err(1005);

        }
    }

    /**
     * The Ajax Change users' basic info.
     *
     * @param Request $request web request
     *
     * @return Response
     */
    public function changeBasicInfo(Request $request){
        // if(!$request->has('username')){
        //     return ResponseModel::err(1003);
        // }
        // $username = $request->input('username');
        $describes = $request->input('describes');
        if(strlen($describes) > 255){
            return ResponseModel::err(1006);

        }
        // $old_username=Auth::user()->name;
        // if($old_username != $username && !empty(UserModel::where('name',$username)->first())){
        //     return ResponseModel::err(2003);
        // }
        $user=Auth::user();
        // $user->name = $username;
        $user->describes = $describes;

        $user->save();
        return ResponseModel::success();

    }

    /**
     * The Ajax Change users' password.
     *
     * @param Request $request web request
     *
     * @return Response
     */
    public function changePassword(Request $request){
        if(!$request->has('old_password') || !$request->has('new_password') || !$request->has('confirm_password')){
            return ResponseModel::err(1003);

        }
        $old_password = $request->input('old_password');
        $new_password = $request->input('new_password');
        $confirm_password = $request->input('confirm_password');
        if($new_password != $confirm_password){
            return ResponseModel::err(2004);

        }
        if(strlen($new_password) < 8 || strlen($old_password) < 8){
            return ResponseModel::err(1006);

        }
        $user = Auth::user();
        if(!Hash::check($old_password, $user->password)){
        if(!Hash::check($old_password, /** @scrutinizer ignore-type */ $user->password)){
            return ResponseModel::err(2005);

        }
        $user->password = Hash::make($new_password);

        $user->save();
        return ResponseModel::success();

    }

    public function checkEmailCooldown(Request $request){
        $last_send = $request->session()->get('last_email_send');
        if(empty($last_send) || time() - $last_send >= 300){
            $request->session()->put('last_email_send',time());
            return ResponseModel::success(200,null,0);
        }else{
            $cooldown =  300 - (time() - $last_send);
            return ResponseModel::success(200,null,$cooldown);
        }
    }

    public function changeExtraInfo(Request $request){
        $input = $request->input();
        $allow_change = ['gender','contact','school','country','location'];
        foreach($input as $key => $value){
            if(!in_array($key,$allow_change)){
                return ResponseModel::error(1007);
            }
        }
        $account_model = new AccountModel();
        $user_id = Auth::user()->id;
        foreach ($input as $key => $value) {
            if(strlen($value) != 0){
                $account_model->setExtraInfo($user_id,$key,$value,0);
            }else{
                $account_model->unsetExtraInfoIfExist($user_id,$key);
            }
        }
        return ResponseModel::success();
    }
}


ZsgsDesign / NOJ

Pull Request — master (#91)

AccountController::changeExtraInfo() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like