ZsgsDesign / NOJ

app/Babel/Install/InstallerBase.php

Braces +2 added lines, -2 removed lines

@@ -38,7 +38,7 @@ 
             //writing database
             $this->transactionDB();
 
-        }catch(Throwable $e){
+        } catch(Throwable $e){
             if ($e->getMessage()!==""){
                 $this->command->line("\n  <bg=red;fg=white> {$e->getMessage()} </>\n");
             }
@@ -220,7 +220,7 @@ 
 
             DB::commit();
 
-        }catch(Throwable $e){
+        } catch(Throwable $e){
             DB::rollback();
             if ($e->getMessage()!=="") {
                 $this->command->line("\n  <bg=red;fg=white> {$e->getMessage()} </>\n");

app/Http/Controllers/Contest/AdminController.php

Braces +1 added lines, -1 removed lines

@@ -58,7 +58,7 @@
         $account=$contestModel->getContestAccount($cid);
         if($account==null){
             return ;
-        }else{
+        } else{
             $AccountExport=new AccountExport($account);
             $filename="ContestAccount$cid";
             return Excel::download($AccountExport, $filename.'.xlsx');

app/Console/Kernel.php

Braces +2 added lines, -2 removed lines

@@ -65,12 +65,12 @@
             foreach ($ret as $gid => $group) {
                 if(empty($group['result'])){
                     Log::channel('group_elo')->info('Refreshed Group Elo (Empty) : ('.$gid.')'.$group['name']);
-                }else{
+                } else{
                     Log::channel('group_elo')->info('Refreshing Group Elo: ('.$gid.')'.$group['name']);
                     foreach ($group['result'] as $contest) {
                         if($contest['ret'] == 'success'){
                             Log::channel('group_elo')->info('    Elo Clac Successfully : ('.$contest['cid'].')'.$contest['name']);
-                        }else{
+                        } else{
                             Log::channel('group_elo')->info('    Elo Clac Faild (Judge Not Over) : ('.$contest['cid'].')'.$contest['name'].'  sids:');
                             foreach ($contest['submissions'] as $sid) {
                                 Log::channel('group_elo')->info('        '.$sid['sid']);

app/Babel/Submit/Curl.php

Braces +105 added lines, -21 removed lines

@@ -18,11 +18,31 @@ 
 
     public function login($all_data)
     {
-        if(isset($all_data["url"]))    $url = $all_data["url"];       else throw new Exception("url is not exist in all_data");
-        if(isset($all_data["data"]))   $data = $all_data["data"];     else throw new Exception("data is not exist in all_data");
-        if(isset($all_data["oj"]))     $oj = $all_data["oj"];         else throw new Exception("oj is not exist in all_data");
-        if(isset($all_data["ret"]))    $ret = $all_data["ret"];       else $ret = 'false';
-        if(isset($all_data["handle"])) $handle = $all_data["handle"]; else $handle = "default";
+        if(isset($all_data["url"])) {
+            $url = $all_data["url"];
+        } else {
+            throw new Exception("url is not exist in all_data");
+        }
+        if(isset($all_data["data"])) {
+            $data = $all_data["data"];
+        } else {
+            throw new Exception("data is not exist in all_data");
+        }
+        if(isset($all_data["oj"])) {
+            $oj = $all_data["oj"];
+        } else {
+            throw new Exception("oj is not exist in all_data");
+        }
+        if(isset($all_data["ret"])) {
+            $ret = $all_data["ret"];
+        } else {
+            $ret = 'false';
+        }
+        if(isset($all_data["handle"])) {
+            $handle = $all_data["handle"];
+        } else {
+            $handle = "default";
+        }
 
         $datapost=curl_init();
         $headers=array("Expect:");
@@ -54,12 +74,36 @@ 
 
     public function grab_page($all_data)
     {
-        if(isset($all_data["site"]))    $site = $all_data["site"];          else throw new Exception("site is not exist in all_data");
-        if(isset($all_data["oj"]))      $oj = $all_data["oj"];              else throw new Exception("oj is not exist in all_data");
-        if(isset($all_data["headers"])) $headers = $all_data["headers"];    else $headers = [];
-        if(isset($all_data["handle"]))  $handle = $all_data["handle"];      else $handle = "default";
-        if(isset($all_data["follow"]))  $follow = $all_data["follow"];      else $follow = false;
-        if(isset($all_data["vcid"]))  $vcid = $all_data["vcid"]."_";      else $vcid = "";
+        if(isset($all_data["site"])) {
+            $site = $all_data["site"];
+        } else {
+            throw new Exception("site is not exist in all_data");
+        }
+        if(isset($all_data["oj"])) {
+            $oj = $all_data["oj"];
+        } else {
+            throw new Exception("oj is not exist in all_data");
+        }
+        if(isset($all_data["headers"])) {
+            $headers = $all_data["headers"];
+        } else {
+            $headers = [];
+        }
+        if(isset($all_data["handle"])) {
+            $handle = $all_data["handle"];
+        } else {
+            $handle = "default";
+        }
+        if(isset($all_data["follow"])) {
+            $follow = $all_data["follow"];
+        } else {
+            $follow = false;
+        }
+        if(isset($all_data["vcid"])) {
+            $vcid = $all_data["vcid"]."_";
+        } else {
+            $vcid = "";
+        }
 
         $handle=urlencode($handle);
 
@@ -86,16 +130,56 @@ 
 
     public function post_data($all_data)
     {
-        if(isset($all_data["site"]))         $site = $all_data["site"];                 else throw new Exception("site is not exist in all_data");
-        if(isset($all_data["data"]))         $data = $all_data["data"];                 else throw new Exception("data is not exist in all_data");
-        if(isset($all_data["oj"]))           $oj = $all_data["oj"];                     else throw new Exception("oj is not exist in all_data");
-        if(isset($all_data["ret"]))          $ret = $all_data["ret"];                   else $ret = false;
-        if(isset($all_data["follow"]))       $follow = $all_data["follow"];             else $follow = true;
-        if(isset($all_data["returnHeader"])) $returnHeader = $all_data["returnHeader"]; else $returnHeader = true;
-        if(isset($all_data["postJson"]))     $postJson = $all_data["postJson"];         else $postJson = false;
-        if(isset($all_data["extraHeaders"])) $extraHeaders = $all_data["extraHeaders"]; else $extraHeaders = [];
-        if(isset($all_data["handle"]))       $handle = $all_data["handle"];             else $handle = "default";
-        if(isset($all_data["vcid"]))  $vcid = $all_data["vcid"]."_";      else $vcid = "";
+        if(isset($all_data["site"])) {
+            $site = $all_data["site"];
+        } else {
+            throw new Exception("site is not exist in all_data");
+        }
+        if(isset($all_data["data"])) {
+            $data = $all_data["data"];
+        } else {
+            throw new Exception("data is not exist in all_data");
+        }
+        if(isset($all_data["oj"])) {
+            $oj = $all_data["oj"];
+        } else {
+            throw new Exception("oj is not exist in all_data");
+        }
+        if(isset($all_data["ret"])) {
+            $ret = $all_data["ret"];
+        } else {
+            $ret = false;
+        }
+        if(isset($all_data["follow"])) {
+            $follow = $all_data["follow"];
+        } else {
+            $follow = true;
+        }
+        if(isset($all_data["returnHeader"])) {
+            $returnHeader = $all_data["returnHeader"];
+        } else {
+            $returnHeader = true;
+        }
+        if(isset($all_data["postJson"])) {
+            $postJson = $all_data["postJson"];
+        } else {
+            $postJson = false;
+        }
+        if(isset($all_data["extraHeaders"])) {
+            $extraHeaders = $all_data["extraHeaders"];
+        } else {
+            $extraHeaders = [];
+        }
+        if(isset($all_data["handle"])) {
+            $handle = $all_data["handle"];
+        } else {
+            $handle = "default";
+        }
+        if(isset($all_data["vcid"])) {
+            $vcid = $all_data["vcid"]."_";
+        } else {
+            $vcid = "";
+        }
 
         $handle=urlencode($handle);
 

app/Models/ProblemModel.php

Braces +7 added lines, -3 removed lines

@@ -446,7 +446,9 @@ 
 
         if (!empty($data["sample"])) {
             foreach ($data["sample"] as $d) {
-                if(!isset($d['sample_note'])) $d['sample_note']=null;
+                if(!isset($d['sample_note'])) {
+                    $d['sample_note']=null;
+                }
                 DB::table("problem_sample")->insert([
                     'pid'=>$pid,
                     'sample_input'=>$d['sample_input'],
@@ -492,7 +494,9 @@ 
 
         if (!empty($data["sample"])) {
             foreach ($data["sample"] as $d) {
-                if(!isset($d['sample_note'])) $d['sample_note']=null;
+                if(!isset($d['sample_note'])) {
+                    $d['sample_note']=null;
+                }
                 DB::table("problem_sample")->insert([
                     'pid'=>$pid,
                     'sample_input'=>$d['sample_input'],
@@ -679,7 +683,7 @@ 
         $top=DB::table('problem_discussion_comment')->where('pdcid','=',$reply_id)->get()->first()['reply_id'];
         if(isset($top)){
             return $this->replyParent($reply_id);
-        }else{
+        } else{
             return $reply_id;
         }
     }

app/Models/Babel/ExtensionModel.php

Braces +16 added lines, -8 removed lines

@@ -68,7 +68,7 @@ 
                     $temp["settings"]=false;
                     $temp["available"]=$installedConfig->status;
                 }
-            }catch (Throwable $e){
+            } catch (Throwable $e){
                 continue;
             }
             $ret[]=$temp;
@@ -80,7 +80,9 @@ 
     {
         $ret=[];
         $marketspaceRaw=self::getRemote();
-        if(empty($marketspaceRaw)) return [];
+        if(empty($marketspaceRaw)) {
+            return [];
+        }
         foreach($marketspaceRaw["packages"] as $extension){
             $temp=[
                 "details"=>$extension,
@@ -94,7 +96,7 @@ 
             try {
                 try {
                     $BabelConfig=json_decode(file_get_contents(babel_path("Extension/{$extension['code']}/babel.json")), true);
-                }catch (Throwable $e){
+                } catch (Throwable $e){
                     $BabelConfig=[];
                 }
                 if (!empty($BabelConfig)) {
@@ -120,7 +122,7 @@ 
                         $temp["available"]=$installedConfig->status;
                     }
                 }
-            }catch (Throwable $e){
+            } catch (Throwable $e){
                 continue;
             }
             $ret[]=$temp;
@@ -136,7 +138,9 @@ 
         foreach($dirs as $d){
             $extension=basename($d);
             $BabelConfig=json_decode(file_get_contents(babel_path("Extension/$extension/babel.json")), true);
-            if($extension==$BabelConfig["code"]) $ret[]=$BabelConfig;
+            if($extension==$BabelConfig["code"]) {
+                $ret[]=$BabelConfig;
+            }
         }
         return $ret;
     }
@@ -145,7 +149,7 @@ 
     {
         try {
             return json_decode(file_get_contents(config('babel.mirror')."/babel.json"), true);
-        }catch(Throwable $e){
+        } catch(Throwable $e){
             return [];
         }
     }
@@ -153,10 +157,14 @@ 
     public static function remoteDetail($code)
     {
         $babelConfig=self::getRemote();
-        if(empty($babelConfig)) return [];
+        if(empty($babelConfig)) {
+            return [];
+        }
         $babelConfigPackages=$babelConfig["packages"];
         foreach($babelConfigPackages as $package) {
-            if($package["code"]==$code) return $package;
+            if($package["code"]==$code) {
+                return $package;
+            }
         }
         return [];
     }

app/Http/Controllers/Ajax/GroupManageController.php

Braces +9 added lines, -3 removed lines

@@ -245,11 +245,17 @@
 
         $groupModel=new GroupModel();
         $is_user=$groupModel->isUser($all_data["email"]);
-        if(!$is_user) return ResponseModel::err(2006);
+        if(!$is_user) {
+            return ResponseModel::err(2006);
+        }
         $clearance=$groupModel->judgeClearance($all_data["gid"], Auth::user()->id);
-        if($clearance<2) return ResponseModel::err(7002);
+        if($clearance<2) {
+            return ResponseModel::err(7002);
+        }
         $targetClearance=$groupModel->judgeEmailClearance($all_data["gid"], $all_data["email"]);
-        if($targetClearance!=-3) return ResponseModel::err(7003);
+        if($targetClearance!=-3) {
+            return ResponseModel::err(7003);
+        }
         $groupModel->inviteMember($all_data["gid"], $all_data["email"]);
         $basic = $groupModel->basic($all_data['gid']);
         $url = route('group.detail',['gcode' => $basic['gcode']]);

app/Http/Controllers/Contest/BoardController.php

Braces +12 added lines, -10 removed lines

@@ -37,7 +37,7 @@ 
         if (!$clearance || time() < strtotime($basicInfo['begin_time'])) {
             if($clearance == 3){
                 return Redirect::route('contest.admin', ['cid' => $cid]);
-            }else{
+            } else{
                 return Redirect::route('contest.detail', ['cid' => $cid]);
             }
         }
@@ -86,7 +86,7 @@ 
         if (!$clearance || time() < strtotime($basicInfo['begin_time'])) {
             if($clearance == 3){
                 return Redirect::route('contest.admin', ['cid' => $cid]);
-            }else{
+            } else{
                 return Redirect::route('contest.detail', ['cid' => $cid]);
             }
         }
@@ -123,7 +123,9 @@ 
         }
 
         $editor_left_width = $accountModel->getExtra(Auth::user()->id, 'editor_left_width');
-        if(empty($editor_left_width)) $editor_left_width='40';
+        if(empty($editor_left_width)) {
+            $editor_left_width='40';
+        }
 
         return view('contest.board.editor', [
             'page_title'=>"Problem Detail",
@@ -160,7 +162,7 @@ 
         if (!$clearance || time() < strtotime($basicInfo['begin_time'])) {
             if($clearance == 3){
                 return Redirect::route('contest.admin', ['cid' => $cid]);
-            }else{
+            } else{
                 return Redirect::route('contest.detail', ['cid' => $cid]);
             }
         }
@@ -179,10 +181,10 @@ 
             if($i != 0) {
                 if($r['score'] == $contestRank[$i-1]['score'] && ($contest_rule == 1 ? ($r['penalty'] == $contestRank[$i-1]['penalty']) : 1) ){
                     $r['rank'] = $contestRank[$i-1]['rank'];
-                }else{
+                } else{
                     $r['rank'] = $i + 1;
                 }
-            }else{
+            } else{
                 $r['rank'] = 1;
             }
         }
@@ -223,7 +225,7 @@ 
         if (!$clearance || time() < strtotime($basicInfo['begin_time'])) {
             if($clearance == 3){
                 return Redirect::route('contest.admin', ['cid' => $cid]);
-            }else{
+            } else{
                 return Redirect::route('contest.detail', ['cid' => $cid]);
             }
         }
@@ -265,7 +267,7 @@ 
         if (!$clearance || time() < strtotime($basicInfo['begin_time'])) {
             if($clearance == 3){
                 return Redirect::route('contest.admin', ['cid' => $cid]);
-            }else{
+            } else{
                 return Redirect::route('contest.detail', ['cid' => $cid]);
             }
         }
@@ -303,7 +305,7 @@ 
         if (!$clearance || time() < strtotime($basicInfo['begin_time'])) {
             if($clearance == 3){
                 return Redirect::route('contest.admin', ['cid' => $cid]);
-            }else{
+            } else{
                 return Redirect::route('contest.detail', ['cid' => $cid]);
             }
         }
@@ -331,7 +333,7 @@ 
         if (!$clearance || time() < strtotime($basicInfo['begin_time'])) {
             if($clearance == 3){
                 return Redirect::route('contest.admin', ['cid' => $cid]);
-            }else{
+            } else{
                 return Redirect::route('contest.detail', ['cid' => $cid]);
             }
         }

app/Models/Eloquent/ContestModel.php

Braces +3 added lines, -3 removed lines

@@ -28,12 +28,12 @@ 
                 $users->add($user);
             }
             return $users->unique();
-        }else{
+        } else{
             $this->load('submissions.user');
             if($ignore_frozen){
                 $frozen_time = $this->frozen_time;
                 $submissions = $this->submissions()->where('submission_date','<',$frozen_time)->get();
-            }else{
+            } else{
                 $submissions = $this->submissions;
             }
             $users = new EloquentCollection;
@@ -102,7 +102,7 @@ 
             });
             Cache::tags(['contest', 'rank'])->put($this->cid, $ret, 60);
             return $ret;
-        }else{
+        } else{
             // IO Mode
             $c = new OutdatedContestModel();
             return $c->contestRankCache($this->cid);