GroupController::joinGroup() - Code Metrics - Inspection of "Merge pull request #390 from ZsgsDesign/dev" - ZsgsDesign/NOJ - Measure and Improve Code Quality continuously with Scrutinizer

Passed
Push — master ( b831b6...96f132 )

by John
created 2020-04-30 19:56 UTC
GroupController::joinGroup() C

↳ Parent: GroupController
Complexity

Conditions	10
Paths	9
Size

Total Lines	123
Code Lines	86
Duplication

Lines	0
Ratio	0 %
Importance

Changes
Metric	Value
cc	10
eloc	86
nc	9
nop	1
dl	0
loc	123
rs	6.4387
c	0
b	0
f	0
How to fix Long Method Complexity

<?php

namespace App\Http\Controllers\Ajax;

use App\Models\GroupModel as OutdatedGroupModel;
use App\Models\Eloquent\Group;
use App\Models\ResponseModel;
use App\Http\Controllers\Controller;
use Illuminate\Http\Request;
use Auth;

class GroupController extends Controller
{
    public function changeNickName(Request $request)
    {
        $request->validate([
            'gid' => 'required|integer',
            'nick_name' => 'max:50',
        ]);

        $all_data=$request->all();

        $groupModel=new OutdatedGroupModel();
        $clearance=$groupModel->judgeClearance($all_data["gid"], Auth::user()->id);
        if ($clearance<1) {
            return ResponseModel::err(2001);
        }
        $groupModel->changeNickName($all_data["gid"], Auth::user()->id, $all_data["nick_name"]);
        return ResponseModel::success(200);
    }

    public function joinGroup(Request $request)
    {
        $request->validate([
            'gid' => 'required|integer',
        ]);

        $all_data=$request->all();

        $groupModel=new OutdatedGroupModel();
        $join_policy=$groupModel->joinPolicy($all_data["gid"]);
        if (is_null($join_policy)) {
            return ResponseModel::err(7001);
        }
        $group  = Group::find($all_data['gid']);
        $leader = $group->leader;
        $clearance=$groupModel->judgeClearance($all_data["gid"], Auth::user()->id);
        if ($join_policy==1) {
            if ($clearance==-1) {
                $groupModel->changeClearance(Auth::user()->id, $all_data["gid"], 1);
                sendMessage([
                    'sender'   => 1,
                    'receiver' => $leader->id,
                    'title'    => "Some users agreed to join your group {$group->name}.",
                    'type'     => 2,
                    'data'     => [
                        'group' => [
                            'gcode' => $group->gcode,
                            'name'  => $group->name,
                            'url'   => route('group.detail',['gcode' => $group->gcode])
                        ],
                        'user'  => [
                            [
                                'name'  => Auth::user()->name,
                                'url'   => route('user.view',['uid' => Auth::user()->id])
                            ]
                        ]
                    ]
                ]);
                return ResponseModel::success(200,null,[
                    'uid'            => Auth::user()->id,
                    'role_color_old' => $groupModel->role_color[-1],
                    'role_color'     => $groupModel->role_color[1],
                    'role'           => $groupModel->role[1],
                ]);
            }
            return ResponseModel::success(200);
        } elseif ($join_policy==2) {
            if ($clearance==-3) {
                $groupModel->addClearance(Auth::user()->id, $all_data["gid"], 0);
                //send message to leader
                sendMessage([
                    'sender'   => 1,
                    'receiver' => $leader->id,
                    'title'    => 'Someone applied to join your group.',
                    'type'     => 1,
                    'data'     => [
                        'group' => [
                            'gcode' => $group->gcode,
                            'name'  => $group->name,
                            'url'   => route('group.detail',['gcode' => $group->gcode])
                        ],
                        'user'  => [
                            [
                                'name'  => Auth::user()->name,
                                'url'   => route('user.view',['uid' => Auth::user()->id])
                            ]
                        ]
                    ]
                ]);
            }
            return ResponseModel::success(200);
        } elseif ($join_policy==3 || $join_policy==0) {  //The default value of join_policy when you create a group will be 0 in old version.
            if ($clearance==-1) {
                $groupModel->changeClearance(Auth::user()->id, $all_data["gid"], 1);
                sendMessage([
                    'sender'   => 1,
                    'receiver' => $leader->id,
                    'title'    => "Some users agreed to join your group {$group->name}.",
                    'type'     => 2,
                    'data'     => [
                        'group' => [
                            'gcode' => $group->gcode,
                            'name'  => $group->name,
                            'url'   => route('group.detail',['gcode' => $group->gcode])
                        ],
                        'user'  => [
                            [
                                'name'  => Auth::user()->name,
                                'url'   => route('user.view',['uid' => Auth::user()->id])
                            ]
                        ]
                    ]
                ]);
                return ResponseModel::success(200,null,[
                    'uid'            => Auth::user()->id,
                    'role_color_old' => $groupModel->role_color[-1],
                    'role_color'     => $groupModel->role_color[1],
                    'role'           => $groupModel->role[1]
                ]);
            } elseif ($clearance==-3) {
                $groupModel->addClearance(Auth::user()->id, $all_data["gid"], 0);
                //send message to leader
                sendMessage([
                    'sender'   => 1,
                    'receiver' => $leader->id,
                    'title'    => "Some users applied to join your group {$group->name}.",
                    'type'     => 1,
                    'data'     => [
                        'group' => [
                            'gcode' => $group->gcode,
                            'name'  => $group->name,
                            'url'   => route('group.detail',['gcode' => $group->gcode])
                        ],
                        'user'  => [
                            [
                                'name'  => Auth::user()->name,
                                'url'   => route('user.view',['uid' => Auth::user()->id])
                            ]
                        ]
                    ]
                ]);
            }
            return ResponseModel::success(200);
        }
    }

    public function exitGroup(Request $request)
    {
        $request->validate([
            'gid' => 'required|integer',
        ]);
        $uid = Auth::user()->id;
        $gid = $request->input('gid');
        $groupModel = new OutdatedGroupModel();
        $clearance = $groupModel->judgeClearance($gid,$uid);
        if($clearance == 3) {
            return ResponseModel::err(7008);
        }
        $groupModel->removeClearance($uid,$gid);
        return ResponseModel::success(200);
    }

    public function createGroup(Request $request)
    {
        $request->validate([
            'gcode' => 'required|alpha_dash|min:3|max:50',
            'name' => 'required|min:3|max:50',
            'public' => 'required|integer|min:1|max:2',
            'description' => 'nullable|max:60000',
            'join_policy'  => 'required|integer|min:1|max:3'
        ]);

        $all_data=$request->all();

        $groupModel=new OutdatedGroupModel();
        if($all_data["gcode"]=="create") return ResponseModel::err(7005);
        $is_group=$groupModel->isGroup($all_data["gcode"]);
        if($is_group) return ResponseModel::err(7006);

        $allow_extension=['jpg', 'png', 'jpeg', 'gif', 'bmp'];
        if (!empty($request->file('img')) && $request->file('img')->isValid()) {
            $extension=$request->file('img')->extension();
            if (!in_array($extension, $allow_extension)) {
                return ResponseModel::err(1005);
            }
            $path=$request->file('img')->store('/static/img/group', 'NOJPublic');
        } else {
            $path="static/img/group/default.png";
        }
        $img='/'.$path;
        $img='/'./** @scrutinizer ignore-type */ $path;

        $groupModel->createGroup(Auth::user()->id, $all_data["gcode"], $img, $all_data["name"], $all_data["public"], $all_data["description"], $all_data["join_policy"]);
        return ResponseModel::success(200);
    }

    public function getPracticeStat(Request $request)
    {
        $request->validate([
            'gid' => 'required|integer',
            'mode' => 'required'
        ]);

        $all_data=$request->all();

        $groupModel=new OutdatedGroupModel();
        $clearance=$groupModel->judgeClearance($all_data["gid"], Auth::user()->id);
        if ($clearance > 0) {
            switch($all_data['mode']){
                case 'contest':
                    $ret = $groupModel->groupMemberPracticeContestStat($all_data["gid"]);
                break;
                case 'tag':
                    $ret = $groupModel->groupMemberPracticeTagStat($all_data["gid"]);
                break;
                default:
                    return ResponseModel::err(1007);
                break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
            }

            return ResponseModel::success(200,null,$ret);
        }
        return ResponseModel::err(7002);
    }

    public function eloChangeLog(Request $request)
    {
        $request->validate([
            'gid' => 'required|integer',
            'uid' => 'required|integer',
        ]);

        $all_data=$request->all();

        $groupModel=new OutdatedGroupModel();
        $clearance=$groupModel->judgeClearance($all_data["gid"], Auth::user()->id);
        if($clearance <= 0){
            return ResponseModel::err(7002);
        }
        $ret = $groupModel->getEloChangeLog($all_data['gid'],$all_data['uid']);
        return ResponseModel::success(200,null,$ret);
    }
}

ZsgsDesign / NOJ

Push — master ( b831b6...96f132 )

GroupController::joinGroup() C

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like
