App\Babel\Judger\Curl::post_data()

Complexity

Conditions	4
Paths	6

Size

Total Lines	30
Code Lines	24

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
    protected function post_data($site, $data, $oj, $ret=false, $follow=true, $returnHeader=true, $postJson=false, $extraHeaders=[], $handle="default")
    {
        $datapost=curl_init();
        $headers=array("Expect:");
        if ($postJson) {
            $data=$data ? json_encode($data) : '{}';
            array_push($headers, 'Content-Type: application/json', 'Content-Length: '.strlen($data));
        }
        curl_setopt($datapost, CURLOPT_CAINFO, dirname(__FILE__)."/cookie/cacert.pem");

It seems like $datapost can also be of type false; however, parameter $ch of curl_setopt() does only seem to accept resource, maybe add an additional type check?

        curl_setopt($datapost, CURLOPT_URL, $site);
        curl_setopt($datapost, CURLOPT_HEADER, $returnHeader);
        curl_setopt($datapost, CURLOPT_HTTPHEADER, array_merge($headers, $extraHeaders));
        curl_setopt($datapost, CURLOPT_USERAGENT, "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/72.0.3626.109 Safari/537.36");
        curl_setopt($datapost, CURLOPT_POST, true);

        curl_setopt($datapost, CURLOPT_RETURNTRANSFER, $ret);
        curl_setopt($datapost, CURLOPT_FOLLOWLOCATION, $follow);

        curl_setopt($datapost, CURLOPT_POSTFIELDS, $data);
        curl_setopt($datapost, CURLOPT_COOKIEFILE, dirname(__FILE__)."/cookie/{$oj}_{$handle}_cookie.txt");
        curl_setopt($datapost, CURLOPT_COOKIEJAR, dirname(__FILE__)."/cookie/{$oj}_{$handle}_cookie.txt");
        ob_start();
        $response=curl_exec($datapost);

It seems like $datapost can also be of type false; however, parameter $ch of curl_exec() does only seem to accept resource, maybe add an additional type check?

        if (curl_errno($datapost)) {

It seems like $datapost can also be of type false; however, parameter $ch of curl_errno() does only seem to accept resource, maybe add an additional type check?

            die(curl_error($datapost));

Using exit here is not recommended.

It seems like $datapost can also be of type false; however, parameter $ch of curl_error() does only seem to accept resource, maybe add an additional type check?

        }
        ob_end_clean();
        curl_close($datapost);

It seems like $datapost can also be of type false; however, parameter $ch of curl_close() does only seem to accept resource, maybe add an additional type check?

        unset($datapost);
        return $response;
    }