App\Http\Controllers\ProblemController

Complexity

Total Complexity

17

Size/Duplication

Total Lines	125
Duplicated Lines	0 %

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
B	index()	0	34	6
A	detail()	0	12	3
A	editor()	0	36	5
A	solution()	0	12	3

<?php

namespace App\Http\Controllers;

use App\Models\ProblemModel;
use App\Models\SubmissionModel;
use App\Models\CompilerModel;
use App\Http\Controllers\Controller;
use Illuminate\Http\Request;
use JavaScript;
use Auth;

class ProblemController extends Controller
{
    /**
     * Show the Problem Index Page.
     *
     * @return Response

The type App\Http\Controllers\Response was not found. Did you mean Response? If so, make sure to prefix the type with \.

     */
    public function index(Request $request)
    {
        $all_data=$request->all();
        $problem=new ProblemModel();
        $filter["oj"]=isset($all_data["oj"]) ? $all_data["oj"] : null;

$filter was never initialized. Although not strictly required by PHP, it is generally a good practice to add $filter = array(); before regardless.

        $filter["tag"]=isset($all_data["tag"]) ? $all_data["tag"] : null;
        $list_return=$problem->list($filter);
        $tags=$problem->tags();
        $ojs=$problem->ojs();
        if (is_null($list_return)) {
            if (isset($all_data["page"]) && $all_data["page"]>1) {
                return redirect("/problem");

The expression return redirect('/problem') returns the type Illuminate\Http\RedirectResponse which is incompatible with the documented return type App\Http\Controllers\Response.

            } else {
                return view('problem.index', [

The expression return view('problem.index', array('page_title' => 'Problem', 'site_title' => 'NOJ', 'navigation' => 'Problem', 'prob_list' => null, 'prob_paginate' => null, 'tags' => $tags, 'ojs' => $ojs, 'filter' => $filter)) returns the type Illuminate\View\View which is incompatible with the documented return type App\Http\Controllers\Response.

                    'page_title' => "Problem",
                    'site_title' => "NOJ",
                    'navigation' => "Problem",
                    'prob_list' => null,
                    'prob_paginate' => null,
                    'tags' => $tags,
                    'ojs' => $ojs,
                    'filter' => $filter
                ]);
            }
        } else {
            return view('problem.index', [

The expression return view('problem.index', array('page_title' => 'Problem', 'site_title' => 'NOJ', 'navigation' => 'Problem', 'prob_list' => $list_return['problems'], 'paginator' => $list_return['paginator'], 'tags' => $tags, 'ojs' => $ojs, 'filter' => $filter)) returns the type Illuminate\View\View which is incompatible with the documented return type App\Http\Controllers\Response.

                'page_title' => "Problem",
                'site_title' => "NOJ",
                'navigation' => "Problem",
                'prob_list' => $list_return['problems'],
                'paginator' => $list_return['paginator'],
                'tags' => $tags,
                'ojs' => $ojs,
                'filter' => $filter
            ]);
        }
    }
    /**
     * Show the Problem Detail Page.
     *
     * @return Response
     */
    public function detail($pcode)
    {
        $problem=new ProblemModel();
        $prob_detail=$problem->detail($pcode);
        if ($problem->isBlocked($prob_detail["pid"])) {
            return abort('403');

Are you sure the usage of abort('403') is correct as it seems to always return null.

The expression return abort('403') returns the type void which is incompatible with the documented return type App\Http\Controllers\Response.

        }
        return is_null($prob_detail) ?  redirect("/problem") : view('problem.detail', [

The expression return is_null($prob_detail) ? redirect('/problem') : view('problem.detail', array('page_title' => $prob_detail['title'], 'site_title' => 'NOJ', 'navigation' => 'Problem', 'detail' => $prob_detail)) returns the type Illuminate\Http\RedirectResponse|Illuminate\View\View which is incompatible with the documented return type App\Http\Controllers\Response.

                                            'page_title'=>$prob_detail["title"],
                                            'site_title'=>"NOJ",
                                            'navigation' => "Problem",
                                            'detail' => $prob_detail
                                        ]);
    }

    /**
     * Show the Problem Solution Page.
     *
     * @return Response
     */
    public function solution($pcode)
    {
        $problem=new ProblemModel();
        $prob_detail=$problem->detail($pcode);
        if ($problem->isBlocked($prob_detail["pid"])) {
            return abort('403');

Are you sure the usage of abort('403') is correct as it seems to always return null.

The expression return abort('403') returns the type void which is incompatible with the documented return type App\Http\Controllers\Response.

        }
        return is_null($prob_detail) ?  redirect("/problem") : view('problem.solution', [

The expression return is_null($prob_detail) ? redirect('/problem') : view('problem.solution', array('page_title' => 'Solution', 'site_title' => 'NOJ', 'navigation' => $prob_detail['title'], 'detail' => $prob_detail)) returns the type Illuminate\Http\RedirectResponse|Illuminate\View\View which is incompatible with the documented return type App\Http\Controllers\Response.

                                            'page_title'=> "Solution",
                                            'site_title'=>"NOJ",
                                            'navigation' => $prob_detail["title"],
                                            'detail' => $prob_detail
                                        ]);
    }

    /**
     * Show the Problem Editor Page.
     *
     * @return Response
     */
    public function editor($pcode)
    {
        $problem=new ProblemModel();
        $compiler=new CompilerModel();
        $submission=new SubmissionModel();
        $prob_detail=$problem->detail($pcode);
        if ($problem->isBlocked($prob_detail["pid"])) {
            return abort('403');

The expression return abort('403') returns the type void which is incompatible with the documented return type App\Http\Controllers\Response.

Are you sure the usage of abort('403') is correct as it seems to always return null.

        }
        $compiler_list=$compiler->list($prob_detail["OJ"], $prob_detail["pid"]);
        $prob_status=$submission->getProblemStatus($prob_detail["pid"], Auth::user()->id);

        $compiler_pref=$compiler->pref($compiler_list, $prob_detail["pid"], Auth::user()->id);
        $pref=$compiler_pref["pref"];
        $submit_code=$compiler_pref["code"];

        $oj_detail=$problem->ojdetail($prob_detail["OJ"]);

        if (empty($prob_status)) {
            $prob_status=[
                "verdict"=>"NOT SUBMIT",
                "color"=>""
            ];
        }

        return is_null($prob_detail) ?  redirect("/problem") : view('problem.editor', [

The expression return is_null($prob_detail) ? redirect('/problem') : view('problem.editor', array('page_title' => $prob_detail['title'], 'site_title' => 'NOJ', 'navigation' => 'Problem', 'detail' => $prob_detail, 'compiler_list' => $compiler_list, 'status' => $prob_status, 'pref' => $pref < 0 ? 0 : $pref, 'submit_code' => $submit_code, 'contest_mode' => false, 'oj_detail' => $oj_detail)) returns the type Illuminate\Http\RedirectResponse|Illuminate\View\View which is incompatible with the documented return type App\Http\Controllers\Response.

                                            'page_title'=>$prob_detail["title"],
                                            'site_title'=>"NOJ",
                                            'navigation' => "Problem",
                                            'detail' => $prob_detail,
                                            'compiler_list' => $compiler_list,
                                            'status' => $prob_status,
                                            'pref'=>$pref<0 ? 0 : $pref,
                                            'submit_code'=>$submit_code,
                                            'contest_mode'=> false,
                                            'oj_detail'=>$oj_detail
                                        ]);
    }
}