ZsgsDesign / NOJ

app/Http/Controllers/Ajax/ContestController.php

Braces +2 added lines, -2 removed lines

@@ -60,7 +60,7 @@ 
         }
         if($assign_uid != 0){
             $assignee = $groupModel->userProfile($assign_uid,$contest_detail['gid']);
-        }else{
+        } else{
             $assignee = null;
         }
         $ret = [
@@ -220,7 +220,7 @@ 
             }
             $contestModel->contestUpdate($cid,$all_data,$problemSet);
             return ResponseModel::success(200);
-        }else{
+        } else{
             $allow_update = ['name','description'];
 
             foreach($all_data as $key => $value){

app/Models/GroupModel.php

Braces +11 added lines, -5 removed lines

@@ -114,7 +114,9 @@ 
     public function details($gcode)
     {
         $basic_info=DB::table($this->tableName)->where(["gcode"=>$gcode])->first();
-        if(empty($basic_info)) return [];
+        if(empty($basic_info)) {
+            return [];
+        }
         $basic_info["members"]=$this->countGroupMembers($basic_info["gid"]);
         $basic_info["tags"]=$this->getGroupTags($basic_info["gid"]);
         $basic_info["create_time_foramt"]=date_format(date_create($basic_info["create_time"]), 'M jS, Y');
@@ -162,7 +164,9 @@ 
         foreach ($user_list as &$u) {
             $u["role_parsed"]=$this->role[$u["role"]];
             $u["role_color"]=$this->role_color[$u["role"]];
-            if(is_null($u["sub_group"])) $u["sub_group"]="None";
+            if(is_null($u["sub_group"])) {
+                $u["sub_group"]="None";
+            }
         }
         return $user_list;
     }
@@ -231,7 +235,7 @@ 
             ->where('gid',$gid)
             ->distinct()
             ->get()->all();
-        }else{
+        } else{
             $tags =  DB::table('group_problem_tag')
             ->select('tag')
             ->where('gid', $gid)
@@ -265,7 +269,7 @@ 
         foreach($problems as $key => $value){
             if($contestModel->judgeClearance($value['cid'],$user_id) != 3){
                 unset($problems[$key]);
-            }else{
+            } else{
                 $problems[$key]['tags'] = $this->problemTags($gid,$value['pid']);
             }
         }
@@ -326,7 +330,9 @@ 
     public function judgeEmailClearance($gid, $email)
     {
         $user=DB::table("users")->where(["email"=>$email])->first();
-        if(empty($user)) return -4;
+        if(empty($user)) {
+            return -4;
+        }
         $ret=DB::table("group_member")->where([
             "gid"=>$gid,
             "uid"=>$user["id"],

app/Http/Controllers/GroupController.php

Braces +16 added lines, -6 removed lines

@@ -43,7 +43,9 @@ 
         $groupModel=new GroupModel();
         $contestModel=new ContestModel();
         $basic_info=$groupModel->details($gcode);
-        if(empty($basic_info)) return Redirect::route('group.index');
+        if(empty($basic_info)) {
+            return Redirect::route('group.index');
+        }
         $my_profile=$groupModel->userProfile(Auth::user()->id, $basic_info["gid"]);
         $clearance=$groupModel->judgeClearance($basic_info["gid"], Auth::user()->id);
         $member_list=$groupModel->userList($basic_info["gid"]);
@@ -110,7 +112,9 @@ 
     {
         $groupModel=new GroupModel();
         $basic_info=$groupModel->details($gcode);
-        if(empty($basic_info)) return Redirect::route('group.index');
+        if(empty($basic_info)) {
+            return Redirect::route('group.index');
+        }
         $clearance=$groupModel->judgeClearance($basic_info["gid"], Auth::user()->id);
         $member_list=$groupModel->userList($basic_info["gid"]);
         return view('group.settings.general', [
@@ -152,7 +156,9 @@ 
     {
         $groupModel=new GroupModel();
         $basic_info=$groupModel->details($gcode);
-        if(empty($basic_info)) return Redirect::route('group.index');
+        if(empty($basic_info)) {
+            return Redirect::route('group.index');
+        }
         return view('group.settings.danger', [
             'page_title'=>"Group Setting danger",
             'site_title'=>config("app.name"),
@@ -188,7 +194,9 @@ 
         $groupModel=new GroupModel();
         $contestModel=new ContestModel();
         $basic_info=$groupModel->details($gcode);
-        if(empty($basic_info)) return Redirect::route('group.index');
+        if(empty($basic_info)) {
+            return Redirect::route('group.index');
+        }
         $clearance=$groupModel->judgeClearance($basic_info["gid"], Auth::user()->id);
         $member_list=$groupModel->userList($basic_info["gid"]);
         $group_notice=$groupModel->detailNotice($gcode);
@@ -208,7 +216,9 @@ 
         $groupModel=new GroupModel();
         $contestModel=new ContestModel();
         $basic_info=$groupModel->details($gcode);
-        if(empty($basic_info)) return Redirect::route('group.index');
+        if(empty($basic_info)) {
+            return Redirect::route('group.index');
+        }
         $clearance=$groupModel->judgeClearance($basic_info["gid"], Auth::user()->id);
         $contest_list=$contestModel->listForSetting($basic_info["gid"]);
         $member_list=$groupModel->userList($basic_info["gid"]);
@@ -244,7 +254,7 @@ 
                 ),
                 $gcode . '_Group_Contest_Analysis.xlsx'
             );
-        }else{
+        } else{
             $data = $groupModel->groupMemberPracticeTagStat($group_info['gid']);
             return Excel::download(
                 new GroupAnalysisExport(

app/Http/Controllers/Ajax/SearchController.php

Braces +1 added lines, -1 removed lines

@@ -43,7 +43,7 @@
                 }
                 $result = $model->search($key);
                 $all_result[$name] = $result;
-            }else{
+            } else{
                 $all_result[$name] = [
                     'code' => -1,
                     'msg' => 'cannot find class named '.$model_class

app/Models/ContestModel.php

Braces +25 added lines, -26 removed lines

@@ -224,7 +224,7 @@ 
                     $paginator=$paginator->where(["practice"=>$filter['practice']]);
                 }
                 $paginator = $paginator ->paginate(10);
-            }elseif($filter['public']=='0'){
+            } elseif($filter['public']=='0'){
                 $paginator=DB::table('group_member')
                 ->groupBy('contest.cid')
                 ->select('contest.*')
@@ -254,7 +254,7 @@ 
                 )
                 ->orderBy('contest.begin_time', 'desc')
                 ->paginate(10);
-            }else{
+            } else{
                 $paginator=DB::table('group_member')
                 ->groupBy('contest.cid')
                 ->select('contest.*')
@@ -797,13 +797,13 @@ 
         if(time() < $end_time){
             if($clearance == 3){
                 $contestRankRaw=Cache::tags(['contest', 'rank'])->get("contestAdmin$cid");
-            }else{
+            } else{
                 $contestRankRaw=Cache::tags(['contest', 'rank'])->get($cid);
             }
             if(!isset($contestRankRaw)){
                 $contestRankRaw=$this->contestRankCache($cid);
             }
-        }else{
+        } else{
             if($clearance == 3){
                 $contestRankRaw=Cache::tags(['contest', 'rank'])->get("contestAdmin$cid");
                 if (!isset($contestRankRaw)) {
@@ -813,7 +813,7 @@ 
                         $this->storeContestRankInMySQL($cid, $contestRankRaw);
                     }
                 }
-            }else{
+            } else{
                 $contestRankRaw=$this->getContestRankFromMySQL($cid);
                 if(!isset($contestRankRaw)){
                     $contestRankRaw=Cache::tags(['contest', 'rank'])->get($cid);
@@ -898,7 +898,7 @@ 
             return DB::table("contest_clarification")->where([
                 "cid"=>$cid
             ])->orderBy('create_time', 'desc')->get()->all();
-        }else{
+        } else{
             return DB::table("contest_clarification")->where([
                 "cid"=>$cid
             ])->where(function ($query) {
@@ -1062,7 +1062,7 @@ 
         $filter['pid'] = array_search($filter['ncode'], array_column($problemSet_temp, 'ncode'));
         if($filter['pid']==false){
             $filter['pid'] = null;
-        }else{
+        } else{
             $filter['pid'] = $problemSet_temp[$filter['pid']]['pid'];
         }
 
@@ -1170,7 +1170,7 @@ 
                     "records"=>[]
                 ];
             }
-        }else{
+        } else{
             if ($basicInfo["status_visibility"]==2) {
                 // View all
                 $paginator=DB::table("submission")->where([
@@ -1420,7 +1420,7 @@ 
             if($ratingCalculator->calculate()){
                 $ratingCalculator->storage();
                 return true;
-            }else{
+            } else{
                 return false;
             }
         } else {
@@ -1469,7 +1469,7 @@ 
             $contestRankRaw = $this->contestRankCache($cid);
             Cache::tags(['contest', 'rank'])->put($cid, $contestRankRaw);
             Cache::tags(['contest', 'rank'])->put("contestAdmin$cid", $contestRankRaw);
-        }else{
+        } else{
             DB::table($this->tableName)
                 ->where('cid',$cid)
                 ->update($data);
@@ -1569,8 +1569,7 @@ 
                     if(time() > $chache['end_time']){
                         $this->storeContestRankInMySQL($cid, $ret);
                     }
-                }
-                else{
+                } else{
                     $ret=[];
                     $chache=[];
                     $chache['contest_info']=DB::table("contest")->where("cid", $cid)->first();
@@ -1585,7 +1584,7 @@ 
                             "cid"=>$cid,
                             "audit"=>1
                         ])->select('uid')->get()->all();
-                    }else{
+                    } else{
                         $submissionUsers=DB::table("submission")->where([
                             "cid"=>$cid
                         ])->where(
@@ -1620,9 +1619,9 @@ 
                     Cache::tags(['contest', 'rank'])->put("contestAdmin$cid", $retAdmin);
                 }
             }
-        }catch(LockTimeoutException $e){
+        } catch(LockTimeoutException $e){
             Log::warning("Contest Rank Lock Timed Out");
-        }finally{
+        } finally{
             optional($lock)->release();
         }
     }
@@ -1645,7 +1644,7 @@ 
                     return 1;
                 }
             });
-        }else if ($contest_info["rule"]==2){
+        } else if ($contest_info["rule"]==2){
             usort($ret, function ($a, $b) {
                 if ($a["score"]==$b["score"]) {
                     if ($a["solved"]==$b["solved"]) {
@@ -1669,8 +1668,9 @@ 
     {
         $id = count($ret);
         foreach($ret as $key => $r){
-            if($r['uid'] == $uid)
-                $id = $key;
+            if($r['uid'] == $uid) {
+                            $id = $key;
+            }
         }
         if ($contest_info["rule"]==1) {
             // ACM/ICPC Mode
@@ -1678,7 +1678,7 @@ 
                 $prob_detail = [];
                 $totPen = 0;
                 $totScore = 0;
-            }else{
+            } else{
                 $prob_detail = $ret[$id]['problem_detail'];
                 $totPen=$ret[$id]['penalty'];
                 $totScore=$ret[$id]['score'];
@@ -1733,7 +1733,7 @@ 
                 $prob_detail = [];
                 $totSolved = 0;
                 $totScore = 0;
-            }else{
+            } else{
                 $prob_detail = $ret[$id]['problem_detail'];
                 $totSolved=$ret[$id]['solved'];
                 $totScore=$ret[$id]['score'];
@@ -1796,18 +1796,18 @@ 
                 return false;
             }
             return true;
-        }else if($status === 0){
+        } else if($status === 0){
             if($begin_time_new !== null){
                 return false;
             }
             if($end_time_new !== null){
                 if(strtotime($end_time_new) <= time()){
                     return false;
-                }else{
+                } else{
                     return true;
                 }
             }
-        }else{
+        } else{
             return false;
         }
 
@@ -1828,8 +1828,7 @@ 
             return DB::table("contest_clarification")->where('ccid','=',$ccid)->update([
                 "public"=>1
             ]);
-        }
-        else
+        } else
         {
             return DB::table("contest_clarification")->where('ccid','=',$ccid)->update([
                 "public"=>0
@@ -1852,7 +1851,7 @@ 
             ->whereIn('pid',array_column($contestRank[0]['problem_detail'],'pid'))
             ->select('pid','title')
             ->get()->all();
-        }else{
+        } else{
             $all_problems = [];
         }
         $tags = DB::table('group_problem_tag')

app/Models/Babel/ExtensionModel.php

Braces +6 added lines, -4 removed lines

@@ -21,7 +21,9 @@ 
     {
         $ret=[];
         $marketspaceRaw=self::getRemote();
-        if(empty($marketspaceRaw)) return [];
+        if(empty($marketspaceRaw)) {
+            return [];
+        }
         foreach($marketspaceRaw["packages"] as $extension){
             $temp=[
                 "details"=>$extension,
@@ -35,7 +37,7 @@ 
             try {
                 try {
                     $BabelConfig=json_decode(file_get_contents(babel_path("Extension/{$extension['code']}/babel.json")), true);
-                }catch (Throwable $e){
+                } catch (Throwable $e){
                     $BabelConfig=[];
                 }
                 if (!empty($BabelConfig)) {
@@ -61,7 +63,7 @@ 
                         $temp["available"]=$installedConfig->status;
                     }
                 }
-            }catch (Throwable $e){
+            } catch (Throwable $e){
                 $temp["status"]=-1;
             }
             $ret[]=$temp;
@@ -74,7 +76,7 @@ 
     {
         try {
             return json_decode(file_get_contents(env("BABEL_MIRROR", "https://acm.njupt.edu.cn/babel")."/babel.json"), true);
-        }catch(Throwable $e){
+        } catch(Throwable $e){
             return [];
         }
     }

app/Models/Update/UpdateModel.php

Braces +1 added lines, -1 removed lines

@@ -24,7 +24,7 @@
                 "name"=>$versionInfo[0]["name"],
                 "updatable"=>$updatable
             ];
-        }catch(Throwable $e){
+        } catch(Throwable $e){
             return null;
         }
     }

app/Babel/Submit/Curl.php

Braces +95 added lines, -19 removed lines

@@ -18,11 +18,31 @@ 
 
     public function login($all_data)
     {
-        if(isset($all_data["url"]))    $url = $all_data["url"];       else throw new Exception("url is not exist in all_data");
-        if(isset($all_data["data"]))   $data = $all_data["data"];     else throw new Exception("data is not exist in all_data");
-        if(isset($all_data["oj"]))     $oj = $all_data["oj"];         else throw new Exception("oj is not exist in all_data");
-        if(isset($all_data["ret"]))    $ret = $all_data["ret"];       else $ret = 'false';
-        if(isset($all_data["handle"])) $handle = $all_data["handle"]; else $handle = "default";
+        if(isset($all_data["url"])) {
+            $url = $all_data["url"];
+        } else {
+            throw new Exception("url is not exist in all_data");
+        }
+        if(isset($all_data["data"])) {
+            $data = $all_data["data"];
+        } else {
+            throw new Exception("data is not exist in all_data");
+        }
+        if(isset($all_data["oj"])) {
+            $oj = $all_data["oj"];
+        } else {
+            throw new Exception("oj is not exist in all_data");
+        }
+        if(isset($all_data["ret"])) {
+            $ret = $all_data["ret"];
+        } else {
+            $ret = 'false';
+        }
+        if(isset($all_data["handle"])) {
+            $handle = $all_data["handle"];
+        } else {
+            $handle = "default";
+        }
 
         $datapost=curl_init();
         $headers=array("Expect:");
@@ -54,11 +74,31 @@ 
 
     public function grab_page($all_data)
     {
-        if(isset($all_data["site"]))    $site = $all_data["site"];          else throw new Exception("site is not exist in all_data");
-        if(isset($all_data["oj"]))      $oj = $all_data["oj"];              else throw new Exception("oj is not exist in all_data");
-        if(isset($all_data["headers"])) $headers = $all_data["headers"];    else $headers = [];
-        if(isset($all_data["handle"]))  $handle = $all_data["handle"];      else $handle = "default";
-        if(isset($all_data["follow"]))  $follow = $all_data["follow"];      else $handle = false;
+        if(isset($all_data["site"])) {
+            $site = $all_data["site"];
+        } else {
+            throw new Exception("site is not exist in all_data");
+        }
+        if(isset($all_data["oj"])) {
+            $oj = $all_data["oj"];
+        } else {
+            throw new Exception("oj is not exist in all_data");
+        }
+        if(isset($all_data["headers"])) {
+            $headers = $all_data["headers"];
+        } else {
+            $headers = [];
+        }
+        if(isset($all_data["handle"])) {
+            $handle = $all_data["handle"];
+        } else {
+            $handle = "default";
+        }
+        if(isset($all_data["follow"])) {
+            $follow = $all_data["follow"];
+        } else {
+            $handle = false;
+        }
 
         $handle=urlencode($handle);
 
@@ -85,15 +125,51 @@ 
 
     public function post_data($all_data)
     {
-        if(isset($all_data["site"]))         $site = $all_data["site"];                 else throw new Exception("site is not exist in all_data");
-        if(isset($all_data["data"]))         $data = $all_data["data"];                 else throw new Exception("data is not exist in all_data");
-        if(isset($all_data["oj"]))           $oj = $all_data["oj"];                     else throw new Exception("oj is not exist in all_data");
-        if(isset($all_data["ret"]))          $ret = $all_data["ret"];                   else $ret = false;
-        if(isset($all_data["follow"]))       $follow = $all_data["follow"];             else $follow = true;
-        if(isset($all_data["returnHeader"])) $returnHeader = $all_data["returnHeader"]; else $returnHeader = true;
-        if(isset($all_data["postJson"]))     $postJson = $all_data["postJson"];         else $postJson = false;
-        if(isset($all_data["extraHeaders"])) $extraHeaders = $all_data["extraHeaders"]; else $extraHeaders = [];
-        if(isset($all_data["handle"]))       $handle = $all_data["handle"];             else $handle = "default";
+        if(isset($all_data["site"])) {
+            $site = $all_data["site"];
+        } else {
+            throw new Exception("site is not exist in all_data");
+        }
+        if(isset($all_data["data"])) {
+            $data = $all_data["data"];
+        } else {
+            throw new Exception("data is not exist in all_data");
+        }
+        if(isset($all_data["oj"])) {
+            $oj = $all_data["oj"];
+        } else {
+            throw new Exception("oj is not exist in all_data");
+        }
+        if(isset($all_data["ret"])) {
+            $ret = $all_data["ret"];
+        } else {
+            $ret = false;
+        }
+        if(isset($all_data["follow"])) {
+            $follow = $all_data["follow"];
+        } else {
+            $follow = true;
+        }
+        if(isset($all_data["returnHeader"])) {
+            $returnHeader = $all_data["returnHeader"];
+        } else {
+            $returnHeader = true;
+        }
+        if(isset($all_data["postJson"])) {
+            $postJson = $all_data["postJson"];
+        } else {
+            $postJson = false;
+        }
+        if(isset($all_data["extraHeaders"])) {
+            $extraHeaders = $all_data["extraHeaders"];
+        } else {
+            $extraHeaders = [];
+        }
+        if(isset($all_data["handle"])) {
+            $handle = $all_data["handle"];
+        } else {
+            $handle = "default";
+        }
 
         $handle=urlencode($handle);
 

app/Babel/Install/InstallerBase.php

Braces +2 added lines, -2 removed lines

@@ -38,7 +38,7 @@ 
             //writing database
             $this->transactionDB();
 
-        }catch(Throwable $e){
+        } catch(Throwable $e){
             if ($e->getMessage()!==""){
                 $this->command->line("\n  <bg=red;fg=white> {$e->getMessage()} </>\n");
             }
@@ -220,7 +220,7 @@ 
 
             DB::commit();
 
-        }catch(Throwable $e){
+        } catch(Throwable $e){
             DB::rollback();
             if ($e->getMessage()!=="") {
                 $this->command->line("\n  <bg=red;fg=white> {$e->getMessage()} </>\n");