App\Http\Controllers\Ajax\AccountController

Complexity

Total Complexity

5

Size/Duplication

Total Lines	50
Duplicated Lines	0 %

Importance

Changes

0

1 Method

Rating	Name	Duplication	Size	Complexity
A	updateAvatar()	0	41	5

<?php

namespace App\Http\Controllers\Ajax;

use App\Http\Controllers\Controller;
use Illuminate\Http\Request;
use Illuminate\Http\Response;
use Illuminate\Support\Facades\Validator;
use Illuminate\Support\Facades\Storage;
use Auth;

class AccountController extends Controller
{
    /**
     * The Ajax Update Avatar.
     *
     * @param Request $request web request
     *
     * @return Response
     */
    public function updateAvatar(Request $request)
    {
        $isValid = $request->file('avatar')->isValid();
        if($isValid){
            $extension = $request->file('avatar')->extension();
        }else{
            $output=[
                'ret' => '400',
                'desc' => 'Invalid file',
                'data' => null
            ];
            return response()->json($output);

The expression return response()->json($output) returns the type Illuminate\Http\JsonResponse which is incompatible with the documented return type Illuminate\Http\Response.

        }
        $allow_extension = ['jpg','png','jpeg'];
        if($isValid && in_array($extension,$allow_extension)){
            $path = $request->file('avatar')->store('/static/img/avatar','NOJPublic');

            $user = Auth::user();
            $old_path = $user->avatar;

The property avatar does not exist on App\User. Since you implemented __get, consider adding a @property annotation.

            if($old_path != '/static/img/avatar/default.png'){
                Storage::disk('NOJPublic')->delete($old_path);
            }

            $user->avatar = '/'.$path;

The property avatar does not exist on App\User. Since you implemented __set, consider adding a @property annotation.

Are you sure $path of type false|string can be used in concatenation?

            $user->save();

            $output=[
                'ret' => '200',
                'desc' => 'success',
                'data' => [
                    'url' => '/'.$path
                ]
            ];
            return response()->json($output);

The expression return response()->json($output) returns the type Illuminate\Http\JsonResponse which is incompatible with the documented return type Illuminate\Http\Response.

        }else{
            $output=[
                'ret' => '400',
                'desc' => 'Invalid file',
                'data' => null
            ];
            return response()->json($output);

The expression return response()->json($output) returns the type Illuminate\Http\JsonResponse which is incompatible with the documented return type Illuminate\Http\Response.

        }

    }
}