App\Models\Search\ContestSearchModel::search()

Complexity

Conditions	7
Paths	6

Size

Total Lines	34
Code Lines	23

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
    public function search($key)
    {
        $result=[];
        //contest name find
        if (strlen($key)>=2) {
            $ret=self::whereRaw('MATCH(`name`) AGAINST (? IN BOOLEAN MODE)', [$key])
                ->select('cid', 'gid', 'name', 'rule', 'public', 'verified', 'practice', 'rated', 'anticheated', 'begin_time', 'end_time')
                ->orderBy('end_time', 'DESC')
                ->limit(120)
                ->get()->all();
            $user_id=Auth::user()->id;

Accessing id on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

            $contestModel=new ContestModel();
            foreach ($ret as $c_index => $c) {
                if (!$contestModel->judgeClearance($c['cid'], $user_id)) {
                    unset($ret[$c_index]);
                }
            }
            if (!empty($ret)) {
                $result+=$ret;
            }
        }
        if (!empty($result)) {
            foreach ($result as &$contest) {
                $contest["rule_parsed"]=$this->rule[$contest["rule"]];
                $contest["date_parsed"]=[
                    "date"=>date_format(date_create($contest["begin_time"]), 'j'),
                    "month_year"=>date_format(date_create($contest["begin_time"]), 'M, Y'),
                ];
                $contest["length"]=$contestModel->calcLength($contest["begin_time"], $contest["end_time"]);

The variable $contestModel does not seem to be defined for all execution paths leading up to this point.

            }
            unset($contest);
        }

        return $result;
    }