MessageController::index() - Code Metrics - ZsgsDesign/NOJ - Measure and Improve Code Quality continuously with Scrutinizer

MessageController::index() A
last analyzed 2021-11-04 16:36 UTC

↳ Parent: MessageController

Complexity

Conditions	1
Paths	1

Size

Total Lines	7
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	5
c	0
b	0
f	0
nc	1
nop	0
dl	0
loc	7
rs	10

<?php

namespace App\Http\Controllers;

use App\Models\Eloquent\Message;
use Auth;
use Illuminate\Support\Facades\Redirect;

class MessageController extends Controller
{
    public function index()
    {
        return view('message.index', [
            'page_title' => "Message",
            'site_title' => config("app.name"),
            'navigation' => "Home",
            'messages' => Message::listAll(Auth::user()->id),

        ]);
    }

    public function detail($id)
    {
        $message = Message::find($id);

        if (blank($message) || $message->receiver != Auth::user()->id) {

            return Redirect::route('message.index');
        }

        $message->read();

        return view('message.detail', [
            'page_title'=>"Message",
            'site_title'=>config("app.name"),
            'navigation'=>"Home",
            'message' => $message
        ]);
    }
}


1			<?php
2
3			namespace App\Http\Controllers;
4
5			use App\Models\Eloquent\Message;
6			use Auth;
7			use Illuminate\Support\Facades\Redirect;
8
9			class MessageController extends Controller
10			{
11			public function index()
12			{
13			return view('message.index', [
14			'page_title' => "Message",
15			'site_title' => config("app.name"),
16			'navigation' => "Home",
17			'messages' => Message::listAll(Auth::user()->id),
			0 ignored issues – show Bug introduced 2021-08-13 20:36 UTC by Report Bug Copy Issue Report Accessing `id` on the interface `Illuminate\Contracts\Auth\Authenticatable` suggest that you code against a concrete implementation. How about adding an `instanceof` check? Loading history...
18			]);
19			}
20
21			public function detail($id)
22			{
23			$message = Message::find($id);
24
25			if (blank($message) \|\| $message->receiver != Auth::user()->id) {
			0 ignored issues – show Bug introduced 2021-08-13 20:36 UTC by Report Bug Copy Issue Report Accessing `id` on the interface `Illuminate\Contracts\Auth\Authenticatable` suggest that you code against a concrete implementation. How about adding an `instanceof` check? Loading history...
26			return Redirect::route('message.index');
27			}
28
29			$message->read();
30
31			return view('message.detail', [
32			'page_title'=>"Message",
33			'site_title'=>config("app.name"),
34			'navigation'=>"Home",
35			'message' => $message
36			]);
37			}
38			}
39

ZsgsDesign / NOJ

MessageController::index() A last analyzed 2021-11-04 16:36 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

MessageController::index() A
last analyzed 2021-11-04 16:36 UTC