App\Http\Controllers\AccountController

Complexity

Total Complexity

4

Size/Duplication

Total Lines	65
Duplicated Lines	0 %

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	settings()	0	21	2
A	index()	0	3	1
A	dashboard()	0	19	1

<?php

namespace App\Http\Controllers;

use Illuminate\Http\Request;
use App\Models\AccountModel;
use App\Models\Eloquent\UserExtra;
use App\Models\Eloquent\Tool\Socialite;
use Auth;

class AccountController extends Controller
{
    /**
     * Show the account index.
     *
     * @return \Illuminate\View\View
     */
    public function index()
    {
        return response()->redirectTo("/account/dashboard");

The expression return response()->redirectTo('/account/dashboard') returns the type Illuminate\Http\RedirectResponse which is incompatible with the documented return type Illuminate\View\View.

    }

    /**
     * Show the account dashboard.
     *
     * @return \Illuminate\View\View
     */
    public function dashboard()
    {
        $accountModel=new AccountModel();
        $info=$accountModel->detail(Auth::user()->id);

Accessing id on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

        $feed=$accountModel->feed(Auth::user()->id);
        $extraInfo=Auth::user()->getExtra(['gender', 'contact', 'school', 'country', 'location'], 100);

The method getExtra() does not exist on Illuminate\Contracts\Auth\Authenticatable. It seems like you code against a sub-type of said class. However, the method does not exist in Illuminate\Auth\GenericUser. Are you sure you never get one of those?

        $socialiteInfo=Auth::user()->getSocialiteInfo(100);

The method getSocialiteInfo() does not exist on Illuminate\Contracts\Auth\Authenticatable. It seems like you code against a sub-type of said class. However, the method does not exist in Illuminate\Auth\GenericUser. Are you sure you never get one of those?

        return view("account.dashboard", [
            'page_title'=>"DashBoard",
            'site_title'=>config("app.name"),
            'navigation'=>"DashBoard",
            'info'=>$info,
            'userView'=>false,
            'settingsView' => false,
            'feed'=>$feed,
            'extra_info' => $extraInfo,
            'extraDict' => UserExtra::$extraDict,
            'socialite_info' => $socialiteInfo,
            'socialites' => Socialite::getAvailable(),
        ]);
    }

    /**
     * Show the account dashboard.
     *
     * @return \Illuminate\View\View
     */
    public function settings()
    {
        $accountModel=new AccountModel();
        $info=$accountModel->detail(Auth::user()->id);

Accessing id on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

        if (!empty(session('last_email_send'))) {
            $email_cooldown=300-(time()-session('last_email_send'));
        }
        $extraInfo=Auth::user()->getExtra(['gender', 'contact', 'school', 'country', 'location'], 100);
        $socialiteInfo=Auth::user()->getSocialiteInfo(100);
        return view("account.dashboard", [
            'page_title'=>"Settings",
            'site_title'=>config("app.name"),
            'navigation'=>"Settings",
            'info'=>$info,
            'userView'=>false,
            'settingsView' => true,
            'email_cooldown' => $email_cooldown ?? null,
            'extra_info' => $extraInfo,
            'extraDict' => UserExtra::$extraDict,
            'socialite_info' => $socialiteInfo,
            'socialites' => Socialite::getAvailable(),
        ]);
    }
}