Phabricator\Client\Curl\CurlClient

Complexity

Total Complexity

5

Size/Duplication

Total Lines	68
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Test Coverage

Coverage

100%

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	request()	0	8	1
A	setOption()	0	5	1
A	setOptionArray()	0	5	1
A	setOptionsOnRequest()	0	5	2

<?php namespace Phabricator\Client\Curl;

use Phabricator\Client\ClientInterface;

/**
 * Simple CURL based client
 *
 * Phabricator PHP API
 *
 * @author Zoltán Borsos <zolli07@gmail.com>
 * @package Phabricator
 * @subpackage Client\Curl
 *
 * @copyright    Copyright 2016, Zoltán Borsos.
 * @license      https://github.com/Zolli/Phabricator-PHP-API/blob/master/LICENSE.md
 * @link         https://github.com/Zolli/Phabricator-PHP-API
 */
class CurlClient implements ClientInterface {

    /**
     * Hold options that set in request when creating it
     *
     * @type array
     */
    protected $options = [];

    /**
     * {@inheritDoc}
     *
     * @codeCoverageIgnore
     */
    public function request($url, $requestData) {
        $request = new CurlRequest($url);
        $request->setPostData($requestData);

        $this->setOptionsOnRequest($request, $this->options);

        return $request->execute();

The expression $request->execute(); of type array|stdClass adds the type stdClass to the return on line 38 which is incompatible with the return type declared by the interface Phabricator\Client\ClientInterface::request of type array.

    }

    /**
     * Set option for CURL request
     *
     * @param int $option CURLOPT_* constants
     * @param mixed $value The option value
     *
     * @return \Phabricator\Client\Curl\CurlClient
     */
    public function setOption($option, $value) {
        $this->options[$option] = $value;

        return $this;
    }

    /**
     * Set CIRL request options from array. The array key is the option
     * and the value is used to option value.
     *
     * @param array $options
     *
     * @return \Phabricator\Client\Curl\CurlClient
     */
    public function setOptionArray(array $options) {
        $this->options = $options;

        return $this;
    }

    /**
     * Set the defined options on the given CurlRequest instance
     *
     * @param \Phabricator\Client\Curl\CurlRequest $request
     * @param $options
     *
     * @throws \BuildR\Foundation\Exception\RuntimeException
     *
     * @codeCoverageIgnore
     */
    protected function setOptionsOnRequest(CurlRequest $request, $options) {
        foreach($options as $option => $value) {
            $request->setOption($option, $value);
        }
    }

}