Issues in ModularLatteFiltersExtension.php - All Issues - Inspection of "[tests] simplify, make use of integration tests" - Zenify/ModularLatteFilters - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 70f26a...90e34c )

by Tomáš

created 2016-11-09 10:09 UTC

src/DI/ModularLatteFiltersExtension.php (2 issues)

Labels

Severity

Major 2

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

declare(strict_types = 1);

/*
 * This file is part of Zenify.
 * Copyright (c) 2015 Tomas Votruba (http://tomasvotruba.cz)
 */

namespace Zenify\ModularLatteFilters\DI;

use Latte\Engine;
use Nette\Bridges\ApplicationLatte\ILatteFactory;
use Nette\DI\CompilerExtension;
use Nette\DI\ServiceDefinition;
use Zenify\ModularLatteFilters\Contract\DI\LatteFiltersProviderInterface;
use Zenify\ModularLatteFilters\Exception\DI\MissingLatteDefinitionException;


final class ModularLatteFiltersExtension extends CompilerExtension
{

	/**
	 * @var string
	 */
	const APPLICATION_LATTE_FACTORY_INTERFACE = ILatteFactory::class;


	public function beforeCompile()
	{
		$containerBuilder = $this->getContainerBuilder();
		$containerBuilder->prepareClassList();

		$latteDefinition = $this->getLatteDefinition();
		foreach ($containerBuilder->findByType(LatteFiltersProviderInterface::class) as $latteFilterProviderDefinition) {
			$latteDefinition->addSetup(
				'foreach (?->getFilters() as $name => $callback) {
					?->addFilter($name, $callback);
				}',
				['@' . $latteFilterProviderDefinition->getClass(), '@self']
			);
		}
	}


	private function getLatteDefinition() : ServiceDefinition
	{
		$containerBuilder = $this->getContainerBuilder();

		if ($containerBuilder->getByType(Engine::class)) {
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
			$serviceName = $containerBuilder->getByType(Engine::class);

		} elseif ($containerBuilder->getByType(self::APPLICATION_LATTE_FACTORY_INTERFACE)) {
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
			$serviceName = $containerBuilder->getByType(self::APPLICATION_LATTE_FACTORY_INTERFACE);

		} else {
			throw new MissingLatteDefinitionException(
				sprintf(
					'No services providing Latte\Engine was found. Register service either of %s or %s type.',
					Engine::class,
					ILatteFactory::class
				)
			);
		}

		return $containerBuilder->getDefinition($serviceName);
	}

}


1		<?php
2
3		declare(strict_types = 1);
4
5		/*
6		* This file is part of Zenify.
7		* Copyright (c) 2015 Tomas Votruba (http://tomasvotruba.cz)
8		*/
9
10		namespace Zenify\ModularLatteFilters\DI;
11
12		use Latte\Engine;
13		use Nette\Bridges\ApplicationLatte\ILatteFactory;
14		use Nette\DI\CompilerExtension;
15		use Nette\DI\ServiceDefinition;
16		use Zenify\ModularLatteFilters\Contract\DI\LatteFiltersProviderInterface;
17		use Zenify\ModularLatteFilters\Exception\DI\MissingLatteDefinitionException;
18
19
20		final class ModularLatteFiltersExtension extends CompilerExtension
21		{
22
23		/**
24		* @var string
25		*/
26		const APPLICATION_LATTE_FACTORY_INTERFACE = ILatteFactory::class;
27
28
29	3	public function beforeCompile()
30		{
31	3	$containerBuilder = $this->getContainerBuilder();
32	3	$containerBuilder->prepareClassList();
33
34	3	$latteDefinition = $this->getLatteDefinition();
35	2	foreach ($containerBuilder->findByType(LatteFiltersProviderInterface::class) as $latteFilterProviderDefinition) {
36	2	$latteDefinition->addSetup(
37		'foreach (?->getFilters() as $name => $callback) {
38		?->addFilter($name, $callback);
39	2	}',
40	2	['@' . $latteFilterProviderDefinition->getClass(), '@self']
41		);
42		}
43	2	}
44
45
46	3	private function getLatteDefinition() : ServiceDefinition
47		{
48	3	$containerBuilder = $this->getContainerBuilder();
49
50	3	if ($containerBuilder->getByType(Engine::class)) {
		0 ignored issues – show Bug Best Practice introduced 2016-10-31 19:04 UTC by Report Bug Copy Issue Report Show Similar Issues like this The expression `$containerBuilder->getBy...e(\Latte\Engine::class)` of type `string\|null` is loosely compared to `true`; this is ambiguous if the string can be empty. You might want to explicitly use `!== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
51	1	$serviceName = $containerBuilder->getByType(Engine::class);
52
53	2	} elseif ($containerBuilder->getByType(self::APPLICATION_LATTE_FACTORY_INTERFACE)) {
		0 ignored issues – show Bug Best Practice introduced 2016-10-31 19:04 UTC by Report Bug Copy Issue Report Show Similar Issues like this The expression `$containerBuilder->getBy...ATTE_FACTORY_INTERFACE)` of type `string\|null` is loosely compared to `true`; this is ambiguous if the string can be empty. You might want to explicitly use `!== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
54	1	$serviceName = $containerBuilder->getByType(self::APPLICATION_LATTE_FACTORY_INTERFACE);
55
56		} else {
57	1	throw new MissingLatteDefinitionException(
58		sprintf(
59	1	'No services providing Latte\Engine was found. Register service either of %s or %s type.',
60	1	Engine::class,
61	1	ILatteFactory::class
62		)
63		);
64		}
65
66	2	return $containerBuilder->getDefinition($serviceName);
67		}
68
69		}
70

Zenify / ModularLatteFilters

Push — master ( 70f26a...90e34c )

src/DI/ModularLatteFiltersExtension.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like