AbstractBehaviorExtensionTest::testBuildDefinition() - Code Metrics - Zenify/DoctrineBehaviors - Measure and Improve Code Quality continuously with Scrutinizer

testBuildDefinition() A
last analyzed 2016-12-29 23:32 UTC

↳ Parent: AbstractBehaviorExtensionTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	7
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	7
c	0
b	0
f	0
rs	9.4285
cc	1
eloc	4
nc	1
nop	0

<?php

declare(strict_types=1);

namespace Zenify\DoctrineBehaviors\Tests\DI;

use Knp\DoctrineBehaviors\ORM\Loggable\LoggerCallable;
use Knp\DoctrineBehaviors\Reflection\ClassAnalyzer;
use Nette\DI\Compiler;
use PHPUnit\Framework\TestCase;
use Zenify\DoctrineBehaviors\DI\AbstractBehaviorExtension;
use Zenify\DoctrineBehaviors\Tests\DI\AbstractBehaviorExtensionSource\SomeBehaviorExtension;


final class AbstractBehaviorExtensionTest extends TestCase
{

	/**
	 * @var AbstractBehaviorExtension|SomeBehaviorExtension
	 */
	private $abstractBehaviorsExtension;


	protected function setUp()
	{
		$this->abstractBehaviorsExtension = new SomeBehaviorExtension;
		$this->abstractBehaviorsExtension->setCompiler(new Compiler, 'someBehavior');
	}


	public function testGetClassAnalyzer()
	{
		$classAnalyzer = $this->abstractBehaviorsExtension->getClassAnalyzerPublic();
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
		$this->assertSame(ClassAnalyzer::class, $classAnalyzer->getClass());

		$sameClassAnalyzer = $this->abstractBehaviorsExtension->getClassAnalyzerPublic();
		$this->assertSame($classAnalyzer, $sameClassAnalyzer);
	}


	public function testBuildDefinitionWithNullValue()
	{
		$this->assertNull($this->abstractBehaviorsExtension->buildDefinitionFromCallablePublic(NULL));
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
	}


	public function testBuildDefinition()
	{
		$definition = $this->abstractBehaviorsExtension->buildDefinitionFromCallablePublic(LoggerCallable::class);
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}

		$this->assertSame(LoggerCallable::class, $definition->getClass());
		$this->assertSame(LoggerCallable::class, $definition->getFactory()->getEntity());
	}

}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace Zenify\DoctrineBehaviors\Tests\DI;
6
7			use Knp\DoctrineBehaviors\ORM\Loggable\LoggerCallable;
8			use Knp\DoctrineBehaviors\Reflection\ClassAnalyzer;
9			use Nette\DI\Compiler;
10			use PHPUnit\Framework\TestCase;
11			use Zenify\DoctrineBehaviors\DI\AbstractBehaviorExtension;
12			use Zenify\DoctrineBehaviors\Tests\DI\AbstractBehaviorExtensionSource\SomeBehaviorExtension;
13
14
15			final class AbstractBehaviorExtensionTest extends TestCase
16			{
17
18			/**
19			* @var AbstractBehaviorExtension\|SomeBehaviorExtension
20			*/
21			private $abstractBehaviorsExtension;
22
23
24			protected function setUp()
25			{
26			$this->abstractBehaviorsExtension = new SomeBehaviorExtension;
27			$this->abstractBehaviorsExtension->setCompiler(new Compiler, 'someBehavior');
28			}
29
30
31			public function testGetClassAnalyzer()
32			{
33			$classAnalyzer = $this->abstractBehaviorsExtension->getClassAnalyzerPublic();
			0 ignored issues – show Bug introduced 2016-09-30 08:20 UTC by Report Bug Copy Issue Report The method `getClassAnalyzerPublic` does only exist in `Zenify\DoctrineBehaviors...e\SomeBehaviorExtension`, but not in `Zenify\DoctrineBehaviors...stractBehaviorExtension`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
34			$this->assertSame(ClassAnalyzer::class, $classAnalyzer->getClass());
35
36			$sameClassAnalyzer = $this->abstractBehaviorsExtension->getClassAnalyzerPublic();
37			$this->assertSame($classAnalyzer, $sameClassAnalyzer);
38			}
39
40
41			public function testBuildDefinitionWithNullValue()
42			{
43			$this->assertNull($this->abstractBehaviorsExtension->buildDefinitionFromCallablePublic(NULL));
			0 ignored issues – show Bug introduced 2016-09-30 08:20 UTC by Report Bug Copy Issue Report The method `buildDefinitionFromCallablePublic` does only exist in `Zenify\DoctrineBehaviors...e\SomeBehaviorExtension`, but not in `Zenify\DoctrineBehaviors...stractBehaviorExtension`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
44			}
45
46
47			public function testBuildDefinition()
48			{
49			$definition = $this->abstractBehaviorsExtension->buildDefinitionFromCallablePublic(LoggerCallable::class);
			0 ignored issues – show Bug introduced 2016-09-30 08:20 UTC by Report Bug Copy Issue Report The method `buildDefinitionFromCallablePublic` does only exist in `Zenify\DoctrineBehaviors...e\SomeBehaviorExtension`, but not in `Zenify\DoctrineBehaviors...stractBehaviorExtension`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
50
51			$this->assertSame(LoggerCallable::class, $definition->getClass());
52			$this->assertSame(LoggerCallable::class, $definition->getFactory()->getEntity());
53			}
54
55			}
56

Zenify / DoctrineBehaviors

testBuildDefinition() A last analyzed 2016-12-29 23:32 UTC

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like

testBuildDefinition() A
last analyzed 2016-12-29 23:32 UTC