Issues in Uploads.php (master) - Issues in master - Zebedeu/uploadfiles - Measure and Improve Code Quality continuously with Scrutinizer

Issues (7)

Upload/Uploads.php (7 issues)

Labels

Severity

<?php

/**
 * APWEB Framework (http://framework.artphoweb.com/)
 * APWEB FW(tm) : Rapid Development Framework (http://framework.artphoweb.com/)
 *
 * Licensed under The MIT License
 * For full copyright and license information, please see the LICENSE.txt
 * Redistributions of files must retain the above copyright notice.
 *
 * @link      http://github.com/zebedeu/artphoweb for the canonical source repository
 * @copyright (c) 2015.  APWEB  Software Technologies AO Inc. (http://www.artphoweb.com)
 * @license   http://framework.artphoweb.com/license/new-bsd New BSD License
 * @author    Marcio Zebedeu - [email protected]
 * @version   1.0.0
 */

/**
 * Class Uploads
 * @package Ballybran\Helpers
 */
class Uploads 
{

    /**
     * @var
     */
    public $path;
    /**
     * @var
     */
    private $tmp;
    /**
     * @var
     */
    public $name;
    /**
     * @var
     */
    public $size;
    /**
     * @var
     */
    public $type;
    /**
     * @var array
     */
    private $explode;
    
    /**
     * @var
     */
    private $ext;
    /**
     * @var
     */
    private $dir;


    /**
     * Uploads constructor.
     */
    function __construct()
    {

        if (isset($_FILES['archive'])) {

            foreach ($_FILES['archive']['name'] as $i => $name) {
                $this->name = $_FILES['archive']['name'][$i];
                $this->size = $_FILES['archive']['size'][$i];
                $this->type = $_FILES['archive']['type'][$i];
                $this->tmp = $_FILES['archive']['tmp_name'][$i];

                $this->explode = explode('.', $name);

            }
        }
    }


    /**
     * @param null $dir

     */
    public function file($dir = null)
    {
        $this->dir = $dir;

        $this->make();
    }

    /**
     * @return string
     */
    private function make()
    {
            $this->makePathBayUserName();
            $this->makeDefaultPath();
            $this->makePathDirIfDefaultFileNotExist();
            return $this->move_upload();
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {

    }


    private function makePathDirIfDefaultFileNotExist()
    {

        if (!file_exists(DIR_FILE . 'Upload' . DS . 'Default' . DS . $this->dir . DS)) {

            mkdir(DIR_FILE . 'Upload' . DS . 'Default' . DS . $this->dir . DS, 0755, true);

        }
    }

    private function move_upload()
    {
        var_dump($this->path);

        move_uploaded_file($this->tmp, $this->path);

    }

    private function makeDefaultPath()
    {
        $this->path = DIR_FILE . 'Upload' . DS . 'Default' . DS . $this->dir . DS;


    }

    private function makePathBayUserName()
    {
        $this->ext = end($this->explode);
        $this->path .= basename($this->explode[0] . time() . '.' . $this->ext);
    }

}

1			<?php
2
3			/**
4			* APWEB Framework (http://framework.artphoweb.com/)
5			* APWEB FW(tm) : Rapid Development Framework (http://framework.artphoweb.com/)
6			*
7			* Licensed under The MIT License
8			* For full copyright and license information, please see the LICENSE.txt
9			* Redistributions of files must retain the above copyright notice.
10			*
11			* @link http://github.com/zebedeu/artphoweb for the canonical source repository
12			* @copyright (c) 2015. APWEB Software Technologies AO Inc. (http://www.artphoweb.com)
13			* @license http://framework.artphoweb.com/license/new-bsd New BSD License
14			* @author Marcio Zebedeu - [email protected]
15			* @version 1.0.0
16			*/
17
18			/**
19			* Class Uploads
20			* @package Ballybran\Helpers
21			*/
22			class Uploads
23			{
24
25			/**
26			* @var
27			*/
28			public $path;
29			/**
30			* @var
31			*/
32			private $tmp;
33			/**
34			* @var
35			*/
36			public $name;
37			/**
38			* @var
39			*/
40			public $size;
41			/**
42			* @var
43			*/
44			public $type;
45			/**
46			* @var array
47			*/
48			private $explode;
49
50			/**
51			* @var
52			*/
53			private $ext;
54			/**
55			* @var
56			*/
57			private $dir;
58
59
60			/**
61			* Uploads constructor.
62			*/
63			function __construct()
64			{
65
66			if (isset($_FILES['archive'])) {
67
68			foreach ($_FILES['archive']['name'] as $i => $name) {
69			$this->name = $_FILES['archive']['name'][$i];
70			$this->size = $_FILES['archive']['size'][$i];
71			$this->type = $_FILES['archive']['type'][$i];
72			$this->tmp = $_FILES['archive']['tmp_name'][$i];
73
74			$this->explode = explode('.', $name);
75
76			}
77			}
78			}
79
80
81			/**
82			* @param null $dir
			0 ignored issues – show Documentation Bug introduced 2020-05-14 10:06 UTC by Report Bug Copy Issue Report Show Similar Issues like this Are you sure the doc-type for parameter `$dir` is correct as it would always require `null` to be passed? Loading history...
83			*/
84			public function file($dir = null)
85			{
86			$this->dir = $dir;
87
88			$this->make();
89			}
90
91			/**
92			* @return string
93			*/
94			private function make()
95			{
96			$this->makePathBayUserName();
97			$this->makeDefaultPath();
98			$this->makePathDirIfDefaultFileNotExist();
99			return $this->move_upload();
			0 ignored issues – show Bug introduced 2020-05-14 10:06 UTC by Report Bug Copy Issue Report Show Similar Issues like this Are you sure the usage of `$this->move_upload()` targeting `Uploads::move_upload()` seems to always return null. This check looks for function or method calls that always return null and whose return value is used. class A { function getObject() { return null; } } $a = new A(); if ($a->getObject()) { The method `getObject()` can return nothing but null, so it makes no sense to use the return value. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
100
101			}
102
103
104			private function makePathDirIfDefaultFileNotExist()
105			{
106
107			if (!file_exists(DIR_FILE . 'Upload' . DS . 'Default' . DS . $this->dir . DS)) {
			0 ignored issues – show Bug introduced 2020-05-14 10:06 UTC by Report Bug Copy Issue Report Show Similar Issues like this The constant `DIR_FILE` was not found. Maybe you did not declare it correctly or list all dependencies? Loading history... Bug introduced 2020-05-14 10:06 UTC by Report Bug Copy Issue Report Show Similar Issues like this The constant `DS` was not found. Maybe you did not declare it correctly or list all dependencies? Loading history...
108			mkdir(DIR_FILE . 'Upload' . DS . 'Default' . DS . $this->dir . DS, 0755, true);
109
110			}
111			}
112
113			private function move_upload()
114			{
115			var_dump($this->path);
			0 ignored issues – show Security Debugging Code introduced 2020-05-14 10:06 UTC by Report Bug Copy Issue Report Show Similar Issues like this `var_dump($this->path)` looks like debug code. Are you sure you do not want to remove it? Loading history...
116			move_uploaded_file($this->tmp, $this->path);
117
118			}
119
120			private function makeDefaultPath()
121			{
122			$this->path = DIR_FILE . 'Upload' . DS . 'Default' . DS . $this->dir . DS;
			0 ignored issues – show Bug introduced 2017-07-30 09:12 UTC by Report Bug Copy Issue Report Show Similar Issues like this The constant `DS` was not found. Maybe you did not declare it correctly or list all dependencies? Loading history... Bug introduced 2017-07-30 09:12 UTC by Report Bug Copy Issue Report Show Similar Issues like this The constant `DIR_FILE` was not found. Maybe you did not declare it correctly or list all dependencies? Loading history...
123
124			}
125
126			private function makePathBayUserName()
127			{
128			$this->ext = end($this->explode);
129			$this->path .= basename($this->explode[0] . time() . '.' . $this->ext);
130			}
131
132			}

Zebedeu / uploadfiles

Issues (7)

Upload/Uploads.php (7 issues)

Labels

Severity

Introduced By

Duplication Side-by-Side

Filter issues like